[INFO] fetching crate concrete-core 1.0.2... [INFO] checking concrete-core-1.0.2 against try#7014e13d5becc920d4bea3cd87942c8a13d359bf+rustflags=-Dtail_expr_drop_order for pr-129864 [INFO] extracting crate concrete-core 1.0.2 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate concrete-core 1.0.2 on toolchain 7014e13d5becc920d4bea3cd87942c8a13d359bf [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate concrete-core 1.0.2 [INFO] finished tweaking crates.io crate concrete-core 1.0.2 [INFO] tweaked toml for crates.io crate concrete-core 1.0.2 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 106 packages to latest compatible versions [INFO] [stderr] Adding aes-soft v0.6.4 (available: v0.99.99) [INFO] [stderr] Adding aligned-vec v0.5.0 (available: v0.6.1) [INFO] [stderr] Adding bitflags v1.3.2 (available: v2.6.0) [INFO] [stderr] Adding cipher v0.2.5 (available: v0.4.4) [INFO] [stderr] Adding clap v2.34.0 (available: v4.5.18) [INFO] [stderr] Adding concrete-csprng v0.2.2 (available: v0.4.1) [INFO] [stderr] Adding concrete-fft v0.1.0 (available: v0.5.1) [INFO] [stderr] Adding criterion v0.3.6 (available: v0.5.1) [INFO] [stderr] Adding criterion-plot v0.4.5 (available: v0.5.0) [INFO] [stderr] Adding dyn-stack v0.8.3 (available: v0.10.0) [INFO] [stderr] Adding generic-array v0.14.7 (available: v1.1.0) [INFO] [stderr] Adding getrandom v0.1.16 (available: v0.2.15) [INFO] [stderr] Adding half v1.8.3 (available: v2.4.1) [INFO] [stderr] Adding hermit-abi v0.1.19 (available: v0.4.0) [INFO] [stderr] Adding itertools v0.10.5 (available: v0.13.0) [INFO] [stderr] Adding rand v0.3.23 (available: v0.8.5) [INFO] [stderr] Adding rand v0.4.6 (available: v0.8.5) [INFO] [stderr] Adding rand v0.7.3 (available: v0.8.5) [INFO] [stderr] Adding rand_chacha v0.2.2 (available: v0.3.1) [INFO] [stderr] Adding rand_core v0.3.1 (available: v0.6.4) [INFO] [stderr] Adding rand_core v0.4.2 (available: v0.6.4) [INFO] [stderr] Adding rand_core v0.5.1 (available: v0.6.4) [INFO] [stderr] Adding rand_hc v0.2.0 (available: v0.3.2) [INFO] [stderr] Adding rdrand v0.4.0 (available: v0.8.3) [INFO] [stderr] Adding textwrap v0.11.0 (available: v0.16.1) [INFO] [stderr] Adding unicode-width v0.1.14 (available: v0.2.0) [INFO] [stderr] Adding wasi v0.9.0+wasi-snapshot-preview1 (available: v0.13.2+wasi-0.2.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] f4c2c1ee41edb7f7f162b419e0bb37a1c11b9d0a043d662382a64d7de1131fba [INFO] running `Command { std: "docker" "start" "-a" "f4c2c1ee41edb7f7f162b419e0bb37a1c11b9d0a043d662382a64d7de1131fba", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "f4c2c1ee41edb7f7f162b419e0bb37a1c11b9d0a043d662382a64d7de1131fba", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f4c2c1ee41edb7f7f162b419e0bb37a1c11b9d0a043d662382a64d7de1131fba", kill_on_drop: false }` [INFO] [stdout] f4c2c1ee41edb7f7f162b419e0bb37a1c11b9d0a043d662382a64d7de1131fba [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 16741aa79c4426ae71ff7b857a8bfe722455708a2d8ca6c7cbcdc98927e9563b [INFO] running `Command { std: "docker" "start" "-a" "16741aa79c4426ae71ff7b857a8bfe722455708a2d8ca6c7cbcdc98927e9563b", kill_on_drop: false }` [INFO] [stderr] Compiling concrete-csprng v0.2.2 [INFO] [stderr] Checking rand v0.4.6 [INFO] [stderr] Checking reborrow v0.5.5 [INFO] [stderr] Checking aligned-vec v0.5.0 [INFO] [stderr] Checking rand_chacha v0.2.2 [INFO] [stderr] Checking dyn-stack v0.8.3 [INFO] [stderr] Checking rand v0.7.3 [INFO] [stderr] Checking concrete-core v1.0.2 (/opt/rustwide/workdir) [INFO] [stderr] Checking rand v0.3.23 [INFO] [stderr] Checking kolmogorov_smirnov v1.1.0 [INFO] [stdout] warning: elided lifetime has a name [INFO] [stdout] --> src/commons/math/decomposition/term.rs:122:33 [INFO] [stdout] | [INFO] [stdout] 113 | impl<'a, Scalar> DecompositionTermTensor<'a, Scalar> [INFO] [stdout] | -- lifetime `'a` declared here [INFO] [stdout] ... [INFO] [stdout] 122 | ) -> DecompositionTermTensor { [INFO] [stdout] | ^ this elided lifetime gets resolved as `'a` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(elided_named_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: elided lifetime has a name [INFO] [stdout] --> src/commons/math/decomposition/term.rs:122:33 [INFO] [stdout] | [INFO] [stdout] 113 | impl<'a, Scalar> DecompositionTermTensor<'a, Scalar> [INFO] [stdout] | -- lifetime `'a` declared here [INFO] [stdout] ... [INFO] [stdout] 122 | ) -> DecompositionTermTensor { [INFO] [stdout] | ^ this elided lifetime gets resolved as `'a` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(elided_named_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Rev as as_tensor::AsRefTensor>::Element]>>>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/commons/crypto/gsw/ciphertext.rs:439:34 [INFO] [stdout] | [INFO] [stdout] 430 | let rounded_input_lwe = &mut *self.rounded_buffer.borrow_mut(); [INFO] [stdout] | -------------------------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 439 | for gsw_decomp_matrix in self.level_matrix_iter().rev() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/commons/crypto/secret/lwe.rs:989:18 [INFO] [stdout] | [INFO] [stdout] 989 | let (mut body, mut mask) = lwe.get_mut_body_and_mask(); [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `concrete-core` (lib) due to 2 previous errors; 2 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: this value of type `Zip, impl Iterator> as as_tensor::AsRefTensor>::Element>>>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/commons/crypto/encoding/encoder.rs:700:23 [INFO] [stdout] | [INFO] [stdout] 686 | let mut seeder = UnixSeeder::new(0); [INFO] [stdout] | ---------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 687 | let mut generator: RandomGenerator = [INFO] [stdout] | ------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 700 | for (m, d) in messages.iter().zip(decoding.cleartext_iter()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `impl Iterator> as as_tensor::AsRefTensor>::Element>>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/commons/crypto/ggsw/tests.rs:29:22 [INFO] [stdout] | [INFO] [stdout] 20 | let mut secret_generator = test_tools::new_secret_random_generator(); [INFO] [stdout] | -------------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 29 | for plaintext in plaintext_vector.plaintext_iter() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Rev as as_tensor::AsRefTensor>::Element]>>>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/commons/crypto/gsw/ciphertext.rs:439:34 [INFO] [stdout] | [INFO] [stdout] 430 | let rounded_input_lwe = &mut *self.rounded_buffer.borrow_mut(); [INFO] [stdout] | -------------------------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 439 | for gsw_decomp_matrix in self.level_matrix_iter().rev() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/commons/crypto/secret/lwe.rs:989:18 [INFO] [stdout] | [INFO] [stdout] 989 | let (mut body, mut mask) = lwe.get_mut_body_and_mask(); [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `concrete-core` (lib test) due to 4 previous errors; 2 warnings emitted [INFO] running `Command { std: "docker" "inspect" "16741aa79c4426ae71ff7b857a8bfe722455708a2d8ca6c7cbcdc98927e9563b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "16741aa79c4426ae71ff7b857a8bfe722455708a2d8ca6c7cbcdc98927e9563b", kill_on_drop: false }` [INFO] [stdout] 16741aa79c4426ae71ff7b857a8bfe722455708a2d8ca6c7cbcdc98927e9563b