[INFO] fetching crate compression 0.1.5... [INFO] checking compression-0.1.5 against try#7014e13d5becc920d4bea3cd87942c8a13d359bf+rustflags=-Dtail_expr_drop_order for pr-129864 [INFO] extracting crate compression 0.1.5 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate compression 0.1.5 on toolchain 7014e13d5becc920d4bea3cd87942c8a13d359bf [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate compression 0.1.5 [INFO] finished tweaking crates.io crate compression 0.1.5 [INFO] tweaked toml for crates.io crate compression 0.1.5 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 40 packages to latest compatible versions [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (available: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-sys v0.48.0 (available: v0.59.0) [INFO] [stderr] Adding windows-targets v0.48.5 (available: v0.52.6) [INFO] [stderr] Adding windows_aarch64_gnullvm v0.48.5 (available: v0.52.6) [INFO] [stderr] Adding windows_aarch64_msvc v0.48.5 (available: v0.52.6) [INFO] [stderr] Adding windows_i686_gnu v0.48.5 (available: v0.52.6) [INFO] [stderr] Adding windows_i686_msvc v0.48.5 (available: v0.52.6) [INFO] [stderr] Adding windows_x86_64_gnu v0.48.5 (available: v0.52.6) [INFO] [stderr] Adding windows_x86_64_gnullvm v0.48.5 (available: v0.52.6) [INFO] [stderr] Adding windows_x86_64_msvc v0.48.5 (available: v0.52.6) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 6c9b4ac7d1f268980fc9d3f8096a56a650f9fdebae2d6d99a5e8360967fcd17f [INFO] running `Command { std: "docker" "start" "-a" "6c9b4ac7d1f268980fc9d3f8096a56a650f9fdebae2d6d99a5e8360967fcd17f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "6c9b4ac7d1f268980fc9d3f8096a56a650f9fdebae2d6d99a5e8360967fcd17f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6c9b4ac7d1f268980fc9d3f8096a56a650f9fdebae2d6d99a5e8360967fcd17f", kill_on_drop: false }` [INFO] [stdout] 6c9b4ac7d1f268980fc9d3f8096a56a650f9fdebae2d6d99a5e8360967fcd17f [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] e75d306bb4359498e869470156bb7229a3ba80a63cc7391d7f99b82e3e2e017a [INFO] running `Command { std: "docker" "start" "-a" "e75d306bb4359498e869470156bb7229a3ba80a63cc7391d7f99b82e3e2e017a", kill_on_drop: false }` [INFO] [stderr] Checking num_threads v0.1.7 [INFO] [stderr] Checking colored v2.1.0 [INFO] [stderr] Checking compression v0.1.5 (/opt/rustwide/workdir) [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking time v0.3.36 [INFO] [stdout] warning: unnecessary braces around block return value [INFO] [stdout] --> src/crc32.rs:17:9 [INFO] [stdout] | [INFO] [stdout] 17 | { make_table_reverse(0xEDB8_8320) }; [INFO] [stdout] | ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_braces)]` on by default [INFO] [stdout] help: remove these braces [INFO] [stdout] | [INFO] [stdout] 17 - { make_table_reverse(0xEDB8_8320) }; [INFO] [stdout] 17 + make_table_reverse(0xEDB8_8320); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary braces around block return value [INFO] [stdout] --> src/crc32.rs:30:9 [INFO] [stdout] | [INFO] [stdout] 30 | { make_table_normal(0x04C1_1DB7) }; [INFO] [stdout] | ^^ ^^ [INFO] [stdout] | [INFO] [stdout] help: remove these braces [INFO] [stdout] | [INFO] [stdout] 30 - { make_table_normal(0x04C1_1DB7) }; [INFO] [stdout] 30 + make_table_normal(0x04C1_1DB7); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stdout] warning: trait `BitWriteExt` is never used [INFO] [stdout] --> src/bitio/writer.rs:21:18 [INFO] [stdout] | [INFO] [stdout] 21 | pub(crate) trait BitWriteExt [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `BitIterator` is never constructed [INFO] [stdout] --> src/bitio/writer.rs:63:19 [INFO] [stdout] | [INFO] [stdout] 63 | pub(crate) struct BitIterator [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `new` is never used [INFO] [stdout] --> src/bitio/writer.rs:98:8 [INFO] [stdout] | [INFO] [stdout] 85 | / impl BitIterator [INFO] [stdout] 86 | | where [INFO] [stdout] 87 | | T: Copy [INFO] [stdout] 88 | | + BitOr [INFO] [stdout] ... | [INFO] [stdout] 95 | | I: Iterator>, [INFO] [stdout] 96 | | W: BorrowMut>, [INFO] [stdout] | |_______________________________- associated function in this implementation [INFO] [stdout] 97 | { [INFO] [stdout] 98 | fn new(inner: I, writer: W, action: Action) -> Self { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 5 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking simple_logger v5.0.0 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stdout] warning: unnecessary braces around block return value [INFO] [stdout] --> src/crc32.rs:17:9 [INFO] [stdout] | [INFO] [stdout] 17 | { make_table_reverse(0xEDB8_8320) }; [INFO] [stdout] | ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_braces)]` on by default [INFO] [stdout] help: remove these braces [INFO] [stdout] | [INFO] [stdout] 17 - { make_table_reverse(0xEDB8_8320) }; [INFO] [stdout] 17 + make_table_reverse(0xEDB8_8320); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary braces around block return value [INFO] [stdout] --> src/crc32.rs:30:9 [INFO] [stdout] | [INFO] [stdout] 30 | { make_table_normal(0x04C1_1DB7) }; [INFO] [stdout] | ^^ ^^ [INFO] [stdout] | [INFO] [stdout] help: remove these braces [INFO] [stdout] | [INFO] [stdout] 30 - { make_table_normal(0x04C1_1DB7) }; [INFO] [stdout] 30 + make_table_normal(0x04C1_1DB7); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::iter::Take>>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cbuffer.rs:195:23 [INFO] [stdout] | [INFO] [stdout] 182 | let mut buf = CircularBuffer::new(16); [INFO] [stdout] | ------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 195 | for (d, i) in buf.clone().into_iter().enumerate().take(16) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::iter::Take>>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cbuffer.rs:217:23 [INFO] [stdout] | [INFO] [stdout] 202 | let mut buf = CircularBuffer::new(16); [INFO] [stdout] | ------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 217 | for (d, i) in buf.clone().into_iter().enumerate().take(16) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `compression` (lib test) due to 3 previous errors; 2 warnings emitted [INFO] running `Command { std: "docker" "inspect" "e75d306bb4359498e869470156bb7229a3ba80a63cc7391d7f99b82e3e2e017a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e75d306bb4359498e869470156bb7229a3ba80a63cc7391d7f99b82e3e2e017a", kill_on_drop: false }` [INFO] [stdout] e75d306bb4359498e869470156bb7229a3ba80a63cc7391d7f99b82e3e2e017a