[INFO] fetching crate clover 0.1.3... [INFO] checking clover-0.1.3 against try#7014e13d5becc920d4bea3cd87942c8a13d359bf+rustflags=-Dtail_expr_drop_order for pr-129864 [INFO] extracting crate clover 0.1.3 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate clover 0.1.3 on toolchain 7014e13d5becc920d4bea3cd87942c8a13d359bf [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate clover 0.1.3 [INFO] finished tweaking crates.io crate clover 0.1.3 [INFO] tweaked toml for crates.io crate clover 0.1.3 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 1 package to latest compatible version [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 6e190a5b90ac0eb954f9114a6b0379b616bd7a0975d6aed13595b923e451478e [INFO] running `Command { std: "docker" "start" "-a" "6e190a5b90ac0eb954f9114a6b0379b616bd7a0975d6aed13595b923e451478e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "6e190a5b90ac0eb954f9114a6b0379b616bd7a0975d6aed13595b923e451478e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6e190a5b90ac0eb954f9114a6b0379b616bd7a0975d6aed13595b923e451478e", kill_on_drop: false }` [INFO] [stdout] 6e190a5b90ac0eb954f9114a6b0379b616bd7a0975d6aed13595b923e451478e [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] f0773ac7e003e87ff3d8af587c0a97f46ffe68205b76eaca4f952362402c49ae [INFO] running `Command { std: "docker" "start" "-a" "f0773ac7e003e87ff3d8af587c0a97f46ffe68205b76eaca4f952362402c49ae", kill_on_drop: false }` [INFO] [stderr] Checking clover v0.1.3 (/opt/rustwide/workdir) [INFO] [stdout] error: this value of type `Option>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/frontend/parser.rs:313:35 [INFO] [stdout] | [INFO] [stdout] 307 | fn parse_call_expression(&mut self, expression: Expression) -> Option { [INFO] [stdout] | ---------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 313 | if let Some(parameters) = self.parse_comma_expressions(&[ TokenValue::RightParentheses, TokenValue::Eof ]) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Option>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/frontend/parser.rs:313:35 [INFO] [stdout] | [INFO] [stdout] 307 | fn parse_call_expression(&mut self, expression: Expression) -> Option { [INFO] [stdout] | ---------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 313 | if let Some(parameters) = self.parse_comma_expressions(&[ TokenValue::RightParentheses, TokenValue::Eof ]) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `RefMut<'_, ModelInstance>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/runtime/state.rs:428:31 [INFO] [stdout] | [INFO] [stdout] 427 | fn index_set_model_instance_by_index(&mut self, model_instance: Reference, index: usize) -> Result<(), RuntimeError> { [INFO] [stdout] | -------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 428 | if let Some(object) = model_instance.borrow_mut().properties.get_mut(index as usize) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `[Object; 2]` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/runtime/operation.rs:265:57 [INFO] [stdout] | [INFO] [stdout] 252 | fn model_instance_operation(&mut self, left: Reference, right: &Object, operand: usize) -> Result<(), RuntimeError> { [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 265 | self.call_function_by_index(meta_method_index, &[ Object::Instance(left.clone()), right.clone() ]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `token` is never read [INFO] [stdout] --> src/intermediate/ast.rs:189:9 [INFO] [stdout] | [INFO] [stdout] 188 | pub struct ForStatement { [INFO] [stdout] | ------------ field in this struct [INFO] [stdout] 189 | pub token: Token, [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `ForStatement` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `RefMut<'_, ModelInstance>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/runtime/state.rs:428:31 [INFO] [stdout] | [INFO] [stdout] 427 | fn index_set_model_instance_by_index(&mut self, model_instance: Reference, index: usize) -> Result<(), RuntimeError> { [INFO] [stdout] | -------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 428 | if let Some(object) = model_instance.borrow_mut().properties.get_mut(index as usize) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `clover` (lib test) due to 4 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: this value of type `[Object; 2]` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/runtime/operation.rs:265:57 [INFO] [stdout] | [INFO] [stdout] 252 | fn model_instance_operation(&mut self, left: Reference, right: &Object, operand: usize) -> Result<(), RuntimeError> { [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 265 | self.call_function_by_index(meta_method_index, &[ Object::Instance(left.clone()), right.clone() ]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `token` is never read [INFO] [stdout] --> src/intermediate/ast.rs:189:9 [INFO] [stdout] | [INFO] [stdout] 188 | pub struct ForStatement { [INFO] [stdout] | ------------ field in this struct [INFO] [stdout] 189 | pub token: Token, [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `ForStatement` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `clover` (lib) due to 4 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "f0773ac7e003e87ff3d8af587c0a97f46ffe68205b76eaca4f952362402c49ae", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f0773ac7e003e87ff3d8af587c0a97f46ffe68205b76eaca4f952362402c49ae", kill_on_drop: false }` [INFO] [stdout] f0773ac7e003e87ff3d8af587c0a97f46ffe68205b76eaca4f952362402c49ae