[INFO] fetching crate chitchat 0.7.0... [INFO] checking chitchat-0.7.0 against try#7014e13d5becc920d4bea3cd87942c8a13d359bf+rustflags=-Dtail_expr_drop_order for pr-129864 [INFO] extracting crate chitchat 0.7.0 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate chitchat 0.7.0 on toolchain 7014e13d5becc920d4bea3cd87942c8a13d359bf [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate chitchat 0.7.0 [INFO] finished tweaking crates.io crate chitchat 0.7.0 [INFO] tweaked toml for crates.io crate chitchat 0.7.0 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 72 packages to latest compatible versions [INFO] [stderr] Adding hermit-abi v0.3.9 (available: v0.4.0) [INFO] [stderr] Adding itertools v0.10.5 (available: v0.13.0) [INFO] [stderr] Adding mock_instant v0.2.1 (available: v0.5.1) [INFO] [stderr] Adding nu-ansi-term v0.46.0 (available: v0.50.1) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (available: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-sys v0.52.0 (available: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] b2a8dcb4d272e1c8aba655184f47f81449fa5df558b04100b417559dda50685d [INFO] running `Command { std: "docker" "start" "-a" "b2a8dcb4d272e1c8aba655184f47f81449fa5df558b04100b417559dda50685d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "b2a8dcb4d272e1c8aba655184f47f81449fa5df558b04100b417559dda50685d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b2a8dcb4d272e1c8aba655184f47f81449fa5df558b04100b417559dda50685d", kill_on_drop: false }` [INFO] [stdout] b2a8dcb4d272e1c8aba655184f47f81449fa5df558b04100b417559dda50685d [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] ee4e3c60e0965ed3ede11f460e42c26a127dc58aa199d5f6cd10939226adcadf [INFO] running `Command { std: "docker" "start" "-a" "ee4e3c60e0965ed3ede11f460e42c26a127dc58aa199d5f6cd10939226adcadf", kill_on_drop: false }` [INFO] [stderr] Checking tracing-core v0.1.32 [INFO] [stderr] Checking overload v0.1.1 [INFO] [stderr] Checking sharded-slab v0.1.7 [INFO] [stderr] Checking thread_local v1.1.8 [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Checking mock_instant v0.2.1 [INFO] [stderr] Checking tokio v1.40.0 [INFO] [stderr] Checking serde_json v1.0.128 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking nu-ansi-term v0.46.0 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking tracing-log v0.2.0 [INFO] [stderr] Checking tracing-subscriber v0.3.18 [INFO] [stderr] Checking assert-json-diff v2.0.2 [INFO] [stderr] Checking tokio-util v0.7.12 [INFO] [stderr] Checking tokio-stream v0.1.16 [INFO] [stderr] Checking chitchat v0.7.0 (/opt/rustwide/workdir) [INFO] [stdout] error: this value of type `Interval` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server.rs:211:13 [INFO] [stdout] | [INFO] [stdout] 211 | let mut gossip_interval = time::interval(gossip_interval); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] 212 | loop { [INFO] [stdout] 213 | / tokio::select! { [INFO] [stdout] 214 | | result = self.transport.recv() => match result { [INFO] [stdout] 215 | | Ok((from_addr, message)) => { [INFO] [stdout] 216 | | let _ = self.handle_message(from_addr, message).await; [INFO] [stdout] ... | [INFO] [stdout] 228 | | } [INFO] [stdout] 229 | | } [INFO] [stdout] | | - [INFO] [stdout] | |_____________| [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Interval` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server.rs:211:13 [INFO] [stdout] | [INFO] [stdout] 211 | let mut gossip_interval = time::interval(gossip_interval); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] 212 | loop { [INFO] [stdout] 213 | / tokio::select! { [INFO] [stdout] 214 | | result = self.transport.recv() => match result { [INFO] [stdout] 215 | | Ok((from_addr, message)) => { [INFO] [stdout] 216 | | let _ = self.handle_message(from_addr, message).await; [INFO] [stdout] ... | [INFO] [stdout] 228 | | } [INFO] [stdout] 229 | | } [INFO] [stdout] | | - [INFO] [stdout] | |_____________| [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `serialize_to_vec` is never used [INFO] [stdout] --> src/serialize.rs:16:8 [INFO] [stdout] | [INFO] [stdout] 13 | pub trait Serializable: Sized { [INFO] [stdout] | ------------ method in this trait [INFO] [stdout] ... [INFO] [stdout] 16 | fn serialize_to_vec(&self) -> Vec { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `chitchat` (lib) due to 2 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: this value of type `ChitchatMessage` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server.rs:468:13 [INFO] [stdout] | [INFO] [stdout] 452 | let transport = ChannelTransport::with_mtu(MAX_UDP_DATAGRAM_PAYLOAD_SIZE); [INFO] [stdout] | --------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 456 | let mut peer_transport = transport.open(peer_addr).await.unwrap(); [INFO] [stdout] | ------------------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 457 | let server = spawn_chitchat(test_config, Vec::new(), &transport) [INFO] [stdout] | ------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 461 | let (from, message) = timeout(peer_transport.recv()).await.unwrap(); [INFO] [stdout] | ------- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 468 | message => panic!("unexpected message: {message:?}"), [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `ChitchatMessage` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server.rs:502:13 [INFO] [stdout] | [INFO] [stdout] 479 | let transport = ChannelTransport::with_mtu(MAX_UDP_DATAGRAM_PAYLOAD_SIZE); [INFO] [stdout] | --------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 482 | let mut transport2 = transport [INFO] [stdout] | -------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 490 | let chitchat = Chitchat::with_chitchat_id_and_seeds(config2, empty_seeds(), Vec::new()); [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 491 | let _handler = spawn_chitchat(config1, Vec::new(), &transport) [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 498 | let (from1, msg) = transport2.recv().await.unwrap(); [INFO] [stdout] | --- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 502 | message => panic!("unexpected message: {message:?}"), [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `ChitchatMessage` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server.rs:530:13 [INFO] [stdout] | [INFO] [stdout] 508 | let transport = ChannelTransport::with_mtu(MAX_UDP_DATAGRAM_PAYLOAD_SIZE); [INFO] [stdout] | --------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 511 | let mut outsider_transport = transport [INFO] [stdout] | ---------------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 515 | let outsider = [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 520 | let _handler = spawn_chitchat(server_config, Vec::new(), &transport) [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 527 | let (_from_addr, syn_ack) = timeout(outsider_transport.recv()).await.unwrap(); [INFO] [stdout] | ------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 530 | message => panic!("unexpected message: {message:?}"), [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `ChitchatMessage` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server.rs:553:13 [INFO] [stdout] | [INFO] [stdout] 536 | let transport = ChannelTransport::with_mtu(MAX_UDP_DATAGRAM_PAYLOAD_SIZE); [INFO] [stdout] | --------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 539 | let mut seed_transport = transport.open(seed_addr).await.unwrap(); [INFO] [stdout] | ------------------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 544 | let _handler = spawn_chitchat(client_config, Vec::new(), &transport) [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 548 | let (from, message) = timeout(seed_transport.recv()).await.unwrap(); [INFO] [stdout] | ------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 553 | message => panic!("unexpected message: {message:?}"), [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `delta::Delta` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/state.rs:895:17 [INFO] [stdout] | [INFO] [stdout] 880 | let max_delta = cluster_state.compute_delta(digest, usize::MAX, dead_nodes, 10_000); [INFO] [stdout] | --------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 895 | let mut expected_delta = Delta::default(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `delta::Delta` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/state.rs:1052:17 [INFO] [stdout] | [INFO] [stdout] 1018 | let mut cluster_state = ClusterState::default(); [INFO] [stdout] | ----------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1052 | let delta = cluster_state.compute_delta( [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `serialize_to_vec` is never used [INFO] [stdout] --> src/serialize.rs:16:8 [INFO] [stdout] | [INFO] [stdout] 13 | pub trait Serializable: Sized { [INFO] [stdout] | ------------ method in this trait [INFO] [stdout] ... [INFO] [stdout] 16 | fn serialize_to_vec(&self) -> Vec { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `chitchat` (lib test) due to 8 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "ee4e3c60e0965ed3ede11f460e42c26a127dc58aa199d5f6cd10939226adcadf", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ee4e3c60e0965ed3ede11f460e42c26a127dc58aa199d5f6cd10939226adcadf", kill_on_drop: false }` [INFO] [stdout] ee4e3c60e0965ed3ede11f460e42c26a127dc58aa199d5f6cd10939226adcadf