[INFO] fetching crate cgroups-rs 0.3.4... [INFO] checking cgroups-rs-0.3.4 against try#7014e13d5becc920d4bea3cd87942c8a13d359bf+rustflags=-Dtail_expr_drop_order for pr-129864 [INFO] extracting crate cgroups-rs 0.3.4 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate cgroups-rs 0.3.4 on toolchain 7014e13d5becc920d4bea3cd87942c8a13d359bf [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] removed /workspace/builds/worker-1-tc2/source/.cargo/config [INFO] started tweaking crates.io crate cgroups-rs 0.3.4 [INFO] finished tweaking crates.io crate cgroups-rs 0.3.4 [INFO] tweaked toml for crates.io crate cgroups-rs 0.3.4 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 19 packages to latest compatible versions [INFO] [stderr] Adding bitflags v1.3.2 (available: v2.6.0) [INFO] [stderr] Adding nix v0.25.1 (available: v0.29.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] d7dab4c6b508dcf270f24dfd09c30448e337f1e7d3086b94e15967999f867eba [INFO] running `Command { std: "docker" "start" "-a" "d7dab4c6b508dcf270f24dfd09c30448e337f1e7d3086b94e15967999f867eba", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "d7dab4c6b508dcf270f24dfd09c30448e337f1e7d3086b94e15967999f867eba", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d7dab4c6b508dcf270f24dfd09c30448e337f1e7d3086b94e15967999f867eba", kill_on_drop: false }` [INFO] [stdout] d7dab4c6b508dcf270f24dfd09c30448e337f1e7d3086b94e15967999f867eba [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] ce5533ffba90bba284eea3be0cee26b2865b88c92fe3f12dacf1e53f8f7f3775 [INFO] running `Command { std: "docker" "start" "-a" "ce5533ffba90bba284eea3be0cee26b2865b88c92fe3f12dacf1e53f8f7f3775", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.159 [INFO] [stderr] Checking regex-syntax v0.8.4 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Checking nix v0.25.1 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking regex v1.10.6 [INFO] [stderr] Checking cgroups-rs v0.3.4 (/opt/rustwide/workdir) [INFO] [stdout] error: this value of type `std::result::Result` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pid.rs:107:19 [INFO] [stdout] | [INFO] [stdout] 105 | self.open_path("pids.events", false).and_then(|mut file| { [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 106 | let mut string = String::new(); [INFO] [stdout] 107 | match file.read_to_string(&mut string) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::result::Result<(), std::io::Error>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pid.rs:146:19 [INFO] [stdout] | [INFO] [stdout] 144 | self.open_path("pids.max", true).and_then(|mut file| { [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 145 | let string_to_write = max_pid.to_string(); [INFO] [stdout] 146 | match file.write_all(string_to_write.as_ref()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::result::Result` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:237:23 [INFO] [stdout] | [INFO] [stdout] 235 | self.open_path(key, false).and_then(|mut file: File| { [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 236 | let mut string = String::new(); [INFO] [stdout] 237 | match file.read_to_string(&mut string) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::result::Result` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:485:19 [INFO] [stdout] | [INFO] [stdout] 483 | self.open_path(file_name, false).and_then(|mut file: File| { [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 484 | let mut string = String::new(); [INFO] [stdout] 485 | match file.read_to_string(&mut string) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::result::Result` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:993:11 [INFO] [stdout] | [INFO] [stdout] 987 | fn read_from(mut file: File) -> Result [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 993 | match file.read_to_string(&mut string) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::result::Result` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:1007:11 [INFO] [stdout] | [INFO] [stdout] 1005 | fn read_string_from(mut file: File) -> Result { [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 1006 | let mut string = String::new(); [INFO] [stdout] 1007 | match file.read_to_string(&mut string) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `get` is never used [INFO] [stdout] --> src/lib.rs:234:12 [INFO] [stdout] | [INFO] [stdout] 225 | pub trait CustomizedAttribute: ControllerInternal { [INFO] [stdout] | ------------------- method in this trait [INFO] [stdout] ... [INFO] [stdout] 234 | fn get(&self, key: &str) -> Result { [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::result::Result` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pid.rs:107:19 [INFO] [stdout] | [INFO] [stdout] 105 | self.open_path("pids.events", false).and_then(|mut file| { [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 106 | let mut string = String::new(); [INFO] [stdout] 107 | match file.read_to_string(&mut string) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::result::Result<(), std::io::Error>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pid.rs:146:19 [INFO] [stdout] | [INFO] [stdout] 144 | self.open_path("pids.max", true).and_then(|mut file| { [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 145 | let string_to_write = max_pid.to_string(); [INFO] [stdout] 146 | match file.write_all(string_to_write.as_ref()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::result::Result` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:237:23 [INFO] [stdout] | [INFO] [stdout] 235 | self.open_path(key, false).and_then(|mut file: File| { [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 236 | let mut string = String::new(); [INFO] [stdout] 237 | match file.read_to_string(&mut string) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `cgroups-rs` (lib) due to 7 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: this value of type `std::result::Result` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:485:19 [INFO] [stdout] | [INFO] [stdout] 483 | self.open_path(file_name, false).and_then(|mut file: File| { [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 484 | let mut string = String::new(); [INFO] [stdout] 485 | match file.read_to_string(&mut string) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::result::Result` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:993:11 [INFO] [stdout] | [INFO] [stdout] 987 | fn read_from(mut file: File) -> Result [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 993 | match file.read_to_string(&mut string) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::result::Result` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:1007:11 [INFO] [stdout] | [INFO] [stdout] 1005 | fn read_string_from(mut file: File) -> Result { [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 1006 | let mut string = String::new(); [INFO] [stdout] 1007 | match file.read_to_string(&mut string) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `get` is never used [INFO] [stdout] --> src/lib.rs:234:12 [INFO] [stdout] | [INFO] [stdout] 225 | pub trait CustomizedAttribute: ControllerInternal { [INFO] [stdout] | ------------------- method in this trait [INFO] [stdout] ... [INFO] [stdout] 234 | fn get(&self, key: &str) -> Result { [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `cgroups-rs` (lib test) due to 7 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "ce5533ffba90bba284eea3be0cee26b2865b88c92fe3f12dacf1e53f8f7f3775", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ce5533ffba90bba284eea3be0cee26b2865b88c92fe3f12dacf1e53f8f7f3775", kill_on_drop: false }` [INFO] [stdout] ce5533ffba90bba284eea3be0cee26b2865b88c92fe3f12dacf1e53f8f7f3775