[INFO] fetching crate cdshealpix 0.6.10... [INFO] checking cdshealpix-0.6.10 against try#7014e13d5becc920d4bea3cd87942c8a13d359bf+rustflags=-Dtail_expr_drop_order for pr-129864 [INFO] extracting crate cdshealpix 0.6.10 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate cdshealpix 0.6.10 on toolchain 7014e13d5becc920d4bea3cd87942c8a13d359bf [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate cdshealpix 0.6.10 [INFO] finished tweaking crates.io crate cdshealpix 0.6.10 [INFO] tweaked toml for crates.io crate cdshealpix 0.6.10 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 92 packages to latest compatible versions [INFO] [stderr] Adding anes v0.1.6 (available: v0.2.0) [INFO] [stderr] Adding base64 v0.21.7 (available: v0.22.1) [INFO] [stderr] Adding bitflags v1.3.2 (available: v2.6.0) [INFO] [stderr] Adding clap v3.2.25 (available: v4.5.18) [INFO] [stderr] Adding clap_lex v0.2.4 (available: v0.7.2) [INFO] [stderr] Adding criterion v0.4.0 (available: v0.5.1) [INFO] [stderr] Adding hashbrown v0.12.3 (available: v0.14.5) [INFO] [stderr] Adding hermit-abi v0.1.19 (available: v0.4.0) [INFO] [stderr] Adding indexmap v1.9.3 (available: v2.5.0) [INFO] [stderr] Adding itertools v0.10.5 (available: v0.13.0) [INFO] [stderr] Adding os_str_bytes v6.6.1 (available: v7.0.0) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (available: v0.13.2+wasi-0.2.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 234890f0c39dd2e63a921f38d5c4e030a2970d5c7049ac9c4109faad0d70c94c [INFO] running `Command { std: "docker" "start" "-a" "234890f0c39dd2e63a921f38d5c4e030a2970d5c7049ac9c4109faad0d70c94c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "234890f0c39dd2e63a921f38d5c4e030a2970d5c7049ac9c4109faad0d70c94c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "234890f0c39dd2e63a921f38d5c4e030a2970d5c7049ac9c4109faad0d70c94c", kill_on_drop: false }` [INFO] [stdout] 234890f0c39dd2e63a921f38d5c4e030a2970d5c7049ac9c4109faad0d70c94c [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] cfc7e3613e1fb6357eac6c96752b791587fa48d69a367bf96c7ec96ebe9e05cd [INFO] running `Command { std: "docker" "start" "-a" "cfc7e3613e1fb6357eac6c96752b791587fa48d69a367bf96c7ec96ebe9e05cd", kill_on_drop: false }` [INFO] [stderr] Compiling indexmap v1.9.3 [INFO] [stderr] Checking os_str_bytes v6.6.1 [INFO] [stderr] Checking textwrap v0.16.1 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking num-complex v0.4.6 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking katex-doc v0.1.0 [INFO] [stderr] Checking serde v1.0.210 [INFO] [stderr] Checking num-bigint v0.4.6 [INFO] [stderr] Checking clap_lex v0.2.4 [INFO] [stderr] Checking num-iter v0.1.45 [INFO] [stderr] Checking clap v3.2.25 [INFO] [stderr] Checking num-rational v0.4.2 [INFO] [stderr] Checking num v0.4.3 [INFO] [stderr] Checking cdshealpix v0.6.10 (/opt/rustwide/workdir) [INFO] [stdout] error: this value of type `Option` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/nested/bmoc.rs:323:28 [INFO] [stdout] | [INFO] [stdout] 321 | let new_bmoc = self.buff_to_bmoc(); [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 322 | self.clear_buff(); [INFO] [stdout] 323 | self.bmoc = Some(match self.bmoc.take() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/nested/gpu.rs:70:19 [INFO] [stdout] | [INFO] [stdout] 70 | pub fn unproj_gpu(mut x: f32, y: f32) -> (f32, f32, f32) { [INFO] [stdout] | ----^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking serde_json v1.0.128 [INFO] [stderr] Checking ciborium v0.2.2 [INFO] [stdout] warning: type `gpu::AbsAndSign` is more private than the item `gpu::abs_sign_decompose` [INFO] [stdout] --> src/nested/gpu.rs:346:1 [INFO] [stdout] | [INFO] [stdout] 346 | pub(crate) fn abs_sign_decompose(x: f32) -> AbsAndSign { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ function `gpu::abs_sign_decompose` is reachable at visibility `pub(crate)` [INFO] [stdout] | [INFO] [stdout] note: but type `gpu::AbsAndSign` is only usable at visibility `pub(self)` [INFO] [stdout] --> src/nested/gpu.rs:341:1 [INFO] [stdout] | [INFO] [stdout] 341 | struct AbsAndSign { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] = note: `#[warn(private_interfaces)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `AbsAndSign` is never constructed [INFO] [stdout] --> src/nested/gpu.rs:341:8 [INFO] [stdout] | [INFO] [stdout] 341 | struct AbsAndSign { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `abs_sign_decompose` is never used [INFO] [stdout] --> src/nested/gpu.rs:346:15 [INFO] [stdout] | [INFO] [stdout] 346 | pub(crate) fn abs_sign_decompose(x: f32) -> AbsAndSign { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `cdshealpix` (lib) due to 2 previous errors; 4 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "cfc7e3613e1fb6357eac6c96752b791587fa48d69a367bf96c7ec96ebe9e05cd", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "cfc7e3613e1fb6357eac6c96752b791587fa48d69a367bf96c7ec96ebe9e05cd", kill_on_drop: false }` [INFO] [stdout] cfc7e3613e1fb6357eac6c96752b791587fa48d69a367bf96c7ec96ebe9e05cd