[INFO] fetching crate cdr 0.2.4... [INFO] checking cdr-0.2.4 against try#7014e13d5becc920d4bea3cd87942c8a13d359bf+rustflags=-Dtail_expr_drop_order for pr-129864 [INFO] extracting crate cdr 0.2.4 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate cdr 0.2.4 on toolchain 7014e13d5becc920d4bea3cd87942c8a13d359bf [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate cdr 0.2.4 [INFO] finished tweaking crates.io crate cdr 0.2.4 [INFO] tweaked toml for crates.io crate cdr 0.2.4 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 7 packages to latest compatible versions [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] abb565baa0b2fb816fda28032f5767cc9249710fb193403bcb380702ba0ed480 [INFO] running `Command { std: "docker" "start" "-a" "abb565baa0b2fb816fda28032f5767cc9249710fb193403bcb380702ba0ed480", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "abb565baa0b2fb816fda28032f5767cc9249710fb193403bcb380702ba0ed480", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "abb565baa0b2fb816fda28032f5767cc9249710fb193403bcb380702ba0ed480", kill_on_drop: false }` [INFO] [stdout] abb565baa0b2fb816fda28032f5767cc9249710fb193403bcb380702ba0ed480 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 67c72d051ac324e01e0f3c41a85d798ab09451abdb168744205a30b857867cb3 [INFO] running `Command { std: "docker" "start" "-a" "67c72d051ac324e01e0f3c41a85d798ab09451abdb168744205a30b857867cb3", kill_on_drop: false }` [INFO] [stderr] Checking cdr v0.2.4 (/opt/rustwide/workdir) [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/de.rs:365:9 [INFO] [stdout] | [INFO] [stdout] 356 | / fn deserialize_enum( [INFO] [stdout] 357 | | self, [INFO] [stdout] 358 | | _name: &'static str, [INFO] [stdout] 359 | | _variants: &'static [&'static str], [INFO] [stdout] ... | [INFO] [stdout] 362 | | where [INFO] [stdout] 363 | | V: de::Visitor<'de>, [INFO] [stdout] | |____________________________- move the `impl` block outside of this method `deserialize_enum` [INFO] [stdout] 364 | { [INFO] [stdout] 365 | impl<'de, 'a, R: 'a, S, E> de::EnumAccess<'de> for &'a mut Deserializer [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^--------------^^^^^^^^^^^^^^^^^^------------^^^^^^^^^ [INFO] [stdout] | | | [INFO] [stdout] | | `Deserializer` is not local [INFO] [stdout] | `EnumAccess` is not local [INFO] [stdout] | [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue [INFO] [stdout] = note: `#[warn(non_local_definitions)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: lint `const_err` has been removed: converted into hard error, see issue #71800 for more information [INFO] [stdout] --> tests/test.rs:573:9 [INFO] [stdout] | [INFO] [stdout] 573 | #[allow(const_err)] [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(renamed_and_removed_lints)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: lint `const_err` has been removed: converted into hard error, see issue #71800 for more information [INFO] [stdout] --> tests/test.rs:580:9 [INFO] [stdout] | [INFO] [stdout] 580 | #[allow(const_err)] [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: lint `const_err` has been removed: converted into hard error, see issue #71800 for more information [INFO] [stdout] --> tests/test.rs:587:9 [INFO] [stdout] | [INFO] [stdout] 587 | #[allow(const_err)] [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: lint `const_err` has been removed: converted into hard error, see issue #71800 for more information [INFO] [stdout] --> tests/test.rs:594:9 [INFO] [stdout] | [INFO] [stdout] 594 | #[allow(const_err)] [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: lint `const_err` has been removed: converted into hard error, see issue #71800 for more information [INFO] [stdout] --> tests/test.rs:601:9 [INFO] [stdout] | [INFO] [stdout] 601 | #[allow(const_err)] [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: lint `const_err` has been removed: converted into hard error, see issue #71800 for more information [INFO] [stdout] --> tests/test.rs:608:9 [INFO] [stdout] | [INFO] [stdout] 608 | #[allow(const_err)] [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: lint `const_err` has been removed: converted into hard error, see issue #71800 for more information [INFO] [stdout] --> tests/test.rs:615:9 [INFO] [stdout] | [INFO] [stdout] 615 | #[allow(const_err)] [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: lint `const_err` has been removed: converted into hard error, see issue #71800 for more information [INFO] [stdout] --> tests/test.rs:622:9 [INFO] [stdout] | [INFO] [stdout] 622 | #[allow(const_err)] [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: lint `const_err` has been removed: converted into hard error, see issue #71800 for more information [INFO] [stdout] --> tests/test.rs:629:9 [INFO] [stdout] | [INFO] [stdout] 629 | #[allow(const_err)] [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: lint `const_err` has been removed: converted into hard error, see issue #71800 for more information [INFO] [stdout] --> tests/test.rs:636:9 [INFO] [stdout] | [INFO] [stdout] 636 | #[allow(const_err)] [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: lint `const_err` has been removed: converted into hard error, see issue #71800 for more information [INFO] [stdout] --> tests/test.rs:643:9 [INFO] [stdout] | [INFO] [stdout] 643 | #[allow(const_err)] [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: lint `const_err` has been removed: converted into hard error, see issue #71800 for more information [INFO] [stdout] --> tests/test.rs:650:9 [INFO] [stdout] | [INFO] [stdout] 650 | #[allow(const_err)] [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: lint `const_err` has been removed: converted into hard error, see issue #71800 for more information [INFO] [stdout] --> tests/test.rs:660:9 [INFO] [stdout] | [INFO] [stdout] 660 | #[allow(const_err)] [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/de.rs:365:9 [INFO] [stdout] | [INFO] [stdout] 356 | / fn deserialize_enum( [INFO] [stdout] 357 | | self, [INFO] [stdout] 358 | | _name: &'static str, [INFO] [stdout] 359 | | _variants: &'static [&'static str], [INFO] [stdout] ... | [INFO] [stdout] 362 | | where [INFO] [stdout] 363 | | V: de::Visitor<'de>, [INFO] [stdout] | |____________________________- move the `impl` block outside of this method `deserialize_enum` [INFO] [stdout] 364 | { [INFO] [stdout] 365 | impl<'de, 'a, R: 'a, S, E> de::EnumAccess<'de> for &'a mut Deserializer [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^--------------^^^^^^^^^^^^^^^^^^------------^^^^^^^^^ [INFO] [stdout] | | | [INFO] [stdout] | | `Deserializer` is not local [INFO] [stdout] | `EnumAccess` is not local [INFO] [stdout] | [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue [INFO] [stdout] = note: `#[warn(non_local_definitions)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `cdr::Error` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> tests/test.rs:791:17 [INFO] [stdout] | [INFO] [stdout] 787 | fn check_error_kind(res: Result) { [INFO] [stdout] | --- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 791 | e => panic!("unexpected error kind: {}", e), [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 13 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `cdr` (test "test") due to 2 previous errors; 13 warnings emitted [INFO] running `Command { std: "docker" "inspect" "67c72d051ac324e01e0f3c41a85d798ab09451abdb168744205a30b857867cb3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "67c72d051ac324e01e0f3c41a85d798ab09451abdb168744205a30b857867cb3", kill_on_drop: false }` [INFO] [stdout] 67c72d051ac324e01e0f3c41a85d798ab09451abdb168744205a30b857867cb3