[INFO] fetching crate candid_derive 0.6.6... [INFO] checking candid_derive-0.6.6 against try#7014e13d5becc920d4bea3cd87942c8a13d359bf+rustflags=-Dtail_expr_drop_order for pr-129864 [INFO] extracting crate candid_derive 0.6.6 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate candid_derive 0.6.6 on toolchain 7014e13d5becc920d4bea3cd87942c8a13d359bf [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate candid_derive 0.6.6 [INFO] finished tweaking crates.io crate candid_derive 0.6.6 [INFO] tweaked toml for crates.io crate candid_derive 0.6.6 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 5 packages to latest compatible versions [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 2538a9b16961717e9fbc9712ff55eac7b0213b077fa00f523841461450151ab9 [INFO] running `Command { std: "docker" "start" "-a" "2538a9b16961717e9fbc9712ff55eac7b0213b077fa00f523841461450151ab9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "2538a9b16961717e9fbc9712ff55eac7b0213b077fa00f523841461450151ab9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2538a9b16961717e9fbc9712ff55eac7b0213b077fa00f523841461450151ab9", kill_on_drop: false }` [INFO] [stdout] 2538a9b16961717e9fbc9712ff55eac7b0213b077fa00f523841461450151ab9 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] bb4a41f4e5a306534722d4bbcaeb60f1687adc063ac4bfe7b2672eb8de875fc6 [INFO] running `Command { std: "docker" "start" "-a" "bb4a41f4e5a306534722d4bbcaeb60f1687adc063ac4bfe7b2672eb8de875fc6", kill_on_drop: false }` [INFO] [stderr] Checking lazy_static v1.5.0 [INFO] [stderr] Checking syn v2.0.77 [INFO] [stderr] Checking candid_derive v0.6.6 (/opt/rustwide/workdir) [INFO] [stdout] error: this value of type `Vec` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/derive.rs:63:21 [INFO] [stdout] | [INFO] [stdout] 63 | let id: Vec<_> = self.members.iter().map(|ident| ident.to_token()).collect(); [INFO] [stdout] | ^^ [INFO] [stdout] 64 | ( [INFO] [stdout] 65 | / quote! { [INFO] [stdout] 66 | | {#(ref #id),*} [INFO] [stdout] 67 | | }, [INFO] [stdout] | | - [INFO] [stdout] | |_____________________| [INFO] [stdout] | |_____________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 82 | / quote! { [INFO] [stdout] 83 | | (#(ref #id),*) [INFO] [stdout] 84 | | }, [INFO] [stdout] | | - [INFO] [stdout] | |_____________________| [INFO] [stdout] | |_____________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Vec` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/derive.rs:63:21 [INFO] [stdout] | [INFO] [stdout] 63 | let id: Vec<_> = self.members.iter().map(|ident| ident.to_token()).collect(); [INFO] [stdout] | ^^ [INFO] [stdout] 64 | ( [INFO] [stdout] 65 | / quote! { [INFO] [stdout] 66 | | {#(ref #id),*} [INFO] [stdout] 67 | | }, [INFO] [stdout] | | - [INFO] [stdout] | |_____________________| [INFO] [stdout] | |_____________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 82 | / quote! { [INFO] [stdout] 83 | | (#(ref #id),*) [INFO] [stdout] 84 | | }, [INFO] [stdout] | | - [INFO] [stdout] | |_____________________| [INFO] [stdout] | |_____________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `proc_macro2::TokenStream` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/derive.rs:149:17 [INFO] [stdout] | [INFO] [stdout] 147 | let (pattern, id) = f.to_pattern(); [INFO] [stdout] | -- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 148 | ( [INFO] [stdout] 149 | pattern, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] 150 | if f.with_bytes { [INFO] [stdout] 151 | / quote! { [INFO] [stdout] 152 | | #(#candid::types::Compound::serialize_blob(&mut ser, #id.as_ref())?;)* [INFO] [stdout] 153 | | } [INFO] [stdout] | |_____________________- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 154 | } else { [INFO] [stdout] 155 | / quote! { [INFO] [stdout] 156 | | #(#candid::types::Compound::serialize_element(&mut ser, #id)?;)* [INFO] [stdout] 157 | | } [INFO] [stdout] | |_____________________- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `proc_macro2::TokenStream` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/derive.rs:149:17 [INFO] [stdout] | [INFO] [stdout] 147 | let (pattern, id) = f.to_pattern(); [INFO] [stdout] | -- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 148 | ( [INFO] [stdout] 149 | pattern, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] 150 | if f.with_bytes { [INFO] [stdout] 151 | / quote! { [INFO] [stdout] 152 | | #(#candid::types::Compound::serialize_blob(&mut ser, #id.as_ref())?;)* [INFO] [stdout] 153 | | } [INFO] [stdout] | |_____________________- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 154 | } else { [INFO] [stdout] 155 | / quote! { [INFO] [stdout] 156 | | #(#candid::types::Compound::serialize_element(&mut ser, #id)?;)* [INFO] [stdout] 157 | | } [INFO] [stdout] | |_____________________- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `MutexGuard<'_, Option>>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/func.rs:73:26 [INFO] [stdout] | [INFO] [stdout] 72 | pub(crate) fn export_service(path: Option) -> TokenStream { [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 73 | if let Some(meths) = METHODS.lock().unwrap().as_mut() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 118 | let service = quote! { [INFO] [stdout] | _______________________- [INFO] [stdout] | |_______________________| [INFO] [stdout] | |_______________________| [INFO] [stdout] | |_______________________| [INFO] [stdout] 119 | | use #candid::types::{CandidType, Function, Type, TypeInner}; [INFO] [stdout] 120 | | let mut service = Vec::<(String, Type)>::new(); [INFO] [stdout] 121 | | let mut env = #candid::types::internal::TypeContainer::new(); [INFO] [stdout] ... | [INFO] [stdout] 124 | | let ty = TypeInner::Service(service).into(); [INFO] [stdout] 125 | | }; [INFO] [stdout] | | - [INFO] [stdout] | |_________| [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `MutexGuard<'_, Option>>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/func.rs:73:26 [INFO] [stdout] | [INFO] [stdout] 72 | pub(crate) fn export_service(path: Option) -> TokenStream { [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 73 | if let Some(meths) = METHODS.lock().unwrap().as_mut() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 118 | let service = quote! { [INFO] [stdout] | _______________________- [INFO] [stdout] | |_______________________| [INFO] [stdout] | |_______________________| [INFO] [stdout] | |_______________________| [INFO] [stdout] 119 | | use #candid::types::{CandidType, Function, Type, TypeInner}; [INFO] [stdout] 120 | | let mut service = Vec::<(String, Type)>::new(); [INFO] [stdout] 121 | | let mut env = #candid::types::internal::TypeContainer::new(); [INFO] [stdout] ... | [INFO] [stdout] 124 | | let ty = TypeInner::Service(service).into(); [INFO] [stdout] 125 | | }; [INFO] [stdout] | | - [INFO] [stdout] | |_________| [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `candid_derive` (lib) due to 4 previous errors [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `candid_derive` (lib test) due to 4 previous errors [INFO] running `Command { std: "docker" "inspect" "bb4a41f4e5a306534722d4bbcaeb60f1687adc063ac4bfe7b2672eb8de875fc6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "bb4a41f4e5a306534722d4bbcaeb60f1687adc063ac4bfe7b2672eb8de875fc6", kill_on_drop: false }` [INFO] [stdout] bb4a41f4e5a306534722d4bbcaeb60f1687adc063ac4bfe7b2672eb8de875fc6