[INFO] fetching crate calcit_runner 0.5.25... [INFO] checking calcit_runner-0.5.25 against try#7014e13d5becc920d4bea3cd87942c8a13d359bf+rustflags=-Dtail_expr_drop_order for pr-129864 [INFO] extracting crate calcit_runner 0.5.25 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate calcit_runner 0.5.25 on toolchain 7014e13d5becc920d4bea3cd87942c8a13d359bf [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate calcit_runner 0.5.25 [INFO] finished tweaking crates.io crate calcit_runner 0.5.25 [INFO] tweaked toml for crates.io crate calcit_runner 0.5.25 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] crate crates.io crate calcit_runner 0.5.25 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 9d7760f477ec0f928b8390bd21093767d8cb3d23eee060fa59664c198d4718b7 [INFO] running `Command { std: "docker" "start" "-a" "9d7760f477ec0f928b8390bd21093767d8cb3d23eee060fa59664c198d4718b7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "9d7760f477ec0f928b8390bd21093767d8cb3d23eee060fa59664c198d4718b7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9d7760f477ec0f928b8390bd21093767d8cb3d23eee060fa59664c198d4718b7", kill_on_drop: false }` [INFO] [stdout] 9d7760f477ec0f928b8390bd21093767d8cb3d23eee060fa59664c198d4718b7 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] f83c04bc9af6d3fd8b88efaf9a4220f9586eb483f5a10b62b7a19e0b4b1c4b60 [INFO] running `Command { std: "docker" "start" "-a" "f83c04bc9af6d3fd8b88efaf9a4220f9586eb483f5a10b62b7a19e0b4b1c4b60", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.105 [INFO] [stderr] Compiling autocfg v1.0.1 [INFO] [stderr] Compiling log v0.4.14 [INFO] [stderr] Compiling memchr v2.4.1 [INFO] [stderr] Checking slab v0.4.3 [INFO] [stderr] Checking lazycell v1.3.0 [INFO] [stderr] Checking static_assertions v1.1.0 [INFO] [stderr] Checking hashbrown v0.11.2 [INFO] [stderr] Checking strsim v0.10.0 [INFO] [stderr] Checking textwrap v0.15.0 [INFO] [stderr] Checking cirru_parser v0.1.18 [INFO] [stderr] Checking libloading v0.7.3 [INFO] [stderr] Checking walkdir v2.3.2 [INFO] [stderr] Checking im_ternary_tree v0.0.6 [INFO] [stderr] Checking archery v0.4.0 [INFO] [stderr] Checking cirru_edn v0.2.14 [INFO] [stderr] Checking rpds v0.11.0 [INFO] [stderr] Compiling memoffset v0.6.4 [INFO] [stderr] Compiling indexmap v1.8.0 [INFO] [stderr] Checking os_str_bytes v6.0.0 [INFO] [stderr] Checking net2 v0.2.37 [INFO] [stderr] Checking iovec v0.1.4 [INFO] [stderr] Checking inotify-sys v0.1.5 [INFO] [stderr] Checking filetime v0.2.14 [INFO] [stderr] Checking dirs-sys v0.3.6 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking nix v0.23.0 [INFO] [stderr] Checking clap v3.1.6 [INFO] [stderr] Checking inotify v0.7.1 [INFO] [stderr] Checking dirs v4.0.0 [INFO] [stderr] Checking mio v0.6.23 [INFO] [stderr] Checking mio-extras v2.0.6 [INFO] [stderr] Checking notify v4.0.17 [INFO] [stderr] Checking ctrlc v3.2.1 [INFO] [stderr] Checking calcit_runner v0.5.25 (/opt/rustwide/workdir) [INFO] [stdout] error: this value of type `Calcit` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/builtins/lists.rs:474:16 [INFO] [stdout] | [INFO] [stdout] 468 | let values = TernaryTreeList::from(&[(*a).to_owned(), (*b).to_owned()]); [INFO] [stdout] | ------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 469 | let v = runner::run_fn(&values, scope, args, body, def_ns.to_owned(), call_stack); [INFO] [stdout] | - [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 474 | Ok(a) => { [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Calcit` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/builtins/lists.rs:500:16 [INFO] [stdout] | [INFO] [stdout] 494 | let values = TernaryTreeList::from(&[(*a).to_owned(), (*b).to_owned()]); [INFO] [stdout] | ------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 495 | let v = builtins::handle_proc(proc, &values, call_stack); [INFO] [stdout] | - [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 500 | Ok(a) => { [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Calcit` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/builtins/lists.rs:474:16 [INFO] [stdout] | [INFO] [stdout] 468 | let values = TernaryTreeList::from(&[(*a).to_owned(), (*b).to_owned()]); [INFO] [stdout] | ------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 469 | let v = runner::run_fn(&values, scope, args, body, def_ns.to_owned(), call_stack); [INFO] [stdout] | - [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 474 | Ok(a) => { [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Calcit` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/builtins/lists.rs:500:16 [INFO] [stdout] | [INFO] [stdout] 494 | let values = TernaryTreeList::from(&[(*a).to_owned(), (*b).to_owned()]); [INFO] [stdout] | ------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 495 | let v = builtins::handle_proc(proc, &values, call_stack); [INFO] [stdout] | - [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 500 | Ok(a) => { [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Arc` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/codegen/emit_js.rs:669:19 [INFO] [stdout] | [INFO] [stdout] 667 | fn track_ns_import(sym: &str, import_rule: ImportedTarget, file_imports: &RefCell) -> Result<(), String> { [INFO] [stdout] | ----------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 668 | let mut dict = file_imports.borrow_mut(); [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 669 | match dict.get(&Arc::from(sym.to_owned())) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Arc` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/codegen/emit_js.rs:669:19 [INFO] [stdout] | [INFO] [stdout] 667 | fn track_ns_import(sym: &str, import_rule: ImportedTarget, file_imports: &RefCell) -> Result<(), String> { [INFO] [stdout] | ----------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 668 | let mut dict = file_imports.borrow_mut(); [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 669 | match dict.get(&Arc::from(sym.to_owned())) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Option` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/runner/preprocess.rs:39:9 [INFO] [stdout] | [INFO] [stdout] 27 | raw_ns: Arc, [INFO] [stdout] | ------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 28 | raw_def: Arc, [INFO] [stdout] | ------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 29 | // pass original string representation, TODO codegen currently relies on this [INFO] [stdout] 30 | raw_sym: Arc, [INFO] [stdout] | ------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 31 | import_rule: Option>, // returns form and possible value [INFO] [stdout] | ----------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 39 | match program::lookup_evaled_def(ns, def) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Option` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:70:9 [INFO] [stdout] | [INFO] [stdout] 42 | pub fn run_program(init_ns: Arc, init_def: Arc, params: CalcitItems) -> Result { [INFO] [stdout] | ------- -------- ------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 70 | match program::lookup_evaled_def(&init_ns, &init_def) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Option` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/runner/preprocess.rs:39:9 [INFO] [stdout] | [INFO] [stdout] 27 | raw_ns: Arc, [INFO] [stdout] | ------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 28 | raw_def: Arc, [INFO] [stdout] | ------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 29 | // pass original string representation, TODO codegen currently relies on this [INFO] [stdout] 30 | raw_sym: Arc, [INFO] [stdout] | ------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 31 | import_rule: Option>, // returns form and possible value [INFO] [stdout] | ----------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 39 | match program::lookup_evaled_def(ns, def) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `calcit_runner` (lib test) due to 6 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: this value of type `Option` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:70:9 [INFO] [stdout] | [INFO] [stdout] 42 | pub fn run_program(init_ns: Arc, init_def: Arc, params: CalcitItems) -> Result { [INFO] [stdout] | ------- -------- ------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 70 | match program::lookup_evaled_def(&init_ns, &init_def) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `calcit_runner` (lib) due to 6 previous errors [INFO] running `Command { std: "docker" "inspect" "f83c04bc9af6d3fd8b88efaf9a4220f9586eb483f5a10b62b7a19e0b4b1c4b60", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f83c04bc9af6d3fd8b88efaf9a4220f9586eb483f5a10b62b7a19e0b4b1c4b60", kill_on_drop: false }` [INFO] [stdout] f83c04bc9af6d3fd8b88efaf9a4220f9586eb483f5a10b62b7a19e0b4b1c4b60