[INFO] fetching crate bytekey2 0.4.5... [INFO] checking bytekey2-0.4.5 against try#7014e13d5becc920d4bea3cd87942c8a13d359bf+rustflags=-Dtail_expr_drop_order for pr-129864 [INFO] extracting crate bytekey2 0.4.5 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate bytekey2 0.4.5 on toolchain 7014e13d5becc920d4bea3cd87942c8a13d359bf [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate bytekey2 0.4.5 [INFO] finished tweaking crates.io crate bytekey2 0.4.5 [INFO] tweaked toml for crates.io crate bytekey2 0.4.5 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 18 packages to latest compatible versions [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (available: v0.13.2+wasi-0.2.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] af449c77f78c4d6979b8e0bb6f953241752160db5fabc8c39dc4b28e3a5bcc7a [INFO] running `Command { std: "docker" "start" "-a" "af449c77f78c4d6979b8e0bb6f953241752160db5fabc8c39dc4b28e3a5bcc7a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "af449c77f78c4d6979b8e0bb6f953241752160db5fabc8c39dc4b28e3a5bcc7a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "af449c77f78c4d6979b8e0bb6f953241752160db5fabc8c39dc4b28e3a5bcc7a", kill_on_drop: false }` [INFO] [stdout] af449c77f78c4d6979b8e0bb6f953241752160db5fabc8c39dc4b28e3a5bcc7a [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] b64babf936b2ef467fad42d2d547a716b85dff0ba11136ef0fc623fee7285925 [INFO] running `Command { std: "docker" "start" "-a" "b64babf936b2ef467fad42d2d547a716b85dff0ba11136ef0fc623fee7285925", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] [stderr] Compiling serde v1.0.210 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking bytekey2 v0.4.5 (/opt/rustwide/workdir) [INFO] [stdout] error: this value of type `std::option::Option>>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/de.rs:215:15 [INFO] [stdout] | [INFO] [stdout] 210 | fn deserialize_char(self, visitor: V) -> Result [INFO] [stdout] | ------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 215 | match utf8_decoder.next_strict() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::option::Option>>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/de.rs:215:15 [INFO] [stdout] | [INFO] [stdout] 210 | fn deserialize_char(self, visitor: V) -> Result [INFO] [stdout] | ------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 215 | match utf8_decoder.next_strict() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/de.rs:462:9 [INFO] [stdout] | [INFO] [stdout] 453 | / fn deserialize_enum( [INFO] [stdout] 454 | | self, [INFO] [stdout] 455 | | _name: &'static str, [INFO] [stdout] 456 | | _fields: &'static [&'static str], [INFO] [stdout] ... | [INFO] [stdout] 459 | | where [INFO] [stdout] 460 | | V: Visitor<'de>, [INFO] [stdout] | |________________________- move the `impl` block outside of this method `deserialize_enum` [INFO] [stdout] 461 | { [INFO] [stdout] 462 | impl<'de, 'a, R> serde::de::EnumAccess<'de> for &'a mut Deserializer [INFO] [stdout] | ^^^^^^^^^^^^^^^^^---------------------^^^^^^^^^^^^^^^^^^------------^^^ [INFO] [stdout] | | | [INFO] [stdout] | | `Deserializer` is not local [INFO] [stdout] | `EnumAccess` is not local [INFO] [stdout] | [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue [INFO] [stdout] = note: `#[warn(non_local_definitions)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/de.rs:480:9 [INFO] [stdout] | [INFO] [stdout] 453 | / fn deserialize_enum( [INFO] [stdout] 454 | | self, [INFO] [stdout] 455 | | _name: &'static str, [INFO] [stdout] 456 | | _fields: &'static [&'static str], [INFO] [stdout] ... | [INFO] [stdout] 459 | | where [INFO] [stdout] 460 | | V: Visitor<'de>, [INFO] [stdout] | |________________________- move the `impl` block outside of this method `deserialize_enum` [INFO] [stdout] ... [INFO] [stdout] 480 | impl<'de, 'a, R> serde::de::VariantAccess<'de> for &'a mut Deserializer [INFO] [stdout] | ^^^^^^^^^^^^^^^^^------------------------^^^^^^^^^^^^^^^^^^------------^^^ [INFO] [stdout] | | | [INFO] [stdout] | | `Deserializer` is not local [INFO] [stdout] | `VariantAccess` is not local [INFO] [stdout] | [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `bytekey2` (lib) due to 2 previous errors; 2 warnings emitted [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/de.rs:462:9 [INFO] [stdout] | [INFO] [stdout] 453 | / fn deserialize_enum( [INFO] [stdout] 454 | | self, [INFO] [stdout] 455 | | _name: &'static str, [INFO] [stdout] 456 | | _fields: &'static [&'static str], [INFO] [stdout] ... | [INFO] [stdout] 459 | | where [INFO] [stdout] 460 | | V: Visitor<'de>, [INFO] [stdout] | |________________________- move the `impl` block outside of this method `deserialize_enum` [INFO] [stdout] 461 | { [INFO] [stdout] 462 | impl<'de, 'a, R> serde::de::EnumAccess<'de> for &'a mut Deserializer [INFO] [stdout] | ^^^^^^^^^^^^^^^^^---------------------^^^^^^^^^^^^^^^^^^------------^^^ [INFO] [stdout] | | | [INFO] [stdout] | | `Deserializer` is not local [INFO] [stdout] | `EnumAccess` is not local [INFO] [stdout] | [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue [INFO] [stdout] = note: `#[warn(non_local_definitions)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/de.rs:480:9 [INFO] [stdout] | [INFO] [stdout] 453 | / fn deserialize_enum( [INFO] [stdout] 454 | | self, [INFO] [stdout] 455 | | _name: &'static str, [INFO] [stdout] 456 | | _fields: &'static [&'static str], [INFO] [stdout] ... | [INFO] [stdout] 459 | | where [INFO] [stdout] 460 | | V: Visitor<'de>, [INFO] [stdout] | |________________________- move the `impl` block outside of this method `deserialize_enum` [INFO] [stdout] ... [INFO] [stdout] 480 | impl<'de, 'a, R> serde::de::VariantAccess<'de> for &'a mut Deserializer [INFO] [stdout] | ^^^^^^^^^^^^^^^^^------------------------^^^^^^^^^^^^^^^^^^------------^^^ [INFO] [stdout] | | | [INFO] [stdout] | | `Deserializer` is not local [INFO] [stdout] | `VariantAccess` is not local [INFO] [stdout] | [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `bytekey2` (lib test) due to 2 previous errors; 2 warnings emitted [INFO] running `Command { std: "docker" "inspect" "b64babf936b2ef467fad42d2d547a716b85dff0ba11136ef0fc623fee7285925", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b64babf936b2ef467fad42d2d547a716b85dff0ba11136ef0fc623fee7285925", kill_on_drop: false }` [INFO] [stdout] b64babf936b2ef467fad42d2d547a716b85dff0ba11136ef0fc623fee7285925