[INFO] fetching crate br-http 0.4.12... [INFO] checking br-http-0.4.12 against try#7014e13d5becc920d4bea3cd87942c8a13d359bf+rustflags=-Dtail_expr_drop_order for pr-129864 [INFO] extracting crate br-http 0.4.12 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate br-http 0.4.12 on toolchain 7014e13d5becc920d4bea3cd87942c8a13d359bf [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate br-http 0.4.12 [INFO] finished tweaking crates.io crate br-http 0.4.12 [INFO] tweaked toml for crates.io crate br-http 0.4.12 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] crate crates.io crate br-http 0.4.12 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 0fde48d6163fcd5e56385bf37eb24e148ab900f5074adbed16d04f1b4a0de22a [INFO] running `Command { std: "docker" "start" "-a" "0fde48d6163fcd5e56385bf37eb24e148ab900f5074adbed16d04f1b4a0de22a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "0fde48d6163fcd5e56385bf37eb24e148ab900f5074adbed16d04f1b4a0de22a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0fde48d6163fcd5e56385bf37eb24e148ab900f5074adbed16d04f1b4a0de22a", kill_on_drop: false }` [INFO] [stdout] 0fde48d6163fcd5e56385bf37eb24e148ab900f5074adbed16d04f1b4a0de22a [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 548201aa5b0d7aa33f58b17d8deab2fe22373b8dfd55bae2e099c3331179e459 [INFO] running `Command { std: "docker" "start" "-a" "548201aa5b0d7aa33f58b17d8deab2fe22373b8dfd55bae2e099c3331179e459", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.155 [INFO] [stderr] Checking bytes v1.7.1 [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Compiling pkg-config v0.3.30 [INFO] [stderr] Compiling vcpkg v0.2.15 [INFO] [stderr] Compiling cc v1.1.8 [INFO] [stderr] Compiling unicase v2.7.0 [INFO] [stderr] Checking log v0.4.22 [INFO] [stderr] Checking futures-io v0.3.30 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking unicode-normalization v0.1.23 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Checking http v1.1.0 [INFO] [stderr] Compiling syn v2.0.72 [INFO] [stderr] Checking unicode-bidi v0.3.15 [INFO] [stderr] Checking foreign-types-shared v0.1.1 [INFO] [stderr] Compiling serde v1.0.205 [INFO] [stderr] Compiling openssl v0.10.66 [INFO] [stderr] Checking foreign-types v0.3.2 [INFO] [stderr] Checking indexmap v2.3.0 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Compiling time-core v0.1.2 [INFO] [stderr] Compiling num-conv v0.1.0 [INFO] [stderr] Checking http-body v1.0.1 [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Compiling native-tls v0.2.12 [INFO] [stderr] Compiling time-macros v0.2.18 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Compiling openssl-sys v0.9.103 [INFO] [stderr] Checking socket2 v0.5.7 [INFO] [stderr] Checking mio v1.0.1 [INFO] [stderr] Compiling cookie v0.18.1 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Checking tower-layer v0.3.2 [INFO] [stderr] Checking tokio v1.40.0 [INFO] [stderr] Compiling serde_json v1.0.122 [INFO] [stderr] Checking tower-service v0.3.2 [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Compiling mime_guess v2.0.5 [INFO] [stderr] Checking idna v0.5.0 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking time v0.3.36 [INFO] [stderr] Checking idna v0.3.0 [INFO] [stderr] Checking psl-types v2.0.11 [INFO] [stderr] Checking utf8parse v0.2.2 [INFO] [stderr] Checking anstyle-parse v0.2.5 [INFO] [stderr] Checking url v2.5.2 [INFO] [stderr] Checking publicsuffix v2.2.3 [INFO] [stderr] Checking http-body-util v0.1.2 [INFO] [stderr] Checking anstyle-query v1.1.1 [INFO] [stderr] Checking base64 v0.22.1 [INFO] [stderr] Checking is_terminal_polyfill v1.70.1 [INFO] [stderr] Checking mime v0.3.17 [INFO] [stderr] Checking colorchoice v1.0.2 [INFO] [stderr] Checking rustls-pki-types v1.8.0 [INFO] [stderr] Checking anstream v0.6.15 [INFO] [stderr] Checking rustls-pemfile v2.1.3 [INFO] [stderr] Checking sync_wrapper v1.0.1 [INFO] [stderr] Checking encoding_rs v0.8.34 [INFO] [stderr] Checking humantime v2.1.0 [INFO] [stderr] Checking ipnet v2.9.0 [INFO] [stderr] Checking json v0.12.4 [INFO] [stderr] Checking regex v1.10.6 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking env_filter v0.1.2 [INFO] [stderr] Checking env_logger v0.11.5 [INFO] [stderr] Compiling openssl-macros v0.1.1 [INFO] [stderr] Compiling pin-project-internal v1.1.5 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Compiling serde_derive v1.0.205 [INFO] [stderr] Checking tokio-util v0.7.11 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking h2 v0.4.5 [INFO] [stderr] Checking pin-project v1.1.5 [INFO] [stderr] Checking tower v0.4.13 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking rand_core v0.9.0-alpha.2 [INFO] [stderr] Checking rand_chacha v0.9.0-alpha.2 [INFO] [stderr] Checking rand v0.9.0-alpha.2 [INFO] [stderr] Checking cookie_store v0.21.0 [INFO] [stderr] Checking hyper v1.4.1 [INFO] [stderr] Checking tokio-native-tls v0.3.1 [INFO] [stderr] Checking hyper-util v0.1.7 [INFO] [stderr] Checking hyper-tls v0.6.0 [INFO] [stderr] Checking reqwest v0.12.7 [INFO] [stderr] Checking br-http v0.4.12 (/opt/rustwide/workdir) [INFO] [stdout] error: this value of type `Result` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:248:15 [INFO] [stdout] | [INFO] [stdout] 195 | let client = reqwest::blocking::Client::new(); [INFO] [stdout] | ------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 248 | match request.send() { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.clone()` on a double reference, which returns `&str` instead of cloning the inner type [INFO] [stdout] --> src/lib.rs:138:62 [INFO] [stdout] | [INFO] [stdout] 138 | form = Some(form.take().unwrap().text(key.clone(), value.to_string().clone())); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(suspicious_double_ref_op)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.clone()` on a double reference, which returns `&str` instead of cloning the inner type [INFO] [stdout] --> src/lib.rs:141:62 [INFO] [stdout] | [INFO] [stdout] 141 | form = Some(form.take().unwrap().file(key.clone(), path.to_string().clone()).unwrap_or_default()); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.clone()` on a double reference, which returns `&str` instead of cloning the inner type [INFO] [stdout] --> src/lib.rs:242:41 [INFO] [stdout] | [INFO] [stdout] 242 | request = request.header(key.clone(), value.clone()); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.clone()` on a double reference, which returns `&str` instead of cloning the inner type [INFO] [stdout] --> src/lib.rs:242:56 [INFO] [stdout] | [INFO] [stdout] 242 | request = request.header(key.clone(), value.clone()); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.clone()` on a double reference, which returns `&str` instead of cloning the inner type [INFO] [stdout] --> src/lib.rs:262:43 [INFO] [stdout] | [INFO] [stdout] 262 | let value = header.clone(); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 5 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:248:15 [INFO] [stdout] | [INFO] [stdout] 195 | let client = reqwest::blocking::Client::new(); [INFO] [stdout] | ------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 248 | match request.send() { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `br-http` (lib) due to 2 previous errors; 5 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: using `.clone()` on a double reference, which returns `&str` instead of cloning the inner type [INFO] [stdout] --> src/lib.rs:138:62 [INFO] [stdout] | [INFO] [stdout] 138 | form = Some(form.take().unwrap().text(key.clone(), value.to_string().clone())); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(suspicious_double_ref_op)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.clone()` on a double reference, which returns `&str` instead of cloning the inner type [INFO] [stdout] --> src/lib.rs:141:62 [INFO] [stdout] | [INFO] [stdout] 141 | form = Some(form.take().unwrap().file(key.clone(), path.to_string().clone()).unwrap_or_default()); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.clone()` on a double reference, which returns `&str` instead of cloning the inner type [INFO] [stdout] --> src/lib.rs:242:41 [INFO] [stdout] | [INFO] [stdout] 242 | request = request.header(key.clone(), value.clone()); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.clone()` on a double reference, which returns `&str` instead of cloning the inner type [INFO] [stdout] --> src/lib.rs:242:56 [INFO] [stdout] | [INFO] [stdout] 242 | request = request.header(key.clone(), value.clone()); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.clone()` on a double reference, which returns `&str` instead of cloning the inner type [INFO] [stdout] --> src/lib.rs:262:43 [INFO] [stdout] | [INFO] [stdout] 262 | let value = header.clone(); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 5 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `br-http` (lib test) due to 2 previous errors; 5 warnings emitted [INFO] running `Command { std: "docker" "inspect" "548201aa5b0d7aa33f58b17d8deab2fe22373b8dfd55bae2e099c3331179e459", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "548201aa5b0d7aa33f58b17d8deab2fe22373b8dfd55bae2e099c3331179e459", kill_on_drop: false }` [INFO] [stdout] 548201aa5b0d7aa33f58b17d8deab2fe22373b8dfd55bae2e099c3331179e459