[INFO] fetching crate bonsaidb-core 0.5.0... [INFO] checking bonsaidb-core-0.5.0 against try#7014e13d5becc920d4bea3cd87942c8a13d359bf+rustflags=-Dtail_expr_drop_order for pr-129864 [INFO] extracting crate bonsaidb-core 0.5.0 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate bonsaidb-core 0.5.0 on toolchain 7014e13d5becc920d4bea3cd87942c8a13d359bf [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate bonsaidb-core 0.5.0 [INFO] finished tweaking crates.io crate bonsaidb-core 0.5.0 [INFO] tweaked toml for crates.io crate bonsaidb-core 0.5.0 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 147 packages to latest compatible versions [INFO] [stderr] Adding attribute-derive v0.8.1 (available: v0.10.1) [INFO] [stderr] Adding attribute-derive-macro v0.8.1 (available: v0.10.1) [INFO] [stderr] Adding darling v0.13.4 (available: v0.20.10) [INFO] [stderr] Adding darling_core v0.13.4 (available: v0.20.10) [INFO] [stderr] Adding darling_macro v0.13.4 (available: v0.20.10) [INFO] [stderr] Adding generic-array v0.14.7 (available: v1.1.0) [INFO] [stderr] Adding hermit-abi v0.3.9 (available: v0.4.0) [INFO] [stderr] Adding itertools v0.11.0 (available: v0.13.0) [INFO] [stderr] Adding manyhow v0.8.1 (available: v0.11.4) [INFO] [stderr] Adding manyhow-macros v0.8.1 (available: v0.11.4) [INFO] [stderr] Adding proc-macro-crate v2.0.2 (available: v3.2.0) [INFO] [stderr] Adding proc-macro-utils v0.8.0 (available: v0.10.0) [INFO] [stderr] Adding quote-use v0.7.2 (available: v0.8.4) [INFO] [stderr] Adding quote-use-macros v0.7.2 (available: v0.8.4) [INFO] [stderr] Adding strsim v0.10.0 (available: v0.11.1) [INFO] [stderr] Adding syn v1.0.109 (available: v2.0.77) [INFO] [stderr] Adding toml v0.8.2 (available: v0.8.19) [INFO] [stderr] Adding toml_datetime v0.6.3 (available: v0.6.8) [INFO] [stderr] Adding toml_edit v0.20.2 (available: v0.20.7) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (available: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-sys v0.52.0 (available: v0.59.0) [INFO] [stderr] Adding winnow v0.5.40 (available: v0.6.20) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] ce97691ad691cbdb1ad642c94e677b6dd69e9e1ac6ce50978f2aa0d9b011307f [INFO] running `Command { std: "docker" "start" "-a" "ce97691ad691cbdb1ad642c94e677b6dd69e9e1ac6ce50978f2aa0d9b011307f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "ce97691ad691cbdb1ad642c94e677b6dd69e9e1ac6ce50978f2aa0d9b011307f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ce97691ad691cbdb1ad642c94e677b6dd69e9e1ac6ce50978f2aa0d9b011307f", kill_on_drop: false }` [INFO] [stdout] ce97691ad691cbdb1ad642c94e677b6dd69e9e1ac6ce50978f2aa0d9b011307f [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 4392a093cf3348de39ee4a27737f94c23817e3d58c1140425bf1645d4ba662d1 [INFO] running `Command { std: "docker" "start" "-a" "4392a093cf3348de39ee4a27737f94c23817e3d58c1140425bf1645d4ba662d1", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Compiling serde v1.0.210 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling smallvec v1.13.2 [INFO] [stderr] Checking futures-core v0.3.30 [INFO] [stderr] Compiling hashbrown v0.14.5 [INFO] [stderr] Compiling winnow v0.5.40 [INFO] [stderr] Compiling ident_case v1.0.1 [INFO] [stderr] Compiling fnv v1.0.7 [INFO] [stderr] Compiling strsim v0.10.0 [INFO] [stderr] Checking futures-io v0.3.30 [INFO] [stderr] Compiling serde_json v1.0.128 [INFO] [stderr] Checking half v2.4.1 [INFO] [stderr] Compiling interpolator v0.5.0 [INFO] [stderr] Compiling collection_literals v1.0.1 [INFO] [stderr] Compiling ryu v1.0.18 [INFO] [stderr] Compiling itoa v1.0.11 [INFO] [stderr] Compiling trybuild v1.0.99 [INFO] [stderr] Checking spin v0.9.8 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Compiling termcolor v1.4.1 [INFO] [stderr] Checking transmog v0.1.0 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking itertools v0.11.0 [INFO] [stderr] Checking bytecount v0.6.8 [INFO] [stderr] Checking ordered-varint v2.0.0 [INFO] [stderr] Checking flume v0.11.0 [INFO] [stderr] Checking sha2 v0.10.8 [INFO] [stderr] Compiling indexmap v2.5.0 [INFO] [stderr] Compiling quote v1.0.37 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Compiling proc-macro-utils v0.8.0 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Compiling manyhow-macros v0.8.1 [INFO] [stderr] Compiling toml_datetime v0.6.3 [INFO] [stderr] Compiling serde_spanned v0.6.8 [INFO] [stderr] Compiling toml_edit v0.20.2 [INFO] [stderr] Compiling darling_core v0.13.4 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Compiling manyhow v0.8.1 [INFO] [stderr] Compiling toml v0.8.2 [INFO] [stderr] Compiling proc-macro-crate v2.0.2 [INFO] [stderr] Compiling darling_macro v0.13.4 [INFO] [stderr] Compiling serde_derive v1.0.210 [INFO] [stderr] Compiling thiserror-impl v1.0.64 [INFO] [stderr] Compiling derive-where v1.2.7 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Compiling zeroize_derive v1.4.2 [INFO] [stderr] Compiling async-trait v0.1.83 [INFO] [stderr] Compiling tokio-macros v2.4.0 [INFO] [stderr] Compiling num-derive v0.4.2 [INFO] [stderr] Compiling darling v0.13.4 [INFO] [stderr] Checking tokio v1.40.0 [INFO] [stderr] Checking zeroize v1.8.1 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking thiserror v1.0.64 [INFO] [stderr] Compiling actionable-macros v0.2.0 [INFO] [stderr] Compiling quote-use-macros v0.7.2 [INFO] [stderr] Compiling quote-use v0.7.2 [INFO] [stderr] Compiling attribute-derive-macro v0.8.1 [INFO] [stderr] Compiling attribute-derive v0.8.1 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Compiling bonsaidb-macros v0.5.0 [INFO] [stderr] Checking pot v3.0.1 [INFO] [stderr] Checking arc-bytes v0.3.5 [INFO] [stderr] Checking bincode v1.3.3 [INFO] [stderr] Checking actionable v0.2.0 [INFO] [stderr] Checking transmog-bincode v0.1.0 [INFO] [stderr] Checking transmog-pot v0.3.0 [INFO] [stderr] Checking circulate v0.5.0 [INFO] [stderr] Checking bonsaidb-core v0.5.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: elided lifetime has a name [INFO] [stdout] --> src/key.rs:906:46 [INFO] [stdout] | [INFO] [stdout] 905 | impl<'a, 'k> IntoPrefixRange<'a, Self> for CowBytes<'k> { [INFO] [stdout] | -- lifetime `'a` declared here [INFO] [stdout] 906 | fn to_prefix_range(&'a self) -> RangeRef<'_, Self> { [INFO] [stdout] | ^^ this elided lifetime gets resolved as `'a` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(elided_named_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: elided lifetime has a name [INFO] [stdout] --> src/key.rs:906:46 [INFO] [stdout] | [INFO] [stdout] 905 | impl<'a, 'k> IntoPrefixRange<'a, Self> for CowBytes<'k> { [INFO] [stdout] | -- lifetime `'a` declared here [INFO] [stdout] 906 | fn to_prefix_range(&'a self) -> RangeRef<'_, Self> { [INFO] [stdout] | ^^ this elided lifetime gets resolved as `'a` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(elided_named_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `CollectionDocument` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/test_util.rs:2744:13 [INFO] [stdout] | [INFO] [stdout] 2737 | server: S, [INFO] [stdout] | ------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 2744 | let user = User::get_async(&user_id, admin) [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Vec` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/test_util.rs:3948:9 [INFO] [stdout] | [INFO] [stdout] 3945 | server: C, [INFO] [stdout] | ------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 3948 | let schemas = server.list_available_schemas().await?; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::option::Option>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/schema/collection.rs:1733:37 [INFO] [stdout] | [INFO] [stdout] 1724 | pub fn execute(self) -> Result>, Error> { [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1728 | insert, [INFO] [stdout] | ------ [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 1729 | update, [INFO] [stdout] | ------ [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1733 | if let Some(mut existing) = Col::load(name, connection)? { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::collections::hash_map::Entry<'_, CollectionName, KeyDescription>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/schema/schematic.rs:53:15 [INFO] [stdout] | [INFO] [stdout] 52 | let name = C::collection_name(); [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 53 | match self.contained_collections.entry(name.clone()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::option::Option>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/schema/view/map.rs:160:38 [INFO] [stdout] | [INFO] [stdout] 159 | let mut iter = iter.into_iter(); [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 160 | if let Some(mut collected) = iter.next() { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::option::Option>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/schema/collection.rs:1733:37 [INFO] [stdout] | [INFO] [stdout] 1724 | pub fn execute(self) -> Result>, Error> { [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1728 | insert, [INFO] [stdout] | ------ [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 1729 | update, [INFO] [stdout] | ------ [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1733 | if let Some(mut existing) = Col::load(name, connection)? { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `bonsaidb-core` (lib) due to 4 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: this value of type `std::collections::hash_map::Entry<'_, CollectionName, KeyDescription>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/schema/schematic.rs:53:15 [INFO] [stdout] | [INFO] [stdout] 52 | let name = C::collection_name(); [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 53 | match self.contained_collections.entry(name.clone()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::option::Option>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/schema/view/map.rs:160:38 [INFO] [stdout] | [INFO] [stdout] 159 | let mut iter = iter.into_iter(); [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 160 | if let Some(mut collected) = iter.next() { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `bonsaidb-core` (lib test) due to 6 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "4392a093cf3348de39ee4a27737f94c23817e3d58c1140425bf1645d4ba662d1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4392a093cf3348de39ee4a27737f94c23817e3d58c1140425bf1645d4ba662d1", kill_on_drop: false }` [INFO] [stdout] 4392a093cf3348de39ee4a27737f94c23817e3d58c1140425bf1645d4ba662d1