[INFO] fetching crate bomboni_request 0.1.60... [INFO] checking bomboni_request-0.1.60 against try#7014e13d5becc920d4bea3cd87942c8a13d359bf+rustflags=-Dtail_expr_drop_order for pr-129864 [INFO] extracting crate bomboni_request 0.1.60 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate bomboni_request 0.1.60 on toolchain 7014e13d5becc920d4bea3cd87942c8a13d359bf [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate bomboni_request 0.1.60 [INFO] finished tweaking crates.io crate bomboni_request 0.1.60 [INFO] tweaked toml for crates.io crate bomboni_request 0.1.60 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 209 packages to latest compatible versions [INFO] [stderr] Adding fallible-iterator v0.2.0 (available: v0.3.0) [INFO] [stderr] Adding fixedbitset v0.4.2 (available: v0.5.7) [INFO] [stderr] Adding generic-array v0.14.7 (available: v1.1.0) [INFO] [stderr] Adding hashbrown v0.12.3 (available: v0.14.5) [INFO] [stderr] Adding hermit-abi v0.3.9 (available: v0.4.0) [INFO] [stderr] Adding indexmap v1.9.3 (available: v2.5.0) [INFO] [stderr] Adding linux-raw-sys v0.4.14 (available: v0.6.5) [INFO] [stderr] Adding matchit v0.7.3 (available: v0.8.4) [INFO] [stderr] Adding sync_wrapper v0.1.2 (available: v1.0.1) [INFO] [stderr] Adding tower v0.4.13 (available: v0.5.1) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (available: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-sys v0.52.0 (available: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 37344c9ee06f642adea30e29602dbd041c5490441e8f99a53e24c358d9763ed9 [INFO] running `Command { std: "docker" "start" "-a" "37344c9ee06f642adea30e29602dbd041c5490441e8f99a53e24c358d9763ed9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "37344c9ee06f642adea30e29602dbd041c5490441e8f99a53e24c358d9763ed9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "37344c9ee06f642adea30e29602dbd041c5490441e8f99a53e24c358d9763ed9", kill_on_drop: false }` [INFO] [stdout] 37344c9ee06f642adea30e29602dbd041c5490441e8f99a53e24c358d9763ed9 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 48e024ff73a05f64ef8a861e160a7d5354b4818d65f9a69efa849a98e4afef09 [INFO] running `Command { std: "docker" "start" "-a" "48e024ff73a05f64ef8a861e160a7d5354b4818d65f9a69efa849a98e4afef09", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.159 [INFO] [stderr] Compiling either v1.13.0 [INFO] [stderr] Checking const-oid v0.9.6 [INFO] [stderr] Compiling anyhow v1.0.89 [INFO] [stderr] Compiling prettyplease v0.2.22 [INFO] [stderr] Compiling rustix v0.38.37 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling bitflags v2.6.0 [INFO] [stderr] Compiling regex-syntax v0.8.4 [INFO] [stderr] Compiling linux-raw-sys v0.4.14 [INFO] [stderr] Compiling equivalent v1.0.1 [INFO] [stderr] Compiling hashbrown v0.14.5 [INFO] [stderr] Checking pem-rfc7468 v0.7.0 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Checking serde v1.0.210 [INFO] [stderr] Compiling bomboni_core v0.1.60 [INFO] [stderr] Compiling fastrand v2.1.1 [INFO] [stderr] Compiling fixedbitset v0.4.2 [INFO] [stderr] Compiling multimap v0.10.0 [INFO] [stderr] Compiling ucd-trie v0.1.6 [INFO] [stderr] Compiling darling_core v0.20.10 [INFO] [stderr] Checking der v0.7.9 [INFO] [stderr] Compiling pest v2.7.13 [INFO] [stderr] Compiling num-bigint-dig v0.8.4 [INFO] [stderr] Compiling itertools v0.13.0 [INFO] [stderr] Checking half v2.4.1 [INFO] [stderr] Checking bytes v1.7.2 [INFO] [stderr] Compiling indexmap v2.5.0 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking spki v0.7.3 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Compiling petgraph v0.6.5 [INFO] [stderr] Checking pkcs8 v0.10.2 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking pkcs1 v0.7.5 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking cipher v0.4.4 [INFO] [stderr] Checking universal-hash v0.5.1 [INFO] [stderr] Checking aead v0.5.2 [INFO] [stderr] Compiling regex-automata v0.4.7 [INFO] [stderr] Checking polyval v0.6.2 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking ghash v0.5.1 [INFO] [stderr] Checking ctr v0.9.2 [INFO] [stderr] Checking aes v0.8.4 [INFO] [stderr] Checking signature v2.2.0 [INFO] [stderr] Checking blake2 v0.10.6 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Compiling tempfile v3.12.0 [INFO] [stderr] Compiling darling_macro v0.20.10 [INFO] [stderr] Checking aes-gcm v0.10.3 [INFO] [stderr] Checking num-iter v0.1.45 [INFO] [stderr] Compiling prost-derive v0.13.3 [INFO] [stderr] Compiling darling v0.20.10 [INFO] [stderr] Compiling bomboni_request_derive v0.1.60 [INFO] [stderr] Compiling pest_meta v2.7.13 [INFO] [stderr] Checking deranged v0.3.11 [INFO] [stderr] Checking serde_json v1.0.128 [INFO] [stderr] Checking pot v3.0.1 [INFO] [stderr] Compiling pest_generator v2.7.13 [INFO] [stderr] Compiling regex v1.10.6 [INFO] [stderr] Compiling prost v0.13.3 [INFO] [stderr] Checking time v0.3.36 [INFO] [stderr] Checking rsa v0.9.6 [INFO] [stderr] Compiling prost-types v0.13.3 [INFO] [stderr] Compiling pest_derive v2.7.13 [INFO] [stderr] Compiling prost-build v0.13.3 [INFO] [stderr] Compiling bomboni_prost v0.1.60 [INFO] [stderr] Checking bomboni_common v0.1.60 [INFO] [stderr] Compiling bomboni_proto v0.1.60 [INFO] [stderr] Checking bomboni_request v0.1.60 (/opt/rustwide/workdir) [INFO] [stdout] error: this value of type `RequestError` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/error.rs:245:13 [INFO] [stdout] | [INFO] [stdout] 230 | pub fn wrap_path

(self, path: P) -> Self [INFO] [stdout] | ---- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 245 | err => panic!("cannot wrap error path `{path:?}` for: {err:?}"), [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `RequestError` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/error.rs:266:13 [INFO] [stdout] | [INFO] [stdout] 250 | pub fn insert_path

(self, path: P, index: usize) -> Self [INFO] [stdout] | ---- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 266 | err => panic!("cannot insert error path `{path:?}` for: {err:?}"), [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `bomboni_request` (lib) due to 3 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: this value of type `error::RequestError` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/error.rs:245:13 [INFO] [stdout] | [INFO] [stdout] 230 | pub fn wrap_path

(self, path: P) -> Self [INFO] [stdout] | ---- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 245 | err => panic!("cannot wrap error path `{path:?}` for: {err:?}"), [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `error::RequestError` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/error.rs:266:13 [INFO] [stdout] | [INFO] [stdout] 250 | pub fn insert_path

(self, path: P, index: usize) -> Self [INFO] [stdout] | ---- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 266 | err => panic!("cannot insert error path `{path:?}` for: {err:?}"), [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/parse/mod.rs:1767:9 [INFO] [stdout] | [INFO] [stdout] 1738 | fn parse_generics() { [INFO] [stdout] | ------------------- move the `impl` block outside of this function `parse_generics` [INFO] [stdout] ... [INFO] [stdout] 1767 | impl RequestParse for i32 { [INFO] [stdout] | ^^^^^------------^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | `RequestParse` is not local [INFO] [stdout] | [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue [INFO] [stdout] = note: `#[warn(non_local_definitions)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `bomboni_request` (lib test) due to 3 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "48e024ff73a05f64ef8a861e160a7d5354b4818d65f9a69efa849a98e4afef09", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "48e024ff73a05f64ef8a861e160a7d5354b4818d65f9a69efa849a98e4afef09", kill_on_drop: false }` [INFO] [stdout] 48e024ff73a05f64ef8a861e160a7d5354b4818d65f9a69efa849a98e4afef09