[INFO] fetching crate beancount-parser 2.2.1... [INFO] checking beancount-parser-2.2.1 against try#7014e13d5becc920d4bea3cd87942c8a13d359bf+rustflags=-Dtail_expr_drop_order for pr-129864 [INFO] extracting crate beancount-parser 2.2.1 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate beancount-parser 2.2.1 on toolchain 7014e13d5becc920d4bea3cd87942c8a13d359bf [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate beancount-parser 2.2.1 [INFO] removed 0 missing examples [INFO] finished tweaking crates.io crate beancount-parser 2.2.1 [INFO] tweaked toml for crates.io crate beancount-parser 2.2.1 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] crate crates.io crate beancount-parser 2.2.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 5c1c9f8df3d940197565a6ce367bba514fb0d152dd6c3e1241b5aa435c198dc6 [INFO] running `Command { std: "docker" "start" "-a" "5c1c9f8df3d940197565a6ce367bba514fb0d152dd6c3e1241b5aa435c198dc6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "5c1c9f8df3d940197565a6ce367bba514fb0d152dd6c3e1241b5aa435c198dc6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5c1c9f8df3d940197565a6ce367bba514fb0d152dd6c3e1241b5aa435c198dc6", kill_on_drop: false }` [INFO] [stdout] 5c1c9f8df3d940197565a6ce367bba514fb0d152dd6c3e1241b5aa435c198dc6 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] beb81cbe52b90d93c400da0468c913bae544127daa3bc8c58fecdc8f1fa1bbcd [INFO] running `Command { std: "docker" "start" "-a" "beb81cbe52b90d93c400da0468c913bae544127daa3bc8c58fecdc8f1fa1bbcd", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.81 [INFO] [stderr] Compiling libc v0.2.153 [INFO] [stderr] Compiling cc v1.0.95 [INFO] [stderr] Checking memchr v2.7.2 [INFO] [stderr] Compiling crossbeam-utils v0.8.19 [INFO] [stderr] Compiling semver v1.0.22 [INFO] [stderr] Compiling serde v1.0.199 [INFO] [stderr] Compiling autocfg v1.2.0 [INFO] [stderr] Compiling num-traits v0.2.18 [INFO] [stderr] Compiling ahash v0.8.11 [INFO] [stderr] Compiling rustc_version v0.4.0 [INFO] [stderr] Checking crossbeam-epoch v0.9.18 [INFO] [stderr] Compiling regex-syntax v0.8.3 [INFO] [stderr] Checking is-terminal v0.4.12 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Compiling thiserror v1.0.59 [INFO] [stderr] Checking either v1.11.0 [INFO] [stderr] Compiling syn v2.0.60 [INFO] [stderr] Compiling aho-corasick v1.1.3 [INFO] [stderr] Checking gimli v0.28.1 [INFO] [stderr] Compiling serde_json v1.0.116 [INFO] [stderr] Compiling rstest_macros v0.19.0 [INFO] [stderr] Checking crossbeam-deque v0.8.5 [INFO] [stderr] Checking miniz_oxide v0.7.2 [INFO] [stderr] Checking object v0.32.2 [INFO] [stderr] Compiling psm v0.1.21 [INFO] [stderr] Compiling backtrace v0.3.71 [INFO] [stderr] Compiling stacker v0.1.15 [INFO] [stderr] Checking half v2.4.1 [INFO] [stderr] Checking ryu v1.0.17 [INFO] [stderr] Checking anstyle v1.0.6 [INFO] [stderr] Checking zerocopy v0.7.32 [INFO] [stderr] Checking plotters-backend v0.3.5 [INFO] [stderr] Checking ciborium-io v0.2.2 [INFO] [stderr] Checking clap_lex v0.7.0 [INFO] [stderr] Checking minimal-lexical v0.2.1 [INFO] [stderr] Checking rustc-demangle v0.1.23 [INFO] [stderr] Checking nom v7.1.3 [INFO] [stderr] Checking clap_builder v4.5.2 [INFO] [stderr] Checking plotters-svg v0.3.5 [INFO] [stderr] Compiling regex-automata v0.4.6 [INFO] [stderr] Checking addr2line v0.21.0 [INFO] [stderr] Checking ciborium-ll v0.2.2 [INFO] [stderr] Checking rayon-core v1.12.1 [INFO] [stderr] Checking itertools v0.10.5 [INFO] [stderr] Checking smawk v0.3.2 [INFO] [stderr] Checking unicode-linebreak v0.1.5 [INFO] [stderr] Compiling glob v0.3.1 [INFO] [stderr] Compiling relative-path v1.9.2 [INFO] [stderr] Compiling rust_decimal v1.35.0 [INFO] [stderr] Checking unicode-width v0.1.12 [INFO] [stderr] Checking bytecount v0.6.8 [INFO] [stderr] Checking is_ci v1.2.0 [INFO] [stderr] Checking hashbrown v0.14.3 [INFO] [stderr] Checking supports-color v2.1.0 [INFO] [stderr] Checking nom_locate v4.2.0 [INFO] [stderr] Checking regex v1.10.4 [INFO] [stderr] Checking textwrap v0.15.2 [INFO] [stderr] Checking rayon v1.10.0 [INFO] [stderr] Checking clap v4.5.4 [INFO] [stderr] Checking plotters v0.3.5 [INFO] [stderr] Checking backtrace-ext v0.2.1 [INFO] [stderr] Checking supports-unicode v2.1.0 [INFO] [stderr] Checking supports-hyperlinks v2.1.0 [INFO] [stderr] Checking terminal_size v0.1.17 [INFO] [stderr] Checking oorandom v11.1.3 [INFO] [stderr] Checking arrayvec v0.7.4 [INFO] [stderr] Checking anes v0.1.6 [INFO] [stderr] Checking owo-colors v3.5.0 [INFO] [stderr] Checking chumsky v0.9.3 [INFO] [stderr] Checking criterion-plot v0.5.0 [INFO] [stderr] Compiling serde_derive v1.0.199 [INFO] [stderr] Compiling thiserror-impl v1.0.59 [INFO] [stderr] Compiling miette-derive v5.10.0 [INFO] [stderr] Checking miette v5.10.0 [INFO] [stderr] Checking beancount-parser v2.2.1 (/opt/rustwide/workdir) [INFO] [stderr] Checking rstest v0.19.0 [INFO] [stderr] Checking ciborium v0.2.2 [INFO] [stderr] Checking tinytemplate v1.2.1 [INFO] [stderr] Checking criterion v0.5.1 [INFO] [stdout] warning: missing documentation for the crate [INFO] [stdout] --> tests/parse_from_file_spec.rs:1:1 [INFO] [stdout] | [INFO] [stdout] 1 | / use std::path::PathBuf; [INFO] [stdout] 2 | | [INFO] [stdout] 3 | | use rstest::rstest; [INFO] [stdout] ... | [INFO] [stdout] 17 | | assert_eq!(file.directives.len(), expected_directive_count); [INFO] [stdout] 18 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = note: requested on the command line with `-W missing-docs` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::vec::IntoIter>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> tests/rust_decimal_spec.rs:44:5 [INFO] [stdout] | [INFO] [stdout] 37 | let trx = parse_single_transaction(input); [INFO] [stdout] | --- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 44 | trx.postings.into_iter().next().unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: missing documentation for the crate [INFO] [stdout] --> tests/rust_decimal_spec.rs:1:1 [INFO] [stdout] | [INFO] [stdout] 1 | / #![allow(clippy::items_after_test_module)] [INFO] [stdout] 2 | | [INFO] [stdout] 3 | | use rstest::rstest; [INFO] [stdout] 4 | | use rust_decimal::Decimal; [INFO] [stdout] ... | [INFO] [stdout] 52 | | trx [INFO] [stdout] 53 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = note: requested on the command line with `-W missing-docs` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: missing documentation for the crate [INFO] [stdout] --> tests/util_spec.rs:1:1 [INFO] [stdout] | [INFO] [stdout] 1 | / use std::fmt::Debug; [INFO] [stdout] 2 | | [INFO] [stdout] 3 | | use rstest::rstest; [INFO] [stdout] ... | [INFO] [stdout] 98 | | assert_eq!(from_file, from_str); [INFO] [stdout] 99 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = note: requested on the command line with `-W missing-docs` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `beancount-parser` (test "rust_decimal_spec") due to 2 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `HashMap>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> tests/parser_spec.rs:402:9 [INFO] [stdout] | [INFO] [stdout] 400 | #[case] expected_value: metadata::Value, [INFO] [stdout] | -------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 401 | ) { [INFO] [stdout] 402 | let metadata = parse_single_directive(input).metadata; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: missing documentation for the crate [INFO] [stdout] --> tests/parser_spec.rs:1:1 [INFO] [stdout] | [INFO] [stdout] 1 | / #![allow(clippy::items_after_test_module, clippy::pedantic)] [INFO] [stdout] 2 | | [INFO] [stdout] 3 | | use std::{collections::HashSet, path::Path}; [INFO] [stdout] ... | [INFO] [stdout] 527 | | directives.into_iter().next().unwrap() [INFO] [stdout] 528 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = note: requested on the command line with `-W missing-docs` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `beancount-parser` (test "parser_spec") due to 2 previous errors; 1 warning emitted [INFO] [stdout] error: this value of type `Amount` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> tests/trx_parser_spec.rs:264:28 [INFO] [stdout] | [INFO] [stdout] 260 | #[case] expected_value: impl Into, [INFO] [stdout] | -------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 264 | let PostingPrice::Unit(amount) = parse_single_posting(&input).price.unwrap() else { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Amount` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> tests/trx_parser_spec.rs:284:29 [INFO] [stdout] | [INFO] [stdout] 280 | #[case] expected_value: impl Into, [INFO] [stdout] | -------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 284 | let PostingPrice::Total(amount) = parse_single_posting(&input).price.unwrap() else { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::vec::IntoIter>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> tests/trx_parser_spec.rs:448:5 [INFO] [stdout] | [INFO] [stdout] 441 | let trx = parse_single_transaction(input); [INFO] [stdout] | --- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 448 | trx.postings.into_iter().next().unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: missing documentation for the crate [INFO] [stdout] --> tests/trx_parser_spec.rs:1:1 [INFO] [stdout] | [INFO] [stdout] 1 | / #![allow(clippy::items_after_test_module, clippy::pedantic)] [INFO] [stdout] 2 | | [INFO] [stdout] 3 | | use std::collections::HashSet; [INFO] [stdout] ... | [INFO] [stdout] 456 | | trx [INFO] [stdout] 457 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = note: requested on the command line with `-W missing-docs` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `beancount-parser` (test "trx_parser_spec") due to 4 previous errors; 1 warning emitted [INFO] [stdout] error: this value of type `metadata::Key` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/metadata.rs:200:18 [INFO] [stdout] | [INFO] [stdout] 197 | #[case] expected_key: Key, [INFO] [stdout] | ------------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 198 | #[case] expected_value: Value, [INFO] [stdout] | -------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 199 | ) { [INFO] [stdout] 200 | let (key, value): (Key, Value) = entry().then_ignore(end()).parse(input).unwrap(); [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `transaction::Posting` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/transaction.rs:628:17 [INFO] [stdout] | [INFO] [stdout] 627 | fn should_parse_posting_amount(#[case] input: &str, #[case] expected: Option>) { [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 628 | let posting: Posting = posting().then_ignore(end()).parse(input).unwrap(); [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `transaction::Posting` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/transaction.rs:649:17 [INFO] [stdout] | [INFO] [stdout] 647 | #[case] expected: Option>, [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 648 | ) { [INFO] [stdout] 649 | let posting: Posting = posting().then_ignore(end()).parse(input).unwrap(); [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `transaction::Posting` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/transaction.rs:659:17 [INFO] [stdout] | [INFO] [stdout] 658 | fn should_parse_posting_cost(#[case] input: &str, #[case] expected: Option>) { [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 659 | let posting: Posting = posting().then_ignore(end()).parse(input).unwrap(); [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `beancount-parser` (lib test) due to 5 previous errors [INFO] running `Command { std: "docker" "inspect" "beb81cbe52b90d93c400da0468c913bae544127daa3bc8c58fecdc8f1fa1bbcd", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "beb81cbe52b90d93c400da0468c913bae544127daa3bc8c58fecdc8f1fa1bbcd", kill_on_drop: false }` [INFO] [stdout] beb81cbe52b90d93c400da0468c913bae544127daa3bc8c58fecdc8f1fa1bbcd