[INFO] fetching crate bazeld 0.1.1... [INFO] checking bazeld-0.1.1 against try#7014e13d5becc920d4bea3cd87942c8a13d359bf+rustflags=-Dtail_expr_drop_order for pr-129864 [INFO] extracting crate bazeld 0.1.1 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate bazeld 0.1.1 on toolchain 7014e13d5becc920d4bea3cd87942c8a13d359bf [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate bazeld 0.1.1 [INFO] finished tweaking crates.io crate bazeld 0.1.1 [INFO] tweaked toml for crates.io crate bazeld 0.1.1 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 53 packages to latest compatible versions [INFO] [stderr] Adding aho-corasick v0.6.10 (available: v1.1.3) [INFO] [stderr] Adding ansi_term v0.9.0 (available: v0.12.1) [INFO] [stderr] Adding bitflags v0.8.2 (available: v2.6.0) [INFO] [stderr] Adding clap v2.24.2 (available: v2.34.0) [INFO] [stderr] Adding dtoa v0.4.8 (available: v1.0.9) [INFO] [stderr] Adding env_logger v0.4.3 (available: v0.11.5) [INFO] [stderr] Adding error-chain v0.10.0 (available: v0.12.4) [INFO] [stderr] Adding hermit-abi v0.1.19 (available: v0.4.0) [INFO] [stderr] Adding log v0.3.9 (available: v0.4.22) [INFO] [stderr] Adding regex v0.2.11 (available: v1.10.6) [INFO] [stderr] Adding regex-syntax v0.5.6 (available: v0.8.4) [INFO] [stderr] Adding serde_yaml v0.7.5 (available: v0.9.34+deprecated) [INFO] [stderr] Adding strsim v0.6.0 (available: v0.11.1) [INFO] [stderr] Adding thread_local v0.3.6 (available: v1.1.8) [INFO] [stderr] Adding ucd-util v0.1.10 (available: v0.2.1) [INFO] [stderr] Adding unicode-width v0.1.14 (available: v0.2.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 0fe3fbc22b3c0e882fcfcbed5e35299dd4ce399799a79c6127aada1461e7efe4 [INFO] running `Command { std: "docker" "start" "-a" "0fe3fbc22b3c0e882fcfcbed5e35299dd4ce399799a79c6127aada1461e7efe4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "0fe3fbc22b3c0e882fcfcbed5e35299dd4ce399799a79c6127aada1461e7efe4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0fe3fbc22b3c0e882fcfcbed5e35299dd4ce399799a79c6127aada1461e7efe4", kill_on_drop: false }` [INFO] [stdout] 0fe3fbc22b3c0e882fcfcbed5e35299dd4ce399799a79c6127aada1461e7efe4 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] f9d3e03ce773d6202d9d4a662d7c9aa03571c0efa1e568fea059bfe303e91963 [INFO] running `Command { std: "docker" "start" "-a" "f9d3e03ce773d6202d9d4a662d7c9aa03571c0efa1e568fea059bfe303e91963", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] [stderr] Compiling serde v1.0.210 [INFO] [stderr] Checking gimli v0.31.0 [INFO] [stderr] Compiling regex v0.2.11 [INFO] [stderr] Checking ucd-util v0.1.10 [INFO] [stderr] Checking adler2 v2.0.0 [INFO] [stderr] Checking rustc-demangle v0.1.24 [INFO] [stderr] Checking linked-hash-map v0.5.6 [INFO] [stderr] Checking utf8-ranges v1.0.5 [INFO] [stderr] Checking vec_map v0.8.2 [INFO] [stderr] Checking object v0.36.4 [INFO] [stderr] Checking thread_local v0.3.6 [INFO] [stderr] Checking aho-corasick v0.6.10 [INFO] [stderr] Checking log v0.3.9 [INFO] [stderr] Checking unicode-width v0.1.14 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking term_size v0.3.2 [INFO] [stderr] Checking miniz_oxide v0.8.0 [INFO] [stderr] Checking ansi_term v0.9.0 [INFO] [stderr] Checking unicode-segmentation v1.12.0 [INFO] [stderr] Checking regex-syntax v0.5.6 [INFO] [stderr] Checking strsim v0.6.0 [INFO] [stderr] Checking bitflags v0.8.2 [INFO] [stderr] Checking dtoa v0.4.8 [INFO] [stderr] Checking yaml-rust v0.4.5 [INFO] [stderr] Checking clap v2.24.2 [INFO] [stderr] Checking env_logger v0.4.3 [INFO] [stderr] Checking addr2line v0.24.1 [INFO] [stderr] Checking serde_yaml v0.7.5 [INFO] [stderr] Checking backtrace v0.3.74 [INFO] [stderr] Checking error-chain v0.10.0 [INFO] [stderr] Checking bazeld v0.1.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/config.rs:32:3 [INFO] [stdout] | [INFO] [stdout] 32 | try!(buf_reader.read_to_string(&mut contents)); [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/config.rs:29:14 [INFO] [stdout] | [INFO] [stdout] 29 | let file = try!(File::open(finalized_path)); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/config.rs:35:6 [INFO] [stdout] | [INFO] [stdout] 35 | Ok(try!(yaml_from_str(&contents))) [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/config.rs:32:3 [INFO] [stdout] | [INFO] [stdout] 32 | try!(buf_reader.read_to_string(&mut contents)); [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/config.rs:29:14 [INFO] [stdout] | [INFO] [stdout] 29 | let file = try!(File::open(finalized_path)); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/config.rs:35:6 [INFO] [stdout] | [INFO] [stdout] 35 | Ok(try!(yaml_from_str(&contents))) [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::error::Error::description`: use the Display impl or to_string() [INFO] [stdout] --> src/errors.rs:4:1 [INFO] [stdout] | [INFO] [stdout] 4 | / error_chain! { [INFO] [stdout] 5 | | [INFO] [stdout] 6 | | foreign_links { [INFO] [stdout] 7 | | IoError(io::Error); [INFO] [stdout] 8 | | YamlError(serde_yaml::Error); [INFO] [stdout] 9 | | } [INFO] [stdout] 10 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = note: this warning originates in the macro `error_chain_processed` which comes from the expansion of the macro `error_chain` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::error::Error::description`: use the Display impl or to_string() [INFO] [stdout] --> src/errors.rs:4:1 [INFO] [stdout] | [INFO] [stdout] 4 | / error_chain! { [INFO] [stdout] 5 | | [INFO] [stdout] 6 | | foreign_links { [INFO] [stdout] 7 | | IoError(io::Error); [INFO] [stdout] 8 | | YamlError(serde_yaml::Error); [INFO] [stdout] 9 | | } [INFO] [stdout] 10 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = note: this warning originates in the macro `error_chain_processed` which comes from the expansion of the macro `error_chain` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::error::Error::cause`: replaced by Error::source, which can support downcasting [INFO] [stdout] --> src/errors.rs:4:1 [INFO] [stdout] | [INFO] [stdout] 4 | / error_chain! { [INFO] [stdout] 5 | | [INFO] [stdout] 6 | | foreign_links { [INFO] [stdout] 7 | | IoError(io::Error); [INFO] [stdout] 8 | | YamlError(serde_yaml::Error); [INFO] [stdout] 9 | | } [INFO] [stdout] 10 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = note: this warning originates in the macro `error_chain_processed` which comes from the expansion of the macro `error_chain` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::error::Error::cause`: replaced by Error::source, which can support downcasting [INFO] [stdout] --> src/errors.rs:4:1 [INFO] [stdout] | [INFO] [stdout] 4 | / error_chain! { [INFO] [stdout] 5 | | [INFO] [stdout] 6 | | foreign_links { [INFO] [stdout] 7 | | IoError(io::Error); [INFO] [stdout] 8 | | YamlError(serde_yaml::Error); [INFO] [stdout] 9 | | } [INFO] [stdout] 10 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = note: this warning originates in the macro `error_chain_processed` which comes from the expansion of the macro `error_chain` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::result::Result` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/config.rs:35:11 [INFO] [stdout] | [INFO] [stdout] 30 | let mut buf_reader = BufReader::new(file); [INFO] [stdout] | -------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 35 | Ok(try!(yaml_from_str(&contents))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::result::Result` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/config.rs:35:11 [INFO] [stdout] | [INFO] [stdout] 30 | let mut buf_reader = BufReader::new(file); [INFO] [stdout] | -------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 35 | Ok(try!(yaml_from_str(&contents))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/config.rs:25:42 [INFO] [stdout] | [INFO] [stdout] 25 | let finalized_path = new_path.as_path().clone(); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `Path` does not implement `Clone`, so calling `clone` on `&Path` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 25 - let finalized_path = new_path.as_path().clone(); [INFO] [stdout] 25 + let finalized_path = new_path.as_path(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/config.rs:25:42 [INFO] [stdout] | [INFO] [stdout] 25 | let finalized_path = new_path.as_path().clone(); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `Path` does not implement `Clone`, so calling `clone` on `&Path` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 25 - let finalized_path = new_path.as_path().clone(); [INFO] [stdout] 25 + let finalized_path = new_path.as_path(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 6 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 6 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `bazeld` (bin "bazeld") due to 2 previous errors; 6 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `bazeld` (bin "bazeld" test) due to 2 previous errors; 6 warnings emitted [INFO] running `Command { std: "docker" "inspect" "f9d3e03ce773d6202d9d4a662d7c9aa03571c0efa1e568fea059bfe303e91963", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f9d3e03ce773d6202d9d4a662d7c9aa03571c0efa1e568fea059bfe303e91963", kill_on_drop: false }` [INFO] [stdout] f9d3e03ce773d6202d9d4a662d7c9aa03571c0efa1e568fea059bfe303e91963