[INFO] fetching crate balena-cdsl 0.10.6... [INFO] checking balena-cdsl-0.10.6 against try#7014e13d5becc920d4bea3cd87942c8a13d359bf+rustflags=-Dtail_expr_drop_order for pr-129864 [INFO] extracting crate balena-cdsl 0.10.6 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate balena-cdsl 0.10.6 on toolchain 7014e13d5becc920d4bea3cd87942c8a13d359bf [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] removed /workspace/builds/worker-1-tc2/source/rust-toolchain [INFO] started tweaking crates.io crate balena-cdsl 0.10.6 [INFO] finished tweaking crates.io crate balena-cdsl 0.10.6 [INFO] tweaked toml for crates.io crate balena-cdsl 0.10.6 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 72 packages to latest compatible versions [INFO] [stderr] Adding ansi_term v0.11.0 (available: v0.12.1) [INFO] [stderr] Adding cfg-if v0.1.10 (available: v1.0.0) [INFO] [stderr] Adding error-chain v0.10.0 (available: v0.12.4) [INFO] [stderr] Adding futures v0.1.31 (available: v0.3.30) [INFO] [stderr] Adding hashbrown v0.12.3 (available: v0.14.5) [INFO] [stderr] Adding heck v0.3.3 (available: v0.5.0) [INFO] [stderr] Adding indexmap v1.9.3 (available: v2.5.0) [INFO] [stderr] Adding itertools v0.7.11 (available: v0.13.0) [INFO] [stderr] Adding pretty_assertions v0.5.1 (available: v1.4.1) [INFO] [stderr] Adding proc-macro2 v0.4.30 (available: v1.0.86) [INFO] [stderr] Adding quote v0.6.13 (available: v1.0.37) [INFO] [stderr] Adding serde_yaml v0.8.26 (available: v0.9.34+deprecated) [INFO] [stderr] Adding strfmt v0.1.6 (available: v0.2.4) [INFO] [stderr] Adding unicode-xid v0.1.0 (available: v0.2.6) [INFO] [stderr] Adding wasm-bindgen-futures v0.3.27 (available: v0.4.43) [INFO] [stderr] Adding wasm-bindgen-test v0.2.50 (available: v0.3.43) [INFO] [stderr] Adding wasm-bindgen-test-macro v0.2.50 (available: v0.3.43) [INFO] [stderr] Adding yaml-merge-keys v0.3.0 (available: v0.7.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 6e72fb188523f88680c2da7ea04443821c95653f9524ff34cb2eab2c17d5db85 [INFO] running `Command { std: "docker" "start" "-a" "6e72fb188523f88680c2da7ea04443821c95653f9524ff34cb2eab2c17d5db85", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "6e72fb188523f88680c2da7ea04443821c95653f9524ff34cb2eab2c17d5db85", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6e72fb188523f88680c2da7ea04443821c95653f9524ff34cb2eab2c17d5db85", kill_on_drop: false }` [INFO] [stdout] 6e72fb188523f88680c2da7ea04443821c95653f9524ff34cb2eab2c17d5db85 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 829b48c6cedaa51857664ed473e67bc8a9b7d12dd5036b2d3a9029337fb2124f [INFO] running `Command { std: "docker" "start" "-a" "829b48c6cedaa51857664ed473e67bc8a9b7d12dd5036b2d3a9029337fb2124f", kill_on_drop: false }` [INFO] [stderr] Compiling indexmap v1.9.3 [INFO] [stderr] Checking hashbrown v0.12.3 [INFO] [stderr] Checking yaml-rust v0.4.5 [INFO] [stderr] Compiling strfmt v0.1.6 [INFO] [stderr] Checking regex-syntax v0.8.4 [INFO] [stderr] Checking error-chain v0.10.0 [INFO] [stderr] Checking itertools v0.7.11 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking unicode-segmentation v1.12.0 [INFO] [stderr] Checking difference v2.0.0 [INFO] [stderr] Checking ansi_term v0.11.0 [INFO] [stderr] Checking pretty_assertions v0.5.1 [INFO] [stderr] Checking heck v0.3.3 [INFO] [stderr] Compiling balena-cdsl v0.10.6 (/opt/rustwide/workdir) [INFO] [stdout] warning: field `message` is never read [INFO] [stdout] --> build.rs:48:5 [INFO] [stdout] | [INFO] [stdout] 47 | struct Error { [INFO] [stdout] | ----- field in this struct [INFO] [stdout] 48 | message: String, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Error` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking serde_yaml v0.8.26 [INFO] [stderr] Checking yaml-merge-keys v0.3.0 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Compiling serde_derive v1.0.210 [INFO] [stderr] Checking regex v1.10.6 [INFO] [stdout] error: this value of type `IntegerObjectBounds` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dsl/schema/object_types/bounds/mod.rs:77:55 [INFO] [stdout] | [INFO] [stdout] 76 | pub fn with_defaults(self, defaults: IntegerObjectBounds) -> IntegerObjectBounds { [INFO] [stdout] | ---- -------- [INFO] [stdout] | | | [INFO] [stdout] | | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 77 | if let IntegerObjectBounds::Conditions(old) = self.clone() { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `IntegerObjectBounds` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dsl/schema/object_types/bounds/mod.rs:77:55 [INFO] [stdout] | [INFO] [stdout] 76 | pub fn with_defaults(self, defaults: IntegerObjectBounds) -> IntegerObjectBounds { [INFO] [stdout] | ---- -------- [INFO] [stdout] | | | [INFO] [stdout] | | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 77 | if let IntegerObjectBounds::Conditions(old) = self.clone() { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `message` is never read [INFO] [stdout] --> src/dsl/schema/compiler/mod.rs:19:5 [INFO] [stdout] | [INFO] [stdout] 18 | pub struct CompilationError { [INFO] [stdout] | ---------------- field in this struct [INFO] [stdout] 19 | message: String, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `CompilationError` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `&Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/output/serialization/object_types.rs:136:18 [INFO] [stdout] | [INFO] [stdout] 136 | for value in default { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(for_loops_over_fallibles)]` on by default [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 136 | while let Some(value) = default { [INFO] [stdout] | ~~~~~~~~~~~~~~~ ~~~ [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 136 | if let Some(value) = default { [INFO] [stdout] | ~~~~~~~~~~~~ ~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `&Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/output/serialization/object_types.rs:158:31 [INFO] [stdout] | [INFO] [stdout] 158 | for enumeration_values in bounds { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 158 | while let Some(enumeration_values) = bounds { [INFO] [stdout] | ~~~~~~~~~~~~~~~ ~~~ [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 158 | if let Some(enumeration_values) = bounds { [INFO] [stdout] | ~~~~~~~~~~~~ ~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `message` is never read [INFO] [stdout] --> src/dsl/schema/compiler/mod.rs:19:5 [INFO] [stdout] | [INFO] [stdout] 18 | pub struct CompilationError { [INFO] [stdout] | ---------------- field in this struct [INFO] [stdout] 19 | message: String, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `CompilationError` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `&Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/output/serialization/object_types.rs:136:18 [INFO] [stdout] | [INFO] [stdout] 136 | for value in default { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(for_loops_over_fallibles)]` on by default [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 136 | while let Some(value) = default { [INFO] [stdout] | ~~~~~~~~~~~~~~~ ~~~ [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 136 | if let Some(value) = default { [INFO] [stdout] | ~~~~~~~~~~~~ ~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `&Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/output/serialization/object_types.rs:158:31 [INFO] [stdout] | [INFO] [stdout] 158 | for enumeration_values in bounds { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 158 | while let Some(enumeration_values) = bounds { [INFO] [stdout] | ~~~~~~~~~~~~~~~ ~~~ [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 158 | if let Some(enumeration_values) = bounds { [INFO] [stdout] | ~~~~~~~~~~~~ ~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `balena-cdsl` (lib) due to 2 previous errors; 3 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 1 previous error; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `balena-cdsl` (lib test) due to 2 previous errors; 3 warnings emitted [INFO] running `Command { std: "docker" "inspect" "829b48c6cedaa51857664ed473e67bc8a9b7d12dd5036b2d3a9029337fb2124f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "829b48c6cedaa51857664ed473e67bc8a9b7d12dd5036b2d3a9029337fb2124f", kill_on_drop: false }` [INFO] [stdout] 829b48c6cedaa51857664ed473e67bc8a9b7d12dd5036b2d3a9029337fb2124f