[INFO] fetching crate az65 0.1.11... [INFO] checking az65-0.1.11 against try#7014e13d5becc920d4bea3cd87942c8a13d359bf+rustflags=-Dtail_expr_drop_order for pr-129864 [INFO] extracting crate az65 0.1.11 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate az65 0.1.11 on toolchain 7014e13d5becc920d4bea3cd87942c8a13d359bf [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] removed /workspace/builds/worker-2-tc2/source/rust-toolchain.toml [INFO] started tweaking crates.io crate az65 0.1.11 [INFO] finished tweaking crates.io crate az65 0.1.11 [INFO] tweaked toml for crates.io crate az65 0.1.11 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] crate crates.io crate az65 0.1.11 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] b677d7b69083d40e59ebdaaba28f5eb601768f763093954ecedb0735adf3adef [INFO] running `Command { std: "docker" "start" "-a" "b677d7b69083d40e59ebdaaba28f5eb601768f763093954ecedb0735adf3adef", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "b677d7b69083d40e59ebdaaba28f5eb601768f763093954ecedb0735adf3adef", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b677d7b69083d40e59ebdaaba28f5eb601768f763093954ecedb0735adf3adef", kill_on_drop: false }` [INFO] [stdout] b677d7b69083d40e59ebdaaba28f5eb601768f763093954ecedb0735adf3adef [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 9b472ce1b79b0d090b7bf79fd31c4891bda0677e0df8840c7ce6ff4a16d0711a [INFO] running `Command { std: "docker" "start" "-a" "9b472ce1b79b0d090b7bf79fd31c4891bda0677e0df8840c7ce6ff4a16d0711a", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.43 [INFO] [stderr] Compiling quote v1.0.21 [INFO] [stderr] Compiling unicode-ident v1.0.3 [INFO] [stderr] Compiling syn v1.0.99 [INFO] [stderr] Compiling version_check v0.9.4 [INFO] [stderr] Compiling libc v0.2.132 [INFO] [stderr] Compiling autocfg v1.1.0 [INFO] [stderr] Checking once_cell v1.14.0 [INFO] [stderr] Checking hashbrown v0.12.3 [INFO] [stderr] Checking os_str_bytes v6.3.0 [INFO] [stderr] Compiling heck v0.4.0 [INFO] [stderr] Checking path-dedot v3.0.17 [INFO] [stderr] Checking termcolor v1.1.3 [INFO] [stderr] Compiling indexmap v1.9.1 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Checking clap_lex v0.2.4 [INFO] [stderr] Checking strsim v0.10.0 [INFO] [stderr] Checking textwrap v0.15.0 [INFO] [stderr] Checking byteorder v1.4.3 [INFO] [stderr] Checking path-absolutize v3.0.13 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking fxhash v0.2.1 [INFO] [stderr] Compiling microserde-derive v0.1.13 [INFO] [stderr] Compiling clap_derive v3.2.18 [INFO] [stderr] Compiling thiserror-impl v1.0.34 [INFO] [stderr] Checking microserde v0.1.13 [INFO] [stderr] Checking thiserror v1.0.34 [INFO] [stderr] Checking clap v3.2.20 [INFO] [stderr] Checking az65 v0.1.11 (/opt/rustwide/workdir) [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/debug.rs:48:10 [INFO] [stdout] | [INFO] [stdout] 48 | #[derive(microserde::Serialize)] [INFO] [stdout] | ^-------------------- [INFO] [stdout] | | [INFO] [stdout] | `Serialize` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_IMPL_MINISERIALIZE_FOR_DebugSymbol` [INFO] [stdout] 49 | struct DebugSymbol { [INFO] [stdout] | ----------- `DebugSymbol` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `microserde::Serialize` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `microserde::Serialize` may come from an old version of the `microserde_derive` crate, try updating your dependency with `cargo update -p microserde_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue [INFO] [stdout] = note: `#[warn(non_local_definitions)]` on by default [INFO] [stdout] = note: this warning originates in the derive macro `microserde::Serialize` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result<(Rc>, FileManager, Symtab), LinkerError>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bin/az65.rs:161:11 [INFO] [stdout] | [INFO] [stdout] 87 | let mut output: Box = if let Some(path) = args.output { [INFO] [stdout] | ---------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 161 | match module.link(&mut output) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `az65` (bin "az65") due to 2 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: this value of type `Result<(Rc>, FileManager, Symtab), LinkerError>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bin/az65.rs:161:11 [INFO] [stdout] | [INFO] [stdout] 87 | let mut output: Box = if let Some(path) = args.output { [INFO] [stdout] | ---------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 161 | match module.link(&mut output) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `az65` (bin "az65" test) due to 2 previous errors [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/debug.rs:48:10 [INFO] [stdout] | [INFO] [stdout] 48 | #[derive(microserde::Serialize)] [INFO] [stdout] | ^-------------------- [INFO] [stdout] | | [INFO] [stdout] | `Serialize` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_IMPL_MINISERIALIZE_FOR_DebugSymbol` [INFO] [stdout] 49 | struct DebugSymbol { [INFO] [stdout] | ----------- `DebugSymbol` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `microserde::Serialize` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `microserde::Serialize` may come from an old version of the `microserde_derive` crate, try updating your dependency with `cargo update -p microserde_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue [INFO] [stdout] = note: `#[warn(non_local_definitions)]` on by default [INFO] [stdout] = note: this warning originates in the derive macro `microserde::Serialize` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] running `Command { std: "docker" "inspect" "9b472ce1b79b0d090b7bf79fd31c4891bda0677e0df8840c7ce6ff4a16d0711a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9b472ce1b79b0d090b7bf79fd31c4891bda0677e0df8840c7ce6ff4a16d0711a", kill_on_drop: false }` [INFO] [stdout] 9b472ce1b79b0d090b7bf79fd31c4891bda0677e0df8840c7ce6ff4a16d0711a