[INFO] fetching crate aws-smithy-http-server 0.63.3... [INFO] checking aws-smithy-http-server-0.63.3 against try#7014e13d5becc920d4bea3cd87942c8a13d359bf+rustflags=-Dtail_expr_drop_order for pr-129864 [INFO] extracting crate aws-smithy-http-server 0.63.3 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate aws-smithy-http-server 0.63.3 on toolchain 7014e13d5becc920d4bea3cd87942c8a13d359bf [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate aws-smithy-http-server 0.63.3 [INFO] finished tweaking crates.io crate aws-smithy-http-server 0.63.3 [INFO] tweaked toml for crates.io crate aws-smithy-http-server 0.63.3 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 152 packages to latest compatible versions [INFO] [stderr] Adding aws_lambda_events v0.12.1 (available: v0.15.1) [INFO] [stderr] Adding base64 v0.20.0 (available: v0.22.1) [INFO] [stderr] Adding base64 v0.21.7 (available: v0.22.1) [INFO] [stderr] Adding bitflags v1.3.2 (available: v2.6.0) [INFO] [stderr] Adding h2 v0.3.26 (available: v0.4.6) [INFO] [stderr] Adding hermit-abi v0.3.9 (available: v0.4.0) [INFO] [stderr] Adding http v0.2.12 (available: v1.1.0) [INFO] [stderr] Adding http-body v0.4.6 (available: v1.0.1) [INFO] [stderr] Adding http-range-header v0.3.1 (available: v0.4.1) [INFO] [stderr] Adding http-serde v1.1.3 (available: v2.1.1) [INFO] [stderr] Adding hyper v0.14.30 (available: v1.4.1) [INFO] [stderr] Adding idna v0.5.0 (available: v1.0.2) [INFO] [stderr] Adding lambda_http v0.8.3 (available: v0.13.0) [INFO] [stderr] Adding lambda_runtime v0.8.3 (available: v0.13.0) [INFO] [stderr] Adding lambda_runtime_api_client v0.8.0 (available: v0.11.1) [INFO] [stderr] Adding minicbor v0.24.4 (available: v0.25.1) [INFO] [stderr] Adding tower v0.4.13 (available: v0.5.1) [INFO] [stderr] Adding tower-http v0.3.5 (available: v0.6.1) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (available: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-sys v0.52.0 (available: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 17b38cb91b9f7f38304c1ca1b9331a601cb33f3dc263456667238988ba7cc1c7 [INFO] running `Command { std: "docker" "start" "-a" "17b38cb91b9f7f38304c1ca1b9331a601cb33f3dc263456667238988ba7cc1c7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "17b38cb91b9f7f38304c1ca1b9331a601cb33f3dc263456667238988ba7cc1c7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "17b38cb91b9f7f38304c1ca1b9331a601cb33f3dc263456667238988ba7cc1c7", kill_on_drop: false }` [INFO] [stdout] 17b38cb91b9f7f38304c1ca1b9331a601cb33f3dc263456667238988ba7cc1c7 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] a7019b94ca47249407330c1b4a851e4c3429214b5fd006ca63bf040182993b0e [INFO] running `Command { std: "docker" "start" "-a" "a7019b94ca47249407330c1b4a851e4c3429214b5fd006ca63bf040182993b0e", kill_on_drop: false }` [INFO] [stderr] Checking futures-task v0.3.30 [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Compiling minicbor v0.24.4 [INFO] [stderr] Checking tower-layer v0.3.3 [INFO] [stderr] Checking tokio v1.40.0 [INFO] [stderr] Compiling serde v1.0.210 [INFO] [stderr] Checking http-range-header v0.3.1 [INFO] [stderr] Checking diff v0.1.13 [INFO] [stderr] Checking yansi v1.0.1 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Checking nom v7.1.3 [INFO] [stderr] Checking pretty_assertions v1.4.1 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking tower-http v0.3.5 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking regex v1.10.6 [INFO] [stderr] Checking tokio-util v0.7.12 [INFO] [stderr] Checking aws-smithy-async v1.2.1 [INFO] [stderr] Checking tower v0.4.13 [INFO] [stderr] Checking h2 v0.3.26 [INFO] [stderr] Checking hyper v0.14.30 [INFO] [stderr] Checking aws-smithy-types v1.2.6 [INFO] [stderr] Checking aws-smithy-runtime-api v1.7.2 [INFO] [stderr] Checking aws-smithy-json v0.60.7 [INFO] [stderr] Checking aws-smithy-cbor v0.60.7 [INFO] [stderr] Checking aws-smithy-http v0.60.11 [INFO] [stderr] Checking aws-smithy-http-server v0.63.3 (/opt/rustwide/workdir) [INFO] [stdout] error: this value of type `Result<>::Service, >::Error>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/routing/mod.rs:194:15 [INFO] [stdout] | [INFO] [stdout] 192 | fn call(&mut self, req: http::Request) -> Self::Future { [INFO] [stdout] | --- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 193 | tracing::debug!("inside routing service call"); [INFO] [stdout] 194 | match self.router.match_route(&req) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `aws-smithy-http-server` (lib) due to 2 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: this value of type `std::vec::IntoIter<(Method, &str)>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/protocol/rest/router.rs:205:31 [INFO] [stdout] | [INFO] [stdout] 167 | let router: RestRouter<_> = request_specs.into_iter().collect(); [INFO] [stdout] | ------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 205 | for (method, miss) in misses { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::vec::IntoIter<(&str, Method, &str)>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/protocol/rest/router.rs:260:40 [INFO] [stdout] | [INFO] [stdout] 252 | let router: RestRouter<_> = request_specs.into_iter().collect(); [INFO] [stdout] | ------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 260 | for (svc_name, method, uri) in hits { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `http::Request<()>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/routing/request_spec.rs:296:49 [INFO] [stdout] | [INFO] [stdout] 288 | let spec = RequestSpec::from_parts( [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 294 | let misses = vec![(Method::GET, "/beta/path"), (Method::GET, "/multiple/stages/in/path")]; [INFO] [stdout] | ------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 295 | for (method, uri) in &misses { [INFO] [stdout] 296 | assert_eq!(Match::No, spec.matches(&req(method, uri, None))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `http::Request<()>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/routing/request_spec.rs:310:49 [INFO] [stdout] | [INFO] [stdout] 302 | let spec = RequestSpec::from_parts(Method::GET, vec![PathSegment::Label], Vec::new()); [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 303 | [INFO] [stdout] 304 | let misses = vec![ [INFO] [stdout] | ------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 310 | assert_eq!(Match::No, spec.matches(&req(method, uri, None))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `http::Request<()>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/routing/request_spec.rs:333:50 [INFO] [stdout] | [INFO] [stdout] 316 | let spec = RequestSpec::from_parts( [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 326 | let hits = vec![ [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 333 | assert_eq!(Match::Yes, spec.matches(&req(method, uri, None))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `http::Request<()>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/routing/request_spec.rs:347:50 [INFO] [stdout] | [INFO] [stdout] 339 | let spec = RequestSpec::from_parts(Method::DELETE, Vec::new(), vec![QuerySegment::Key(String::from("foo"))]); [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 340 | [INFO] [stdout] 341 | let hits = vec![ [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 347 | assert_eq!(Match::Yes, spec.matches(&req(method, uri, None))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `request_spec::RequestSpec` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/routing/request_spec.rs:407:35 [INFO] [stdout] | [INFO] [stdout] 405 | let misses = vec![(Method::GET, "/a//b"), (Method::GET, "//////a//b")]; [INFO] [stdout] | ------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 406 | for (method, uri) in &misses { [INFO] [stdout] 407 | assert_eq!(Match::No, ab_spec().matches(&req(method, uri, None))); [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `http::Request<()>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/routing/request_spec.rs:452:63 [INFO] [stdout] | [INFO] [stdout] 436 | let greedy_label_spec = RequestSpec::from_parts( [INFO] [stdout] | ----------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 446 | let hits = vec![ [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 452 | assert_eq!(Match::Yes, greedy_label_spec.matches(&req(method, uri, None))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `request_spec::RequestSpec` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/routing/request_spec.rs:467:35 [INFO] [stdout] | [INFO] [stdout] 461 | let misses = vec![ [INFO] [stdout] | ------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 467 | assert_eq!(Match::No, ab_spec().matches(&req(method, uri, None))); [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `http::Request<()>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/routing/request_spec.rs:487:56 [INFO] [stdout] | [INFO] [stdout] 473 | let label_spec = RequestSpec::from_parts( [INFO] [stdout] | ---------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 479 | let misses = vec![(Method::GET, "/a"), (Method::GET, "/a//"), (Method::GET, "/a///")]; [INFO] [stdout] | ------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 485 | let hits = vec![(Method::GET, "/a/label"), (Method::GET, "/a/")]; [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 486 | for (method, uri) in &hits { [INFO] [stdout] 487 | assert_eq!(Match::Yes, label_spec.matches(&req(method, uri, None))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result<>::Service, >::Error>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/routing/mod.rs:194:15 [INFO] [stdout] | [INFO] [stdout] 192 | fn call(&mut self, req: http::Request) -> Self::Future { [INFO] [stdout] | --- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 193 | tracing::debug!("inside routing service call"); [INFO] [stdout] 194 | match self.router.match_route(&req) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 11 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `aws-smithy-http-server` (lib test) due to 12 previous errors [INFO] running `Command { std: "docker" "inspect" "a7019b94ca47249407330c1b4a851e4c3429214b5fd006ca63bf040182993b0e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a7019b94ca47249407330c1b4a851e4c3429214b5fd006ca63bf040182993b0e", kill_on_drop: false }` [INFO] [stdout] a7019b94ca47249407330c1b4a851e4c3429214b5fd006ca63bf040182993b0e