[INFO] fetching crate avro-rs 0.13.0... [INFO] checking avro-rs-0.13.0 against try#7014e13d5becc920d4bea3cd87942c8a13d359bf+rustflags=-Dtail_expr_drop_order for pr-129864 [INFO] extracting crate avro-rs 0.13.0 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate avro-rs 0.13.0 on toolchain 7014e13d5becc920d4bea3cd87942c8a13d359bf [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate avro-rs 0.13.0 [INFO] finished tweaking crates.io crate avro-rs 0.13.0 [INFO] tweaked toml for crates.io crate avro-rs 0.13.0 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] crate crates.io crate avro-rs 0.13.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 50cfd601d86220009e82049b146ead86fb5bed89e9bcc29de8272050238f31aa [INFO] running `Command { std: "docker" "start" "-a" "50cfd601d86220009e82049b146ead86fb5bed89e9bcc29de8272050238f31aa", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "50cfd601d86220009e82049b146ead86fb5bed89e9bcc29de8272050238f31aa", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "50cfd601d86220009e82049b146ead86fb5bed89e9bcc29de8272050238f31aa", kill_on_drop: false }` [INFO] [stdout] 50cfd601d86220009e82049b146ead86fb5bed89e9bcc29de8272050238f31aa [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 93fb4b01ea2b7fc4c4000f4f74b51c25c10caef63ce73fbe3440ff226f498694 [INFO] running `Command { std: "docker" "start" "-a" "93fb4b01ea2b7fc4c4000f4f74b51c25c10caef63ce73fbe3440ff226f498694", kill_on_drop: false }` [INFO] [stderr] Compiling autocfg v1.0.1 [INFO] [stderr] Compiling proc-macro2 v1.0.24 [INFO] [stderr] Compiling unicode-xid v0.2.1 [INFO] [stderr] Compiling syn v1.0.60 [INFO] [stderr] Compiling libc v0.2.83 [INFO] [stderr] Compiling serde_derive v1.0.123 [INFO] [stderr] Compiling serde v1.0.123 [INFO] [stderr] Checking lazy_static v1.4.0 [INFO] [stderr] Compiling typenum v1.12.0 [INFO] [stderr] Compiling version_check v0.9.2 [INFO] [stderr] Compiling const_fn v0.4.5 [INFO] [stderr] Compiling semver-parser v0.7.0 [INFO] [stderr] Compiling getrandom v0.1.16 [INFO] [stderr] Compiling crossbeam-utils v0.8.1 [INFO] [stderr] Compiling num-traits v0.2.14 [INFO] [stderr] Compiling generic-array v0.14.4 [INFO] [stderr] Compiling memoffset v0.6.1 [INFO] [stderr] Compiling semver v0.9.0 [INFO] [stderr] Compiling memchr v2.3.4 [INFO] [stderr] Checking byteorder v1.4.2 [INFO] [stderr] Compiling quote v1.0.8 [INFO] [stderr] Compiling rustc_version v0.2.3 [INFO] [stderr] Checking scopeguard v1.1.0 [INFO] [stderr] Compiling rayon-core v1.9.0 [INFO] [stderr] Checking either v1.6.1 [INFO] [stderr] Compiling cast v0.2.3 [INFO] [stderr] Compiling num-integer v0.1.44 [INFO] [stderr] Checking crossbeam-epoch v0.9.1 [INFO] [stderr] Compiling getrandom v0.2.2 [INFO] [stderr] Compiling crc32fast v1.2.1 [INFO] [stderr] Checking dtoa v0.4.2 [INFO] [stderr] Checking num-traits v0.1.41 [INFO] [stderr] Compiling ryu v1.0.5 [INFO] [stderr] Checking itoa v0.3.4 [INFO] [stderr] Checking crossbeam-deque v0.8.0 [INFO] [stderr] Checking rand_core v0.5.1 [INFO] [stderr] Checking crossbeam-channel v0.5.0 [INFO] [stderr] Checking regex-automata v0.1.9 [INFO] [stderr] Checking num_cpus v1.13.0 [INFO] [stderr] Compiling num-bigint v0.2.6 [INFO] [stderr] Compiling rayon v1.5.0 [INFO] [stderr] Checking plotters-backend v0.3.0 [INFO] [stderr] Compiling unicode-segmentation v1.7.1 [INFO] [stderr] Checking unicode-width v0.1.8 [INFO] [stderr] Checking ppv-lite86 v0.2.10 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking plotters-svg v0.3.0 [INFO] [stderr] Checking digest v0.9.0 [INFO] [stderr] Checking block-buffer v0.9.0 [INFO] [stderr] Compiling heck v0.3.2 [INFO] [stderr] Checking csv-core v0.1.10 [INFO] [stderr] Checking rand_chacha v0.2.2 [INFO] [stderr] Checking itertools v0.9.0 [INFO] [stderr] Checking half v1.7.1 [INFO] [stderr] Checking opaque-debug v0.3.0 [INFO] [stderr] Checking rle-decode-fast v1.0.1 [INFO] [stderr] Checking libflate_lz77 v1.0.0 [INFO] [stderr] Checking regex-syntax v0.6.22 [INFO] [stderr] Checking adler32 v1.0.2 [INFO] [stderr] Compiling anyhow v1.0.38 [INFO] [stderr] Checking itoa v0.4.7 [INFO] [stderr] Checking walkdir v2.3.1 [INFO] [stderr] Checking rand v0.7.3 [INFO] [stderr] Checking libflate v1.0.3 [INFO] [stderr] Checking clap v2.33.3 [INFO] [stderr] Checking plotters v0.3.0 [INFO] [stderr] Checking criterion-plot v0.4.3 [INFO] [stderr] Checking itertools v0.10.0 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking cpuid-bool v0.1.2 [INFO] [stderr] Checking oorandom v11.1.3 [INFO] [stderr] Checking regex v1.4.3 [INFO] [stderr] Checking strum v0.18.0 [INFO] [stderr] Checking sha2 v0.9.2 [INFO] [stderr] Checking md-5 v0.9.1 [INFO] [stderr] Compiling hex-literal v0.3.1 [INFO] [stderr] Compiling synstructure v0.12.4 [INFO] [stderr] Compiling thiserror-impl v1.0.23 [INFO] [stderr] Compiling zerocopy-derive v0.2.0 [INFO] [stderr] Compiling strum_macros v0.18.0 [INFO] [stderr] Compiling typed-builder v0.5.1 [INFO] [stderr] Checking zerocopy v0.3.0 [INFO] [stderr] Checking thiserror v1.0.23 [INFO] [stderr] Checking serde_json v1.0.7 [INFO] [stderr] Checking bstr v0.2.14 [INFO] [stderr] Checking serde_cbor v0.11.1 [INFO] [stderr] Checking uuid v0.8.2 [INFO] [stderr] Checking csv v1.1.5 [INFO] [stderr] Checking tinytemplate v1.2.0 [INFO] [stderr] Checking avro-rs v0.13.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: elided lifetime has a name [INFO] [stdout] --> src/ser.rs:46:69 [INFO] [stdout] | [INFO] [stdout] 45 | impl<'a> SeqVariantSerializer<'a> { [INFO] [stdout] | -- lifetime `'a` declared here [INFO] [stdout] 46 | pub fn new(index: u32, variant: &'a str, len: Option) -> SeqVariantSerializer { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ this elided lifetime gets resolved as `'a` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(elided_named_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: elided lifetime has a name [INFO] [stdout] --> src/ser.rs:79:61 [INFO] [stdout] | [INFO] [stdout] 78 | impl<'a> StructVariantSerializer<'a> { [INFO] [stdout] | -- lifetime `'a` declared here [INFO] [stdout] 79 | pub fn new(index: u32, variant: &'a str, len: usize) -> StructVariantSerializer { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ this elided lifetime gets resolved as `'a` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking criterion v0.3.4 [INFO] [stdout] warning: 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Schema` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> tests/io.rs:131:13 [INFO] [stdout] | [INFO] [stdout] 124 | let promotable_values = vec![ [INFO] [stdout] | ----------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 131 | let writer_schema = Schema::parse_str(writer_raw_schema).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> tests/io.rs:88:13 [INFO] [stdout] | [INFO] [stdout] 88 | format!("value {:?} does not validate schema: {}", value, raw_schema) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this usage of `assert!()` is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: the `assert!()` macro supports formatting, so there's no need for the `format!()` macro here [INFO] [stdout] = note: `#[warn(non_fmt_panics)]` on by default [INFO] [stdout] help: remove the `format!(..)` macro call [INFO] [stdout] | [INFO] [stdout] 88 - format!("value {:?} does not validate schema: {}", value, raw_schema) [INFO] [stdout] 88 + "value {:?} does not validate schema: {}", value, raw_schema [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `avro-rs` (test "io") due to 2 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: this value of type `Vec` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> tests/schema.rs:887:13 [INFO] [stdout] | [INFO] [stdout] 879 | let parsed = vec![ [INFO] [stdout] | ------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 887 | let schemas = Schema::parse_list(&schema_str_perm).expect("Test failed"); [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Vec` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> tests/schema.rs:963:13 [INFO] [stdout] | [INFO] [stdout] 955 | let parsed = vec![ [INFO] [stdout] | ------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 963 | let schemas = Schema::parse_list(&schema_str_perm).expect("Test failed"); [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> tests/schema.rs:1156:13 [INFO] [stdout] | [INFO] [stdout] 1156 | e.to_string() [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this usage of `assert!()` is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(non_fmt_panics)]` on by default [INFO] [stdout] help: add a "{}" format string to `Display` the message [INFO] [stdout] | [INFO] [stdout] 1156 | "{}", e.to_string() [INFO] [stdout] | +++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `avro-rs` (test "schema") due to 3 previous errors; 1 warning emitted [INFO] [stdout] warning: elided lifetime has a name [INFO] [stdout] --> src/ser.rs:46:69 [INFO] [stdout] | [INFO] [stdout] 45 | impl<'a> SeqVariantSerializer<'a> { [INFO] [stdout] | -- lifetime `'a` declared here [INFO] [stdout] 46 | pub fn new(index: u32, variant: &'a str, len: Option) -> SeqVariantSerializer { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ this elided lifetime gets resolved as `'a` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(elided_named_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: elided lifetime has a name [INFO] [stdout] --> src/ser.rs:79:61 [INFO] [stdout] | [INFO] [stdout] 78 | impl<'a> StructVariantSerializer<'a> { [INFO] [stdout] | -- lifetime `'a` declared here [INFO] [stdout] 79 | pub fn new(index: u32, variant: &'a str, len: usize) -> StructVariantSerializer { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ this elided lifetime gets resolved as `'a` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Enumerate>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/reader.rs:370:27 [INFO] [stdout] | [INFO] [stdout] 357 | let schema = Schema::parse_str(SCHEMA).unwrap(); [INFO] [stdout] | ------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 368 | let expected = vec![record1.into(), record2.into()]; [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 369 | [INFO] [stdout] 370 | for (i, value) in reader.enumerate() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `schema::Schema` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/writer.rs:494:14 [INFO] [stdout] | [INFO] [stdout] 487 | let inner = Schema::Fixed { [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 494 | &Schema::Decimal { [INFO] [stdout] | ______________^ [INFO] [stdout] 495 | | precision: 20, [INFO] [stdout] 496 | | scale: 5, [INFO] [stdout] 497 | | inner: Box::new(inner.clone()), [INFO] [stdout] 498 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `schema::Schema` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/writer.rs:511:14 [INFO] [stdout] | [INFO] [stdout] 507 | let inner = Schema::Bytes; [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 511 | &Schema::Decimal { [INFO] [stdout] | ______________^ [INFO] [stdout] 512 | | precision: 4, [INFO] [stdout] 513 | | scale: 3, [INFO] [stdout] 514 | | inner: Box::new(inner.clone()), [INFO] [stdout] 515 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `avro-rs` (lib test) due to 4 previous errors; 2 warnings emitted [INFO] running `Command { std: "docker" "inspect" "93fb4b01ea2b7fc4c4000f4f74b51c25c10caef63ce73fbe3440ff226f498694", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "93fb4b01ea2b7fc4c4000f4f74b51c25c10caef63ce73fbe3440ff226f498694", kill_on_drop: false }` [INFO] [stdout] 93fb4b01ea2b7fc4c4000f4f74b51c25c10caef63ce73fbe3440ff226f498694