[INFO] fetching crate atomsh 0.1.1... [INFO] checking atomsh-0.1.1 against try#7014e13d5becc920d4bea3cd87942c8a13d359bf+rustflags=-Dtail_expr_drop_order for pr-129864 [INFO] extracting crate atomsh 0.1.1 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate atomsh 0.1.1 on toolchain 7014e13d5becc920d4bea3cd87942c8a13d359bf [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate atomsh 0.1.1 [INFO] finished tweaking crates.io crate atomsh 0.1.1 [INFO] tweaked toml for crates.io crate atomsh 0.1.1 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] crate crates.io crate atomsh 0.1.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] b4e869aa0afa779beb4e4782249c2163beef3c558a48a82948580d5ebb4f1cbb [INFO] running `Command { std: "docker" "start" "-a" "b4e869aa0afa779beb4e4782249c2163beef3c558a48a82948580d5ebb4f1cbb", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "b4e869aa0afa779beb4e4782249c2163beef3c558a48a82948580d5ebb4f1cbb", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b4e869aa0afa779beb4e4782249c2163beef3c558a48a82948580d5ebb4f1cbb", kill_on_drop: false }` [INFO] [stdout] b4e869aa0afa779beb4e4782249c2163beef3c558a48a82948580d5ebb4f1cbb [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 8dc852dedb5d586710eb05e92093fa8fa35fd4dc8a859c6633251cd90152280e [INFO] running `Command { std: "docker" "start" "-a" "8dc852dedb5d586710eb05e92093fa8fa35fd4dc8a859c6633251cd90152280e", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.81 [INFO] [stderr] Compiling autocfg v1.0.1 [INFO] [stderr] Compiling memchr v2.3.4 [INFO] [stderr] Compiling log v0.4.11 [INFO] [stderr] Compiling byteorder v1.3.4 [INFO] [stderr] Compiling unicode-xid v0.2.1 [INFO] [stderr] Compiling crunchy v0.2.2 [INFO] [stderr] Compiling proc-macro2 v1.0.24 [INFO] [stderr] Checking cfg-if v0.1.10 [INFO] [stderr] Compiling tiny-keccak v2.0.2 [INFO] [stderr] Compiling lazy_static v1.4.0 [INFO] [stderr] Compiling bitflags v1.2.1 [INFO] [stderr] Compiling syn v1.0.56 [INFO] [stderr] Compiling regex-syntax v0.6.21 [INFO] [stderr] Compiling getrandom v0.2.1 [INFO] [stderr] Compiling siphasher v0.3.3 [INFO] [stderr] Compiling thread_local v1.0.1 [INFO] [stderr] Compiling hashbrown v0.9.1 [INFO] [stderr] Compiling precomputed-hash v0.1.1 [INFO] [stderr] Compiling phf_shared v0.8.0 [INFO] [stderr] Compiling fixedbitset v0.2.0 [INFO] [stderr] Compiling either v1.6.1 [INFO] [stderr] Compiling serde_derive v1.0.118 [INFO] [stderr] Compiling bit-vec v0.6.3 [INFO] [stderr] Compiling new_debug_unreachable v1.0.4 [INFO] [stderr] Compiling string_cache v0.8.1 [INFO] [stderr] Compiling ena v0.14.0 [INFO] [stderr] Compiling indexmap v1.6.1 [INFO] [stderr] Compiling num-traits v0.2.14 [INFO] [stderr] Compiling bit-set v0.5.2 [INFO] [stderr] Checking aho-corasick v0.7.15 [INFO] [stderr] Compiling itertools v0.9.0 [INFO] [stderr] Compiling num-integer v0.1.44 [INFO] [stderr] Compiling quote v1.0.8 [INFO] [stderr] Compiling pico-args v0.3.4 [INFO] [stderr] Compiling diff v0.1.12 [INFO] [stderr] Compiling serde v1.0.118 [INFO] [stderr] Compiling nix v0.18.0 [INFO] [stderr] Checking ppv-lite86 v0.2.10 [INFO] [stderr] Compiling petgraph v0.5.1 [INFO] [stderr] Checking utf8parse v0.2.0 [INFO] [stderr] Checking unicode-width v0.1.8 [INFO] [stderr] Checking unicode-segmentation v1.7.1 [INFO] [stderr] Checking comment v0.1.1 [INFO] [stderr] Checking dunce v1.0.1 [INFO] [stderr] Checking asciicolor v0.1.0 [INFO] [stderr] Checking dirs v1.0.5 [INFO] [stderr] Checking dirs-sys-next v0.1.1 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking nix v0.19.1 [INFO] [stderr] Checking fs2 v0.4.3 [INFO] [stderr] Checking term v0.5.2 [INFO] [stderr] Checking dirs-next v2.0.0 [INFO] [stderr] Checking dirs-sys v0.3.5 [INFO] [stderr] Checking time v0.1.44 [INFO] [stderr] Checking rand_core v0.6.1 [INFO] [stderr] Checking dirs v3.0.1 [INFO] [stderr] Compiling regex v1.4.2 [INFO] [stderr] Checking chrono v0.4.19 [INFO] [stderr] Checking rand_chacha v0.3.0 [INFO] [stderr] Checking ascii-canvas v2.0.0 [INFO] [stderr] Checking rand v0.8.1 [INFO] [stderr] Compiling lalrpop-util v0.19.3 [INFO] [stderr] Compiling lalrpop v0.19.3 [INFO] [stderr] Compiling rustyline-derive v0.4.0 [INFO] [stderr] Checking rustyline v7.1.0 [INFO] [stderr] Checking ctrlc v3.1.7 [INFO] [stderr] Checking os_info v3.0.1 [INFO] [stderr] Compiling atomsh v0.1.1 (/opt/rustwide/workdir) [INFO] [stdout] error: this value of type `Value` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/env.rs:1825:48 [INFO] [stdout] | [INFO] [stdout] 1822 | let func = args[0].eval(env)?; [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 1823 | let mut acc = args[1].eval(env)?; [INFO] [stdout] | ------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 1824 | [INFO] [stdout] 1825 | if let Value::List(list) = args[2].eval(env)? { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Value` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/env.rs:1802:48 [INFO] [stdout] | [INFO] [stdout] 1800 | let func = args[0].eval(env)?; [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 1801 | [INFO] [stdout] 1802 | if let Value::List(list) = args[1].eval(env)? { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Value` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/env.rs:1787:48 [INFO] [stdout] | [INFO] [stdout] 1786 | let func = args[0].eval(env)?; [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 1787 | if let Value::List(list) = args[1].eval(env)? { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Value` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/env.rs:1825:48 [INFO] [stdout] | [INFO] [stdout] 1822 | let func = args[0].eval(env)?; [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 1823 | let mut acc = args[1].eval(env)?; [INFO] [stdout] | ------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 1824 | [INFO] [stdout] 1825 | if let Value::List(list) = args[2].eval(env)? { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Value` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/env.rs:1802:48 [INFO] [stdout] | [INFO] [stdout] 1800 | let func = args[0].eval(env)?; [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 1801 | [INFO] [stdout] 1802 | if let Value::List(list) = args[1].eval(env)? { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Value` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/env.rs:1787:48 [INFO] [stdout] | [INFO] [stdout] 1786 | let func = args[0].eval(env)?; [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 1787 | if let Value::List(list) = args[1].eval(env)? { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result, &str>>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:30:11 [INFO] [stdout] | [INFO] [stdout] 23 | pub fn parse(code: impl ToString) -> Result { [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 30 | match ProgramParser::new().parse(&code) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `to_triple` is never used [INFO] [stdout] --> /opt/rustwide/target/debug/build/atomsh-8ce95c1de1366303/out/parser.rs:8892:8 [INFO] [stdout] | [INFO] [stdout] 8891 | pub trait __ToTriple<'input, > { [INFO] [stdout] | ---------- associated function in this trait [INFO] [stdout] 8892 | fn to_triple(value: Self) -> Result<(usize,Token<'input>,usize), __lalrpop_util::ParseError, &'static str>>; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.clone()` on a double reference, which returns `&str` instead of cloning the inner type [INFO] [stdout] --> /opt/rustwide/target/debug/build/atomsh-8ce95c1de1366303/out/parser.rs:6589:47 [INFO] [stdout] | [INFO] [stdout] 6589 | None => list.iter().map(|(v, s)| v.clone()).collect(), [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(suspicious_double_ref_op)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.clone()` on a double reference, which returns `&str` instead of cloning the inner type [INFO] [stdout] --> /opt/rustwide/target/debug/build/atomsh-8ce95c1de1366303/out/parser.rs:6591:66 [INFO] [stdout] | [INFO] [stdout] 6591 | let mut list: Vec<_> = list.iter().map(|(v, s)| v.clone()).collect(); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.clone()` on a double reference, which returns `&str` instead of cloning the inner type [INFO] [stdout] --> /opt/rustwide/target/debug/build/atomsh-8ce95c1de1366303/out/parser.rs:6612:47 [INFO] [stdout] | [INFO] [stdout] 6612 | None => list.iter().map(|(v, s)| v.clone()).collect(), [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.clone()` on a double reference, which returns `&str` instead of cloning the inner type [INFO] [stdout] --> /opt/rustwide/target/debug/build/atomsh-8ce95c1de1366303/out/parser.rs:6614:66 [INFO] [stdout] | [INFO] [stdout] 6614 | let mut list: Vec<_> = list.iter().map(|(v, s)| v.clone()).collect(); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 5 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `atomsh` (lib) due to 5 previous errors; 5 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: this value of type `Result, &str>>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:30:11 [INFO] [stdout] | [INFO] [stdout] 23 | pub fn parse(code: impl ToString) -> Result { [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 30 | match ProgramParser::new().parse(&code) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `to_triple` is never used [INFO] [stdout] --> /opt/rustwide/target/debug/build/atomsh-8ce95c1de1366303/out/parser.rs:8892:8 [INFO] [stdout] | [INFO] [stdout] 8891 | pub trait __ToTriple<'input, > { [INFO] [stdout] | ---------- associated function in this trait [INFO] [stdout] 8892 | fn to_triple(value: Self) -> Result<(usize,Token<'input>,usize), __lalrpop_util::ParseError, &'static str>>; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.clone()` on a double reference, which returns `&str` instead of cloning the inner type [INFO] [stdout] --> /opt/rustwide/target/debug/build/atomsh-8ce95c1de1366303/out/parser.rs:6589:47 [INFO] [stdout] | [INFO] [stdout] 6589 | None => list.iter().map(|(v, s)| v.clone()).collect(), [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(suspicious_double_ref_op)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.clone()` on a double reference, which returns `&str` instead of cloning the inner type [INFO] [stdout] --> /opt/rustwide/target/debug/build/atomsh-8ce95c1de1366303/out/parser.rs:6591:66 [INFO] [stdout] | [INFO] [stdout] 6591 | let mut list: Vec<_> = list.iter().map(|(v, s)| v.clone()).collect(); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.clone()` on a double reference, which returns `&str` instead of cloning the inner type [INFO] [stdout] --> /opt/rustwide/target/debug/build/atomsh-8ce95c1de1366303/out/parser.rs:6612:47 [INFO] [stdout] | [INFO] [stdout] 6612 | None => list.iter().map(|(v, s)| v.clone()).collect(), [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.clone()` on a double reference, which returns `&str` instead of cloning the inner type [INFO] [stdout] --> /opt/rustwide/target/debug/build/atomsh-8ce95c1de1366303/out/parser.rs:6614:66 [INFO] [stdout] | [INFO] [stdout] 6614 | let mut list: Vec<_> = list.iter().map(|(v, s)| v.clone()).collect(); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 5 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `atomsh` (lib test) due to 5 previous errors; 5 warnings emitted [INFO] running `Command { std: "docker" "inspect" "8dc852dedb5d586710eb05e92093fa8fa35fd4dc8a859c6633251cd90152280e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8dc852dedb5d586710eb05e92093fa8fa35fd4dc8a859c6633251cd90152280e", kill_on_drop: false }` [INFO] [stdout] 8dc852dedb5d586710eb05e92093fa8fa35fd4dc8a859c6633251cd90152280e