[INFO] fetching crate asyncgit 0.26.3... [INFO] checking asyncgit-0.26.3 against try#7014e13d5becc920d4bea3cd87942c8a13d359bf+rustflags=-Dtail_expr_drop_order for pr-129864 [INFO] extracting crate asyncgit 0.26.3 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate asyncgit 0.26.3 on toolchain 7014e13d5becc920d4bea3cd87942c8a13d359bf [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate asyncgit 0.26.3 [INFO] finished tweaking crates.io crate asyncgit 0.26.3 [INFO] tweaked toml for crates.io crate asyncgit 0.26.3 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 197 packages to latest compatible versions [INFO] [stderr] Adding generic-array v0.14.7 (available: v1.1.0) [INFO] [stderr] Adding git2 v0.18.3 (available: v0.19.0) [INFO] [stderr] Adding idna v0.5.0 (available: v1.0.2) [INFO] [stderr] Adding libgit2-sys v0.16.2+1.7.2 (available: v0.17.0+1.8.1) [INFO] [stderr] Adding linux-raw-sys v0.4.14 (available: v0.6.5) [INFO] [stderr] Adding unicode-width v0.1.14 (available: v0.2.0) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (available: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-sys v0.48.0 (available: v0.59.0) [INFO] [stderr] Adding windows-sys v0.52.0 (available: v0.59.0) [INFO] [stderr] Adding windows-targets v0.48.5 (available: v0.52.6) [INFO] [stderr] Adding windows_aarch64_gnullvm v0.48.5 (available: v0.52.6) [INFO] [stderr] Adding windows_aarch64_msvc v0.48.5 (available: v0.52.6) [INFO] [stderr] Adding windows_i686_gnu v0.48.5 (available: v0.52.6) [INFO] [stderr] Adding windows_i686_msvc v0.48.5 (available: v0.52.6) [INFO] [stderr] Adding windows_x86_64_gnu v0.48.5 (available: v0.52.6) [INFO] [stderr] Adding windows_x86_64_gnullvm v0.48.5 (available: v0.52.6) [INFO] [stderr] Adding windows_x86_64_msvc v0.48.5 (available: v0.52.6) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 268849f1963ea5913e8cf61373b8768c7ff844503578b815a2b646a06e41d075 [INFO] running `Command { std: "docker" "start" "-a" "268849f1963ea5913e8cf61373b8768c7ff844503578b815a2b646a06e41d075", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "268849f1963ea5913e8cf61373b8768c7ff844503578b815a2b646a06e41d075", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "268849f1963ea5913e8cf61373b8768c7ff844503578b815a2b646a06e41d075", kill_on_drop: false }` [INFO] [stdout] 268849f1963ea5913e8cf61373b8768c7ff844503578b815a2b646a06e41d075 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 24f2953f7dd058004ee03c724801a8558215f7c62f915e483d25a1fbb7d0667c [INFO] running `Command { std: "docker" "start" "-a" "24f2953f7dd058004ee03c724801a8558215f7c62f915e483d25a1fbb7d0667c", kill_on_drop: false }` [INFO] [stderr] Checking zeroize v1.8.1 [INFO] [stderr] Compiling libc v0.2.159 [INFO] [stderr] Checking subtle v2.6.1 [INFO] [stderr] Checking const-oid v0.9.6 [INFO] [stderr] Compiling generic-array v0.14.7 [INFO] [stderr] Compiling shlex v1.3.0 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Compiling pkg-config v0.3.31 [INFO] [stderr] Compiling vcpkg v0.2.15 [INFO] [stderr] Checking der v0.7.9 [INFO] [stderr] Checking base16ct v0.2.0 [INFO] [stderr] Compiling semver v1.0.23 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking block-buffer v0.10.4 [INFO] [stderr] Compiling jobserver v0.1.32 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking block-padding v0.3.3 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking inout v0.1.3 [INFO] [stderr] Checking universal-hash v0.5.1 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking log v0.4.22 [INFO] [stderr] Checking sha2 v0.10.8 [INFO] [stderr] Checking cipher v0.4.4 [INFO] [stderr] Checking hmac v0.12.1 [INFO] [stderr] Checking ff v0.13.0 [INFO] [stderr] Checking spki v0.7.3 [INFO] [stderr] Compiling cc v1.1.21 [INFO] [stderr] Checking signature v2.2.0 [INFO] [stderr] Checking group v0.13.0 [INFO] [stderr] Checking sec1 v0.7.3 [INFO] [stderr] Checking crypto-bigint v0.5.5 [INFO] [stderr] Checking tinyvec_macros v0.1.1 [INFO] [stderr] Checking rfc6979 v0.4.0 [INFO] [stderr] Compiling rustc_version v0.4.1 [INFO] [stderr] Checking polyval v0.6.2 [INFO] [stderr] Checking tinyvec v1.8.0 [INFO] [stderr] Checking futures-core v0.3.30 [INFO] [stderr] Checking percent-encoding v2.3.1 [INFO] [stderr] Checking unicode-bidi v0.3.15 [INFO] [stderr] Checking spin v0.9.8 [INFO] [stderr] Compiling curve25519-dalek v4.1.3 [INFO] [stderr] Checking base64ct v1.6.0 [INFO] [stderr] Checking option-ext v0.2.0 [INFO] [stderr] Compiling num-bigint-dig v0.8.4 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Checking pem-rfc7468 v0.7.0 [INFO] [stderr] Checking dirs-sys v0.4.1 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking lazy_static v1.5.0 [INFO] [stderr] Checking form_urlencoded v1.2.1 [INFO] [stderr] Checking ghash v0.5.1 [INFO] [stderr] Checking aes v0.8.4 [INFO] [stderr] Checking ctr v0.9.2 [INFO] [stderr] Checking unicode-normalization v0.1.24 [INFO] [stderr] Checking pkcs8 v0.10.2 [INFO] [stderr] Checking num-iter v0.1.45 [INFO] [stderr] Checking aead v0.5.2 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Checking futures-io v0.3.30 [INFO] [stderr] Compiling parking_lot_core v0.9.10 [INFO] [stderr] Checking either v1.13.0 [INFO] [stderr] Checking aes-gcm v0.10.3 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking elliptic-curve v0.13.8 [INFO] [stderr] Checking pkcs1 v0.7.5 [INFO] [stderr] Checking ssh-encoding v0.2.0 [INFO] [stderr] Checking idna v0.5.0 [INFO] [stderr] Checking dirs v5.0.1 [INFO] [stderr] Checking chacha20 v0.9.1 [INFO] [stderr] Checking primeorder v0.13.6 [INFO] [stderr] Checking ecdsa v0.16.9 [INFO] [stderr] Checking blowfish v0.9.1 [INFO] [stderr] Checking url v2.5.2 [INFO] [stderr] Checking cbc v0.1.2 [INFO] [stderr] Checking ed25519 v2.2.3 [INFO] [stderr] Compiling openssl-sys v0.9.103 [INFO] [stderr] Compiling libz-sys v1.1.20 [INFO] [stderr] Compiling libssh2-sys v0.3.0 [INFO] [stderr] Compiling libgit2-sys v0.16.2+1.7.2 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking poly1305 v0.8.0 [INFO] [stderr] Checking pbkdf2 v0.12.2 [INFO] [stderr] Compiling serde v1.0.210 [INFO] [stderr] Checking utf8parse v0.2.2 [INFO] [stderr] Compiling rustix v0.38.37 [INFO] [stderr] Checking openssl-probe v0.1.5 [INFO] [stderr] Checking anstyle-parse v0.2.5 [INFO] [stderr] Checking ssh-cipher v0.2.0 [INFO] [stderr] Checking bcrypt-pbkdf v0.10.0 [INFO] [stderr] Checking p384 v0.13.0 [INFO] [stderr] Checking p521 v0.13.3 [INFO] [stderr] Checking p256 v0.13.2 [INFO] [stderr] Checking shellexpand v3.1.0 [INFO] [stderr] Checking itertools v0.13.0 [INFO] [stderr] Checking thread_local v1.1.8 [INFO] [stderr] Checking unicode-segmentation v1.12.0 [INFO] [stderr] Checking linux-raw-sys v0.4.14 [INFO] [stderr] Checking anstyle v1.0.8 [INFO] [stderr] Checking anstyle-query v1.1.1 [INFO] [stderr] Checking colorchoice v1.0.2 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Compiling curve25519-dalek-derive v0.1.1 [INFO] [stderr] Compiling thiserror-impl v1.0.64 [INFO] [stderr] Compiling serde_derive v1.0.210 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking sdd v3.0.3 [INFO] [stderr] Checking unicode-width v0.1.14 [INFO] [stderr] Checking regex v1.10.6 [INFO] [stderr] Checking is_terminal_polyfill v1.70.1 [INFO] [stderr] Checking scc v2.1.17 [INFO] [stderr] Checking anstream v0.6.15 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking env_filter v0.1.2 [INFO] [stderr] Checking unicode-truncate v1.1.0 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Compiling serial_test_derive v3.1.1 [INFO] [stderr] Checking thiserror v1.0.64 [INFO] [stderr] Checking fuzzy-matcher v0.3.7 [INFO] [stderr] Checking ed25519-dalek v2.1.1 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Checking rayon v1.10.0 [INFO] [stderr] Checking crossbeam-channel v0.5.13 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking scopetime v0.1.2 [INFO] [stderr] Checking easy-cast v0.5.2 [INFO] [stderr] Checking humantime v2.1.0 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking yansi v1.0.1 [INFO] [stderr] Checking env_logger v0.11.5 [INFO] [stderr] Checking serial_test v3.1.1 [INFO] [stderr] Checking pretty_assertions v1.4.1 [INFO] [stderr] Checking tempfile v3.12.0 [INFO] [stderr] Checking invalidstring v0.1.3 [INFO] [stderr] Checking rsa v0.9.6 [INFO] [stderr] Checking ssh-key v0.6.6 [INFO] [stderr] Checking git2 v0.18.3 [INFO] [stderr] Checking git2-hooks v0.3.3 [INFO] [stderr] Checking asyncgit v0.26.3 (/opt/rustwide/workdir) [INFO] [stdout] error: this value of type `std::result::Result>, PoisonError>>>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/asyncjob/mod.rs:166:25 [INFO] [stdout] | [INFO] [stdout] 165 | fn schedule_next(&mut self, task: J) { [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 166 | if let Ok(mut next) = self.next.lock() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Branch<'_>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sync/branch/mod.rs:136:5 [INFO] [stdout] | [INFO] [stdout] 134 | let branch = b.ok()?.0; [INFO] [stdout] | ------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 135 | let upstream = branch.upstream(); [INFO] [stdout] 136 | / upstream [INFO] [stdout] 137 | | .ok()? [INFO] [stdout] | |__________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::result::Result` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sync/reword.rs:46:8 [INFO] [stdout] | [INFO] [stdout] 17 | let repo = repo(repo_path)?; [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 18 | let config = repo.config()?; [INFO] [stdout] | ------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 46 | match reword_internal(&repo, commit.get_oid(), message) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::result::Result>, PoisonError>>>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/asyncjob/mod.rs:166:25 [INFO] [stdout] | [INFO] [stdout] 165 | fn schedule_next(&mut self, task: J) { [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 166 | if let Ok(mut next) = self.next.lock() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `asyncgit` (lib) due to 4 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: this value of type `Branch<'_>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sync/branch/mod.rs:136:5 [INFO] [stdout] | [INFO] [stdout] 134 | let branch = b.ok()?.0; [INFO] [stdout] | ------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 135 | let upstream = branch.upstream(); [INFO] [stdout] 136 | / upstream [INFO] [stdout] 137 | | .ok()? [INFO] [stdout] | |__________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::result::Result` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sync/reword.rs:46:8 [INFO] [stdout] | [INFO] [stdout] 17 | let repo = repo(repo_path)?; [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 18 | let config = repo.config()?; [INFO] [stdout] | ------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 46 | match reword_internal(&repo, commit.get_oid(), message) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: missing documentation for a module [INFO] [stdout] --> src/sync/branch/merge_ff.rs:53:1 [INFO] [stdout] | [INFO] [stdout] 53 | pub mod test { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: the lint level is defined here [INFO] [stdout] --> src/lib.rs:3:11 [INFO] [stdout] | [INFO] [stdout] 3 | #![forbid(missing_docs)] [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: missing documentation for a method [INFO] [stdout] --> src/sync/sign.rs:74:2 [INFO] [stdout] | [INFO] [stdout] 74 | fn program(&self) -> &String; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: missing documentation for a method [INFO] [stdout] --> src/sync/sign.rs:77:2 [INFO] [stdout] | [INFO] [stdout] 77 | fn signing_key(&self) -> &String; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `asyncgit` (lib test) due to 7 previous errors [INFO] running `Command { std: "docker" "inspect" "24f2953f7dd058004ee03c724801a8558215f7c62f915e483d25a1fbb7d0667c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "24f2953f7dd058004ee03c724801a8558215f7c62f915e483d25a1fbb7d0667c", kill_on_drop: false }` [INFO] [stdout] 24f2953f7dd058004ee03c724801a8558215f7c62f915e483d25a1fbb7d0667c