[INFO] fetching crate async-map 0.2.3... [INFO] checking async-map-0.2.3 against try#7014e13d5becc920d4bea3cd87942c8a13d359bf+rustflags=-Dtail_expr_drop_order for pr-129864 [INFO] extracting crate async-map 0.2.3 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate async-map 0.2.3 on toolchain 7014e13d5becc920d4bea3cd87942c8a13d359bf [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate async-map 0.2.3 [INFO] finished tweaking crates.io crate async-map 0.2.3 [INFO] tweaked toml for crates.io crate async-map 0.2.3 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 117 packages to latest compatible versions [INFO] [stderr] Adding anes v0.1.6 (available: v0.2.0) [INFO] [stderr] Adding bitflags v1.3.2 (available: v2.6.0) [INFO] [stderr] Adding bitmaps v2.1.0 (available: v3.2.1) [INFO] [stderr] Adding clap v3.2.25 (available: v4.5.18) [INFO] [stderr] Adding clap_lex v0.2.4 (available: v0.7.2) [INFO] [stderr] Adding criterion v0.4.0 (available: v0.5.1) [INFO] [stderr] Adding hashbrown v0.12.3 (available: v0.14.5) [INFO] [stderr] Adding hermit-abi v0.1.19 (available: v0.4.0) [INFO] [stderr] Adding hermit-abi v0.3.9 (available: v0.4.0) [INFO] [stderr] Adding indexmap v1.9.3 (available: v2.5.0) [INFO] [stderr] Adding itertools v0.10.5 (available: v0.13.0) [INFO] [stderr] Adding os_str_bytes v6.6.1 (available: v7.0.0) [INFO] [stderr] Adding sized-chunks v0.6.5 (available: v0.7.0) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (available: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-sys v0.52.0 (available: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 914936ca6b45223b661b475f886f715a6ceb95d6c7edd2c373051ffe89112084 [INFO] running `Command { std: "docker" "start" "-a" "914936ca6b45223b661b475f886f715a6ceb95d6c7edd2c373051ffe89112084", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "914936ca6b45223b661b475f886f715a6ceb95d6c7edd2c373051ffe89112084", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "914936ca6b45223b661b475f886f715a6ceb95d6c7edd2c373051ffe89112084", kill_on_drop: false }` [INFO] [stdout] 914936ca6b45223b661b475f886f715a6ceb95d6c7edd2c373051ffe89112084 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 0f3dd5ef3edf2d40f177352a62bcc5f941f6d18108bc3745e36b6f1f4df8c368 [INFO] running `Command { std: "docker" "start" "-a" "0f3dd5ef3edf2d40f177352a62bcc5f941f6d18108bc3745e36b6f1f4df8c368", kill_on_drop: false }` [INFO] [stderr] Compiling autocfg v1.3.0 [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Compiling unicode-ident v1.0.13 [INFO] [stderr] Compiling libc v0.2.159 [INFO] [stderr] Checking cfg-if v1.0.0 [INFO] [stderr] Compiling crossbeam-utils v0.8.20 [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Checking futures-core v0.3.30 [INFO] [stderr] Compiling parking_lot_core v0.9.10 [INFO] [stderr] Checking pin-project-lite v0.2.14 [INFO] [stderr] Checking futures-sink v0.3.30 [INFO] [stderr] Compiling typenum v1.17.0 [INFO] [stderr] Compiling serde v1.0.210 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Checking futures-task v0.3.30 [INFO] [stderr] Checking futures-io v0.3.30 [INFO] [stderr] Compiling slab v0.4.9 [INFO] [stderr] Compiling lock_api v0.4.12 [INFO] [stderr] Checking scopeguard v1.2.0 [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Checking pin-utils v0.1.0 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling indexmap v1.9.3 [INFO] [stderr] Compiling rayon-core v1.12.1 [INFO] [stderr] Checking crossbeam-epoch v0.9.18 [INFO] [stderr] Compiling serde_json v1.0.128 [INFO] [stderr] Compiling version_check v0.9.5 [INFO] [stderr] Compiling quote v1.0.37 [INFO] [stderr] Checking either v1.13.0 [INFO] [stderr] Checking half v2.4.1 [INFO] [stderr] Checking crossbeam-deque v0.8.5 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Compiling im v15.1.0 [INFO] [stderr] Checking plotters-backend v0.3.7 [INFO] [stderr] Checking ryu v1.0.18 [INFO] [stderr] Checking mio v1.0.2 [INFO] [stderr] Checking signal-hook-registry v1.4.2 [INFO] [stderr] Checking socket2 v0.5.7 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking itoa v1.0.11 [INFO] [stderr] Checking ciborium-io v0.2.2 [INFO] [stderr] Checking hashbrown v0.12.3 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Checking os_str_bytes v6.6.1 [INFO] [stderr] Checking regex-syntax v0.8.4 [INFO] [stderr] Checking bytes v1.7.2 [INFO] [stderr] Checking bitmaps v2.1.0 [INFO] [stderr] Checking ciborium-ll v0.2.2 [INFO] [stderr] Checking rand_xoshiro v0.6.0 [INFO] [stderr] Checking plotters-svg v0.3.7 [INFO] [stderr] Checking clap_lex v0.2.4 [INFO] [stderr] Checking itertools v0.10.5 [INFO] [stderr] Checking textwrap v0.16.1 [INFO] [stderr] Checking same-file v1.0.6 [INFO] [stderr] Checking bitflags v1.3.2 [INFO] [stderr] Checking cast v0.3.0 [INFO] [stderr] Checking rayon v1.10.0 [INFO] [stderr] Checking walkdir v2.5.0 [INFO] [stderr] Checking sized-chunks v0.6.5 [INFO] [stderr] Checking clap v3.2.25 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking oorandom v11.1.4 [INFO] [stderr] Checking anes v0.1.6 [INFO] [stderr] Checking lazy_static v1.5.0 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking plotters v0.3.7 [INFO] [stderr] Checking criterion-plot v0.5.0 [INFO] [stderr] Checking regex v1.10.6 [INFO] [stderr] Compiling serde_derive v1.0.210 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Compiling tokio-macros v2.4.0 [INFO] [stderr] Checking tokio v1.40.0 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Checking async-map v0.2.3 (/opt/rustwide/workdir) [INFO] [stdout] error: this value of type `Result>, PoisonError>>>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lockingmap.rs:71:15 [INFO] [stdout] | [INFO] [stdout] 68 | key: K, [INFO] [stdout] | --- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 69 | factory: B, [INFO] [stdout] | ------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 70 | ) -> V { [INFO] [stdout] 71 | match map.write() { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Option` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/non_locking_map.rs:35:15 [INFO] [stdout] | [INFO] [stdout] 33 | factory: F, [INFO] [stdout] | ------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 34 | ) -> Pin + Send + 'b)>> { [INFO] [stdout] 35 | match self.get_if_present(key) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result<(), tokio::sync::mpsc::error::SendError>>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/single_writer_versioned/mod.rs:296:25 [INFO] [stdout] | [INFO] [stdout] 295 | pub fn quit(self) { [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 296 | if let Err(_) = self.update_sender.send(VersionedUpdaterAction::Quit) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result, tokio::sync::oneshot::error::TryRecvError>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/versioned_map.rs:108:19 [INFO] [stdout] | [INFO] [stdout] 107 | self.receiver.take().and_then(|mut receiver| { [INFO] [stdout] | ------------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 108 | match receiver.try_recv() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result<(), MapHolder>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/versioned_map.rs:130:25 [INFO] [stdout] | [INFO] [stdout] 129 | pub fn apply(self, new_map: MapHolder) { [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 130 | if let Err(_) = self.sender.send(new_map) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Option` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/versioned_map.rs:150:15 [INFO] [stdout] | [INFO] [stdout] 148 | factory: B, [INFO] [stdout] | ------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 149 | ) -> Pin + Send + 'b>> { [INFO] [stdout] 150 | match self.get_if_present(key) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Option>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/versioned_map.rs:197:38 [INFO] [stdout] | [INFO] [stdout] 196 | let lockable_map_holder = current_map_holder; [INFO] [stdout] | ------------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 197 | while let Some(action) = update_receiver.recv().await { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result<(), (V, MapHolder)>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/versioned_map.rs:322:33 [INFO] [stdout] | [INFO] [stdout] 315 | key: K, [INFO] [stdout] | --- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 316 | factory: Box>, [INFO] [stdout] | ------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 322 | if let Err(_) = result_sender.send(( [INFO] [stdout] | _________________________________^ [INFO] [stdout] 323 | | v.clone(), [INFO] [stdout] 324 | | MapHolder { [INFO] [stdout] 325 | | version: latest_version.load(Ordering::Acquire), [INFO] [stdout] 326 | | map: map.clone(), [INFO] [stdout] 327 | | }, [INFO] [stdout] 328 | | )) { [INFO] [stdout] | |__________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 8 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `async-map` (lib) due to 9 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "0f3dd5ef3edf2d40f177352a62bcc5f941f6d18108bc3745e36b6f1f4df8c368", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0f3dd5ef3edf2d40f177352a62bcc5f941f6d18108bc3745e36b6f1f4df8c368", kill_on_drop: false }` [INFO] [stdout] 0f3dd5ef3edf2d40f177352a62bcc5f941f6d18108bc3745e36b6f1f4df8c368