[INFO] fetching crate assembly-xml 0.3.0... [INFO] checking assembly-xml-0.3.0 against try#7014e13d5becc920d4bea3cd87942c8a13d359bf+rustflags=-Dtail_expr_drop_order for pr-129864 [INFO] extracting crate assembly-xml 0.3.0 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate assembly-xml 0.3.0 on toolchain 7014e13d5becc920d4bea3cd87942c8a13d359bf [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate assembly-xml 0.3.0 [INFO] finished tweaking crates.io crate assembly-xml 0.3.0 [INFO] tweaked toml for crates.io crate assembly-xml 0.3.0 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] crate crates.io crate assembly-xml 0.3.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] d4ead0bc7e805185c63fe0ec7bf9c2901dd3adc5943cb0bae5dc79485fb1fec3 [INFO] running `Command { std: "docker" "start" "-a" "d4ead0bc7e805185c63fe0ec7bf9c2901dd3adc5943cb0bae5dc79485fb1fec3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "d4ead0bc7e805185c63fe0ec7bf9c2901dd3adc5943cb0bae5dc79485fb1fec3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d4ead0bc7e805185c63fe0ec7bf9c2901dd3adc5943cb0bae5dc79485fb1fec3", kill_on_drop: false }` [INFO] [stdout] d4ead0bc7e805185c63fe0ec7bf9c2901dd3adc5943cb0bae5dc79485fb1fec3 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 670a0a3a875b518c1240f47159cf06b06f4465c44bb87d35a2f9731eae20461d [INFO] running `Command { std: "docker" "start" "-a" "670a0a3a875b518c1240f47159cf06b06f4465c44bb87d35a2f9731eae20461d", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.34 [INFO] [stderr] Compiling unicode-xid v0.2.2 [INFO] [stderr] Compiling syn v1.0.82 [INFO] [stderr] Checking lazy_static v1.4.0 [INFO] [stderr] Compiling version_check v0.9.3 [INFO] [stderr] Compiling memchr v2.4.1 [INFO] [stderr] Compiling serde_derive v1.0.132 [INFO] [stderr] Compiling libc v0.2.112 [INFO] [stderr] Compiling serde v1.0.132 [INFO] [stderr] Checking once_cell v1.9.0 [INFO] [stderr] Checking tracing-core v0.1.21 [INFO] [stderr] Compiling autocfg v1.0.1 [INFO] [stderr] Compiling unicode-segmentation v1.8.0 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Checking thread_local v1.1.3 [INFO] [stderr] Checking sharded-slab v0.1.4 [INFO] [stderr] Compiling encoding_rs v0.8.30 [INFO] [stderr] Compiling miniz_oxide v0.4.4 [INFO] [stderr] Checking pin-project-lite v0.2.7 [INFO] [stderr] Compiling cc v1.0.72 [INFO] [stderr] Compiling heck v0.3.3 [INFO] [stderr] Checking adler v1.0.2 [INFO] [stderr] Compiling quote v1.0.10 [INFO] [stderr] Checking gimli v0.26.1 [INFO] [stderr] Compiling eyre v0.6.5 [INFO] [stderr] Checking unicode-width v0.1.9 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking object v0.27.1 [INFO] [stderr] Checking tracing-subscriber v0.2.25 [INFO] [stderr] Checking vec_map v0.8.2 [INFO] [stderr] Checking rustc-demangle v0.1.21 [INFO] [stderr] Checking indenter v0.3.3 [INFO] [stderr] Compiling backtrace v0.3.63 [INFO] [stderr] Checking ansi_term v0.12.1 [INFO] [stderr] Checking strsim v0.8.0 [INFO] [stderr] Checking owo-colors v1.3.0 [INFO] [stderr] Compiling argh_shared v0.1.7 [INFO] [stderr] Checking bitflags v1.3.2 [INFO] [stderr] Compiling serde_json v1.0.73 [INFO] [stderr] Checking clap v2.34.0 [INFO] [stderr] Checking itoa v1.0.1 [INFO] [stderr] Checking ryu v1.0.9 [INFO] [stderr] Checking addr2line v0.17.0 [INFO] [stderr] Compiling tracing-attributes v0.1.18 [INFO] [stderr] Compiling thiserror-impl v1.0.30 [INFO] [stderr] Compiling displaydoc v0.1.7 [INFO] [stderr] Compiling structopt-derive v0.4.18 [INFO] [stderr] Compiling argh_derive v0.1.7 [INFO] [stderr] Checking tracing v0.1.29 [INFO] [stderr] Checking tracing-error v0.1.2 [INFO] [stderr] Checking argh v0.1.7 [INFO] [stderr] Checking thiserror v1.0.30 [INFO] [stderr] Checking color-spantrace v0.1.6 [INFO] [stderr] Checking color-eyre v0.5.11 [INFO] [stderr] Checking structopt v0.3.25 [INFO] [stderr] Checking quick-xml v0.20.0 [INFO] [stderr] Checking serde_path_to_error v0.1.5 [INFO] [stderr] Checking assembly-xml v0.3.0 (/opt/rustwide/workdir) [INFO] [stdout] error: this value of type `std::result::Result` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/database/mod.rs:292:13 [INFO] [stdout] | [INFO] [stdout] 283 | let mut d = Deserializer::from_reader(c); [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 292 | Row::deserialize(&mut d) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/common/mod.rs:12:17 [INFO] [stdout] | [INFO] [stdout] 12 | #[derive(Debug, Display, Error)] [INFO] [stdout] | ^------ [INFO] [stdout] | | [INFO] [stdout] | `Display` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_DERIVE_Display_FOR_XmlError` [INFO] [stdout] 13 | pub enum XmlError { [INFO] [stdout] | -------- `XmlError` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Display` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Display` may come from an old version of the `displaydoc` crate, try updating your dependency with `cargo update -p displaydoc` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue [INFO] [stdout] = note: `#[warn(non_local_definitions)]` on by default [INFO] [stdout] = note: this warning originates in the derive macro `Display` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/common/exact.rs:14:17 [INFO] [stdout] | [INFO] [stdout] 14 | #[derive(Debug, Display, Error)] [INFO] [stdout] | ^------ [INFO] [stdout] | | [INFO] [stdout] | `Display` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_DERIVE_Display_FOR_Error` [INFO] [stdout] 15 | pub enum Error { [INFO] [stdout] | ----- `Error` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Display` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Display` may come from an old version of the `displaydoc` crate, try updating your dependency with `cargo update -p displaydoc` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue [INFO] [stdout] = note: this warning originates in the derive macro `Display` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/database/mod.rs:82:17 [INFO] [stdout] | [INFO] [stdout] 82 | #[derive(Debug, Display)] [INFO] [stdout] | ^------ [INFO] [stdout] | | [INFO] [stdout] | `Display` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_DERIVE_Display_FOR_UnknownValueType` [INFO] [stdout] 83 | /// Unknown value type '{0}' [INFO] [stdout] 84 | pub struct UnknownValueType(String); [INFO] [stdout] | ---------------- `UnknownValueType` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Display` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Display` may come from an old version of the `displaydoc` crate, try updating your dependency with `cargo update -p displaydoc` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue [INFO] [stdout] = note: this warning originates in the derive macro `Display` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/localization.rs:19:17 [INFO] [stdout] | [INFO] [stdout] 19 | #[derive(Debug, Display, Error)] [INFO] [stdout] | ^------ [INFO] [stdout] | | [INFO] [stdout] | `Display` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_DERIVE_Display_FOR_LocaleError` [INFO] [stdout] 20 | /// Some problem with loading a locale file [INFO] [stdout] 21 | pub enum LocaleError { [INFO] [stdout] | ----------- `LocaleError` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Display` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Display` may come from an old version of the `displaydoc` crate, try updating your dependency with `cargo update -p displaydoc` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue [INFO] [stdout] = note: this warning originates in the derive macro `Display` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/common/mod.rs:12:17 [INFO] [stdout] | [INFO] [stdout] 12 | #[derive(Debug, Display, Error)] [INFO] [stdout] | ^------ [INFO] [stdout] | | [INFO] [stdout] | `Display` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_DERIVE_Display_FOR_XmlError` [INFO] [stdout] 13 | pub enum XmlError { [INFO] [stdout] | -------- `XmlError` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Display` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Display` may come from an old version of the `displaydoc` crate, try updating your dependency with `cargo update -p displaydoc` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue [INFO] [stdout] = note: `#[warn(non_local_definitions)]` on by default [INFO] [stdout] = note: this warning originates in the derive macro `Display` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/common/exact.rs:14:17 [INFO] [stdout] | [INFO] [stdout] 14 | #[derive(Debug, Display, Error)] [INFO] [stdout] | ^------ [INFO] [stdout] | | [INFO] [stdout] | `Display` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_DERIVE_Display_FOR_Error` [INFO] [stdout] 15 | pub enum Error { [INFO] [stdout] | ----- `Error` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Display` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Display` may come from an old version of the `displaydoc` crate, try updating your dependency with `cargo update -p displaydoc` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue [INFO] [stdout] = note: this warning originates in the derive macro `Display` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/database/mod.rs:82:17 [INFO] [stdout] | [INFO] [stdout] 82 | #[derive(Debug, Display)] [INFO] [stdout] | ^------ [INFO] [stdout] | | [INFO] [stdout] | `Display` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_DERIVE_Display_FOR_UnknownValueType` [INFO] [stdout] 83 | /// Unknown value type '{0}' [INFO] [stdout] 84 | pub struct UnknownValueType(String); [INFO] [stdout] | ---------------- `UnknownValueType` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Display` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Display` may come from an old version of the `displaydoc` crate, try updating your dependency with `cargo update -p displaydoc` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue [INFO] [stdout] = note: this warning originates in the derive macro `Display` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/localization.rs:19:17 [INFO] [stdout] | [INFO] [stdout] 19 | #[derive(Debug, Display, Error)] [INFO] [stdout] | ^------ [INFO] [stdout] | | [INFO] [stdout] | `Display` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_DERIVE_Display_FOR_LocaleError` [INFO] [stdout] 20 | /// Some problem with loading a locale file [INFO] [stdout] 21 | pub enum LocaleError { [INFO] [stdout] | ----------- `LocaleError` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Display` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Display` may come from an old version of the `displaydoc` crate, try updating your dependency with `cargo update -p displaydoc` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue [INFO] [stdout] = note: this warning originates in the derive macro `Display` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `assembly-xml` (lib test) due to 2 previous errors; 4 warnings emitted [INFO] running `Command { std: "docker" "inspect" "670a0a3a875b518c1240f47159cf06b06f4465c44bb87d35a2f9731eae20461d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "670a0a3a875b518c1240f47159cf06b06f4465c44bb87d35a2f9731eae20461d", kill_on_drop: false }` [INFO] [stdout] 670a0a3a875b518c1240f47159cf06b06f4465c44bb87d35a2f9731eae20461d