[INFO] fetching crate arr-rs 0.6.0... [INFO] checking arr-rs-0.6.0 against try#7014e13d5becc920d4bea3cd87942c8a13d359bf+rustflags=-Dtail_expr_drop_order for pr-129864 [INFO] extracting crate arr-rs 0.6.0 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate arr-rs 0.6.0 on toolchain 7014e13d5becc920d4bea3cd87942c8a13d359bf [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate arr-rs 0.6.0 [INFO] finished tweaking crates.io crate arr-rs 0.6.0 [INFO] tweaked toml for crates.io crate arr-rs 0.6.0 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 97 packages to latest compatible versions [INFO] [stderr] Adding anes v0.1.6 (available: v0.2.0) [INFO] [stderr] Adding itertools v0.10.5 (available: v0.13.0) [INFO] [stderr] Adding rstest v0.18.2 (available: v0.22.0) [INFO] [stderr] Adding rstest_macros v0.18.2 (available: v0.22.0) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (available: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-sys v0.52.0 (available: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] f0728b3db2d7a12725d6975779d48d7261d48628374a3d8f4f878e790fd48c59 [INFO] running `Command { std: "docker" "start" "-a" "f0728b3db2d7a12725d6975779d48d7261d48628374a3d8f4f878e790fd48c59", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "f0728b3db2d7a12725d6975779d48d7261d48628374a3d8f4f878e790fd48c59", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f0728b3db2d7a12725d6975779d48d7261d48628374a3d8f4f878e790fd48c59", kill_on_drop: false }` [INFO] [stdout] f0728b3db2d7a12725d6975779d48d7261d48628374a3d8f4f878e790fd48c59 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] a2234468bd9d238636169eddf8bcc9c1141efd66e1427948e036c56506ea3007 [INFO] running `Command { std: "docker" "start" "-a" "a2234468bd9d238636169eddf8bcc9c1141efd66e1427948e036c56506ea3007", kill_on_drop: false }` [INFO] [stderr] Compiling semver v1.0.23 [INFO] [stderr] Compiling memchr v2.7.4 [INFO] [stderr] Checking futures-core v0.3.30 [INFO] [stderr] Checking futures-sink v0.3.30 [INFO] [stderr] Compiling regex-syntax v0.8.4 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Compiling relative-path v1.9.3 [INFO] [stderr] Checking futures-timer v3.0.3 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Compiling rustc_version v0.4.1 [INFO] [stderr] Compiling aho-corasick v1.1.3 [INFO] [stderr] Compiling rstest_macros v0.18.2 [INFO] [stderr] Compiling regex-automata v0.4.7 [INFO] [stderr] Compiling regex v1.10.6 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Compiling serde_derive v1.0.210 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking serde v1.0.210 [INFO] [stderr] Checking arr-rs v0.6.0 (/opt/rustwide/workdir) [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stdout] error: this value of type `core::array::Array` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/core/operations/axis.rs:307:9 [INFO] [stdout] | [INFO] [stdout] 305 | fn apply_along_axis(&self, axis: usize, f: F) -> Result, ArrayError> [INFO] [stdout] | - these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 306 | where F: FnMut(&Array) -> Result, ArrayError> { [INFO] [stdout] 307 | self.clone()?.apply_along_axis(axis, f) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking futures v0.3.30 [INFO] [stdout] error: this value of type `core::array::Array` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/core/operations/iter.rs:130:9 [INFO] [stdout] | [INFO] [stdout] 129 | fn filter bool>(&self, mut f: F) -> Result { [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 130 | / self.elements.clone().into_iter() [INFO] [stdout] 131 | | .filter(|item| f(item)) [INFO] [stdout] 132 | | .collect::() [INFO] [stdout] | |______________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `core::array::Array` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/core/operations/iter.rs:137:9 [INFO] [stdout] | [INFO] [stdout] 136 | fn filter_e bool>(&self, mut f: F) -> Result { [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 137 | / self.elements.clone().into_iter().enumerate() [INFO] [stdout] 138 | | .filter(|(idx, item)| f(*idx, item)) [INFO] [stdout] 139 | | .map(|i| i.1) [INFO] [stdout] 140 | | .collect::() [INFO] [stdout] | |______________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `core::array::Array` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/core/operations/iter.rs:283:9 [INFO] [stdout] | [INFO] [stdout] 282 | fn map_e S>(&self, mut f: F) -> Result, ArrayError> { [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 283 | / self.elements.iter().enumerate() [INFO] [stdout] 284 | | .map(|(idx, item)| f(idx, item)) [INFO] [stdout] 285 | | .collect::>() [INFO] [stdout] | |__________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `core::array::Array` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/core/operations/iter.rs:297:9 [INFO] [stdout] | [INFO] [stdout] 296 | fn filter_map_e Option>(&self, mut f: F) -> Result, ArrayError> { [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 297 | / self.elements.clone().iter().enumerate() [INFO] [stdout] 298 | | .filter_map(|(idx, item)| f(idx, item)) [INFO] [stdout] 299 | | .collect::>() [INFO] [stdout] | |__________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `core::array::Array>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/core/operations/iter.rs:310:9 [INFO] [stdout] | [INFO] [stdout] 309 | let other = other.broadcast_to(self.get_shape()?)?; [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 310 | / self.get_elements()?.into_iter() [INFO] [stdout] 311 | | .zip(other.get_elements()?) [INFO] [stdout] 312 | | .map(|item| Tuple2(item.0, item.1)) [INFO] [stdout] 313 | | .collect::>>() [INFO] [stdout] | |_____________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking rstest v0.18.2 [INFO] [stdout] error: this value of type `core::array::Array` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/core/operations/sort.rs:115:9 [INFO] [stdout] | [INFO] [stdout] 114 | fn sort(&self, axis: Option, kind: Option) -> Self { [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 115 | self.clone()?.sort(axis, kind) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `core::array::Array` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/core/operations/sort.rs:119:9 [INFO] [stdout] | [INFO] [stdout] 118 | fn argsort(&self, axis: Option, kind: Option) -> Result, ArrayError> { [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 119 | self.clone()?.argsort(axis, kind) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result, errors::ArrayError>>, errors::ArrayError>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/core/operations/split.rs:186:31 [INFO] [stdout] | [INFO] [stdout] 171 | arr.clone().map_or_else(|_| Err(arr.err().unwrap()), |arr| { [INFO] [stdout] | --- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 172 | let result = div_points [INFO] [stdout] | ------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 186 | if let Err(err) = result.has_error() { Err(err) } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `core::array::Array` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/alphanumeric/operations/compare.rs:273:9 [INFO] [stdout] | [INFO] [stdout] 272 | fn compare(&self, other: &Array, cmp_op: impl CompareOpType) -> Result, ArrayError> { [INFO] [stdout] | ------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 273 | self.clone()?.compare(other, cmp_op) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `core::array::Array` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/alphanumeric/operations/manipulate.rs:694:39 [INFO] [stdout] | [INFO] [stdout] 693 | fn split(&self, sep: Option>, max_split: Option>) -> Result>, ArrayError> { [INFO] [stdout] | --- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 694 | ArrayStringManipulate::split(&self.clone()?, sep, max_split) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `core::array::Array` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/alphanumeric/operations/manipulate.rs:698:9 [INFO] [stdout] | [INFO] [stdout] 697 | fn rsplit(&self, sep: Option>, max_split: Option>) -> Result>, ArrayError> { [INFO] [stdout] | --- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 698 | self.clone()?.rsplit(sep, max_split) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `core::array::Array` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/alphanumeric/operations/manipulate.rs:710:9 [INFO] [stdout] | [INFO] [stdout] 709 | fn strip(&self, chars: Option>) -> Self { [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 710 | self.clone()?.strip(chars) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `core::array::Array` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/alphanumeric/operations/manipulate.rs:714:9 [INFO] [stdout] | [INFO] [stdout] 713 | fn lstrip(&self, chars: Option>) -> Self { [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 714 | self.clone()?.lstrip(chars) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `core::array::Array` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/alphanumeric/operations/manipulate.rs:718:9 [INFO] [stdout] | [INFO] [stdout] 717 | fn rstrip(&self, chars: Option>) -> Self { [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 718 | self.clone()?.rstrip(chars) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 15 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `arr-rs` (lib) due to 16 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "a2234468bd9d238636169eddf8bcc9c1141efd66e1427948e036c56506ea3007", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a2234468bd9d238636169eddf8bcc9c1141efd66e1427948e036c56506ea3007", kill_on_drop: false }` [INFO] [stdout] a2234468bd9d238636169eddf8bcc9c1141efd66e1427948e036c56506ea3007