[INFO] fetching crate ap 0.1.5... [INFO] checking ap-0.1.5 against try#7014e13d5becc920d4bea3cd87942c8a13d359bf+rustflags=-Dtail_expr_drop_order for pr-129864 [INFO] extracting crate ap 0.1.5 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate ap 0.1.5 on toolchain 7014e13d5becc920d4bea3cd87942c8a13d359bf [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate ap 0.1.5 [INFO] finished tweaking crates.io crate ap 0.1.5 [INFO] tweaked toml for crates.io crate ap 0.1.5 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] crate crates.io crate ap 0.1.5 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] a7b8ad45f3ab15fc69135478d6b2ae34eaae3a5bbe94a438b33ad4de9c6715c3 [INFO] running `Command { std: "docker" "start" "-a" "a7b8ad45f3ab15fc69135478d6b2ae34eaae3a5bbe94a438b33ad4de9c6715c3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "a7b8ad45f3ab15fc69135478d6b2ae34eaae3a5bbe94a438b33ad4de9c6715c3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a7b8ad45f3ab15fc69135478d6b2ae34eaae3a5bbe94a438b33ad4de9c6715c3", kill_on_drop: false }` [INFO] [stdout] a7b8ad45f3ab15fc69135478d6b2ae34eaae3a5bbe94a438b33ad4de9c6715c3 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] ce1c46d537bb00c64ffdf37e609a741af5885be38f635fb82636e6f6f6a79cc4 [INFO] running `Command { std: "docker" "start" "-a" "ce1c46d537bb00c64ffdf37e609a741af5885be38f635fb82636e6f6f6a79cc4", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.26 [INFO] [stderr] Compiling unicode-xid v0.2.1 [INFO] [stderr] Compiling syn v1.0.70 [INFO] [stderr] Compiling memchr v2.4.0 [INFO] [stderr] Checking regex-syntax v0.6.25 [INFO] [stderr] Checking aho-corasick v0.7.18 [INFO] [stderr] Compiling quote v1.0.9 [INFO] [stderr] Checking regex v1.5.4 [INFO] [stderr] Compiling thiserror-impl v1.0.24 [INFO] [stderr] Checking thiserror v1.0.24 [INFO] [stderr] Checking ap v0.1.5 (/opt/rustwide/workdir) [INFO] [stdout] error: this value of type `args::App<'_>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/args.rs:1475:17 [INFO] [stdout] | [INFO] [stdout] 1230 | let tests = &[ [INFO] [stdout] | ______________________- [INFO] [stdout] 1231 | | TestData { [INFO] [stdout] 1232 | | cli_args: vec![], [INFO] [stdout] 1233 | | args: None, [INFO] [stdout] ... | [INFO] [stdout] 1462 | | }, [INFO] [stdout] 1463 | | ]; [INFO] [stdout] | |_________- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1475 | let mut app: App; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::result::Result<(), error::Error>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/args.rs:1603:17 [INFO] [stdout] | [INFO] [stdout] 1527 | let tests = &[ [INFO] [stdout] | ______________________- [INFO] [stdout] 1528 | | TestData { [INFO] [stdout] 1529 | | cli_args: vec![], [INFO] [stdout] 1530 | | args: vec![flag_opt.clone()], [INFO] [stdout] ... | [INFO] [stdout] 1588 | | }, [INFO] [stdout] 1589 | | ]; [INFO] [stdout] | |_________- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1603 | let result = app.parse_with_args(string_args); [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::result::Result<(), error::Error>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/args.rs:1829:17 [INFO] [stdout] | [INFO] [stdout] 1695 | let tests = &[ [INFO] [stdout] | ______________________- [INFO] [stdout] 1696 | | TestData { [INFO] [stdout] 1697 | | cli_args: vec![], [INFO] [stdout] 1698 | | result: Ok(()), [INFO] [stdout] ... | [INFO] [stdout] 1815 | | }, [INFO] [stdout] 1816 | | ]; [INFO] [stdout] | |_________- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1829 | let result = app.parse_with_args(string_args); [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `args::App<'_>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/args.rs:2048:17 [INFO] [stdout] | [INFO] [stdout] 1959 | let tests = &[ [INFO] [stdout] | ______________________- [INFO] [stdout] 1960 | | TestData { [INFO] [stdout] 1961 | | cli_args: vec!["-z"], [INFO] [stdout] 1962 | | args: vec![need_arg_opt.clone()], [INFO] [stdout] ... | [INFO] [stdout] 2036 | | }, [INFO] [stdout] 2037 | | ]; [INFO] [stdout] | |_________- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 2048 | let mut app = App::default().args(args).handler(Box::new(&mut handler)); [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `args::App<'_>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/args.rs:2174:17 [INFO] [stdout] | [INFO] [stdout] 2085 | let tests = &[ [INFO] [stdout] | ______________________- [INFO] [stdout] 2086 | | TestData { [INFO] [stdout] 2087 | | cli_args: vec!["foo bar"], [INFO] [stdout] 2088 | | args: vec![need_arg_opt.clone()], [INFO] [stdout] ... | [INFO] [stdout] 2162 | | }, [INFO] [stdout] 2163 | | ]; [INFO] [stdout] | |_________- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 2174 | let mut app = App::default().args(args).handler(Box::new(&mut handler)); [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `args::App<'_>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/args.rs:2702:17 [INFO] [stdout] | [INFO] [stdout] 2615 | let tests = &[ [INFO] [stdout] | ______________________- [INFO] [stdout] 2616 | | TestData { [INFO] [stdout] 2617 | | cli_args: vec!["-r", "foo", "-d"], [INFO] [stdout] 2618 | | args: vec![flag_opt.clone(), need_arg_opt.clone()], [INFO] [stdout] ... | [INFO] [stdout] 2690 | | }, [INFO] [stdout] 2691 | | ]; [INFO] [stdout] | |_________- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 2702 | let mut app = App::default().args(args).handler(Box::new(&mut handler)); [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `ap` (lib test) due to 7 previous errors [INFO] running `Command { std: "docker" "inspect" "ce1c46d537bb00c64ffdf37e609a741af5885be38f635fb82636e6f6f6a79cc4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ce1c46d537bb00c64ffdf37e609a741af5885be38f635fb82636e6f6f6a79cc4", kill_on_drop: false }` [INFO] [stdout] ce1c46d537bb00c64ffdf37e609a741af5885be38f635fb82636e6f6f6a79cc4