[INFO] fetching crate alloy-json-rpc 0.3.6... [INFO] checking alloy-json-rpc-0.3.6 against try#7014e13d5becc920d4bea3cd87942c8a13d359bf+rustflags=-Dtail_expr_drop_order for pr-129864 [INFO] extracting crate alloy-json-rpc 0.3.6 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate alloy-json-rpc 0.3.6 on toolchain 7014e13d5becc920d4bea3cd87942c8a13d359bf [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate alloy-json-rpc 0.3.6 [INFO] finished tweaking crates.io crate alloy-json-rpc 0.3.6 [INFO] tweaked toml for crates.io crate alloy-json-rpc 0.3.6 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 168 packages to latest compatible versions [INFO] [stderr] Adding ark-ff v0.3.0 (available: v0.4.2) [INFO] [stderr] Adding ark-ff-asm v0.3.0 (available: v0.4.2) [INFO] [stderr] Adding ark-ff-macros v0.3.0 (available: v0.4.2) [INFO] [stderr] Adding ark-serialize v0.3.0 (available: v0.4.2) [INFO] [stderr] Adding ark-std v0.3.0 (available: v0.4.0) [INFO] [stderr] Adding bit-set v0.5.3 (available: v0.8.0) [INFO] [stderr] Adding bit-vec v0.6.3 (available: v0.8.0) [INFO] [stderr] Adding digest v0.9.0 (available: v0.10.7) [INFO] [stderr] Adding fastrlp v0.3.1 (available: v0.4.0) [INFO] [stderr] Adding generic-array v0.14.7 (available: v1.1.0) [INFO] [stderr] Adding impl-codec v0.6.0 (available: v0.7.0) [INFO] [stderr] Adding itertools v0.10.5 (available: v0.13.0) [INFO] [stderr] Adding linux-raw-sys v0.4.14 (available: v0.6.5) [INFO] [stderr] Adding primitive-types v0.12.2 (available: v0.13.1) [INFO] [stderr] Adding quick-error v1.2.3 (available: v2.0.1) [INFO] [stderr] Adding radium v0.7.0 (available: v1.1.0) [INFO] [stderr] Adding rlp v0.5.2 (available: v0.6.1) [INFO] [stderr] Adding rustc_version v0.3.3 (available: v0.4.1) [INFO] [stderr] Adding semver v0.11.0 (available: v1.0.23) [INFO] [stderr] Adding syn v1.0.109 (available: v2.0.77) [INFO] [stderr] Adding uint v0.9.5 (available: v0.10.0) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (available: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-sys v0.52.0 (available: v0.59.0) [INFO] [stderr] Adding wyz v0.5.1 (available: v0.6.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] fd1240f0636b9f6a12b1c0b414e949037ff51bc6e2e5bc8c86a53a583e3e1082 [INFO] running `Command { std: "docker" "start" "-a" "fd1240f0636b9f6a12b1c0b414e949037ff51bc6e2e5bc8c86a53a583e3e1082", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "fd1240f0636b9f6a12b1c0b414e949037ff51bc6e2e5bc8c86a53a583e3e1082", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "fd1240f0636b9f6a12b1c0b414e949037ff51bc6e2e5bc8c86a53a583e3e1082", kill_on_drop: false }` [INFO] [stdout] fd1240f0636b9f6a12b1c0b414e949037ff51bc6e2e5bc8c86a53a583e3e1082 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] ef967fcbce0fc5a880e149b67eb9dc11c48cb70eef0a112ea3eec215e17fe1c6 [INFO] running `Command { std: "docker" "start" "-a" "ef967fcbce0fc5a880e149b67eb9dc11c48cb70eef0a112ea3eec215e17fe1c6", kill_on_drop: false }` [INFO] [stderr] Compiling crunchy v0.2.2 [INFO] [stderr] Compiling serde v1.0.210 [INFO] [stderr] Compiling tiny-keccak v2.0.2 [INFO] [stderr] Compiling cpufeatures v0.2.14 [INFO] [stderr] Compiling cfg-if v1.0.0 [INFO] [stderr] Compiling heck v0.5.0 [INFO] [stderr] Compiling hashbrown v0.14.5 [INFO] [stderr] Compiling equivalent v1.0.1 [INFO] [stderr] Compiling dunce v1.0.5 [INFO] [stderr] Compiling unicode-xid v0.2.6 [INFO] [stderr] Compiling ruint-macro v1.2.1 [INFO] [stderr] Checking hex-literal v0.4.1 [INFO] [stderr] Compiling serde_json v1.0.128 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Compiling proc-macro-error-attr2 v2.0.0 [INFO] [stderr] Compiling const-hex v1.12.0 [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Compiling indexmap v2.5.0 [INFO] [stderr] Compiling syn-solidity v0.8.5 [INFO] [stderr] Compiling proc-macro-error2 v2.0.1 [INFO] [stderr] Compiling serde_derive v1.0.210 [INFO] [stderr] Compiling derive_more-impl v1.0.0 [INFO] [stderr] Compiling thiserror-impl v1.0.64 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Checking thiserror v1.0.64 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Compiling alloy-sol-macro-input v0.8.5 [INFO] [stderr] Compiling alloy-sol-macro-expander v0.8.5 [INFO] [stderr] Checking derive_more v1.0.0 [INFO] [stderr] Compiling alloy-sol-macro v0.8.5 [INFO] [stderr] Checking bytes v1.7.2 [INFO] [stderr] Checking ruint v1.12.3 [INFO] [stderr] Checking alloy-primitives v0.8.5 [INFO] [stderr] Checking alloy-sol-types v0.8.5 [INFO] [stderr] Checking alloy-json-rpc v0.3.6 (/opt/rustwide/workdir) [INFO] [stdout] error: this value of type `RequestPacket` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/packet.rs:95:17 [INFO] [stdout] | [INFO] [stdout] 89 | pub fn push(&mut self, req: SerializedRequest) { [INFO] [stdout] | --- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 95 | let old = std::mem::replace(self, Self::Batch(Vec::with_capacity(10))); [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::option::Option>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/response/error.rs:240:15 [INFO] [stdout] | [INFO] [stdout] 239 | pub fn deser_data(self) -> Result, Self> { [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 240 | match self.try_data_as::() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Box` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/notification.rs:165:70 [INFO] [stdout] | [INFO] [stdout] 162 | let deser = serde_json::from_str::(notification).unwrap(); [INFO] [stdout] | ----- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 165 | PubSubItem::Notification(EthNotification { subscription, result }) => { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result, ResponsePayload>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/response/mod.rs:79:15 [INFO] [stdout] | [INFO] [stdout] 78 | pub fn deser_success(self) -> Result, Self> { [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 79 | match self.payload.deserialize_success() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `RequestPacket` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/packet.rs:95:17 [INFO] [stdout] | [INFO] [stdout] 89 | pub fn push(&mut self, req: SerializedRequest) { [INFO] [stdout] | --- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 95 | let old = std::mem::replace(self, Self::Batch(Vec::with_capacity(10))); [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result, ResponsePayload>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/response/mod.rs:106:15 [INFO] [stdout] | [INFO] [stdout] 105 | pub fn deser_err(self) -> Result, Self> { [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 106 | match self.payload.deserialize_error() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `(std::option::Option, std::option::Option>)` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/response/mod.rs:209:23 [INFO] [stdout] | [INFO] [stdout] 174 | fn visit_map(self, mut map: M) -> Result [INFO] [stdout] | ------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 209 | match (result, error) { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `alloy-json-rpc` (lib) due to 6 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: this value of type `std::option::Option>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/response/error.rs:240:15 [INFO] [stdout] | [INFO] [stdout] 239 | pub fn deser_data(self) -> Result, Self> { [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 240 | match self.try_data_as::() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result, ResponsePayload>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/response/mod.rs:79:15 [INFO] [stdout] | [INFO] [stdout] 78 | pub fn deser_success(self) -> Result, Self> { [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 79 | match self.payload.deserialize_success() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result, ResponsePayload>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/response/mod.rs:106:15 [INFO] [stdout] | [INFO] [stdout] 105 | pub fn deser_err(self) -> Result, Self> { [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 106 | match self.payload.deserialize_error() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `(std::option::Option, std::option::Option>)` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/response/mod.rs:209:23 [INFO] [stdout] | [INFO] [stdout] 174 | fn visit_map(self, mut map: M) -> Result [INFO] [stdout] | ------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 209 | match (result, error) { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `alloy-json-rpc` (lib test) due to 7 previous errors [INFO] running `Command { std: "docker" "inspect" "ef967fcbce0fc5a880e149b67eb9dc11c48cb70eef0a112ea3eec215e17fe1c6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ef967fcbce0fc5a880e149b67eb9dc11c48cb70eef0a112ea3eec215e17fe1c6", kill_on_drop: false }` [INFO] [stdout] ef967fcbce0fc5a880e149b67eb9dc11c48cb70eef0a112ea3eec215e17fe1c6