[INFO] fetching crate albion_terminal_rpg 1.8.6... [INFO] checking albion_terminal_rpg-1.8.6 against try#7014e13d5becc920d4bea3cd87942c8a13d359bf+rustflags=-Dtail_expr_drop_order for pr-129864 [INFO] extracting crate albion_terminal_rpg 1.8.6 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate albion_terminal_rpg 1.8.6 on toolchain 7014e13d5becc920d4bea3cd87942c8a13d359bf [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate albion_terminal_rpg 1.8.6 [INFO] finished tweaking crates.io crate albion_terminal_rpg 1.8.6 [INFO] tweaked toml for crates.io crate albion_terminal_rpg 1.8.6 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] crate crates.io crate albion_terminal_rpg 1.8.6 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 50dd4b0cec3670217abf014aee94c227b774e3f8d2d4a38e7e4031438cd2ea5f [INFO] running `Command { std: "docker" "start" "-a" "50dd4b0cec3670217abf014aee94c227b774e3f8d2d4a38e7e4031438cd2ea5f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "50dd4b0cec3670217abf014aee94c227b774e3f8d2d4a38e7e4031438cd2ea5f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "50dd4b0cec3670217abf014aee94c227b774e3f8d2d4a38e7e4031438cd2ea5f", kill_on_drop: false }` [INFO] [stdout] 50dd4b0cec3670217abf014aee94c227b774e3f8d2d4a38e7e4031438cd2ea5f [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 1ba5db8d2b69a78f3252f23b5b5afcb52f8c70a71163bb8de6d21c68d2a3f8c1 [INFO] running `Command { std: "docker" "start" "-a" "1ba5db8d2b69a78f3252f23b5b5afcb52f8c70a71163bb8de6d21c68d2a3f8c1", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.153 [INFO] [stderr] Compiling proc-macro2 v1.0.78 [INFO] [stderr] Compiling unicode-ident v1.0.12 [INFO] [stderr] Compiling version_check v0.9.4 [INFO] [stderr] Compiling serde v1.0.197 [INFO] [stderr] Compiling autocfg v1.1.0 [INFO] [stderr] Checking unicode-width v0.1.11 [INFO] [stderr] Compiling signal-hook v0.3.17 [INFO] [stderr] Compiling rustix v0.38.31 [INFO] [stderr] Compiling parking_lot_core v0.9.9 [INFO] [stderr] Compiling rustversion v1.0.14 [INFO] [stderr] Checking bitflags v2.4.2 [INFO] [stderr] Checking smallvec v1.13.1 [INFO] [stderr] Checking log v0.4.20 [INFO] [stderr] Checking hashbrown v0.14.3 [INFO] [stderr] Compiling thiserror v1.0.57 [INFO] [stderr] Checking bytecount v0.6.7 [INFO] [stderr] Checking memchr v2.7.1 [INFO] [stderr] Checking linux-raw-sys v0.4.13 [INFO] [stderr] Checking papergrid v0.11.0 [INFO] [stderr] Checking ryu v1.0.17 [INFO] [stderr] Checking lazy_static v1.4.0 [INFO] [stderr] Checking ppv-lite86 v0.2.17 [INFO] [stderr] Checking winnow v0.6.2 [INFO] [stderr] Checking itoa v1.0.10 [INFO] [stderr] Compiling heck v0.4.1 [INFO] [stderr] Checking fastrand v2.0.1 [INFO] [stderr] Compiling generic-array v0.14.7 [INFO] [stderr] Compiling lock_api v0.4.11 [INFO] [stderr] Checking zeroize v1.7.0 [INFO] [stderr] Checking base64 v0.21.7 [INFO] [stderr] Checking subtle v2.5.0 [INFO] [stderr] Checking shell-words v1.1.0 [INFO] [stderr] Checking whoami v1.4.1 [INFO] [stderr] Checking csv-core v0.1.11 [INFO] [stderr] Checking indexmap v2.2.3 [INFO] [stderr] Compiling quote v1.0.35 [INFO] [stderr] Compiling syn v2.0.50 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking inout v0.1.3 [INFO] [stderr] Checking tabled v0.15.0 [INFO] [stderr] Checking getrandom v0.2.12 [INFO] [stderr] Checking signal-hook-registry v1.4.1 [INFO] [stderr] Checking mio v0.8.10 [INFO] [stderr] Checking rtoolbox v0.0.2 [INFO] [stderr] Checking console v0.15.8 [INFO] [stderr] Checking cipher v0.4.4 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking rpassword v7.3.1 [INFO] [stderr] Checking parking_lot v0.12.1 [INFO] [stderr] Checking blowfish v0.9.1 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking bcrypt v0.15.0 [INFO] [stderr] Checking signal-hook-mio v0.2.3 [INFO] [stderr] Checking crossterm v0.27.0 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking tempfile v3.10.1 [INFO] [stderr] Compiling serde_derive v1.0.197 [INFO] [stderr] Compiling thiserror-impl v1.0.57 [INFO] [stderr] Compiling strum_macros v0.26.1 [INFO] [stderr] Checking dialoguer v0.11.0 [INFO] [stderr] Checking strum v0.26.1 [INFO] [stderr] Checking toml_datetime v0.6.5 [INFO] [stderr] Checking serde_spanned v0.6.5 [INFO] [stderr] Checking csv v1.3.0 [INFO] [stderr] Checking toml_edit v0.22.6 [INFO] [stderr] Checking csv_to_table v0.4.0 [INFO] [stderr] Checking toml v0.8.10 [INFO] [stderr] Checking albion_terminal_rpg v1.8.6 (/opt/rustwide/workdir) [INFO] [stdout] error: this value of type `std::result::Result<(), std::io::Error>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils/files.rs:125:27 [INFO] [stdout] | [INFO] [stdout] 117 | pub fn write_file(file_path: &str, data: T) { [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 125 | if let Err(message) = fs::write(file_path, data.to_string()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::result::Result<(), std::io::Error>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils/files.rs:125:27 [INFO] [stdout] | [INFO] [stdout] 117 | pub fn write_file(file_path: &str, data: T) { [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 125 | if let Err(message) = fs::write(file_path, data.to_string()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::result::Result<(), Box>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/data/player.rs:281:35 [INFO] [stdout] | [INFO] [stdout] 261 | let file_result: error::Result = read_file(&profile_path); [INFO] [stdout] | ----------- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 281 | if let Err(message) = Player::delete_from(username) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] ::: src/utils/error.rs:342:86 [INFO] [stdout] | [INFO] [stdout] 342 | $crate::utils::error::macros::panic_builder(file!(), line!(), column!(), Some($fmt)); [INFO] [stdout] | ---------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::result::Result<(), Box>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/data/player.rs:281:35 [INFO] [stdout] | [INFO] [stdout] 261 | let file_result: error::Result = read_file(&profile_path); [INFO] [stdout] | ----------- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 281 | if let Err(message) = Player::delete_from(username) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] ::: src/utils/error.rs:342:86 [INFO] [stdout] | [INFO] [stdout] 342 | $crate::utils::error::macros::panic_builder(file!(), line!(), column!(), Some($fmt)); [INFO] [stdout] | ---------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `albion_terminal_rpg` (lib test) due to 3 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 2 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `albion_terminal_rpg` (lib) due to 3 previous errors [INFO] running `Command { std: "docker" "inspect" "1ba5db8d2b69a78f3252f23b5b5afcb52f8c70a71163bb8de6d21c68d2a3f8c1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1ba5db8d2b69a78f3252f23b5b5afcb52f8c70a71163bb8de6d21c68d2a3f8c1", kill_on_drop: false }` [INFO] [stdout] 1ba5db8d2b69a78f3252f23b5b5afcb52f8c70a71163bb8de6d21c68d2a3f8c1