[INFO] cloning repository https://github.com/MohamedJeffal/balena-warp [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/MohamedJeffal/balena-warp" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FMohamedJeffal%2Fbalena-warp", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FMohamedJeffal%2Fbalena-warp'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] e0d166ca4244a885abb95090035250ef71fe6833 [INFO] checking MohamedJeffal/balena-warp/e0d166ca4244a885abb95090035250ef71fe6833 against try#7014e13d5becc920d4bea3cd87942c8a13d359bf+rustflags=-Dtail_expr_drop_order for pr-129864 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FMohamedJeffal%2Fbalena-warp" "/workspace/builds/worker-7-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-7-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/MohamedJeffal/balena-warp on toolchain 7014e13d5becc920d4bea3cd87942c8a13d359bf [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] removed /workspace/builds/worker-7-tc2/source/rust-toolchain [INFO] started tweaking git repo https://github.com/MohamedJeffal/balena-warp [INFO] finished tweaking git repo https://github.com/MohamedJeffal/balena-warp [INFO] tweaked toml for git repo https://github.com/MohamedJeffal/balena-warp written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/MohamedJeffal/balena-warp already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] bef52fdcfe47ebcc24bacd359b1bf33d99bed5b5c0d9ae79247dfeb46b0649a3 [INFO] running `Command { std: "docker" "start" "-a" "bef52fdcfe47ebcc24bacd359b1bf33d99bed5b5c0d9ae79247dfeb46b0649a3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "bef52fdcfe47ebcc24bacd359b1bf33d99bed5b5c0d9ae79247dfeb46b0649a3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "bef52fdcfe47ebcc24bacd359b1bf33d99bed5b5c0d9ae79247dfeb46b0649a3", kill_on_drop: false }` [INFO] [stdout] bef52fdcfe47ebcc24bacd359b1bf33d99bed5b5c0d9ae79247dfeb46b0649a3 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] e7503b6f5c7e9da51e7c20812d2f7f6a5774eb1f43c5aa62fb2abe6a988f4533 [INFO] running `Command { std: "docker" "start" "-a" "e7503b6f5c7e9da51e7c20812d2f7f6a5774eb1f43c5aa62fb2abe6a988f4533", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] [stderr] Compiling libc v0.2.44 [INFO] [stderr] Compiling semver-parser v0.7.0 [INFO] [stderr] Checking byteorder v1.2.7 [INFO] [stderr] Checking rand_core v0.3.0 [INFO] [stderr] Checking futures v0.1.25 [INFO] [stderr] Checking log v0.4.6 [INFO] [stderr] Checking crossbeam-utils v0.6.1 [INFO] [stderr] Compiling typenum v1.10.0 [INFO] [stderr] Checking void v1.0.2 [INFO] [stderr] Compiling semver v0.9.0 [INFO] [stderr] Checking slab v0.4.1 [INFO] [stderr] Checking rand_core v0.2.2 [INFO] [stderr] Checking unreachable v1.0.0 [INFO] [stderr] Checking stable_deref_trait v1.1.1 [INFO] [stderr] Checking lazycell v1.2.0 [INFO] [stderr] Checking owning_ref v0.4.0 [INFO] [stderr] Compiling rustc_version v0.2.3 [INFO] [stderr] Checking smallvec v0.6.6 [INFO] [stderr] Checking itoa v0.4.3 [INFO] [stderr] Checking lock_api v0.1.5 [INFO] [stderr] Compiling parking_lot_core v0.3.1 [INFO] [stderr] Compiling rand_pcg v0.1.1 [INFO] [stderr] Compiling rand_chacha v0.1.0 [INFO] [stderr] Compiling proc-macro2 v0.4.24 [INFO] [stderr] Checking arrayvec v0.4.7 [INFO] [stderr] Compiling rand v0.6.0 [INFO] [stderr] Checking iovec v0.1.2 [INFO] [stderr] Checking rand v0.5.5 [INFO] [stderr] Checking num_cpus v1.8.0 [INFO] [stderr] Checking bytes v0.4.11 [INFO] [stderr] Checking net2 v0.2.33 [INFO] [stderr] Compiling phf_shared v0.7.23 [INFO] [stderr] Checking crossbeam-epoch v0.6.1 [INFO] [stderr] Checking mio v0.6.16 [INFO] [stderr] Checking rand_xorshift v0.1.0 [INFO] [stderr] Checking tokio-executor v0.1.5 [INFO] [stderr] Checking tokio-io v0.1.10 [INFO] [stderr] Checking rand_hc v0.1.0 [INFO] [stderr] Checking rand_isaac v0.1.0 [INFO] [stderr] Compiling unicase v2.2.0 [INFO] [stderr] Compiling memchr v2.1.1 [INFO] [stderr] Checking fnv v1.0.6 [INFO] [stderr] Checking http v0.1.14 [INFO] [stderr] Checking unicode-bidi v0.3.4 [INFO] [stderr] Compiling quote v0.6.10 [INFO] [stderr] Checking tokio-codec v0.1.1 [INFO] [stderr] Checking crossbeam-deque v0.6.2 [INFO] [stderr] Checking generic-array v0.12.0 [INFO] [stderr] Checking time v0.1.40 [INFO] [stderr] Checking fake-simd v0.1.2 [INFO] [stderr] Compiling serde v1.0.80 [INFO] [stderr] Checking byte-tools v0.3.0 [INFO] [stderr] Checking unicode-normalization v0.1.7 [INFO] [stderr] Compiling num-traits v0.2.6 [INFO] [stderr] Compiling httparse v1.3.3 [INFO] [stderr] Checking parking_lot v0.6.4 [INFO] [stderr] Checking block-padding v0.1.2 [INFO] [stderr] Checking mio-uds v0.6.7 [INFO] [stderr] Compiling syn v0.15.21 [INFO] [stderr] Checking tokio-reactor v0.1.7 [INFO] [stderr] Checking generic-array v0.9.0 [INFO] [stderr] Compiling regex v1.0.6 [INFO] [stderr] Compiling phf_generator v0.7.23 [INFO] [stderr] Checking tokio-threadpool v0.1.9 [INFO] [stderr] Compiling phf_codegen v0.7.23 [INFO] [stderr] Checking idna v0.1.5 [INFO] [stderr] Compiling ryu v0.2.7 [INFO] [stderr] Checking arrayref v0.3.5 [INFO] [stderr] Compiling num-integer v0.1.39 [INFO] [stderr] Checking byte-tools v0.2.0 [INFO] [stderr] Checking ucd-util v0.1.3 [INFO] [stderr] Checking block-buffer v0.3.3 [INFO] [stderr] Compiling mime_guess v2.0.0-alpha.6 [INFO] [stderr] Checking regex-syntax v0.6.3 [INFO] [stderr] Checking tokio-fs v0.1.4 [INFO] [stderr] Checking digest v0.7.6 [INFO] [stderr] Checking aho-corasick v0.6.9 [INFO] [stderr] Checking mime v0.3.12 [INFO] [stderr] Checking url v1.7.2 [INFO] [stderr] Checking tokio-uds v0.2.4 [INFO] [stderr] Checking tokio-udp v0.1.3 [INFO] [stderr] Checking tokio-tcp v0.1.2 [INFO] [stderr] Checking block-buffer v0.7.0 [INFO] [stderr] Checking digest v0.8.0 [INFO] [stderr] Checking tokio-current-thread v0.1.4 [INFO] [stderr] Checking tokio-timer v0.2.8 [INFO] [stderr] Checking thread_local v0.3.6 [INFO] [stderr] Checking quick-error v1.2.2 [INFO] [stderr] Checking try-lock v0.2.2 [INFO] [stderr] Checking opaque-debug v0.2.1 [INFO] [stderr] Checking safemem v0.3.0 [INFO] [stderr] Checking indexmap v1.0.2 [INFO] [stderr] Checking utf8-ranges v1.0.2 [INFO] [stderr] Checking string v0.1.2 [INFO] [stderr] Checking humantime v1.1.1 [INFO] [stderr] Checking base64 v0.9.3 [INFO] [stderr] Checking sha-1 v0.8.1 [INFO] [stderr] Checking h2 v0.1.13 [INFO] [stderr] Checking want v0.0.6 [INFO] [stderr] Checking tokio v0.1.13 [INFO] [stderr] Checking headers-core v0.0.1 [INFO] [stderr] Checking phf v0.7.23 [INFO] [stderr] Checking sha-1 v0.7.0 [INFO] [stderr] Checking futures-cpupool v0.1.8 [INFO] [stderr] Checking input_buffer v0.2.0 [INFO] [stderr] Checking atty v0.2.11 [INFO] [stderr] Checking base64 v0.10.0 [INFO] [stderr] Checking termcolor v1.0.4 [INFO] [stderr] Checking utf-8 v0.7.4 [INFO] [stderr] Checking dtoa v0.4.3 [INFO] [stderr] Checking chrono v0.4.6 [INFO] [stderr] Checking scoped-tls v0.1.2 [INFO] [stderr] Checking tungstenite v0.6.1 [INFO] [stderr] Checking urlencoding v1.0.0 [INFO] [stderr] Compiling headers-derive v0.0.1 [INFO] [stderr] Compiling serde_derive v1.0.80 [INFO] [stderr] Checking headers-ext v0.0.3 [INFO] [stderr] Checking hyper v0.12.16 [INFO] [stderr] Checking env_logger v0.5.13 [INFO] [stderr] Checking pretty_env_logger v0.2.5 [INFO] [stderr] Checking serde_json v1.0.33 [INFO] [stderr] Checking serde_urlencoded v0.5.4 [INFO] [stderr] Checking warp v0.1.9 [INFO] [stderr] Checking warp-testo v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] error: this value of type `MutexGuard<'_, Vec>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:118:25 [INFO] [stdout] | [INFO] [stdout] 116 | fn list_todos(db: Db) -> impl warp::Reply { [INFO] [stdout] | -- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 117 | // Just return a JSON array of all Todos. [INFO] [stdout] 118 | warp::reply::json(&*db.lock().unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `MutexGuard<'_, Vec>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:118:25 [INFO] [stdout] | [INFO] [stdout] 116 | fn list_todos(db: Db) -> impl warp::Reply { [INFO] [stdout] | -- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 117 | // Just return a JSON array of all Todos. [INFO] [stdout] 118 | warp::reply::json(&*db.lock().unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/main.rs:17:17 [INFO] [stdout] | [INFO] [stdout] 17 | #[derive(Debug, Deserialize, Serialize)] [INFO] [stdout] | ^---------- [INFO] [stdout] | | [INFO] [stdout] | `Deserialize` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_IMPL_DESERIALIZE_FOR_Todo` [INFO] [stdout] 18 | struct Todo { [INFO] [stdout] | ---- `Todo` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Deserialize` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Deserialize` may come from an old version of the `serde_derive` crate, try updating your dependency with `cargo update -p serde_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue [INFO] [stdout] note: the lint level is defined here [INFO] [stdout] --> src/main.rs:1:9 [INFO] [stdout] | [INFO] [stdout] 1 | #![deny(warnings)] [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] = note: `#[deny(non_local_definitions)]` implied by `#[deny(warnings)]` [INFO] [stdout] = note: this error originates in the derive macro `Deserialize` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/main.rs:17:30 [INFO] [stdout] | [INFO] [stdout] 17 | #[derive(Debug, Deserialize, Serialize)] [INFO] [stdout] | ^-------- [INFO] [stdout] | | [INFO] [stdout] | `Serialize` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_IMPL_SERIALIZE_FOR_Todo` [INFO] [stdout] 18 | struct Todo { [INFO] [stdout] | ---- `Todo` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Serialize` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Serialize` may come from an old version of the `serde_derive` crate, try updating your dependency with `cargo update -p serde_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue [INFO] [stdout] = note: this error originates in the derive macro `Serialize` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `warp-testo` (bin "warp-testo" test) due to 4 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/main.rs:17:17 [INFO] [stdout] | [INFO] [stdout] 17 | #[derive(Debug, Deserialize, Serialize)] [INFO] [stdout] | ^---------- [INFO] [stdout] | | [INFO] [stdout] | `Deserialize` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_IMPL_DESERIALIZE_FOR_Todo` [INFO] [stdout] 18 | struct Todo { [INFO] [stdout] | ---- `Todo` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Deserialize` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Deserialize` may come from an old version of the `serde_derive` crate, try updating your dependency with `cargo update -p serde_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue [INFO] [stdout] note: the lint level is defined here [INFO] [stdout] --> src/main.rs:1:9 [INFO] [stdout] | [INFO] [stdout] 1 | #![deny(warnings)] [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] = note: `#[deny(non_local_definitions)]` implied by `#[deny(warnings)]` [INFO] [stdout] = note: this error originates in the derive macro `Deserialize` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/main.rs:17:30 [INFO] [stdout] | [INFO] [stdout] 17 | #[derive(Debug, Deserialize, Serialize)] [INFO] [stdout] | ^-------- [INFO] [stdout] | | [INFO] [stdout] | `Serialize` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_IMPL_SERIALIZE_FOR_Todo` [INFO] [stdout] 18 | struct Todo { [INFO] [stdout] | ---- `Todo` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Serialize` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Serialize` may come from an old version of the `serde_derive` crate, try updating your dependency with `cargo update -p serde_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue [INFO] [stdout] = note: this error originates in the derive macro `Serialize` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `warp-testo` (bin "warp-testo") due to 4 previous errors [INFO] running `Command { std: "docker" "inspect" "e7503b6f5c7e9da51e7c20812d2f7f6a5774eb1f43c5aa62fb2abe6a988f4533", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e7503b6f5c7e9da51e7c20812d2f7f6a5774eb1f43c5aa62fb2abe6a988f4533", kill_on_drop: false }` [INFO] [stdout] e7503b6f5c7e9da51e7c20812d2f7f6a5774eb1f43c5aa62fb2abe6a988f4533