[INFO] cloning repository https://github.com/KoenWestendorp/rlox [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/KoenWestendorp/rlox" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FKoenWestendorp%2Frlox", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FKoenWestendorp%2Frlox'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] caf1328429193147989092701b9a9ced10172825 [INFO] checking KoenWestendorp/rlox/caf1328429193147989092701b9a9ced10172825 against try#7014e13d5becc920d4bea3cd87942c8a13d359bf+rustflags=-Dtail_expr_drop_order for pr-129864 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FKoenWestendorp%2Frlox" "/workspace/builds/worker-3-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-3-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/KoenWestendorp/rlox on toolchain 7014e13d5becc920d4bea3cd87942c8a13d359bf [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/KoenWestendorp/rlox [INFO] finished tweaking git repo https://github.com/KoenWestendorp/rlox [INFO] tweaked toml for git repo https://github.com/KoenWestendorp/rlox written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/KoenWestendorp/rlox already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] a12264414f9675c0706355fc8c7e156a46a19ae84c7d30e81d0d5137c2b3da09 [INFO] running `Command { std: "docker" "start" "-a" "a12264414f9675c0706355fc8c7e156a46a19ae84c7d30e81d0d5137c2b3da09", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "a12264414f9675c0706355fc8c7e156a46a19ae84c7d30e81d0d5137c2b3da09", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a12264414f9675c0706355fc8c7e156a46a19ae84c7d30e81d0d5137c2b3da09", kill_on_drop: false }` [INFO] [stdout] a12264414f9675c0706355fc8c7e156a46a19ae84c7d30e81d0d5137c2b3da09 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 70b5ce556f315726a0feba47f5991e2c253388a402b4ccd086efbdc65a9ed17f [INFO] running `Command { std: "docker" "start" "-a" "70b5ce556f315726a0feba47f5991e2c253388a402b4ccd086efbdc65a9ed17f", kill_on_drop: false }` [INFO] [stderr] Checking rlox v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `Arguments` [INFO] [stdout] --> src/ast.rs:1:16 [INFO] [stdout] | [INFO] [stdout] 1 | use std::fmt::{Arguments, Display}; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Expr` [INFO] [stdout] --> src/callable.rs:1:18 [INFO] [stdout] | [INFO] [stdout] 1 | use crate::ast::{Expr, Stmt}; [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `self` [INFO] [stdout] --> src/callable.rs:2:26 [INFO] [stdout] | [INFO] [stdout] 2 | use crate::environment::{self, Environment}; [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Arguments` [INFO] [stdout] --> src/ast.rs:1:16 [INFO] [stdout] | [INFO] [stdout] 1 | use std::fmt::{Arguments, Display}; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `environment::Environment` [INFO] [stdout] --> src/token.rs:5:5 [INFO] [stdout] | [INFO] [stdout] 5 | environment::Environment, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Expr` [INFO] [stdout] --> src/callable.rs:1:18 [INFO] [stdout] | [INFO] [stdout] 1 | use crate::ast::{Expr, Stmt}; [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `self` [INFO] [stdout] --> src/callable.rs:2:26 [INFO] [stdout] | [INFO] [stdout] 2 | use crate::environment::{self, Environment}; [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `environment::Environment` [INFO] [stdout] --> src/token.rs:5:5 [INFO] [stdout] | [INFO] [stdout] 5 | environment::Environment, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `params` [INFO] [stdout] --> src/ast.rs:130:36 [INFO] [stdout] | [INFO] [stdout] 130 | Stmt::Function { name, params, body } => write!(f, "", name = name.lexeme()), [INFO] [stdout] | ^^^^^^ help: try ignoring the field: `params: _` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `body` [INFO] [stdout] --> src/ast.rs:130:44 [INFO] [stdout] | [INFO] [stdout] 130 | Stmt::Function { name, params, body } => write!(f, "", name = name.lexeme()), [INFO] [stdout] | ^^^^ help: try ignoring the field: `body: _` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `params` [INFO] [stdout] --> src/ast.rs:130:36 [INFO] [stdout] | [INFO] [stdout] 130 | Stmt::Function { name, params, body } => write!(f, "", name = name.lexeme()), [INFO] [stdout] | ^^^^^^ help: try ignoring the field: `params: _` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `body` [INFO] [stdout] --> src/ast.rs:130:44 [INFO] [stdout] | [INFO] [stdout] 130 | Stmt::Function { name, params, body } => write!(f, "", name = name.lexeme()), [INFO] [stdout] | ^^^^ help: try ignoring the field: `body: _` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Box` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/interpreter.rs:34:17 [INFO] [stdout] | [INFO] [stdout] 24 | fn evaluate(&mut self, expr: Expr, environment: &mut Environment) -> Result { [INFO] [stdout] | ---- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 34 | left, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Box` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/interpreter.rs:34:17 [INFO] [stdout] | [INFO] [stdout] 24 | fn evaluate(&mut self, expr: Expr, environment: &mut Environment) -> Result { [INFO] [stdout] | ---- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 34 | left, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `globals` and `backtrace` are never read [INFO] [stdout] --> src/interpreter.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 8 | pub(crate) struct Interpreter { [INFO] [stdout] | ----------- fields in this struct [INFO] [stdout] 9 | globals: Box, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] 10 | backtrace: Vec, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Interpreter` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `Identifier` is never constructed [INFO] [stdout] --> src/token.rs:69:5 [INFO] [stdout] | [INFO] [stdout] 68 | pub enum Literal { [INFO] [stdout] | ------- variant in this enum [INFO] [stdout] 69 | Identifier(String), [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Literal` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `identifier` is never used [INFO] [stdout] --> src/token.rs:78:8 [INFO] [stdout] | [INFO] [stdout] 77 | impl Literal { [INFO] [stdout] | ------------ method in this implementation [INFO] [stdout] 78 | fn identifier(&self) -> Option<&String> { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `globals` and `backtrace` are never read [INFO] [stdout] --> src/interpreter.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 8 | pub(crate) struct Interpreter { [INFO] [stdout] | ----------- fields in this struct [INFO] [stdout] 9 | globals: Box, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] 10 | backtrace: Vec, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Interpreter` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `Identifier` is never constructed [INFO] [stdout] --> src/token.rs:69:5 [INFO] [stdout] | [INFO] [stdout] 68 | pub enum Literal { [INFO] [stdout] | ------- variant in this enum [INFO] [stdout] 69 | Identifier(String), [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Literal` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `identifier` is never used [INFO] [stdout] --> src/token.rs:78:8 [INFO] [stdout] | [INFO] [stdout] 77 | impl Literal { [INFO] [stdout] | ------------ method in this implementation [INFO] [stdout] 78 | fn identifier(&self) -> Option<&String> { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 9 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 9 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rlox` (bin "rlox") due to 2 previous errors; 9 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `rlox` (bin "rlox" test) due to 2 previous errors; 9 warnings emitted [INFO] running `Command { std: "docker" "inspect" "70b5ce556f315726a0feba47f5991e2c253388a402b4ccd086efbdc65a9ed17f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "70b5ce556f315726a0feba47f5991e2c253388a402b4ccd086efbdc65a9ed17f", kill_on_drop: false }` [INFO] [stdout] 70b5ce556f315726a0feba47f5991e2c253388a402b4ccd086efbdc65a9ed17f