[INFO] cloning repository https://github.com/KeenS/pattern-match-compile [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/KeenS/pattern-match-compile" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FKeenS%2Fpattern-match-compile", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FKeenS%2Fpattern-match-compile'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] fca6481b02c31c2507bda25e10949482e4384a2f [INFO] checking KeenS/pattern-match-compile/fca6481b02c31c2507bda25e10949482e4384a2f against try#7014e13d5becc920d4bea3cd87942c8a13d359bf+rustflags=-Dtail_expr_drop_order for pr-129864 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FKeenS%2Fpattern-match-compile" "/workspace/builds/worker-5-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/KeenS/pattern-match-compile on toolchain 7014e13d5becc920d4bea3cd87942c8a13d359bf [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/KeenS/pattern-match-compile [INFO] finished tweaking git repo https://github.com/KeenS/pattern-match-compile [INFO] tweaked toml for git repo https://github.com/KeenS/pattern-match-compile written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/KeenS/pattern-match-compile already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 4dde2cc4b1ebea0cd2e58243614cf14ffd8f17450a149fdead4fa076a2e3efa9 [INFO] running `Command { std: "docker" "start" "-a" "4dde2cc4b1ebea0cd2e58243614cf14ffd8f17450a149fdead4fa076a2e3efa9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "4dde2cc4b1ebea0cd2e58243614cf14ffd8f17450a149fdead4fa076a2e3efa9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4dde2cc4b1ebea0cd2e58243614cf14ffd8f17450a149fdead4fa076a2e3efa9", kill_on_drop: false }` [INFO] [stdout] 4dde2cc4b1ebea0cd2e58243614cf14ffd8f17450a149fdead4fa076a2e3efa9 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 8d3c52226bea63e4653c8147c22869b0b573b148abec5e0e270b165baed8b351 [INFO] running `Command { std: "docker" "start" "-a" "8d3c52226bea63e4653c8147c22869b0b573b148abec5e0e270b165baed8b351", kill_on_drop: false }` [INFO] [stderr] Checking pattern-match-compile v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] error: this value of type `(Vec, simple_case::Expr)` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:548:9 [INFO] [stdout] | [INFO] [stdout] 546 | mut clauses: Vec<(Stack, simple_case::Expr)>, [INFO] [stdout] | ----------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 547 | ) -> simple_case::Expr { [INFO] [stdout] 548 | clauses.remove(0).1 [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `(Vec, simple_case::Expr)` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:548:9 [INFO] [stdout] | [INFO] [stdout] 546 | mut clauses: Vec<(Stack, simple_case::Expr)>, [INFO] [stdout] | ----------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 547 | ) -> simple_case::Expr { [INFO] [stdout] 548 | clauses.remove(0).1 [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `m` [INFO] [stdout] --> src/main.rs:1436:9 [INFO] [stdout] | [INFO] [stdout] 1436 | let m = { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_m` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `m3` [INFO] [stdout] --> src/main.rs:1578:9 [INFO] [stdout] | [INFO] [stdout] 1578 | let m3 = { [INFO] [stdout] | ^^ help: if this is intentional, prefix it with an underscore: `_m3` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `consv` is never used [INFO] [stdout] --> src/main.rs:1589:12 [INFO] [stdout] | [INFO] [stdout] 1589 | fn consv(arg: Expr) -> Expr { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `Symbol` is never constructed [INFO] [stdout] --> src/main.rs:63:9 [INFO] [stdout] | [INFO] [stdout] 48 | pub enum Expr { [INFO] [stdout] | ---- variant in this enum [INFO] [stdout] ... [INFO] [stdout] 63 | Symbol(Symbol), [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Expr` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over an `Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/pp.rs:57:30 [INFO] [stdout] | [INFO] [stdout] 57 | for d in data.as_ref().map(|d| &**d) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(for_loops_over_fallibles)]` on by default [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 57 | while let Some(d) = data.as_ref().map(|d| &**d) { [INFO] [stdout] | ~~~~~~~~~~~~~~~ ~~~ [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 57 | if let Some(d) = data.as_ref().map(|d| &**d) { [INFO] [stdout] | ~~~~~~~~~~~~ ~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over an `Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/pp.rs:100:30 [INFO] [stdout] | [INFO] [stdout] 100 | for d in value.as_ref().map(|d| &**d) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 100 | while let Some(d) = value.as_ref().map(|d| &**d) { [INFO] [stdout] | ~~~~~~~~~~~~~~~ ~~~ [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 100 | if let Some(d) = value.as_ref().map(|d| &**d) { [INFO] [stdout] | ~~~~~~~~~~~~ ~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over an `Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/pp.rs:127:30 [INFO] [stdout] | [INFO] [stdout] 127 | for p in pattern.as_ref().map(|p| &**p) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 127 | while let Some(p) = pattern.as_ref().map(|p| &**p) { [INFO] [stdout] | ~~~~~~~~~~~~~~~ ~~~ [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 127 | if let Some(p) = pattern.as_ref().map(|p| &**p) { [INFO] [stdout] | ~~~~~~~~~~~~ ~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over an `Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/pp.rs:165:30 [INFO] [stdout] | [INFO] [stdout] 165 | for d in data.as_ref().map(|d| &**d) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 165 | while let Some(d) = data.as_ref().map(|d| &**d) { [INFO] [stdout] | ~~~~~~~~~~~~~~~ ~~~ [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 165 | if let Some(d) = data.as_ref().map(|d| &**d) { [INFO] [stdout] | ~~~~~~~~~~~~ ~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `&Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/pp.rs:219:30 [INFO] [stdout] | [INFO] [stdout] 219 | for s in data { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 219 | while let Some(s) = data { [INFO] [stdout] | ~~~~~~~~~~~~~~~ ~~~ [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 219 | if let Some(s) = data { [INFO] [stdout] | ~~~~~~~~~~~~ ~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 9 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `m` [INFO] [stdout] --> src/main.rs:1436:9 [INFO] [stdout] | [INFO] [stdout] 1436 | let m = { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_m` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `m3` [INFO] [stdout] --> src/main.rs:1578:9 [INFO] [stdout] | [INFO] [stdout] 1578 | let m3 = { [INFO] [stdout] | ^^ help: if this is intentional, prefix it with an underscore: `_m3` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `Symbol` is never constructed [INFO] [stdout] --> src/main.rs:63:9 [INFO] [stdout] | [INFO] [stdout] 48 | pub enum Expr { [INFO] [stdout] | ---- variant in this enum [INFO] [stdout] ... [INFO] [stdout] 63 | Symbol(Symbol), [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Expr` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over an `Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/pp.rs:57:30 [INFO] [stdout] | [INFO] [stdout] 57 | for d in data.as_ref().map(|d| &**d) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(for_loops_over_fallibles)]` on by default [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 57 | while let Some(d) = data.as_ref().map(|d| &**d) { [INFO] [stdout] | ~~~~~~~~~~~~~~~ ~~~ [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 57 | if let Some(d) = data.as_ref().map(|d| &**d) { [INFO] [stdout] | ~~~~~~~~~~~~ ~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `pattern-match-compile` (bin "pattern-match-compile") due to 2 previous errors; 9 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: for loop over an `Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/pp.rs:100:30 [INFO] [stdout] | [INFO] [stdout] 100 | for d in value.as_ref().map(|d| &**d) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 100 | while let Some(d) = value.as_ref().map(|d| &**d) { [INFO] [stdout] | ~~~~~~~~~~~~~~~ ~~~ [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 100 | if let Some(d) = value.as_ref().map(|d| &**d) { [INFO] [stdout] | ~~~~~~~~~~~~ ~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over an `Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/pp.rs:127:30 [INFO] [stdout] | [INFO] [stdout] 127 | for p in pattern.as_ref().map(|p| &**p) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 127 | while let Some(p) = pattern.as_ref().map(|p| &**p) { [INFO] [stdout] | ~~~~~~~~~~~~~~~ ~~~ [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 127 | if let Some(p) = pattern.as_ref().map(|p| &**p) { [INFO] [stdout] | ~~~~~~~~~~~~ ~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over an `Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/pp.rs:165:30 [INFO] [stdout] | [INFO] [stdout] 165 | for d in data.as_ref().map(|d| &**d) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 165 | while let Some(d) = data.as_ref().map(|d| &**d) { [INFO] [stdout] | ~~~~~~~~~~~~~~~ ~~~ [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 165 | if let Some(d) = data.as_ref().map(|d| &**d) { [INFO] [stdout] | ~~~~~~~~~~~~ ~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `&Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/pp.rs:219:30 [INFO] [stdout] | [INFO] [stdout] 219 | for s in data { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 219 | while let Some(s) = data { [INFO] [stdout] | ~~~~~~~~~~~~~~~ ~~~ [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 219 | if let Some(s) = data { [INFO] [stdout] | ~~~~~~~~~~~~ ~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 8 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `pattern-match-compile` (bin "pattern-match-compile" test) due to 2 previous errors; 8 warnings emitted [INFO] running `Command { std: "docker" "inspect" "8d3c52226bea63e4653c8147c22869b0b573b148abec5e0e270b165baed8b351", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8d3c52226bea63e4653c8147c22869b0b573b148abec5e0e270b165baed8b351", kill_on_drop: false }` [INFO] [stdout] 8d3c52226bea63e4653c8147c22869b0b573b148abec5e0e270b165baed8b351