[INFO] cloning repository https://github.com/JamesWP/compiler [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/JamesWP/compiler" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FJamesWP%2Fcompiler", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FJamesWP%2Fcompiler'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 2c7f4892aba75baead227b30e6c5bb9d5d1b006a [INFO] checking JamesWP/compiler/2c7f4892aba75baead227b30e6c5bb9d5d1b006a against try#7014e13d5becc920d4bea3cd87942c8a13d359bf+rustflags=-Dtail_expr_drop_order for pr-129864 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FJamesWP%2Fcompiler" "/workspace/builds/worker-2-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-2-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/JamesWP/compiler on toolchain 7014e13d5becc920d4bea3cd87942c8a13d359bf [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/JamesWP/compiler [INFO] finished tweaking git repo https://github.com/JamesWP/compiler [INFO] tweaked toml for git repo https://github.com/JamesWP/compiler written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/JamesWP/compiler already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 5e4f20a2f4d98c743dc7aa1c34638c032608508ddb10134abccd98f577249e38 [INFO] running `Command { std: "docker" "start" "-a" "5e4f20a2f4d98c743dc7aa1c34638c032608508ddb10134abccd98f577249e38", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "5e4f20a2f4d98c743dc7aa1c34638c032608508ddb10134abccd98f577249e38", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5e4f20a2f4d98c743dc7aa1c34638c032608508ddb10134abccd98f577249e38", kill_on_drop: false }` [INFO] [stdout] 5e4f20a2f4d98c743dc7aa1c34638c032608508ddb10134abccd98f577249e38 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 32c490a0e64c1cbd15e6ad2f16a8bdf7c6158920e3676059cba060996348f80c [INFO] running `Command { std: "docker" "start" "-a" "32c490a0e64c1cbd15e6ad2f16a8bdf7c6158920e3676059cba060996348f80c", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.103 [INFO] [stderr] Compiling memchr v2.4.1 [INFO] [stderr] Checking either v1.6.1 [INFO] [stderr] Checking itertools v0.10.3 [INFO] [stderr] Checking flate2 v1.0.22 [INFO] [stderr] Checking object v0.26.2 [INFO] [stderr] Checking compiler v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] error: this value of type `Expression` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ast.rs:645:62 [INFO] [stdout] | [INFO] [stdout] 643 | pub fn new_call(lhs: Box, arguments: Vec) -> Expression { [INFO] [stdout] | --- --------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 644 | // TODO: get return type from lhs expression [INFO] [stdout] 645 | if let TypeDefinition::FUNCTION(return_type, _, _) = lhs.as_ref().clone().expr_type { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Expression` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ast.rs:645:62 [INFO] [stdout] | [INFO] [stdout] 643 | pub fn new_call(lhs: Box, arguments: Vec) -> Expression { [INFO] [stdout] | --- --------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 644 | // TODO: get return type from lhs expression [INFO] [stdout] 645 | if let TypeDefinition::FUNCTION(return_type, _, _) = lhs.as_ref().clone().expr_type { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `source` is never read [INFO] [stdout] --> src/ast.rs:14:9 [INFO] [stdout] | [INFO] [stdout] 6 | pub struct Token { [INFO] [stdout] | ----- field in this struct [INFO] [stdout] ... [INFO] [stdout] 14 | pub source: Option, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Token` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `is_memory` and `reg` are never used [INFO] [stdout] --> src/platform.rs:124:8 [INFO] [stdout] | [INFO] [stdout] 123 | pub trait Operand: Display { [INFO] [stdout] | ------- methods in this trait [INFO] [stdout] 124 | fn is_memory(&self) -> bool; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] 125 | fn reg(&self) -> Option<&X86_64Reg>; [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/source.rs:30:57 [INFO] [stdout] | [INFO] [stdout] 30 | let mut open_file = std::fs::File::open(filename.clone()).map_err(|err| SourceError { [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `compiler` (bin "compiler") due to 2 previous errors; 3 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: field `source` is never read [INFO] [stdout] --> src/ast.rs:14:9 [INFO] [stdout] | [INFO] [stdout] 6 | pub struct Token { [INFO] [stdout] | ----- field in this struct [INFO] [stdout] ... [INFO] [stdout] 14 | pub source: Option, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Token` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `is_memory` and `reg` are never used [INFO] [stdout] --> src/platform.rs:124:8 [INFO] [stdout] | [INFO] [stdout] 123 | pub trait Operand: Display { [INFO] [stdout] | ------- methods in this trait [INFO] [stdout] 124 | fn is_memory(&self) -> bool; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] 125 | fn reg(&self) -> Option<&X86_64Reg>; [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/source.rs:30:57 [INFO] [stdout] | [INFO] [stdout] 30 | let mut open_file = std::fs::File::open(filename.clone()).map_err(|err| SourceError { [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `compiler` (bin "compiler" test) due to 2 previous errors; 3 warnings emitted [INFO] running `Command { std: "docker" "inspect" "32c490a0e64c1cbd15e6ad2f16a8bdf7c6158920e3676059cba060996348f80c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "32c490a0e64c1cbd15e6ad2f16a8bdf7c6158920e3676059cba060996348f80c", kill_on_drop: false }` [INFO] [stdout] 32c490a0e64c1cbd15e6ad2f16a8bdf7c6158920e3676059cba060996348f80c