[INFO] cloning repository https://github.com/JamesHinshelwood/dpl [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/JamesHinshelwood/dpl" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FJamesHinshelwood%2Fdpl", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FJamesHinshelwood%2Fdpl'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] b647ebfdd7b970ded7bb8c3e8fd8a8e3654ca2e5 [INFO] checking JamesHinshelwood/dpl/b647ebfdd7b970ded7bb8c3e8fd8a8e3654ca2e5 against try#7014e13d5becc920d4bea3cd87942c8a13d359bf+rustflags=-Dtail_expr_drop_order for pr-129864 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FJamesHinshelwood%2Fdpl" "/workspace/builds/worker-3-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-3-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/JamesHinshelwood/dpl on toolchain 7014e13d5becc920d4bea3cd87942c8a13d359bf [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/JamesHinshelwood/dpl [INFO] finished tweaking git repo https://github.com/JamesHinshelwood/dpl [INFO] tweaked toml for git repo https://github.com/JamesHinshelwood/dpl written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/JamesHinshelwood/dpl already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] a227aa17cb53f44c969d11fbdba6fa7c2b10b8ad72e063ee6385c84a866de6e5 [INFO] running `Command { std: "docker" "start" "-a" "a227aa17cb53f44c969d11fbdba6fa7c2b10b8ad72e063ee6385c84a866de6e5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "a227aa17cb53f44c969d11fbdba6fa7c2b10b8ad72e063ee6385c84a866de6e5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a227aa17cb53f44c969d11fbdba6fa7c2b10b8ad72e063ee6385c84a866de6e5", kill_on_drop: false }` [INFO] [stdout] a227aa17cb53f44c969d11fbdba6fa7c2b10b8ad72e063ee6385c84a866de6e5 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] b0853a541d86d047ea102274e1b73399424fcfb9b7bed3b47d5d4e6efba66a50 [INFO] running `Command { std: "docker" "start" "-a" "b0853a541d86d047ea102274e1b73399424fcfb9b7bed3b47d5d4e6efba66a50", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v0.4.27 [INFO] [stderr] Compiling libc v0.2.51 [INFO] [stderr] Compiling autocfg v0.1.2 [INFO] [stderr] Compiling rand_core v0.4.0 [INFO] [stderr] Compiling syn v0.15.30 [INFO] [stderr] Compiling memchr v2.2.0 [INFO] [stderr] Compiling typenum v1.10.0 [INFO] [stderr] Compiling serde v1.0.89 [INFO] [stderr] Compiling lazy_static v1.3.0 [INFO] [stderr] Compiling byteorder v1.3.1 [INFO] [stderr] Compiling string_cache_shared v0.3.0 [INFO] [stderr] Compiling regex v1.1.5 [INFO] [stderr] Compiling byte-tools v0.3.1 [INFO] [stderr] Compiling ucd-util v0.1.3 [INFO] [stderr] Compiling cfg-if v0.1.7 [INFO] [stderr] Compiling utf8-ranges v1.0.2 [INFO] [stderr] Compiling block-padding v0.1.3 [INFO] [stderr] Compiling log v0.4.6 [INFO] [stderr] Compiling opaque-debug v0.2.2 [INFO] [stderr] Compiling thread_local v0.3.6 [INFO] [stderr] Compiling regex-syntax v0.6.6 [INFO] [stderr] Compiling term v0.4.6 [INFO] [stderr] Compiling ordermap v0.3.5 [INFO] [stderr] Compiling fixedbitset v0.1.9 [INFO] [stderr] Compiling rand_core v0.3.1 [INFO] [stderr] Compiling rand_jitter v0.1.3 [INFO] [stderr] Compiling precomputed-hash v0.1.1 [INFO] [stderr] Compiling rand_xorshift v0.1.1 [INFO] [stderr] Compiling rand_pcg v0.1.2 [INFO] [stderr] Compiling rand_chacha v0.1.1 [INFO] [stderr] Compiling rand v0.6.5 [INFO] [stderr] Compiling rand_isaac v0.1.1 [INFO] [stderr] Compiling rand_hc v0.1.0 [INFO] [stderr] Compiling rand_os v0.1.3 [INFO] [stderr] Compiling bit-vec v0.5.1 [INFO] [stderr] Compiling strsim v0.7.0 [INFO] [stderr] Compiling either v1.5.2 [INFO] [stderr] Compiling new_debug_unreachable v1.0.3 [INFO] [stderr] Compiling fake-simd v0.1.2 [INFO] [stderr] Compiling bit-set v0.5.1 [INFO] [stderr] Compiling petgraph v0.4.13 [INFO] [stderr] Compiling ascii-canvas v1.0.0 [INFO] [stderr] Compiling aho-corasick v0.7.3 [INFO] [stderr] Compiling atty v0.2.11 [INFO] [stderr] Compiling ena v0.11.0 [INFO] [stderr] Compiling quote v0.6.11 [INFO] [stderr] Compiling itertools v0.8.0 [INFO] [stderr] Compiling diff v0.1.11 [INFO] [stderr] Compiling lalrpop-util v0.16.3 [INFO] [stderr] Compiling generic-array v0.12.0 [INFO] [stderr] Compiling unicode-segmentation v1.2.1 [INFO] [stderr] Checking unicode-width v0.1.5 [INFO] [stderr] Checking ansi_term v0.11.0 [INFO] [stderr] Checking vec_map v0.8.1 [INFO] [stderr] Checking bitflags v1.0.4 [INFO] [stderr] Checking textwrap v0.10.0 [INFO] [stderr] Compiling heck v0.3.1 [INFO] [stderr] Compiling digest v0.8.0 [INFO] [stderr] Compiling block-buffer v0.7.0 [INFO] [stderr] Compiling phf_generator v0.7.24 [INFO] [stderr] Compiling sha2 v0.8.0 [INFO] [stderr] Compiling string_cache_codegen v0.4.2 [INFO] [stderr] Checking clap v2.32.0 [INFO] [stderr] Compiling string_cache v0.7.3 [INFO] [stderr] Compiling synstructure v0.10.1 [INFO] [stderr] Compiling serde_derive v1.0.89 [INFO] [stderr] Compiling structopt-derive v0.2.15 [INFO] [stderr] Compiling moniker-derive v0.5.0 [INFO] [stderr] Checking structopt v0.2.15 [INFO] [stderr] Checking moniker v0.5.0 [INFO] [stderr] Compiling docopt v1.0.2 [INFO] [stderr] Compiling lalrpop v0.16.3 [INFO] [stderr] Compiling dpl v0.1.0 (/opt/rustwide/workdir/dpl) [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> /opt/rustwide/target/debug/build/dpl-7cc5369a036b4840/out/grammar.rs:2891:5 [INFO] [stdout] | [INFO] [stdout] 2891 | (__0) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 2891 - (__0) [INFO] [stdout] 2891 + __0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> /opt/rustwide/target/debug/build/dpl-7cc5369a036b4840/out/grammar.rs:3405:5 [INFO] [stdout] | [INFO] [stdout] 3405 | (__0) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 3405 - (__0) [INFO] [stdout] 3405 + __0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> /opt/rustwide/target/debug/build/dpl-7cc5369a036b4840/out/grammar.rs:3463:5 [INFO] [stdout] | [INFO] [stdout] 3463 | (__0) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 3463 - (__0) [INFO] [stdout] 3463 + __0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> /opt/rustwide/target/debug/build/dpl-7cc5369a036b4840/out/grammar.rs:2891:5 [INFO] [stdout] | [INFO] [stdout] 2891 | (__0) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 2891 - (__0) [INFO] [stdout] 2891 + __0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> /opt/rustwide/target/debug/build/dpl-7cc5369a036b4840/out/grammar.rs:3405:5 [INFO] [stdout] | [INFO] [stdout] 3405 | (__0) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 3405 - (__0) [INFO] [stdout] 3405 + __0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> /opt/rustwide/target/debug/build/dpl-7cc5369a036b4840/out/grammar.rs:3463:5 [INFO] [stdout] | [INFO] [stdout] 3463 | (__0) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 3463 - (__0) [INFO] [stdout] 3463 + __0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Box` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> dpl/src/check.rs:174:49 [INFO] [stdout] | [INFO] [stdout] 147 | let ty = &ty.nf(ctx); [INFO] [stdout] | ---------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 174 | let (((Binder(x), Binder(y)), Embed(p)), rest) = let_scope.clone().unbind(); [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Box` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> dpl/src/check.rs:174:49 [INFO] [stdout] | [INFO] [stdout] 147 | let ty = &ty.nf(ctx); [INFO] [stdout] | ---------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 174 | let (((Binder(x), Binder(y)), Embed(p)), rest) = let_scope.clone().unbind(); [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `to_triple` is never used [INFO] [stdout] --> /opt/rustwide/target/debug/build/dpl-7cc5369a036b4840/out/grammar.rs:3881:8 [INFO] [stdout] | [INFO] [stdout] 3880 | pub trait __ToTriple<'input, > { [INFO] [stdout] | ---------- associated function in this trait [INFO] [stdout] 3881 | fn to_triple(value: Self) -> Result<(usize,Token<'input>,usize), __lalrpop_util::ParseError, &'static str>>; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `to_triple` is never used [INFO] [stdout] --> /opt/rustwide/target/debug/build/dpl-7cc5369a036b4840/out/grammar.rs:3881:8 [INFO] [stdout] | [INFO] [stdout] 3880 | pub trait __ToTriple<'input, > { [INFO] [stdout] | ---------- associated function in this trait [INFO] [stdout] 3881 | fn to_triple(value: Self) -> Result<(usize,Token<'input>,usize), __lalrpop_util::ParseError, &'static str>>; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> dpl/src/ast.rs:7:24 [INFO] [stdout] | [INFO] [stdout] 7 | #[derive(Clone, Debug, BoundTerm)] [INFO] [stdout] | ^-------- [INFO] [stdout] | | [INFO] [stdout] | `BoundTerm` is not local [INFO] [stdout] | `String` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_DERIVE_moniker_BoundTerm_String_FOR_Term` [INFO] [stdout] 8 | pub enum Term { [INFO] [stdout] | ---- `Term` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `BoundTerm` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `BoundTerm` may come from an old version of the `moniker_derive` crate, try updating your dependency with `cargo update -p moniker_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue [INFO] [stdout] = note: `#[warn(non_local_definitions)]` on by default [INFO] [stdout] = note: this warning originates in the derive macro `BoundTerm` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> dpl/src/ast.rs:7:24 [INFO] [stdout] | [INFO] [stdout] 7 | #[derive(Clone, Debug, BoundTerm)] [INFO] [stdout] | ^-------- [INFO] [stdout] | | [INFO] [stdout] | `BoundTerm` is not local [INFO] [stdout] | `String` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_DERIVE_moniker_BoundTerm_String_FOR_Term` [INFO] [stdout] 8 | pub enum Term { [INFO] [stdout] | ---- `Term` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `BoundTerm` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `BoundTerm` may come from an old version of the `moniker_derive` crate, try updating your dependency with `cargo update -p moniker_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue [INFO] [stdout] = note: `#[warn(non_local_definitions)]` on by default [INFO] [stdout] = note: this warning originates in the derive macro `BoundTerm` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 5 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 5 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `dpl` (lib) due to 2 previous errors; 5 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `dpl` (lib test) due to 2 previous errors; 5 warnings emitted [INFO] running `Command { std: "docker" "inspect" "b0853a541d86d047ea102274e1b73399424fcfb9b7bed3b47d5d4e6efba66a50", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b0853a541d86d047ea102274e1b73399424fcfb9b7bed3b47d5d4e6efba66a50", kill_on_drop: false }` [INFO] [stdout] b0853a541d86d047ea102274e1b73399424fcfb9b7bed3b47d5d4e6efba66a50