[INFO] cloning repository https://github.com/GoldenStack/secure-website [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/GoldenStack/secure-website" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FGoldenStack%2Fsecure-website", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FGoldenStack%2Fsecure-website'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] b29a797e49ea2b035f744a000771a446fd3cfe4a [INFO] checking GoldenStack/secure-website/b29a797e49ea2b035f744a000771a446fd3cfe4a against try#7014e13d5becc920d4bea3cd87942c8a13d359bf+rustflags=-Dtail_expr_drop_order for pr-129864 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FGoldenStack%2Fsecure-website" "/workspace/builds/worker-3-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-3-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/GoldenStack/secure-website on toolchain 7014e13d5becc920d4bea3cd87942c8a13d359bf [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/GoldenStack/secure-website [INFO] finished tweaking git repo https://github.com/GoldenStack/secure-website [INFO] tweaked toml for git repo https://github.com/GoldenStack/secure-website written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/GoldenStack/secure-website already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] a08d607d84fb26888f29cff2fc2bb73c26bb5906fd152101695b452cfeb1f77d [INFO] running `Command { std: "docker" "start" "-a" "a08d607d84fb26888f29cff2fc2bb73c26bb5906fd152101695b452cfeb1f77d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "a08d607d84fb26888f29cff2fc2bb73c26bb5906fd152101695b452cfeb1f77d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a08d607d84fb26888f29cff2fc2bb73c26bb5906fd152101695b452cfeb1f77d", kill_on_drop: false }` [INFO] [stdout] a08d607d84fb26888f29cff2fc2bb73c26bb5906fd152101695b452cfeb1f77d [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] ac4b5da0437f88cb6a7fa58d839a8e9dea3f8d7af65914d90ffe681d910dee16 [INFO] running `Command { std: "docker" "start" "-a" "ac4b5da0437f88cb6a7fa58d839a8e9dea3f8d7af65914d90ffe681d910dee16", kill_on_drop: false }` [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Compiling typenum v1.17.0 [INFO] [stderr] Compiling syn v2.0.70 [INFO] [stderr] Compiling unicase v2.7.0 [INFO] [stderr] Compiling generic-array v0.14.7 [INFO] [stderr] Checking futures-task v0.3.30 [INFO] [stderr] Checking http v1.1.0 [INFO] [stderr] Compiling serde v1.0.204 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking parking_lot_core v0.9.10 [INFO] [stderr] Compiling libm v0.2.8 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Checking subtle v2.6.1 [INFO] [stderr] Compiling mime_guess v2.0.5 [INFO] [stderr] Compiling vcpkg v0.2.15 [INFO] [stderr] Compiling minimal-lexical v0.2.1 [INFO] [stderr] Compiling httparse v1.9.4 [INFO] [stderr] Compiling memchr v2.7.4 [INFO] [stderr] Checking http-body v1.0.0 [INFO] [stderr] Compiling cc v1.0.106 [INFO] [stderr] Compiling pkg-config v0.3.30 [INFO] [stderr] Checking ahash v0.8.11 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Compiling axum-core v0.4.3 [INFO] [stderr] Compiling nom v7.1.3 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking tower-layer v0.3.2 [INFO] [stderr] Compiling proc-macro-hack v0.5.20+deprecated [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling mime v0.3.17 [INFO] [stderr] Checking tower-service v0.3.2 [INFO] [stderr] Checking ppv-lite86 v0.2.17 [INFO] [stderr] Checking block-buffer v0.10.4 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Compiling libsqlite3-sys v0.28.0 [INFO] [stderr] Checking http-body-util v0.1.2 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Compiling serde_json v1.0.120 [INFO] [stderr] Checking sync_wrapper v0.1.2 [INFO] [stderr] Checking httpdate v1.0.3 [INFO] [stderr] Checking humansize v2.1.3 [INFO] [stderr] Checking hashlink v0.9.1 [INFO] [stderr] Compiling askama_parser v0.2.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking scheduled-thread-pool v0.2.7 [INFO] [stderr] Compiling axum v0.7.5 [INFO] [stderr] Checking cpufeatures v0.2.12 [INFO] [stderr] Checking fallible-streaming-iterator v0.1.9 [INFO] [stderr] Compiling dotenv v0.15.0 [INFO] [stderr] Checking fallible-iterator v0.3.0 [INFO] [stderr] Compiling thiserror v1.0.61 [INFO] [stderr] Compiling anyhow v1.0.86 [INFO] [stderr] Checking base64ct v1.6.0 [INFO] [stderr] Checking askama_escape v0.10.3 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking serde_path_to_error v0.1.16 [INFO] [stderr] Checking password-hash v0.5.0 [INFO] [stderr] Checking uuid v1.10.0 [INFO] [stderr] Checking r2d2 v0.8.10 [INFO] [stderr] Checking blake2 v0.10.6 [INFO] [stderr] Checking sync_wrapper v1.0.1 [INFO] [stderr] Checking matchit v0.7.3 [INFO] [stderr] Checking argon2 v0.5.3 [INFO] [stderr] Checking sha2 v0.10.8 [INFO] [stderr] Compiling serde_derive v1.0.204 [INFO] [stderr] Compiling tokio-macros v2.3.0 [INFO] [stderr] Compiling async-trait v0.1.81 [INFO] [stderr] Compiling pin-project-internal v1.1.5 [INFO] [stderr] Compiling dotenv_codegen_implementation v0.15.0 [INFO] [stderr] Compiling thiserror-impl v1.0.61 [INFO] [stderr] Checking dotenv_codegen v0.15.0 [INFO] [stderr] Checking tokio v1.38.0 [INFO] [stderr] Checking pin-project v1.1.5 [INFO] [stderr] Checking hyper v1.4.0 [INFO] [stderr] Checking tower v0.4.13 [INFO] [stderr] Compiling basic-toml v0.1.9 [INFO] [stderr] Checking hyper-util v0.1.6 [INFO] [stderr] Compiling askama_derive v0.12.5 [INFO] [stderr] Checking rusqlite v0.31.0 [INFO] [stderr] Checking r2d2_sqlite v0.24.0 [INFO] [stderr] Checking askama v0.12.1 [INFO] [stderr] Checking askama_axum v0.4.0 [INFO] [stderr] Checking secure-website v4915.229.188224 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `askama_axum::Response` [INFO] [stdout] --> src/main.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 6 | use askama_axum::Response; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `db_verified` [INFO] [stdout] --> src/main.rs:11:31 [INFO] [stdout] | [INFO] [stdout] 11 | use database::{db_initialize, db_verified}; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `askama_axum::Response` [INFO] [stdout] --> src/main.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 6 | use askama_axum::Response; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `db_verified` [INFO] [stdout] --> src/main.rs:11:31 [INFO] [stdout] | [INFO] [stdout] 11 | use database::{db_initialize, db_verified}; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Option>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/database.rs:66:37 [INFO] [stdout] | [INFO] [stdout] 53 | let mut get = db.prepare("SELECT id, username, password, salt, boxes, verified FROM users WHERE username = ?1")?; [INFO] [stdout] | ------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 54 | [INFO] [stdout] 55 | let mut users = get.query_map([username], |row| { [INFO] [stdout] | --------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 66 | return Ok(if let Some(result) = users.next() { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Option>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/database.rs:66:37 [INFO] [stdout] | [INFO] [stdout] 53 | let mut get = db.prepare("SELECT id, username, password, salt, boxes, verified FROM users WHERE username = ?1")?; [INFO] [stdout] | ------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 54 | [INFO] [stdout] 55 | let mut users = get.query_map([username], |row| { [INFO] [stdout] | --------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 66 | return Ok(if let Some(result) = users.next() { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/response.rs:153:11 [INFO] [stdout] | [INFO] [stdout] 152 | pub fn wrapped_db_auth T, T: IntoResponse>(db: &DB, username: &str, password: &str, f: F) -> Response { [INFO] [stdout] | - these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 153 | match db_authenticate(db, username, password) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result, anyhow::Error>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/response.rs:161:11 [INFO] [stdout] | [INFO] [stdout] 160 | pub fn wrapped_db_retrieve T, T: IntoResponse>(db: &DB, username: &str,f: F) -> Response { [INFO] [stdout] | - these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 161 | match db_retrieve(db, username) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/response.rs:153:11 [INFO] [stdout] | [INFO] [stdout] 152 | pub fn wrapped_db_auth T, T: IntoResponse>(db: &DB, username: &str, password: &str, f: F) -> Response { [INFO] [stdout] | - these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 153 | match db_authenticate(db, username, password) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result, anyhow::Error>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/response.rs:161:11 [INFO] [stdout] | [INFO] [stdout] 160 | pub fn wrapped_db_retrieve T, T: IntoResponse>(db: &DB, username: &str,f: F) -> Response { [INFO] [stdout] | - these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 161 | match db_retrieve(db, username) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `request` [INFO] [stdout] --> src/main.rs:66:46 [INFO] [stdout] | [INFO] [stdout] 66 | let handler = |Host(mut hostname): Host, request: Request| async move { [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_request` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `request` [INFO] [stdout] --> src/main.rs:66:46 [INFO] [stdout] | [INFO] [stdout] 66 | let handler = |Host(mut hostname): Host, request: Request| async move { [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_request` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `secure-website` (bin "secure-website") due to 4 previous errors; 3 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `secure-website` (bin "secure-website" test) due to 4 previous errors; 3 warnings emitted [INFO] running `Command { std: "docker" "inspect" "ac4b5da0437f88cb6a7fa58d839a8e9dea3f8d7af65914d90ffe681d910dee16", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ac4b5da0437f88cb6a7fa58d839a8e9dea3f8d7af65914d90ffe681d910dee16", kill_on_drop: false }` [INFO] [stdout] ac4b5da0437f88cb6a7fa58d839a8e9dea3f8d7af65914d90ffe681d910dee16