[INFO] cloning repository https://github.com/GeorgeSaussy/anvil_db [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/GeorgeSaussy/anvil_db" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FGeorgeSaussy%2Fanvil_db", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FGeorgeSaussy%2Fanvil_db'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 24cadd6f1c9d399137c03bf20e20a64bfa122ede [INFO] checking GeorgeSaussy/anvil_db/24cadd6f1c9d399137c03bf20e20a64bfa122ede against try#7014e13d5becc920d4bea3cd87942c8a13d359bf+rustflags=-Dtail_expr_drop_order for pr-129864 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FGeorgeSaussy%2Fanvil_db" "/workspace/builds/worker-0-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/GeorgeSaussy/anvil_db on toolchain 7014e13d5becc920d4bea3cd87942c8a13d359bf [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/GeorgeSaussy/anvil_db [INFO] finished tweaking git repo https://github.com/GeorgeSaussy/anvil_db [INFO] tweaked toml for git repo https://github.com/GeorgeSaussy/anvil_db written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] f3877adde59794187e97f02370bf885e65407bf3a725fda331bce615d265d95a [INFO] running `Command { std: "docker" "start" "-a" "f3877adde59794187e97f02370bf885e65407bf3a725fda331bce615d265d95a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "f3877adde59794187e97f02370bf885e65407bf3a725fda331bce615d265d95a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f3877adde59794187e97f02370bf885e65407bf3a725fda331bce615d265d95a", kill_on_drop: false }` [INFO] [stdout] f3877adde59794187e97f02370bf885e65407bf3a725fda331bce615d265d95a [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 10f4a5de23cfd8389d77b6cbce9ffcfc52ce9ea3bcd52df38cd1ee7e8d08b05d [INFO] running `Command { std: "docker" "start" "-a" "10f4a5de23cfd8389d77b6cbce9ffcfc52ce9ea3bcd52df38cd1ee7e8d08b05d", kill_on_drop: false }` [INFO] [stderr] Checking anvil_db v0.2.1 (/opt/rustwide/workdir) [INFO] [stdout] error: this value of type `Result<(), std::io::Error>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage/blob_store.rs:425:15 [INFO] [stdout] | [INFO] [stdout] 424 | fn finalize(self) -> Result<(), BlobStoreError> { [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 425 | match self.file.sync_all() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result<(), BlobStoreError>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/wal/wal_writer.rs:140:15 [INFO] [stdout] | [INFO] [stdout] 138 | fn close(mut self) -> Result<(), WalError> { [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 139 | let result = self.flush(); [INFO] [stdout] 140 | match self.blob_writer.finalize() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait `KeyValuePointReader` is never used [INFO] [stdout] --> src/kv.rs:10:18 [INFO] [stdout] | [INFO] [stdout] 10 | pub(crate) trait KeyValuePointReader { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait `AsyncTombstoneIterator` is never used [INFO] [stdout] --> src/kv.rs:201:18 [INFO] [stdout] | [INFO] [stdout] 201 | pub(crate) trait AsyncTombstoneIterator: [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait `TryAsyncTombstoneScanner` is never used [INFO] [stdout] --> src/kv.rs:223:18 [INFO] [stdout] | [INFO] [stdout] 223 | pub(crate) trait TryAsyncTombstoneScanner { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `read_exact` is never used [INFO] [stdout] --> src/sst/block_cache/cache.rs:19:8 [INFO] [stdout] | [INFO] [stdout] 15 | pub(crate) trait BlockCache: Clone { [INFO] [stdout] | ---------- method in this trait [INFO] [stdout] ... [INFO] [stdout] 19 | fn read_exact( [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `BlockTooSmall` is never constructed [INFO] [stdout] --> src/sst/block_cache/common.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 7 | pub(crate) enum CacheError { [INFO] [stdout] | ---------- variant in this enum [INFO] [stdout] 8 | Read(String), [INFO] [stdout] 9 | BlockTooSmall, [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `CacheError` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `get_sst_reader` is never used [INFO] [stdout] --> src/tablet.rs:117:8 [INFO] [stdout] | [INFO] [stdout] 102 | pub(crate) trait TabletSstStore: Clone + TombstonePointReader + TryTombstoneScanner { [INFO] [stdout] | -------------- method in this trait [INFO] [stdout] ... [INFO] [stdout] 117 | fn get_sst_reader(&self, blob_id: &str) -> Option; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 6 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `anvil_db` (lib) due to 3 previous errors; 6 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: this value of type `std::pin::Pin, DefaultLogger>> as kv::TombstoneStore>::E>>>>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mem_table.rs:679:17 [INFO] [stdout] | [INFO] [stdout] 649 | let ctx = SimpleContext::from(( [INFO] [stdout] | --- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 659 | let mc = unwrap!(result.ok()); [INFO] [stdout] | -- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 679 | let mut poller = Box::pin(mc.async_set(buf_1, &value)); [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result<(), std::io::Error>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage/blob_store.rs:425:15 [INFO] [stdout] | [INFO] [stdout] 424 | fn finalize(self) -> Result<(), BlobStoreError> { [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 425 | match self.file.sync_all() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Enumerate, DefaultLogger>>>, kv::MergedHomogenousIter, DefaultLogger>>>>>>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tablet.rs:765:34 [INFO] [stdout] | [INFO] [stdout] 747 | let (compactor_tx, _compactor_rx) = channel(); [INFO] [stdout] | ------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 748 | let (ctx, sst_store) = new_test_sst_store(Some(compactor_tx)); [INFO] [stdout] | --- --------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 765 | for (idx, result) in iter.enumerate() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `sst::common::SstError` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tablet.rs:832:33 [INFO] [stdout] | [INFO] [stdout] 830 | .map(|result| match result { [INFO] [stdout] | ------ [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 831 | Ok(ok) => ok, [INFO] [stdout] 832 | Err(err) => { [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result<(), BlobStoreError>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/wal/wal_writer.rs:140:15 [INFO] [stdout] | [INFO] [stdout] 138 | fn close(mut self) -> Result<(), WalError> { [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 139 | let result = self.flush(); [INFO] [stdout] 140 | match self.blob_writer.finalize() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait `KeyValuePointReader` is never used [INFO] [stdout] --> src/kv.rs:10:18 [INFO] [stdout] | [INFO] [stdout] 10 | pub(crate) trait KeyValuePointReader { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait `AsyncTombstoneIterator` is never used [INFO] [stdout] --> src/kv.rs:201:18 [INFO] [stdout] | [INFO] [stdout] 201 | pub(crate) trait AsyncTombstoneIterator: [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait `TryAsyncTombstoneScanner` is never used [INFO] [stdout] --> src/kv.rs:223:18 [INFO] [stdout] | [INFO] [stdout] 223 | pub(crate) trait TryAsyncTombstoneScanner { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `read_exact` is never used [INFO] [stdout] --> src/sst/block_cache/cache.rs:19:8 [INFO] [stdout] | [INFO] [stdout] 15 | pub(crate) trait BlockCache: Clone { [INFO] [stdout] | ---------- method in this trait [INFO] [stdout] ... [INFO] [stdout] 19 | fn read_exact( [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `BlockTooSmall` is never constructed [INFO] [stdout] --> src/sst/block_cache/common.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 7 | pub(crate) enum CacheError { [INFO] [stdout] | ---------- variant in this enum [INFO] [stdout] 8 | Read(String), [INFO] [stdout] 9 | BlockTooSmall, [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `CacheError` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `get_sst_reader` is never used [INFO] [stdout] --> src/tablet.rs:117:8 [INFO] [stdout] | [INFO] [stdout] 102 | pub(crate) trait TabletSstStore: Clone + TombstonePointReader + TryTombstoneScanner { [INFO] [stdout] | -------------- method in this trait [INFO] [stdout] ... [INFO] [stdout] 117 | fn get_sst_reader(&self, blob_id: &str) -> Option; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors; 6 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `anvil_db` (lib test) due to 6 previous errors; 6 warnings emitted [INFO] running `Command { std: "docker" "inspect" "10f4a5de23cfd8389d77b6cbce9ffcfc52ce9ea3bcd52df38cd1ee7e8d08b05d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "10f4a5de23cfd8389d77b6cbce9ffcfc52ce9ea3bcd52df38cd1ee7e8d08b05d", kill_on_drop: false }` [INFO] [stdout] 10f4a5de23cfd8389d77b6cbce9ffcfc52ce9ea3bcd52df38cd1ee7e8d08b05d