[INFO] cloning repository https://github.com/FungusHumungus/smteepee-rs [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/FungusHumungus/smteepee-rs" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FFungusHumungus%2Fsmteepee-rs", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FFungusHumungus%2Fsmteepee-rs'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 85baf8bc23dcd6de8bb9282675d205322f10e965 [INFO] checking FungusHumungus/smteepee-rs/85baf8bc23dcd6de8bb9282675d205322f10e965 against try#7014e13d5becc920d4bea3cd87942c8a13d359bf+rustflags=-Dtail_expr_drop_order for pr-129864 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FFungusHumungus%2Fsmteepee-rs" "/workspace/builds/worker-4-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-4-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/FungusHumungus/smteepee-rs on toolchain 7014e13d5becc920d4bea3cd87942c8a13d359bf [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/FungusHumungus/smteepee-rs [INFO] finished tweaking git repo https://github.com/FungusHumungus/smteepee-rs [INFO] tweaked toml for git repo https://github.com/FungusHumungus/smteepee-rs written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/FungusHumungus/smteepee-rs already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] fbecc85a09ee643e37e597ad3afa71bd0d930878e9714ae287b4e3ae8570e978 [INFO] running `Command { std: "docker" "start" "-a" "fbecc85a09ee643e37e597ad3afa71bd0d930878e9714ae287b4e3ae8570e978", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "fbecc85a09ee643e37e597ad3afa71bd0d930878e9714ae287b4e3ae8570e978", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "fbecc85a09ee643e37e597ad3afa71bd0d930878e9714ae287b4e3ae8570e978", kill_on_drop: false }` [INFO] [stdout] fbecc85a09ee643e37e597ad3afa71bd0d930878e9714ae287b4e3ae8570e978 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 8503d140e52e89294ab07e39a5489999e7e69d30ce40476c597affd5bfa8f75b [INFO] running `Command { std: "docker" "start" "-a" "8503d140e52e89294ab07e39a5489999e7e69d30ce40476c597affd5bfa8f75b", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.19 [INFO] [stderr] Compiling syn v1.0.38 [INFO] [stderr] Compiling libc v0.2.74 [INFO] [stderr] Compiling memchr v2.2.1 [INFO] [stderr] Checking slab v0.4.2 [INFO] [stderr] Checking cfg-if v0.1.9 [INFO] [stderr] Checking futures-core v0.3.5 [INFO] [stderr] Compiling log v0.4.7 [INFO] [stderr] Compiling pin-project-internal v0.4.23 [INFO] [stderr] Compiling proc-macro2 v0.4.30 [INFO] [stderr] Checking futures-sink v0.3.5 [INFO] [stderr] Compiling proc-macro-nested v0.1.6 [INFO] [stderr] Checking lazy_static v1.3.0 [INFO] [stderr] Checking arc-swap v0.4.7 [INFO] [stderr] Compiling proc-macro-hack v0.5.18 [INFO] [stderr] Compiling unicode-xid v0.1.0 [INFO] [stderr] Checking once_cell v1.4.0 [INFO] [stderr] Checking futures-channel v0.3.5 [INFO] [stderr] Checking futures-task v0.3.5 [INFO] [stderr] Compiling byteorder v1.3.2 [INFO] [stderr] Checking bytes v0.5.6 [INFO] [stderr] Compiling serde v1.0.96 [INFO] [stderr] Compiling quote v1.0.7 [INFO] [stderr] Checking pin-project-lite v0.1.7 [INFO] [stderr] Checking iovec v0.1.4 [INFO] [stderr] Checking net2 v0.2.34 [INFO] [stderr] Checking signal-hook-registry v1.2.1 [INFO] [stderr] Checking num_cpus v1.13.0 [INFO] [stderr] Checking futures-io v0.3.5 [INFO] [stderr] Compiling syn v0.15.39 [INFO] [stderr] Compiling quote v0.6.13 [INFO] [stderr] Checking ucd-util v0.1.3 [INFO] [stderr] Compiling regex v1.1.9 [INFO] [stderr] Checking regex-syntax v0.6.8 [INFO] [stderr] Checking mio v0.6.22 [INFO] [stderr] Checking aho-corasick v0.7.4 [INFO] [stderr] Checking thread_local v0.3.6 [INFO] [stderr] Checking utf8-ranges v1.0.3 [INFO] [stderr] Checking base64 v0.10.1 [INFO] [stderr] Checking mio-uds v0.6.8 [INFO] [stderr] Compiling serde_derive v1.0.96 [INFO] [stderr] Checking toml v0.5.1 [INFO] [stderr] Compiling tokio-macros v0.2.5 [INFO] [stderr] Compiling futures-macro v0.3.5 [INFO] [stderr] Checking tokio v0.2.22 [INFO] [stderr] Checking pin-project v0.4.23 [INFO] [stderr] Checking futures-util v0.3.5 [INFO] [stderr] Checking futures-executor v0.3.5 [INFO] [stderr] Checking futures v0.3.5 [INFO] [stderr] Checking tokio-util v0.3.1 [INFO] [stderr] Checking tokio-test v0.2.1 [INFO] [stderr] Checking smteepee v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] error: this value of type `Result` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/settings.rs:36:15 [INFO] [stdout] | [INFO] [stdout] 32 | let mut file = File::open(filename)?; [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 36 | match de::from_str(&data) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `saved` is never read [INFO] [stdout] --> src/message.rs:10:9 [INFO] [stdout] | [INFO] [stdout] 6 | pub struct Message { [INFO] [stdout] | ------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 10 | pub saved: Option, [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Message` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/settings.rs:10:10 [INFO] [stdout] | [INFO] [stdout] 10 | #[derive(Deserialize, PartialEq, Eq)] [INFO] [stdout] | ^---------- [INFO] [stdout] | | [INFO] [stdout] | `Deserialize` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_IMPL_DESERIALIZE_FOR_Protocol` [INFO] [stdout] 11 | pub enum Protocol { [INFO] [stdout] | -------- `Protocol` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Deserialize` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Deserialize` may come from an old version of the `serde_derive` crate, try updating your dependency with `cargo update -p serde_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue [INFO] [stdout] = note: `#[warn(non_local_definitions)]` on by default [INFO] [stdout] = note: this warning originates in the derive macro `Deserialize` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/settings.rs:16:10 [INFO] [stdout] | [INFO] [stdout] 16 | #[derive(Deserialize, Clone)] [INFO] [stdout] | ^---------- [INFO] [stdout] | | [INFO] [stdout] | `Deserialize` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_IMPL_DESERIALIZE_FOR_Settings` [INFO] [stdout] 17 | pub struct Settings { [INFO] [stdout] | -------- `Settings` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Deserialize` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Deserialize` may come from an old version of the `serde_derive` crate, try updating your dependency with `cargo update -p serde_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue [INFO] [stdout] = note: this warning originates in the derive macro `Deserialize` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `smteepee` (bin "smteepee") due to 2 previous errors; 3 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: this value of type `Result` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/settings.rs:36:15 [INFO] [stdout] | [INFO] [stdout] 32 | let mut file = File::open(filename)?; [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 36 | match de::from_str(&data) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `saved` is never read [INFO] [stdout] --> src/message.rs:10:9 [INFO] [stdout] | [INFO] [stdout] 6 | pub struct Message { [INFO] [stdout] | ------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 10 | pub saved: Option, [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Message` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/settings.rs:10:10 [INFO] [stdout] | [INFO] [stdout] 10 | #[derive(Deserialize, PartialEq, Eq)] [INFO] [stdout] | ^---------- [INFO] [stdout] | | [INFO] [stdout] | `Deserialize` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_IMPL_DESERIALIZE_FOR_Protocol` [INFO] [stdout] 11 | pub enum Protocol { [INFO] [stdout] | -------- `Protocol` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Deserialize` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Deserialize` may come from an old version of the `serde_derive` crate, try updating your dependency with `cargo update -p serde_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue [INFO] [stdout] = note: `#[warn(non_local_definitions)]` on by default [INFO] [stdout] = note: this warning originates in the derive macro `Deserialize` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/settings.rs:16:10 [INFO] [stdout] | [INFO] [stdout] 16 | #[derive(Deserialize, Clone)] [INFO] [stdout] | ^---------- [INFO] [stdout] | | [INFO] [stdout] | `Deserialize` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_IMPL_DESERIALIZE_FOR_Settings` [INFO] [stdout] 17 | pub struct Settings { [INFO] [stdout] | -------- `Settings` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Deserialize` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Deserialize` may come from an old version of the `serde_derive` crate, try updating your dependency with `cargo update -p serde_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue [INFO] [stdout] = note: this warning originates in the derive macro `Deserialize` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `smteepee` (bin "smteepee" test) due to 2 previous errors; 3 warnings emitted [INFO] running `Command { std: "docker" "inspect" "8503d140e52e89294ab07e39a5489999e7e69d30ce40476c597affd5bfa8f75b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8503d140e52e89294ab07e39a5489999e7e69d30ce40476c597affd5bfa8f75b", kill_on_drop: false }` [INFO] [stdout] 8503d140e52e89294ab07e39a5489999e7e69d30ce40476c597affd5bfa8f75b