[INFO] cloning repository https://github.com/EmilHernvall/hermes [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/EmilHernvall/hermes" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FEmilHernvall%2Fhermes", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FEmilHernvall%2Fhermes'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 3697c61fd4a54ae17369523cf9d18c8bacc38762 [INFO] checking EmilHernvall/hermes/3697c61fd4a54ae17369523cf9d18c8bacc38762 against try#7014e13d5becc920d4bea3cd87942c8a13d359bf+rustflags=-Dtail_expr_drop_order for pr-129864 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FEmilHernvall%2Fhermes" "/workspace/builds/worker-5-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/EmilHernvall/hermes on toolchain 7014e13d5becc920d4bea3cd87942c8a13d359bf [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/EmilHernvall/hermes [INFO] finished tweaking git repo https://github.com/EmilHernvall/hermes [INFO] tweaked toml for git repo https://github.com/EmilHernvall/hermes written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/EmilHernvall/hermes already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] e329b55d9e8c6425d69939cbaf4e0a67aec873ae5e0655e0dd860c8152952ea3 [INFO] running `Command { std: "docker" "start" "-a" "e329b55d9e8c6425d69939cbaf4e0a67aec873ae5e0655e0dd860c8152952ea3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "e329b55d9e8c6425d69939cbaf4e0a67aec873ae5e0655e0dd860c8152952ea3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e329b55d9e8c6425d69939cbaf4e0a67aec873ae5e0655e0dd860c8152952ea3", kill_on_drop: false }` [INFO] [stdout] e329b55d9e8c6425d69939cbaf4e0a67aec873ae5e0655e0dd860c8152952ea3 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 8583ac3b4979f947a6fc52003c396fdcef7dd11e933cb7724a49b83c620f220e [INFO] running `Command { std: "docker" "start" "-a" "8583ac3b4979f947a6fc52003c396fdcef7dd11e933cb7724a49b83c620f220e", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.18 [INFO] [stderr] Compiling libc v0.2.71 [INFO] [stderr] Compiling autocfg v1.0.0 [INFO] [stderr] Compiling unicode-xid v0.2.1 [INFO] [stderr] Compiling syn v1.0.33 [INFO] [stderr] Compiling serde v1.0.114 [INFO] [stderr] Compiling ucd-trie v0.1.3 [INFO] [stderr] Compiling getrandom v0.1.14 [INFO] [stderr] Compiling log v0.4.8 [INFO] [stderr] Compiling pest v2.1.3 [INFO] [stderr] Checking tinyvec v0.3.3 [INFO] [stderr] Compiling maplit v1.0.2 [INFO] [stderr] Compiling num-traits v0.2.12 [INFO] [stderr] Compiling num-integer v0.1.43 [INFO] [stderr] Checking matches v0.1.2 [INFO] [stderr] Compiling memchr v2.3.3 [INFO] [stderr] Checking unicode-normalization v0.1.13 [INFO] [stderr] Checking unicode-bidi v0.3.4 [INFO] [stderr] Compiling serde_json v1.0.57 [INFO] [stderr] Compiling quote v1.0.7 [INFO] [stderr] Checking time v0.1.43 [INFO] [stderr] Checking rand_core v0.5.1 [INFO] [stderr] Checking itoa v0.4.6 [INFO] [stderr] Checking ppv-lite86 v0.2.8 [INFO] [stderr] Compiling pest_meta v2.1.3 [INFO] [stderr] Compiling serde_derive v1.0.114 [INFO] [stderr] Checking idna v0.2.0 [INFO] [stderr] Checking thread_local v1.0.1 [INFO] [stderr] Checking aho-corasick v0.7.13 [INFO] [stderr] Checking rand_chacha v0.2.2 [INFO] [stderr] Checking ascii v1.0.0 [INFO] [stderr] Checking unicode-width v0.1.5 [INFO] [stderr] Checking chunked_transfer v1.2.0 [INFO] [stderr] Checking url v2.1.1 [INFO] [stderr] Checking regex-syntax v0.6.18 [INFO] [stderr] Checking getopts v0.2.21 [INFO] [stderr] Checking rand v0.7.3 [INFO] [stderr] Compiling pest_generator v2.1.3 [INFO] [stderr] Checking chrono v0.4.13 [INFO] [stderr] Compiling derive_more v0.99.9 [INFO] [stderr] Checking regex v1.3.9 [INFO] [stderr] Compiling pest_derive v2.1.0 [INFO] [stderr] Checking tiny_http v0.7.0 [INFO] [stderr] Checking handlebars v3.3.0 [INFO] [stderr] Checking hermes v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: elided lifetime has a name [INFO] [stdout] --> src/dns/buffer.rs:238:57 [INFO] [stdout] | [INFO] [stdout] 234 | impl<'a, T> StreamPacketBuffer<'a, T> [INFO] [stdout] | -- lifetime `'a` declared here [INFO] [stdout] ... [INFO] [stdout] 238 | pub fn new(stream: &'a mut T) -> StreamPacketBuffer<'_, T> { [INFO] [stdout] | ^^ this elided lifetime gets resolved as `'a` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(elided_named_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: elided lifetime has a name [INFO] [stdout] --> src/dns/buffer.rs:238:57 [INFO] [stdout] | [INFO] [stdout] 234 | impl<'a, T> StreamPacketBuffer<'a, T> [INFO] [stdout] | -- lifetime `'a` declared here [INFO] [stdout] ... [INFO] [stdout] 238 | pub fn new(stream: &'a mut T) -> StreamPacketBuffer<'_, T> { [INFO] [stdout] | ^^ this elided lifetime gets resolved as `'a` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(elided_named_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::sync::atomic::AtomicUsize::compare_and_swap`: Use `compare_exchange` or `compare_exchange_weak` instead [INFO] [stdout] --> src/dns/client.rs:106:22 [INFO] [stdout] | [INFO] [stdout] 106 | self.seq.compare_and_swap(0xFFFF, 0, Ordering::SeqCst); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::sync::atomic::AtomicUsize::compare_and_swap`: Use `compare_exchange` or `compare_exchange_weak` instead [INFO] [stdout] --> src/dns/client.rs:153:22 [INFO] [stdout] | [INFO] [stdout] 153 | self.seq.compare_and_swap(0xFFFF, 0, Ordering::SeqCst); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::sync::atomic::AtomicUsize::compare_and_swap`: Use `compare_exchange` or `compare_exchange_weak` instead [INFO] [stdout] --> src/dns/client.rs:106:22 [INFO] [stdout] | [INFO] [stdout] 106 | self.seq.compare_and_swap(0xFFFF, 0, Ordering::SeqCst); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::sync::atomic::AtomicUsize::compare_and_swap`: Use `compare_exchange` or `compare_exchange_weak` instead [INFO] [stdout] --> src/dns/client.rs:153:22 [INFO] [stdout] | [INFO] [stdout] 153 | self.seq.compare_and_swap(0xFFFF, 0, Ordering::SeqCst); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/dns/resolve.rs:230:18 [INFO] [stdout] | [INFO] [stdout] 230 | Some(mut ctx) => { [INFO] [stdout] | ----^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::result::Result` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dns/resolve.rs:303:24 [INFO] [stdout] | [INFO] [stdout] 294 | let context = create_test_context(Box::new(|_, _, _, _| { [INFO] [stdout] | ------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 300 | let mut resolver = context.create_resolver(context.clone()); [INFO] [stdout] | ------------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 303 | if let Ok(_) = resolver.resolve("google.com", QueryType::A, true) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::result::Result` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dns/resolve.rs:333:24 [INFO] [stdout] | [INFO] [stdout] 310 | let context = create_test_context(Box::new(|_, _, _, _| { [INFO] [stdout] | ------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 316 | let mut resolver = context.create_resolver(context.clone()); [INFO] [stdout] | ------------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 333 | if let Ok(_) = resolver.resolve("google.com", QueryType::A, true) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::result::Result` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dns/resolve.rs:452:15 [INFO] [stdout] | [INFO] [stdout] 340 | let context = create_test_context(Box::new(|_, _, (server, _), _| { [INFO] [stdout] | ------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 380 | let mut resolver = context.create_resolver(context.clone()); [INFO] [stdout] | ------------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 452 | match resolver.resolve("google.com", QueryType::A, true) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/dns/server.rs:484:18 [INFO] [stdout] | [INFO] [stdout] 484 | Some(mut ctx) => { [INFO] [stdout] | ----^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/dns/server.rs:561:18 [INFO] [stdout] | [INFO] [stdout] 561 | Some(mut ctx) => { [INFO] [stdout] | ----^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/dns/server.rs:592:18 [INFO] [stdout] | [INFO] [stdout] 592 | Some(mut ctx) => { [INFO] [stdout] | ----^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 7 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `hermes` (lib test) due to 4 previous errors; 7 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> src/bin/hermes.rs:40:26 [INFO] [stdout] | [INFO] [stdout] 40 | Err(f) => panic!(f.to_string()), [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this usage of `panic!()` is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(non_fmt_panics)]` on by default [INFO] [stdout] help: add a "{}" format string to `Display` the message [INFO] [stdout] | [INFO] [stdout] 40 | Err(f) => panic!("{}", f.to_string()), [INFO] [stdout] | +++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> src/bin/hermes.rs:40:26 [INFO] [stdout] | [INFO] [stdout] 40 | Err(f) => panic!(f.to_string()), [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this usage of `panic!()` is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(non_fmt_panics)]` on by default [INFO] [stdout] help: add a "{}" format string to `Display` the message [INFO] [stdout] | [INFO] [stdout] 40 | Err(f) => panic!("{}", f.to_string()), [INFO] [stdout] | +++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] running `Command { std: "docker" "inspect" "8583ac3b4979f947a6fc52003c396fdcef7dd11e933cb7724a49b83c620f220e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8583ac3b4979f947a6fc52003c396fdcef7dd11e933cb7724a49b83c620f220e", kill_on_drop: false }` [INFO] [stdout] 8583ac3b4979f947a6fc52003c396fdcef7dd11e933cb7724a49b83c620f220e