[INFO] cloning repository https://github.com/DrJackilD/kvs [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/DrJackilD/kvs" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FDrJackilD%2Fkvs", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FDrJackilD%2Fkvs'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 4a3003e564ff1ea9c92408f168c6d75a4081ff8d [INFO] checking DrJackilD/kvs/4a3003e564ff1ea9c92408f168c6d75a4081ff8d against try#7014e13d5becc920d4bea3cd87942c8a13d359bf+rustflags=-Dtail_expr_drop_order for pr-129864 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FDrJackilD%2Fkvs" "/workspace/builds/worker-5-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/DrJackilD/kvs on toolchain 7014e13d5becc920d4bea3cd87942c8a13d359bf [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/DrJackilD/kvs [INFO] finished tweaking git repo https://github.com/DrJackilD/kvs [INFO] tweaked toml for git repo https://github.com/DrJackilD/kvs written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/DrJackilD/kvs already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 4c0e5deab359332d05d7575a53cb4d4f374b9860021eaeff61b58d1f440a5ff7 [INFO] running `Command { std: "docker" "start" "-a" "4c0e5deab359332d05d7575a53cb4d4f374b9860021eaeff61b58d1f440a5ff7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "4c0e5deab359332d05d7575a53cb4d4f374b9860021eaeff61b58d1f440a5ff7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4c0e5deab359332d05d7575a53cb4d4f374b9860021eaeff61b58d1f440a5ff7", kill_on_drop: false }` [INFO] [stdout] 4c0e5deab359332d05d7575a53cb4d4f374b9860021eaeff61b58d1f440a5ff7 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 3124d41377f62c10bf5bc6754b1b2f4c2e00cbc7df47da0641da0e06407d4d2b [INFO] running `Command { std: "docker" "start" "-a" "3124d41377f62c10bf5bc6754b1b2f4c2e00cbc7df47da0641da0e06407d4d2b", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.68 [INFO] [stderr] Compiling proc-macro2 v1.0.9 [INFO] [stderr] Compiling unicode-xid v0.2.0 [INFO] [stderr] Compiling syn v1.0.17 [INFO] [stderr] Compiling serde v1.0.105 [INFO] [stderr] Compiling ryu v1.0.3 [INFO] [stderr] Compiling cc v1.0.50 [INFO] [stderr] Compiling memchr v2.3.3 [INFO] [stderr] Compiling autocfg v1.0.0 [INFO] [stderr] Compiling getrandom v0.1.14 [INFO] [stderr] Compiling failure_derive v0.1.7 [INFO] [stderr] Compiling bitflags v1.2.1 [INFO] [stderr] Checking itoa v0.4.5 [INFO] [stderr] Compiling log v0.4.8 [INFO] [stderr] Checking unicode-width v0.1.7 [INFO] [stderr] Checking rustc-demangle v0.1.16 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking thread_local v1.0.1 [INFO] [stderr] Checking regex-syntax v0.6.17 [INFO] [stderr] Checking yaml-rust v0.3.5 [INFO] [stderr] Compiling doc-comment v0.3.3 [INFO] [stderr] Checking vec_map v0.8.1 [INFO] [stderr] Checking predicates-core v1.0.0 [INFO] [stderr] Compiling escargot v0.5.0 [INFO] [stderr] Checking ansi_term v0.11.0 [INFO] [stderr] Checking ppv-lite86 v0.2.6 [INFO] [stderr] Checking treeline v0.1.0 [INFO] [stderr] Checking normalize-line-endings v0.3.0 [INFO] [stderr] Checking difference v2.0.0 [INFO] [stderr] Checking remove_dir_all v0.5.2 [INFO] [stderr] Checking predicates-tree v1.0.0 [INFO] [stderr] Checking walkdir v2.3.1 [INFO] [stderr] Compiling num-traits v0.2.11 [INFO] [stderr] Checking aho-corasick v0.7.10 [INFO] [stderr] Compiling backtrace-sys v0.1.35 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking wait-timeout v0.2.0 [INFO] [stderr] Checking clap v2.33.0 [INFO] [stderr] Compiling quote v1.0.3 [INFO] [stderr] Checking rand_core v0.5.1 [INFO] [stderr] Checking rand_chacha v0.2.2 [INFO] [stderr] Checking float-cmp v0.6.0 [INFO] [stderr] Checking rand v0.7.3 [INFO] [stderr] Checking backtrace v0.3.46 [INFO] [stderr] Checking tempfile v3.1.0 [INFO] [stderr] Checking regex v1.3.6 [INFO] [stderr] Checking predicates v1.0.4 [INFO] [stderr] Compiling synstructure v0.12.3 [INFO] [stderr] Compiling serde_derive v1.0.105 [INFO] [stderr] Checking failure v0.1.7 [INFO] [stderr] Checking serde_json v1.0.50 [INFO] [stderr] Checking kvs v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/error.rs:4:10 [INFO] [stdout] | [INFO] [stdout] 4 | #[derive(Fail, Debug)] [INFO] [stdout] | ^--- [INFO] [stdout] | | [INFO] [stdout] | `Fail` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_DERIVE_failure_Fail_FOR_KvsError` [INFO] [stdout] 5 | pub enum KvsError { [INFO] [stdout] | -------- `KvsError` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Fail` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Fail` may come from an old version of the `failure_derive` crate, try updating your dependency with `cargo update -p failure_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue [INFO] [stdout] = note: `#[warn(non_local_definitions)]` on by default [INFO] [stdout] = note: this warning originates in the derive macro `Fail` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/error.rs:4:10 [INFO] [stdout] | [INFO] [stdout] 4 | #[derive(Fail, Debug)] [INFO] [stdout] | ^--- [INFO] [stdout] | | [INFO] [stdout] | `Display` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_DERIVE_failure_core_fmt_Display_FOR_KvsError` [INFO] [stdout] 5 | pub enum KvsError { [INFO] [stdout] | -------- `KvsError` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Fail` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Fail` may come from an old version of the `failure_derive` crate, try updating your dependency with `cargo update -p failure_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue [INFO] [stdout] = note: this warning originates in the derive macro `Fail` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/kv.rs:13:24 [INFO] [stdout] | [INFO] [stdout] 13 | #[derive(Debug, Clone, Serialize, Deserialize)] [INFO] [stdout] | ^-------- [INFO] [stdout] | | [INFO] [stdout] | `Serialize` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_IMPL_SERIALIZE_FOR_Log` [INFO] [stdout] 14 | pub enum Log { [INFO] [stdout] | --- `Log` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Serialize` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Serialize` may come from an old version of the `serde_derive` crate, try updating your dependency with `cargo update -p serde_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue [INFO] [stdout] = note: this warning originates in the derive macro `Serialize` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/kv.rs:13:35 [INFO] [stdout] | [INFO] [stdout] 13 | #[derive(Debug, Clone, Serialize, Deserialize)] [INFO] [stdout] | ^---------- [INFO] [stdout] | | [INFO] [stdout] | `Deserialize` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_IMPL_DESERIALIZE_FOR_Log` [INFO] [stdout] 14 | pub enum Log { [INFO] [stdout] | --- `Log` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Deserialize` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Deserialize` may come from an old version of the `serde_derive` crate, try updating your dependency with `cargo update -p serde_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue [INFO] [stdout] = note: this warning originates in the derive macro `Deserialize` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result<(), KvsError>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bin/kvs.rs:93:11 [INFO] [stdout] | [INFO] [stdout] 91 | let mut store = KvStore::new(db_name)?; [INFO] [stdout] | --------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 92 | let key = args.value_of("KEY").unwrap(); [INFO] [stdout] 93 | match store.remove(key) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result<(), KvsError>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bin/kvs.rs:106:11 [INFO] [stdout] | [INFO] [stdout] 105 | let mut shell = Shell::create(store); [INFO] [stdout] | --------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 106 | match shell.start() { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `kvs` (bin "kvs") due to 3 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "3124d41377f62c10bf5bc6754b1b2f4c2e00cbc7df47da0641da0e06407d4d2b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3124d41377f62c10bf5bc6754b1b2f4c2e00cbc7df47da0641da0e06407d4d2b", kill_on_drop: false }` [INFO] [stdout] 3124d41377f62c10bf5bc6754b1b2f4c2e00cbc7df47da0641da0e06407d4d2b