[INFO] cloning repository https://github.com/DebGB/Copy-of-Book [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/DebGB/Copy-of-Book" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FDebGB%2FCopy-of-Book", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FDebGB%2FCopy-of-Book'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 5f9358faeb1f46e19b8a23a21e79fd7fe150491e [INFO] checking DebGB/Copy-of-Book/5f9358faeb1f46e19b8a23a21e79fd7fe150491e against try#7014e13d5becc920d4bea3cd87942c8a13d359bf+rustflags=-Dtail_expr_drop_order for pr-129864 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FDebGB%2FCopy-of-Book" "/workspace/builds/worker-7-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-7-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/DebGB/Copy-of-Book on toolchain 7014e13d5becc920d4bea3cd87942c8a13d359bf [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] removed /workspace/builds/worker-7-tc2/source/.cargo/config [INFO] removed /workspace/builds/worker-7-tc2/source/rust-toolchain [INFO] started tweaking git repo https://github.com/DebGB/Copy-of-Book [INFO] finished tweaking git repo https://github.com/DebGB/Copy-of-Book [INFO] tweaked toml for git repo https://github.com/DebGB/Copy-of-Book written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/DebGB/Copy-of-Book already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 6685289528b2464f50575a315374021088227743c8da9d83837d41148d28068d [INFO] running `Command { std: "docker" "start" "-a" "6685289528b2464f50575a315374021088227743c8da9d83837d41148d28068d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "6685289528b2464f50575a315374021088227743c8da9d83837d41148d28068d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6685289528b2464f50575a315374021088227743c8da9d83837d41148d28068d", kill_on_drop: false }` [INFO] [stdout] 6685289528b2464f50575a315374021088227743c8da9d83837d41148d28068d [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 6d2c5edbc67fc7ccdef2ff33d02797f578c3ad0a30db41b75935c9423f9fc34c [INFO] running `Command { std: "docker" "start" "-a" "6d2c5edbc67fc7ccdef2ff33d02797f578c3ad0a30db41b75935c9423f9fc34c", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.8 [INFO] [stderr] Compiling libc v0.2.66 [INFO] [stderr] Compiling unicode-xid v0.2.0 [INFO] [stderr] Compiling syn v1.0.14 [INFO] [stderr] Compiling memchr v2.3.0 [INFO] [stderr] Checking cfg-if v0.1.10 [INFO] [stderr] Compiling serde v1.0.104 [INFO] [stderr] Compiling crc32fast v1.2.0 [INFO] [stderr] Checking lazy_static v1.4.0 [INFO] [stderr] Checking adler32 v1.0.4 [INFO] [stderr] Checking regex-syntax v0.6.13 [INFO] [stderr] Checking strsim v0.9.3 [INFO] [stderr] Checking same-file v1.0.6 [INFO] [stderr] Checking thread_local v1.0.1 [INFO] [stderr] Checking miniz_oxide v0.3.5 [INFO] [stderr] Checking walkdir v2.3.1 [INFO] [stderr] Checking aho-corasick v0.7.6 [INFO] [stderr] Compiling quote v1.0.2 [INFO] [stderr] Checking filetime v0.2.7 [INFO] [stderr] Checking xattr v0.2.2 [INFO] [stderr] Checking flate2 v1.0.13 [INFO] [stderr] Checking tar v0.4.26 [INFO] [stderr] Checking regex v1.3.3 [INFO] [stderr] Compiling serde_derive v1.0.104 [INFO] [stderr] Checking docopt v1.1.0 [INFO] [stderr] Checking rust-book v0.0.1 (/opt/rustwide/workdir) [INFO] [stdout] error: this value of type `Result` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> tools/src/bin/lfp.rs:75:11 [INFO] [stdout] | [INFO] [stdout] 75 | match fs::File::open(path) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] 76 | Ok(file) => lint_lines(io::BufReader::new(&file).lines()), [INFO] [stdout] 77 | Err(_) => vec![LintingError::UnableToOpenFile], [INFO] [stdout] | ------------------------------------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> tools/src/bin/lfp.rs:69:17 [INFO] [stdout] | [INFO] [stdout] 69 | #[derive(Debug, Deserialize)] [INFO] [stdout] | ^---------- [INFO] [stdout] | | [INFO] [stdout] | `Deserialize` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_IMPL_DESERIALIZE_FOR_Args` [INFO] [stdout] 70 | struct Args { [INFO] [stdout] | ---- `Args` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Deserialize` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Deserialize` may come from an old version of the `serde_derive` crate, try updating your dependency with `cargo update -p serde_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue [INFO] [stdout] = note: `#[warn(non_local_definitions)]` on by default [INFO] [stdout] = note: this warning originates in the derive macro `Deserialize` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rust-book` (bin "lfp") due to 2 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: this value of type `Result` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> tools/src/bin/lfp.rs:75:11 [INFO] [stdout] | [INFO] [stdout] 75 | match fs::File::open(path) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] 76 | Ok(file) => lint_lines(io::BufReader::new(&file).lines()), [INFO] [stdout] 77 | Err(_) => vec![LintingError::UnableToOpenFile], [INFO] [stdout] | ------------------------------------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> tools/src/bin/lfp.rs:69:17 [INFO] [stdout] | [INFO] [stdout] 69 | #[derive(Debug, Deserialize)] [INFO] [stdout] | ^---------- [INFO] [stdout] | | [INFO] [stdout] | `Deserialize` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_IMPL_DESERIALIZE_FOR_Args` [INFO] [stdout] 70 | struct Args { [INFO] [stdout] | ---- `Args` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Deserialize` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Deserialize` may come from an old version of the `serde_derive` crate, try updating your dependency with `cargo update -p serde_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue [INFO] [stdout] = note: `#[warn(non_local_definitions)]` on by default [INFO] [stdout] = note: this warning originates in the derive macro `Deserialize` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rust-book` (bin "lfp" test) due to 2 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "6d2c5edbc67fc7ccdef2ff33d02797f578c3ad0a30db41b75935c9423f9fc34c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6d2c5edbc67fc7ccdef2ff33d02797f578c3ad0a30db41b75935c9423f9fc34c", kill_on_drop: false }` [INFO] [stdout] 6d2c5edbc67fc7ccdef2ff33d02797f578c3ad0a30db41b75935c9423f9fc34c