[INFO] cloning repository https://github.com/Clownvin/Flashr [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Clownvin/Flashr" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FClownvin%2FFlashr", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FClownvin%2FFlashr'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 2242bb798acddd6ae94271fd3e5e3cf6677c08ac [INFO] checking Clownvin/Flashr/2242bb798acddd6ae94271fd3e5e3cf6677c08ac against try#7014e13d5becc920d4bea3cd87942c8a13d359bf+rustflags=-Dtail_expr_drop_order for pr-129864 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FClownvin%2FFlashr" "/workspace/builds/worker-3-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-3-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/Clownvin/Flashr on toolchain 7014e13d5becc920d4bea3cd87942c8a13d359bf [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/Clownvin/Flashr [INFO] finished tweaking git repo https://github.com/Clownvin/Flashr [INFO] tweaked toml for git repo https://github.com/Clownvin/Flashr written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/Clownvin/Flashr already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] ad07c4e7cee9f251581e9be1e320055eb48824b77296c100ca65f8701ff42cef [INFO] running `Command { std: "docker" "start" "-a" "ad07c4e7cee9f251581e9be1e320055eb48824b77296c100ca65f8701ff42cef", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "ad07c4e7cee9f251581e9be1e320055eb48824b77296c100ca65f8701ff42cef", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ad07c4e7cee9f251581e9be1e320055eb48824b77296c100ca65f8701ff42cef", kill_on_drop: false }` [INFO] [stdout] ad07c4e7cee9f251581e9be1e320055eb48824b77296c100ca65f8701ff42cef [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 88226344dfa234317713e479c50b26047e367ec164e1d433c599a63b8084718f [INFO] running `Command { std: "docker" "start" "-a" "88226344dfa234317713e479c50b26047e367ec164e1d433c599a63b8084718f", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Compiling rustversion v1.0.17 [INFO] [stderr] Compiling serde v1.0.205 [INFO] [stderr] Compiling heck v0.5.0 [INFO] [stderr] Compiling signal-hook v0.3.17 [INFO] [stderr] Checking utf8parse v0.2.2 [INFO] [stderr] Compiling rustix v0.38.34 [INFO] [stderr] Checking log v0.4.22 [INFO] [stderr] Checking once_cell v1.19.0 [INFO] [stderr] Checking anstyle-parse v0.2.5 [INFO] [stderr] Checking mio v1.0.1 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking is_terminal_polyfill v1.70.1 [INFO] [stderr] Checking anstyle-query v1.1.1 [INFO] [stderr] Checking bitflags v2.6.0 [INFO] [stderr] Checking colorchoice v1.0.2 [INFO] [stderr] Checking anstyle v1.0.8 [INFO] [stderr] Checking linux-raw-sys v0.4.14 [INFO] [stderr] Checking itertools v0.13.0 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking unicode-segmentation v1.11.0 [INFO] [stderr] Checking option-ext v0.2.0 [INFO] [stderr] Checking anstream v0.6.15 [INFO] [stderr] Checking static_assertions v1.1.0 [INFO] [stderr] Checking strsim v0.11.1 [INFO] [stderr] Checking signal-hook-mio v0.2.4 [INFO] [stderr] Compiling serde_json v1.0.122 [INFO] [stderr] Checking unicode-width v0.1.13 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Checking clap_lex v0.7.2 [INFO] [stderr] Checking castaway v0.2.3 [INFO] [stderr] Checking dirs-sys v0.4.1 [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Checking clap_builder v4.5.15 [INFO] [stderr] Checking dirs v5.0.1 [INFO] [stderr] Checking compact_str v0.8.0 [INFO] [stderr] Compiling syn v2.0.72 [INFO] [stderr] Checking crossterm v0.28.1 [INFO] [stderr] Checking unicode-truncate v1.1.0 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Compiling serde_derive v1.0.205 [INFO] [stderr] Compiling strum_macros v0.26.4 [INFO] [stderr] Compiling instability v0.3.2 [INFO] [stderr] Compiling clap_derive v4.5.13 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking strum v0.26.3 [INFO] [stderr] Checking ahash v0.8.11 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking clap v4.5.15 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Checking lru v0.12.4 [INFO] [stderr] Checking ratatui v0.28.0 [INFO] [stderr] Checking flashr v0.5.3 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused variable: `term` [INFO] [stdout] --> src/modes/type_faces.rs:32:9 [INFO] [stdout] | [INFO] [stdout] 32 | let term = &mut term; [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_term` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `problems` [INFO] [stdout] --> src/modes/type_faces.rs:35:13 [INFO] [stdout] | [INFO] [stdout] 35 | let mut problems = TypeProblemIterator::new(args.deck_cards, stats, args.faces, rng); [INFO] [stdout] | ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_problems` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `total_correct` [INFO] [stdout] --> src/modes/type_faces.rs:37:13 [INFO] [stdout] | [INFO] [stdout] 37 | let mut total_correct = 0; [INFO] [stdout] | ^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_total_correct` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/modes/type_faces.rs:35:9 [INFO] [stdout] | [INFO] [stdout] 35 | let mut problems = TypeProblemIterator::new(args.deck_cards, stats, args.faces, rng); [INFO] [stdout] | ----^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/modes/type_faces.rs:37:9 [INFO] [stdout] | [INFO] [stdout] 37 | let mut total_correct = 0; [INFO] [stdout] | ----^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `term` [INFO] [stdout] --> src/modes/type_faces.rs:110:5 [INFO] [stdout] | [INFO] [stdout] 110 | term: &TerminalWrapper, [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_term` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `problem` [INFO] [stdout] --> src/modes/type_faces.rs:111:5 [INFO] [stdout] | [INFO] [stdout] 111 | problem: &TypeProblem, [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_problem` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `progress` [INFO] [stdout] --> src/modes/type_faces.rs:112:5 [INFO] [stdout] | [INFO] [stdout] 112 | progress: (usize, usize), [INFO] [stdout] | ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_progress` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `type_faces` is never used [INFO] [stdout] --> src/modes/type_faces.rs:31:8 [INFO] [stdout] | [INFO] [stdout] 31 | pub fn type_faces(mut term: TerminalWrapper, args: ModeArguments) -> Result { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `TypeProblemIterator` is never constructed [INFO] [stdout] --> src/modes/type_faces.rs:42:8 [INFO] [stdout] | [INFO] [stdout] 42 | struct TypeProblemIterator<'a> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `new` is never used [INFO] [stdout] --> src/modes/type_faces.rs:49:8 [INFO] [stdout] | [INFO] [stdout] 48 | impl<'a> TypeProblemIterator<'a> { [INFO] [stdout] | -------------------------------- associated function in this implementation [INFO] [stdout] 49 | fn new( [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `deck`, `question`, `answer`, and `index` are never read [INFO] [stdout] --> src/modes/type_faces.rs:103:5 [INFO] [stdout] | [INFO] [stdout] 102 | struct TypeProblem<'a> { [INFO] [stdout] | ----------- fields in this struct [INFO] [stdout] 103 | deck: &'a Deck, [INFO] [stdout] | ^^^^ [INFO] [stdout] 104 | question: (&'a String, &'a Face), [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] 105 | answer: (&'a String, &'a Face), [INFO] [stdout] | ^^^^^^ [INFO] [stdout] 106 | index: usize, [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `show_type_problem` is never used [INFO] [stdout] --> src/modes/type_faces.rs:109:4 [INFO] [stdout] | [INFO] [stdout] 109 | fn show_type_problem( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 13 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `term` [INFO] [stdout] --> src/modes/type_faces.rs:32:9 [INFO] [stdout] | [INFO] [stdout] 32 | let term = &mut term; [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_term` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `problems` [INFO] [stdout] --> src/modes/type_faces.rs:35:13 [INFO] [stdout] | [INFO] [stdout] 35 | let mut problems = TypeProblemIterator::new(args.deck_cards, stats, args.faces, rng); [INFO] [stdout] | ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_problems` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `total_correct` [INFO] [stdout] --> src/modes/type_faces.rs:37:13 [INFO] [stdout] | [INFO] [stdout] 37 | let mut total_correct = 0; [INFO] [stdout] | ^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_total_correct` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/modes/type_faces.rs:35:9 [INFO] [stdout] | [INFO] [stdout] 35 | let mut problems = TypeProblemIterator::new(args.deck_cards, stats, args.faces, rng); [INFO] [stdout] | ----^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/modes/type_faces.rs:37:9 [INFO] [stdout] | [INFO] [stdout] 37 | let mut total_correct = 0; [INFO] [stdout] | ----^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `term` [INFO] [stdout] --> src/modes/type_faces.rs:110:5 [INFO] [stdout] | [INFO] [stdout] 110 | term: &TerminalWrapper, [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_term` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `problem` [INFO] [stdout] --> src/modes/type_faces.rs:111:5 [INFO] [stdout] | [INFO] [stdout] 111 | problem: &TypeProblem, [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_problem` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `progress` [INFO] [stdout] --> src/modes/type_faces.rs:112:5 [INFO] [stdout] | [INFO] [stdout] 112 | progress: (usize, usize), [INFO] [stdout] | ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_progress` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `type_faces` is never used [INFO] [stdout] --> src/modes/type_faces.rs:31:8 [INFO] [stdout] | [INFO] [stdout] 31 | pub fn type_faces(mut term: TerminalWrapper, args: ModeArguments) -> Result { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `TypeProblemIterator` is never constructed [INFO] [stdout] --> src/modes/type_faces.rs:42:8 [INFO] [stdout] | [INFO] [stdout] 42 | struct TypeProblemIterator<'a> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `new` is never used [INFO] [stdout] --> src/modes/type_faces.rs:49:8 [INFO] [stdout] | [INFO] [stdout] 48 | impl<'a> TypeProblemIterator<'a> { [INFO] [stdout] | -------------------------------- associated function in this implementation [INFO] [stdout] 49 | fn new( [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `deck`, `question`, `answer`, and `index` are never read [INFO] [stdout] --> src/modes/type_faces.rs:103:5 [INFO] [stdout] | [INFO] [stdout] 102 | struct TypeProblem<'a> { [INFO] [stdout] | ----------- fields in this struct [INFO] [stdout] 103 | deck: &'a Deck, [INFO] [stdout] | ^^^^ [INFO] [stdout] 104 | question: (&'a String, &'a Face), [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] 105 | answer: (&'a String, &'a Face), [INFO] [stdout] | ^^^^^^ [INFO] [stdout] 106 | index: usize, [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `show_type_problem` is never used [INFO] [stdout] --> src/modes/type_faces.rs:109:4 [INFO] [stdout] | [INFO] [stdout] 109 | fn show_type_problem( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/weighted_list.rs:227:9 [INFO] [stdout] | [INFO] [stdout] 226 | fn bench_weighted_list_change_weight() { [INFO] [stdout] | -------------------------------------- move the `impl` block outside of this function `bench_weighted_list_change_weight` [INFO] [stdout] 227 | impl WeightedList { [INFO] [stdout] | ^^^^^^^^------------^^^ [INFO] [stdout] | | [INFO] [stdout] | `WeightedList` is not local [INFO] [stdout] | [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue [INFO] [stdout] = note: `#[warn(non_local_definitions)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/weighted_list.rs:391:9 [INFO] [stdout] | [INFO] [stdout] 327 | fn bench_weighted_list_iterator() { [INFO] [stdout] | --------------------------------- move the `impl` block outside of this function `bench_weighted_list_iterator` [INFO] [stdout] ... [INFO] [stdout] 391 | impl WeightedList { [INFO] [stdout] | ^^^^^^^^------------^^^ [INFO] [stdout] | | [INFO] [stdout] | `WeightedList` is not local [INFO] [stdout] | [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 15 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 36.29s [INFO] running `Command { std: "docker" "inspect" "88226344dfa234317713e479c50b26047e367ec164e1d433c599a63b8084718f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "88226344dfa234317713e479c50b26047e367ec164e1d433c599a63b8084718f", kill_on_drop: false }` [INFO] [stdout] 88226344dfa234317713e479c50b26047e367ec164e1d433c599a63b8084718f