[INFO] cloning repository https://github.com/AliasT/craftinginterpreters [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/AliasT/craftinginterpreters" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FAliasT%2Fcraftinginterpreters", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FAliasT%2Fcraftinginterpreters'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] dd806d2e9fdeefecdca38f77e6d5e082d7274bac [INFO] checking AliasT/craftinginterpreters/dd806d2e9fdeefecdca38f77e6d5e082d7274bac against try#7014e13d5becc920d4bea3cd87942c8a13d359bf+rustflags=-Dtail_expr_drop_order for pr-129864 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FAliasT%2Fcraftinginterpreters" "/workspace/builds/worker-2-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-2-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/AliasT/craftinginterpreters on toolchain 7014e13d5becc920d4bea3cd87942c8a13d359bf [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/AliasT/craftinginterpreters [INFO] finished tweaking git repo https://github.com/AliasT/craftinginterpreters [INFO] tweaked toml for git repo https://github.com/AliasT/craftinginterpreters written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/AliasT/craftinginterpreters already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] d0690b2da42c7a8891a3f82555e255b962d43cde371995c22056f1826867c05f [INFO] running `Command { std: "docker" "start" "-a" "d0690b2da42c7a8891a3f82555e255b962d43cde371995c22056f1826867c05f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "d0690b2da42c7a8891a3f82555e255b962d43cde371995c22056f1826867c05f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d0690b2da42c7a8891a3f82555e255b962d43cde371995c22056f1826867c05f", kill_on_drop: false }` [INFO] [stdout] d0690b2da42c7a8891a3f82555e255b962d43cde371995c22056f1826867c05f [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] aba71e3c6e8028db8b0011bf287192d4ee9d636b600490aad8fd0f5456270133 [INFO] running `Command { std: "docker" "start" "-a" "aba71e3c6e8028db8b0011bf287192d4ee9d636b600490aad8fd0f5456270133", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.98 [INFO] [stderr] Compiling ppv-lite86 v0.2.10 [INFO] [stderr] Compiling proc-macro-hack v0.5.19 [INFO] [stderr] Compiling siphasher v0.3.7 [INFO] [stderr] Compiling syn v1.0.73 [INFO] [stderr] Checking phf_shared v0.10.0 [INFO] [stderr] Compiling getrandom v0.2.3 [INFO] [stderr] Compiling rand_core v0.6.3 [INFO] [stderr] Compiling rand_chacha v0.3.1 [INFO] [stderr] Compiling rand v0.8.4 [INFO] [stderr] Compiling phf_generator v0.10.0 [INFO] [stderr] Compiling phf_macros v0.10.0 [INFO] [stderr] Checking phf v0.10.0 [INFO] [stderr] Checking crafting v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused imports: `collections::btree_set::Union` and `env` [INFO] [stdout] --> src/lang/compiler.rs:3:42 [INFO] [stdout] | [INFO] [stdout] 3 | use std::{borrow::Borrow, cell::RefCell, collections::btree_set::Union, env, rc::Rc}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::lang::environment` [INFO] [stdout] --> src/lang/compiler.rs:5:5 [INFO] [stdout] | [INFO] [stdout] 5 | use crate::lang::environment; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `TokenType` [INFO] [stdout] --> src/lang/ast.rs:3:35 [INFO] [stdout] | [INFO] [stdout] 3 | use super::token::{Object, Token, TokenType}; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `collections::btree_set::Union` and `env` [INFO] [stdout] --> src/lang/compiler.rs:3:42 [INFO] [stdout] | [INFO] [stdout] 3 | use std::{borrow::Borrow, cell::RefCell, collections::btree_set::Union, env, rc::Rc}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::lang::environment` [INFO] [stdout] --> src/lang/compiler.rs:5:5 [INFO] [stdout] | [INFO] [stdout] 5 | use crate::lang::environment; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `callee` [INFO] [stdout] --> src/lang/ast.rs:42:34 [INFO] [stdout] | [INFO] [stdout] 42 | Expression::Call(callee, paren, arguments) => todo!(), [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_callee` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `paren` [INFO] [stdout] --> src/lang/ast.rs:42:42 [INFO] [stdout] | [INFO] [stdout] 42 | Expression::Call(callee, paren, arguments) => todo!(), [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_paren` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `arguments` [INFO] [stdout] --> src/lang/ast.rs:42:49 [INFO] [stdout] | [INFO] [stdout] 42 | Expression::Call(callee, paren, arguments) => todo!(), [INFO] [stdout] | ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_arguments` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `expr` [INFO] [stdout] --> src/lang/ast.rs:72:14 [INFO] [stdout] | [INFO] [stdout] 72 | e.walk(&|expr| { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_expr` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/lang/ast.rs:71:9 [INFO] [stdout] | [INFO] [stdout] 71 | let mut i = 0; [INFO] [stdout] | ----^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `a` [INFO] [stdout] --> src/lang/compiler.rs:96:48 [INFO] [stdout] | [INFO] [stdout] 96 | if let Statement::Function(a, parameters, stmts) = function.borrow() { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_a` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Box` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lang/compiler.rs:63:32 [INFO] [stdout] | [INFO] [stdout] 35 | fn compile_expr(&mut self, expr: Expression) -> Rc> { [INFO] [stdout] | ---- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 63 | Expression::Binary(le, op, re) => { [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `callee` [INFO] [stdout] --> src/lang/ast.rs:42:34 [INFO] [stdout] | [INFO] [stdout] 42 | Expression::Call(callee, paren, arguments) => todo!(), [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_callee` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `paren` [INFO] [stdout] --> src/lang/ast.rs:42:42 [INFO] [stdout] | [INFO] [stdout] 42 | Expression::Call(callee, paren, arguments) => todo!(), [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_paren` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `arguments` [INFO] [stdout] --> src/lang/ast.rs:42:49 [INFO] [stdout] | [INFO] [stdout] 42 | Expression::Call(callee, paren, arguments) => todo!(), [INFO] [stdout] | ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_arguments` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `a` [INFO] [stdout] --> src/lang/compiler.rs:96:48 [INFO] [stdout] | [INFO] [stdout] 96 | if let Statement::Function(a, parameters, stmts) = function.borrow() { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_a` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Box` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lang/compiler.rs:63:32 [INFO] [stdout] | [INFO] [stdout] 35 | fn compile_expr(&mut self, expr: Expression) -> Rc> { [INFO] [stdout] | ---- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 63 | Expression::Binary(le, op, re) => { [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `v` [INFO] [stdout] --> src/lang/token.rs:127:36 [INFO] [stdout] | [INFO] [stdout] 127 | UnionObject::Reference(v) => todo!(), [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_v` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `A` is never constructed [INFO] [stdout] --> src/playground/lifetime.rs:3:8 [INFO] [stdout] | [INFO] [stdout] 3 | struct A<'a> { [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `B` is never constructed [INFO] [stdout] --> src/playground/lifetime.rs:7:8 [INFO] [stdout] | [INFO] [stdout] 7 | struct B<'a> { [INFO] [stdout] | ^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `C` is never constructed [INFO] [stdout] --> src/playground/lifetime.rs:11:8 [INFO] [stdout] | [INFO] [stdout] 11 | struct C {} [INFO] [stdout] | ^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `test` is never used [INFO] [stdout] --> src/playground/lifetime.rs:14:8 [INFO] [stdout] | [INFO] [stdout] 13 | impl<'a> A<'a> { [INFO] [stdout] | -------------- associated function in this implementation [INFO] [stdout] 14 | fn test() { [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 13 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `crafting` (lib test) due to 2 previous errors; 13 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: unused variable: `v` [INFO] [stdout] --> src/lang/token.rs:127:36 [INFO] [stdout] | [INFO] [stdout] 127 | UnionObject::Reference(v) => todo!(), [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_v` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `walk` is never used [INFO] [stdout] --> src/lang/ast.rs:22:8 [INFO] [stdout] | [INFO] [stdout] 21 | impl Expression { [INFO] [stdout] | --------------- method in this implementation [INFO] [stdout] 22 | fn walk(&self, visitor: &F) -> bool [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `A` is never constructed [INFO] [stdout] --> src/playground/lifetime.rs:3:8 [INFO] [stdout] | [INFO] [stdout] 3 | struct A<'a> { [INFO] [stdout] | ^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `B` is never constructed [INFO] [stdout] --> src/playground/lifetime.rs:7:8 [INFO] [stdout] | [INFO] [stdout] 7 | struct B<'a> { [INFO] [stdout] | ^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `C` is never constructed [INFO] [stdout] --> src/playground/lifetime.rs:11:8 [INFO] [stdout] | [INFO] [stdout] 11 | struct C {} [INFO] [stdout] | ^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `test` is never used [INFO] [stdout] --> src/playground/lifetime.rs:14:8 [INFO] [stdout] | [INFO] [stdout] 13 | impl<'a> A<'a> { [INFO] [stdout] | -------------- associated function in this implementation [INFO] [stdout] 14 | fn test() { [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 13 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `crafting` (lib) due to 2 previous errors; 13 warnings emitted [INFO] running `Command { std: "docker" "inspect" "aba71e3c6e8028db8b0011bf287192d4ee9d636b600490aad8fd0f5456270133", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "aba71e3c6e8028db8b0011bf287192d4ee9d636b600490aad8fd0f5456270133", kill_on_drop: false }` [INFO] [stdout] aba71e3c6e8028db8b0011bf287192d4ee9d636b600490aad8fd0f5456270133