[INFO] fetching crate ambient_package_semantic 0.3.1... [INFO] checking ambient_package_semantic-0.3.1 against master#38352b01ae4af9300be03b805d6db68c45e51068 for pr-129864 [INFO] extracting crate ambient_package_semantic 0.3.1 into /workspace/builds/worker-1-tc1/source [INFO] validating manifest of crates.io crate ambient_package_semantic 0.3.1 on toolchain 38352b01ae4af9300be03b805d6db68c45e51068 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+38352b01ae4af9300be03b805d6db68c45e51068" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate ambient_package_semantic 0.3.1 [INFO] finished tweaking crates.io crate ambient_package_semantic 0.3.1 [INFO] tweaked toml for crates.io crate ambient_package_semantic 0.3.1 written to /workspace/builds/worker-1-tc1/source/Cargo.toml [INFO] crate crates.io crate ambient_package_semantic 0.3.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+38352b01ae4af9300be03b805d6db68c45e51068" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded toml v0.7.8 [INFO] [stderr] Downloaded ulid v1.1.0 [INFO] [stderr] Downloaded strum v0.24.1 [INFO] [stderr] Downloaded ambient_dirs v0.3.1 [INFO] [stderr] Downloaded ambient_std v0.3.1 [INFO] [stderr] Downloaded strum_macros v0.24.3 [INFO] [stderr] Downloaded directories v5.0.1 [INFO] [stderr] Downloaded redox_users v0.4.3 [INFO] [stderr] Downloaded hyper-rustls v0.24.1 [INFO] [stderr] Downloaded socket2 v0.5.4 [INFO] [stderr] Downloaded semver v1.0.19 [INFO] [stderr] Downloaded indexmap v2.0.2 [INFO] [stderr] Downloaded base64 v0.21.4 [INFO] [stderr] Downloaded tokio-util v0.7.9 [INFO] [stderr] Downloaded hashbrown v0.14.1 [INFO] [stderr] Downloaded serde_json v1.0.107 [INFO] [stderr] Downloaded rustls-webpki v0.101.6 [INFO] [stderr] Downloaded reqwest v0.11.21 [INFO] [stderr] Downloaded syn v2.0.37 [INFO] [stderr] Downloaded proc-macro2 v1.0.67 [INFO] [stderr] Downloaded sct v0.7.0 [INFO] [stderr] Downloaded webpki-roots v0.25.2 [INFO] [stderr] Downloaded thiserror-impl v1.0.49 [INFO] [stderr] Downloaded rustls v0.21.7 [INFO] [stderr] Downloaded smallvec v1.11.1 [INFO] [stderr] Downloaded iana-time-zone v0.1.57 [INFO] [stderr] Downloaded cpufeatures v0.2.9 [INFO] [stderr] Downloaded ambient_package v0.3.1 [INFO] [stderr] Downloaded ambient_schema v0.3.1 [INFO] [stderr] Downloaded ambient_shared_types v0.3.1 [INFO] [stderr] Downloaded data-encoding v2.4.0 [INFO] [stderr] Downloaded rustls-pemfile v1.0.3 [INFO] [stderr] Downloaded async-recursion v1.0.5 [INFO] [stderr] Downloaded thiserror v1.0.49 [INFO] [stderr] Downloaded libc v0.2.148 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+38352b01ae4af9300be03b805d6db68c45e51068" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 675c0cf0926d87d4b029b27c4f25957ccc2dbe36d4aa6837cc727ba3a1e7d432 [INFO] running `Command { std: "docker" "start" "-a" "675c0cf0926d87d4b029b27c4f25957ccc2dbe36d4aa6837cc727ba3a1e7d432", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "675c0cf0926d87d4b029b27c4f25957ccc2dbe36d4aa6837cc727ba3a1e7d432", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "675c0cf0926d87d4b029b27c4f25957ccc2dbe36d4aa6837cc727ba3a1e7d432", kill_on_drop: false }` [INFO] [stdout] 675c0cf0926d87d4b029b27c4f25957ccc2dbe36d4aa6837cc727ba3a1e7d432 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+38352b01ae4af9300be03b805d6db68c45e51068" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 8a83c4a102b89d551941db2928c44687e3fb5f9051d2ab5ce0188ba6fe55cb14 [INFO] running `Command { std: "docker" "start" "-a" "8a83c4a102b89d551941db2928c44687e3fb5f9051d2ab5ce0188ba6fe55cb14", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.67 [INFO] [stderr] Compiling libc v0.2.148 [INFO] [stderr] Compiling autocfg v1.1.0 [INFO] [stderr] Compiling parking_lot_core v0.9.8 [INFO] [stderr] Checking smallvec v1.11.1 [INFO] [stderr] Compiling serde v1.0.188 [INFO] [stderr] Checking pin-project-lite v0.2.13 [INFO] [stderr] Compiling futures-core v0.3.28 [INFO] [stderr] Checking bytes v1.5.0 [INFO] [stderr] Checking memchr v2.6.4 [INFO] [stderr] Checking itoa v1.0.9 [INFO] [stderr] Compiling lock_api v0.4.10 [INFO] [stderr] Compiling slab v0.4.9 [INFO] [stderr] Compiling futures-task v0.3.28 [INFO] [stderr] Checking untrusted v0.7.1 [INFO] [stderr] Checking spin v0.5.2 [INFO] [stderr] Compiling indexmap v1.9.3 [INFO] [stderr] Compiling quote v1.0.33 [INFO] [stderr] Compiling futures-util v0.3.28 [INFO] [stderr] Compiling rustversion v1.0.14 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking http v0.2.9 [INFO] [stderr] Compiling syn v2.0.37 [INFO] [stderr] Checking getrandom v0.2.10 [INFO] [stderr] Checking socket2 v0.5.4 [INFO] [stderr] Checking mio v0.8.8 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Compiling cc v1.0.83 [INFO] [stderr] Checking once_cell v1.18.0 [INFO] [stderr] Checking parking_lot v0.12.1 [INFO] [stderr] Checking signal-hook-registry v1.4.1 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking tracing-core v0.1.31 [INFO] [stderr] Checking tinyvec v1.6.0 [INFO] [stderr] Compiling rustls v0.21.7 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Compiling futures-channel v0.3.28 [INFO] [stderr] Checking futures-sink v0.3.28 [INFO] [stderr] Checking futures-io v0.3.28 [INFO] [stderr] Compiling httparse v1.8.0 [INFO] [stderr] Checking percent-encoding v2.3.0 [INFO] [stderr] Checking hashbrown v0.12.3 [INFO] [stderr] Checking tracing v0.1.37 [INFO] [stderr] Checking form_urlencoded v1.2.0 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Compiling num-traits v0.2.16 [INFO] [stderr] Compiling heck v0.4.1 [INFO] [stderr] Checking hashbrown v0.14.1 [INFO] [stderr] Checking unicode-bidi v0.3.13 [INFO] [stderr] Checking unicode-normalization v0.1.22 [INFO] [stderr] Checking log v0.4.20 [INFO] [stderr] Compiling ring v0.16.20 [INFO] [stderr] Checking unicode-ident v1.0.12 [INFO] [stderr] Checking try-lock v0.2.4 [INFO] [stderr] Compiling paste v1.0.14 [INFO] [stderr] Compiling thiserror v1.0.49 [INFO] [stderr] Checking want v0.3.1 [INFO] [stderr] Checking idna v0.4.0 [INFO] [stderr] Compiling backtrace v0.3.69 [INFO] [stderr] Checking http-body v0.4.5 [INFO] [stderr] Checking socket2 v0.4.9 [INFO] [stderr] Checking adler v1.0.2 [INFO] [stderr] Checking winnow v0.5.15 [INFO] [stderr] Checking gimli v0.28.0 [INFO] [stderr] Checking ryu v1.0.15 [INFO] [stderr] Checking option-ext v0.2.0 [INFO] [stderr] Compiling semver v1.0.19 [INFO] [stderr] Compiling serde_json v1.0.107 [INFO] [stderr] Checking dirs-sys v0.4.1 [INFO] [stderr] Checking miniz_oxide v0.7.1 [INFO] [stderr] Checking object v0.32.1 [INFO] [stderr] Checking rustc-demangle v0.1.23 [INFO] [stderr] Compiling anyhow v1.0.75 [INFO] [stderr] Checking either v1.9.0 [INFO] [stderr] Compiling ambient_schema v0.3.1 [INFO] [stderr] Checking base64 v0.21.4 [INFO] [stderr] Checking cpufeatures v0.2.9 [INFO] [stderr] Checking unicode-segmentation v1.10.1 [INFO] [stderr] Checking iana-time-zone v0.1.57 [INFO] [stderr] Compiling strum_macros v0.24.3 [INFO] [stderr] Checking convert_case v0.6.0 [INFO] [stderr] Checking rustls-pemfile v1.0.3 [INFO] [stderr] Checking sha2 v0.10.8 [INFO] [stderr] Checking itertools v0.10.5 [INFO] [stderr] Compiling serde_derive v1.0.188 [INFO] [stderr] Compiling tokio-macros v2.1.0 [INFO] [stderr] Compiling futures-macro v0.3.28 [INFO] [stderr] Checking rustls-webpki v0.101.6 [INFO] [stderr] Checking tokio v1.32.0 [INFO] [stderr] Checking sct v0.7.0 [INFO] [stderr] Compiling thiserror-impl v1.0.49 [INFO] [stderr] Checking strum v0.24.1 [INFO] [stderr] Checking addr2line v0.21.0 [INFO] [stderr] Checking directories v5.0.1 [INFO] [stderr] Checking encoding_rs v0.8.33 [INFO] [stderr] Checking data-encoding v2.4.0 [INFO] [stderr] Checking ipnet v2.8.0 [INFO] [stderr] Checking bytemuck v1.14.0 [INFO] [stderr] Checking webpki-roots v0.25.2 [INFO] [stderr] Checking ambient_dirs v0.3.1 [INFO] [stderr] Compiling async-recursion v1.0.5 [INFO] [stderr] Checking ambient_std v0.3.1 [INFO] [stderr] Checking tokio-util v0.7.9 [INFO] [stderr] Checking tokio-rustls v0.24.1 [INFO] [stderr] Checking h2 v0.3.21 [INFO] [stderr] Checking toml_datetime v0.6.3 [INFO] [stderr] Checking serde_spanned v0.6.3 [INFO] [stderr] Checking indexmap v2.0.2 [INFO] [stderr] Checking url v2.4.1 [INFO] [stderr] Checking ulid v1.1.0 [INFO] [stderr] Checking ambient_shared_types v0.3.1 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking chrono v0.4.31 [INFO] [stderr] Checking glam v0.24.2 [INFO] [stderr] Checking toml_edit v0.19.15 [INFO] [stderr] Checking hyper v0.14.27 [INFO] [stderr] Checking toml v0.7.8 [INFO] [stderr] Checking ambient_package v0.3.1 [INFO] [stderr] Checking hyper-rustls v0.24.1 [INFO] [stderr] Checking reqwest v0.11.21 [INFO] [stderr] Checking ambient_package_semantic v0.3.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/item.rs:229:9 [INFO] [stdout] | [INFO] [stdout] 228 | pub fn scope_and_dependencies(&self, id: ItemId) -> Vec> { [INFO] [stdout] | --------------------------------------------------------------------------------- move the `impl` block outside of this method `scope_and_dependencies` [INFO] [stdout] 229 | impl TopologicalSortable for ItemId { [INFO] [stdout] | ^^^^^-------------------^-------^^^^^^------^-------^ [INFO] [stdout] | | | | | [INFO] [stdout] | | | | `Package` is not local [INFO] [stdout] | | | `ItemId` is not local [INFO] [stdout] | | `ItemMap` is not local [INFO] [stdout] | `TopologicalSortable` is not local [INFO] [stdout] | [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue [INFO] [stdout] = note: `#[warn(non_local_definitions)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/item.rs:229:9 [INFO] [stdout] | [INFO] [stdout] 228 | pub fn scope_and_dependencies(&self, id: ItemId) -> Vec> { [INFO] [stdout] | --------------------------------------------------------------------------------- move the `impl` block outside of this method `scope_and_dependencies` [INFO] [stdout] 229 | impl TopologicalSortable for ItemId { [INFO] [stdout] | ^^^^^-------------------^-------^^^^^^------^-------^ [INFO] [stdout] | | | | | [INFO] [stdout] | | | | `Package` is not local [INFO] [stdout] | | | `ItemId` is not local [INFO] [stdout] | | `ItemMap` is not local [INFO] [stdout] | `TopologicalSortable` is not local [INFO] [stdout] | [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue [INFO] [stdout] = note: `#[warn(non_local_definitions)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 24.18s [INFO] running `Command { std: "docker" "inspect" "8a83c4a102b89d551941db2928c44687e3fb5f9051d2ab5ce0188ba6fe55cb14", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8a83c4a102b89d551941db2928c44687e3fb5f9051d2ab5ce0188ba6fe55cb14", kill_on_drop: false }` [INFO] [stdout] 8a83c4a102b89d551941db2928c44687e3fb5f9051d2ab5ce0188ba6fe55cb14