[INFO] fetching crate zune-bmp 0.5.0-rc4... [INFO] checking zune-bmp-0.5.0-rc4 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate zune-bmp 0.5.0-rc4 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate zune-bmp 0.5.0-rc4 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate zune-bmp 0.5.0-rc4 [INFO] finished tweaking crates.io crate zune-bmp 0.5.0-rc4 [INFO] tweaked toml for crates.io crate zune-bmp 0.5.0-rc4 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 3 packages to latest compatible versions [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] afd5aaea398ddfb27f4bde7a05c5b42334d7a5f14dcd00e014226f04f790c123 [INFO] running `Command { std: "docker" "start" "-a" "afd5aaea398ddfb27f4bde7a05c5b42334d7a5f14dcd00e014226f04f790c123", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "afd5aaea398ddfb27f4bde7a05c5b42334d7a5f14dcd00e014226f04f790c123", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "afd5aaea398ddfb27f4bde7a05c5b42334d7a5f14dcd00e014226f04f790c123", kill_on_drop: false }` [INFO] [stdout] afd5aaea398ddfb27f4bde7a05c5b42334d7a5f14dcd00e014226f04f790c123 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] f6bd8c39c83f9fd8682e3b7f62ed10e69b1b0d26415c1e33083c311c6de4968e [INFO] running `Command { std: "docker" "start" "-a" "f6bd8c39c83f9fd8682e3b7f62ed10e69b1b0d26415c1e33083c311c6de4968e", kill_on_drop: false }` [INFO] [stderr] Checking log v0.4.22 [INFO] [stderr] Checking zune-core v0.5.0-rc2 [INFO] [stderr] Checking zune-bmp v0.5.0-rc4 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused variable: `size` [INFO] [stdout] --> src/decoder.rs:334:21 [INFO] [stdout] | [INFO] [stdout] 334 | let size = self.bytes.get_u32_le_err()?; [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_size` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `x_pixels` [INFO] [stdout] --> src/decoder.rs:335:21 [INFO] [stdout] | [INFO] [stdout] 335 | let x_pixels = self.bytes.get_u32_le_err()?; [INFO] [stdout] | ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_x_pixels` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `y_pixels` [INFO] [stdout] --> src/decoder.rs:336:21 [INFO] [stdout] | [INFO] [stdout] 336 | let y_pixels = self.bytes.get_u32_le_err()?; [INFO] [stdout] | ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_y_pixels` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `color_used` [INFO] [stdout] --> src/decoder.rs:337:21 [INFO] [stdout] | [INFO] [stdout] 337 | let color_used = self.bytes.get_u32_le_err()?; [INFO] [stdout] | ^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_color_used` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `important_colors` [INFO] [stdout] --> src/decoder.rs:338:21 [INFO] [stdout] | [INFO] [stdout] 338 | let important_colors = self.bytes.get_u32_le_err()?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_important_colors` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `intent` is assigned to, but never used [INFO] [stdout] --> src/decoder.rs:381:29 [INFO] [stdout] | [INFO] [stdout] 381 | let mut intent = None; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: consider using `_intent` instead [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `intent` is never read [INFO] [stdout] --> src/decoder.rs:384:30 [INFO] [stdout] | [INFO] [stdout] 384 | 1 => intent = Some(RenderingIntent::AbsoluteColorimetric), [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] = note: `#[warn(unused_assignments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `intent` is never read [INFO] [stdout] --> src/decoder.rs:385:30 [INFO] [stdout] | [INFO] [stdout] 385 | 2 => intent = Some(RenderingIntent::Saturation), [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `intent` is never read [INFO] [stdout] --> src/decoder.rs:386:30 [INFO] [stdout] | [INFO] [stdout] 386 | 4 => intent = Some(RenderingIntent::RelativeColorimetric), [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `intent` is never read [INFO] [stdout] --> src/decoder.rs:387:30 [INFO] [stdout] | [INFO] [stdout] 387 | 8 => intent = Some(RenderingIntent::Perceptual), [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `size` [INFO] [stdout] --> src/decoder.rs:334:21 [INFO] [stdout] | [INFO] [stdout] 334 | let size = self.bytes.get_u32_le_err()?; [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_size` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `x_pixels` [INFO] [stdout] --> src/decoder.rs:335:21 [INFO] [stdout] | [INFO] [stdout] 335 | let x_pixels = self.bytes.get_u32_le_err()?; [INFO] [stdout] | ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_x_pixels` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `y_pixels` [INFO] [stdout] --> src/decoder.rs:336:21 [INFO] [stdout] | [INFO] [stdout] 336 | let y_pixels = self.bytes.get_u32_le_err()?; [INFO] [stdout] | ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_y_pixels` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `color_used` [INFO] [stdout] --> src/decoder.rs:337:21 [INFO] [stdout] | [INFO] [stdout] 337 | let color_used = self.bytes.get_u32_le_err()?; [INFO] [stdout] | ^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_color_used` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `important_colors` [INFO] [stdout] --> src/decoder.rs:338:21 [INFO] [stdout] | [INFO] [stdout] 338 | let important_colors = self.bytes.get_u32_le_err()?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_important_colors` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `intent` is assigned to, but never used [INFO] [stdout] --> src/decoder.rs:381:29 [INFO] [stdout] | [INFO] [stdout] 381 | let mut intent = None; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: consider using `_intent` instead [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `intent` is never read [INFO] [stdout] --> src/decoder.rs:384:30 [INFO] [stdout] | [INFO] [stdout] 384 | 1 => intent = Some(RenderingIntent::AbsoluteColorimetric), [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] = note: `#[warn(unused_assignments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `intent` is never read [INFO] [stdout] --> src/decoder.rs:385:30 [INFO] [stdout] | [INFO] [stdout] 385 | 2 => intent = Some(RenderingIntent::Saturation), [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `intent` is never read [INFO] [stdout] --> src/decoder.rs:386:30 [INFO] [stdout] | [INFO] [stdout] 386 | 4 => intent = Some(RenderingIntent::RelativeColorimetric), [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `intent` is never read [INFO] [stdout] --> src/decoder.rs:387:30 [INFO] [stdout] | [INFO] [stdout] 387 | 8 => intent = Some(RenderingIntent::Perceptual), [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/decoder.rs:254:20 [INFO] [stdout] | [INFO] [stdout] 252 | pub fn new_with_options(data: T, options: DecoderOptions) -> BmpDecoder { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 253 | BmpDecoder { [INFO] [stdout] 254 | bytes: ZReader::new(data), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 10 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `zune-bmp` (lib test) due to 2 previous errors; 10 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/decoder.rs:254:20 [INFO] [stdout] | [INFO] [stdout] 252 | pub fn new_with_options(data: T, options: DecoderOptions) -> BmpDecoder { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 253 | BmpDecoder { [INFO] [stdout] 254 | bytes: ZReader::new(data), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 10 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `zune-bmp` (lib) due to 2 previous errors; 10 warnings emitted [INFO] running `Command { std: "docker" "inspect" "f6bd8c39c83f9fd8682e3b7f62ed10e69b1b0d26415c1e33083c311c6de4968e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f6bd8c39c83f9fd8682e3b7f62ed10e69b1b0d26415c1e33083c311c6de4968e", kill_on_drop: false }` [INFO] [stdout] f6bd8c39c83f9fd8682e3b7f62ed10e69b1b0d26415c1e33083c311c6de4968e