[INFO] fetching crate zopfli 0.8.1... [INFO] checking zopfli-0.8.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate zopfli 0.8.1 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate zopfli 0.8.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate zopfli 0.8.1 [INFO] finished tweaking crates.io crate zopfli 0.8.1 [INFO] tweaked toml for crates.io crate zopfli 0.8.1 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] crate crates.io crate zopfli 0.8.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 338feceb1ec7ff1fb84ecd055ab7d5a45c864408b863d0b71062fe230c34a14a [INFO] running `Command { std: "docker" "start" "-a" "338feceb1ec7ff1fb84ecd055ab7d5a45c864408b863d0b71062fe230c34a14a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "338feceb1ec7ff1fb84ecd055ab7d5a45c864408b863d0b71062fe230c34a14a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "338feceb1ec7ff1fb84ecd055ab7d5a45c864408b863d0b71062fe230c34a14a", kill_on_drop: false }` [INFO] [stdout] 338feceb1ec7ff1fb84ecd055ab7d5a45c864408b863d0b71062fe230c34a14a [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 66a8a50574c7b0364ce72eec97b5933ec2484e98244d45a12be8b05e950cc18f [INFO] running `Command { std: "docker" "start" "-a" "66a8a50574c7b0364ce72eec97b5933ec2484e98244d45a12be8b05e950cc18f", kill_on_drop: false }` [INFO] [stderr] Compiling rustix v0.38.34 [INFO] [stderr] Compiling proc-macro2 v1.0.82 [INFO] [stderr] Compiling crc32fast v1.4.0 [INFO] [stderr] Checking bitflags v2.5.0 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking fastrand v2.1.0 [INFO] [stderr] Checking wait-timeout v0.2.0 [INFO] [stderr] Checking simd-adler32 v0.3.7 [INFO] [stderr] Checking lockfree-object-pool v0.1.5 [INFO] [stderr] Checking log v0.4.21 [INFO] [stderr] Checking quick-error v1.2.3 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking rand_xorshift v0.3.0 [INFO] [stderr] Checking unarray v0.1.4 [INFO] [stderr] Checking regex-syntax v0.8.3 [INFO] [stderr] Checking miniz_oxide v0.7.3 [INFO] [stderr] Checking zopfli v0.8.1 (/opt/rustwide/workdir) [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/deflate.rs:55:29 [INFO] [stdout] | [INFO] [stdout] 48 | pub fn new(options: Options, btype: BlockType, sink: W) -> Self { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 55 | bitwise_writer: Some(BitwiseWriter::new(sink)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/deflate.rs:67:13 [INFO] [stdout] | [INFO] [stdout] 64 | pub fn new_buffered(options: Options, btype: BlockType, sink: W) -> std::io::BufWriter { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 67 | Self::new(options, btype, sink), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/deflate.rs:80:9 [INFO] [stdout] | [INFO] [stdout] 79 | pub fn finish(mut self) -> Result { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 80 | self._finish().map(|sink| sink.unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/deflate.rs:135:12 [INFO] [stdout] | [INFO] [stdout] 132 | let mut bitwise_writer = self.bitwise_writer.take().unwrap(); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 135 | Ok(Some(bitwise_writer.out)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/gzip.rs:32:12 [INFO] [stdout] | [INFO] [stdout] 19 | pub fn new(options: Options, btype: BlockType, mut sink: W) -> Result { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 32 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 33 | | deflate_encoder: Some(DeflateEncoder::new(options, btype, sink)), [INFO] [stdout] 34 | | crc32_hasher: crc32fast::Hasher::new(), [INFO] [stdout] 35 | | input_size: 0, [INFO] [stdout] 36 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/gzip.rs:49:12 [INFO] [stdout] | [INFO] [stdout] 47 | sink: W, [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 48 | ) -> Result, Error> { [INFO] [stdout] 49 | Ok(std::io::BufWriter::with_capacity( [INFO] [stdout] | ____________^ [INFO] [stdout] 50 | | crate::util::ZOPFLI_MASTER_BLOCK_SIZE, [INFO] [stdout] 51 | | Self::new(options, btype, sink)?, [INFO] [stdout] 52 | | )) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/gzip.rs:64:9 [INFO] [stdout] | [INFO] [stdout] 63 | pub fn finish(mut self) -> Result { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 64 | self._finish().map(|sink| sink.unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/gzip.rs:77:12 [INFO] [stdout] | [INFO] [stdout] 72 | let mut sink = self.deflate_encoder.take().unwrap().finish()?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 77 | Ok(Some(sink)) [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/iter.rs:20:20 [INFO] [stdout] | [INFO] [stdout] 18 | fn flag_last(self) -> FlagLastIterator { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 19 | FlagLastIterator { [INFO] [stdout] 20 | inner: self.peekable(), [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/util.rs:47:11 [INFO] [stdout] | [INFO] [stdout] 46 | pub fn boxed_array(element: T) -> Box<[T; N]> { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 47 | match vec![element; N].into_boxed_slice().try_into() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/zlib.rs:28:12 [INFO] [stdout] | [INFO] [stdout] 18 | pub fn new(options: Options, btype: BlockType, mut sink: W) -> Result { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 28 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 29 | | deflate_encoder: Some(DeflateEncoder::new(options, btype, sink)), [INFO] [stdout] 30 | | adler_hasher: simd_adler32::Adler32::new(), [INFO] [stdout] 31 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/zlib.rs:44:12 [INFO] [stdout] | [INFO] [stdout] 42 | sink: W, [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 43 | ) -> Result, Error> { [INFO] [stdout] 44 | Ok(std::io::BufWriter::with_capacity( [INFO] [stdout] | ____________^ [INFO] [stdout] 45 | | crate::util::ZOPFLI_MASTER_BLOCK_SIZE, [INFO] [stdout] 46 | | Self::new(options, btype, sink)?, [INFO] [stdout] 47 | | )) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/zlib.rs:59:9 [INFO] [stdout] | [INFO] [stdout] 58 | pub fn finish(mut self) -> Result { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 59 | self._finish().map(|sink| sink.unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/zlib.rs:71:12 [INFO] [stdout] | [INFO] [stdout] 67 | let mut sink = self.deflate_encoder.take().unwrap().finish()?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 71 | Ok(Some(sink)) [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 14 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `zopfli` (lib) due to 15 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "66a8a50574c7b0364ce72eec97b5933ec2484e98244d45a12be8b05e950cc18f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "66a8a50574c7b0364ce72eec97b5933ec2484e98244d45a12be8b05e950cc18f", kill_on_drop: false }` [INFO] [stdout] 66a8a50574c7b0364ce72eec97b5933ec2484e98244d45a12be8b05e950cc18f