[INFO] fetching crate zopen 1.0.0... [INFO] checking zopen-1.0.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate zopen 1.0.0 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate zopen 1.0.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate zopen 1.0.0 [INFO] finished tweaking crates.io crate zopen 1.0.0 [INFO] tweaked toml for crates.io crate zopen 1.0.0 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 36 packages to latest compatible versions [INFO] [stderr] Adding linux-raw-sys v0.4.14 (latest: v0.6.5) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 456bef3f398161f5a6e1e6de6c4706f6aa990ce044445f99450a3b2ccdd92392 [INFO] running `Command { std: "docker" "start" "-a" "456bef3f398161f5a6e1e6de6c4706f6aa990ce044445f99450a3b2ccdd92392", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "456bef3f398161f5a6e1e6de6c4706f6aa990ce044445f99450a3b2ccdd92392", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "456bef3f398161f5a6e1e6de6c4706f6aa990ce044445f99450a3b2ccdd92392", kill_on_drop: false }` [INFO] [stdout] 456bef3f398161f5a6e1e6de6c4706f6aa990ce044445f99450a3b2ccdd92392 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 4a580d1ba72e80186ef9032c6086a5cc281b2ff4cf4906ff337e3f786b9f2467 [INFO] running `Command { std: "docker" "start" "-a" "4a580d1ba72e80186ef9032c6086a5cc281b2ff4cf4906ff337e3f786b9f2467", kill_on_drop: false }` [INFO] [stderr] Compiling rustix v0.38.35 [INFO] [stderr] Checking linux-raw-sys v0.4.14 [INFO] [stderr] Checking bitflags v2.6.0 [INFO] [stderr] Checking once_cell v1.19.0 [INFO] [stderr] Checking fastrand v2.1.1 [INFO] [stderr] Checking cfg-if v1.0.0 [INFO] [stderr] Checking zopen v1.0.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unexpected `cfg` condition value: `flate2` [INFO] [stdout] --> src/lib.rs:80:7 [INFO] [stdout] | [INFO] [stdout] 80 | #[cfg(feature = "flate2")] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: expected values for `feature` are: `all`, `bzip2`, `defaults`, `gzip`, `xz`, and `zstd` [INFO] [stdout] = help: consider adding `flate2` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: `#[warn(unexpected_cfgs)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `flate2` [INFO] [stdout] --> src/lib.rs:98:11 [INFO] [stdout] | [INFO] [stdout] 98 | #[cfg(not(feature = "flate2"))] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: expected values for `feature` are: `all`, `bzip2`, `defaults`, `gzip`, `xz`, and `zstd` [INFO] [stdout] = help: consider adding `flate2` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `rust-lzma` [INFO] [stdout] --> src/lib.rs:157:7 [INFO] [stdout] | [INFO] [stdout] 157 | #[cfg(feature = "rust-lzma")] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: expected values for `feature` are: `all`, `bzip2`, `defaults`, `gzip`, `xz`, and `zstd` [INFO] [stdout] = help: consider adding `rust-lzma` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `rust-lzma` [INFO] [stdout] --> src/lib.rs:216:11 [INFO] [stdout] | [INFO] [stdout] 216 | #[cfg(not(feature = "rust-lzma"))] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: expected values for `feature` are: `all`, `bzip2`, `defaults`, `gzip`, `xz`, and `zstd` [INFO] [stdout] = help: consider adding `rust-lzma` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:286:8 [INFO] [stdout] | [INFO] [stdout] 284 | pub fn read(path: impl AsRef) -> std::io::Result> { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 285 | let ext = path.as_ref().extension().unwrap_or_else(|| OsStr::new("")); [INFO] [stdout] 286 | Ok(if ext == "gz" { [INFO] [stdout] | ________^ [INFO] [stdout] 287 | | Box::new(gz::read(path)?) [INFO] [stdout] 288 | | } else if ext == "bz2" { [INFO] [stdout] 289 | | Box::new(bzip::read(path)?) [INFO] [stdout] ... | [INFO] [stdout] 295 | | Box::new(File::open(path)?) [INFO] [stdout] 296 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:312:8 [INFO] [stdout] | [INFO] [stdout] 310 | pub fn write(path: impl AsRef) -> std::io::Result> { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 311 | let ext = path.as_ref().extension().unwrap_or_else(|| OsStr::new("")); [INFO] [stdout] 312 | Ok(if ext == "gz" { [INFO] [stdout] | ________^ [INFO] [stdout] 313 | | Box::new(gz::write(path)?) [INFO] [stdout] 314 | | } else if ext == "bz2" { [INFO] [stdout] 315 | | Box::new(bzip::write(path)?) [INFO] [stdout] ... | [INFO] [stdout] 321 | | Box::new(File::create(path)?) [INFO] [stdout] 322 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tool.rs:88:12 [INFO] [stdout] | [INFO] [stdout] 83 | pub fn new(cmd: &str, args: I) -> io::Result [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 88 | Ok(ToolRead(Some( [INFO] [stdout] | ____________^ [INFO] [stdout] 89 | | Command::new(cmd) [INFO] [stdout] 90 | | .env_clear() [INFO] [stdout] 91 | | .args(args) [INFO] [stdout] ... | [INFO] [stdout] 95 | | .spawn()?, [INFO] [stdout] 96 | | ))) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tool.rs:107:12 [INFO] [stdout] | [INFO] [stdout] 102 | pub fn new_with_file(cmd: &str, args: I, path: impl AsRef) -> io::Result [INFO] [stdout] | ------- ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 107 | Ok(ToolRead(Some( [INFO] [stdout] | ____________^ [INFO] [stdout] 108 | | Command::new(cmd) [INFO] [stdout] 109 | | .env_clear() [INFO] [stdout] 110 | | .args(args) [INFO] [stdout] ... | [INFO] [stdout] 114 | | .spawn()?, [INFO] [stdout] 115 | | ))) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tool.rs:147:12 [INFO] [stdout] | [INFO] [stdout] 142 | pub fn new(cmd: &str, args: I) -> io::Result [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 147 | Ok(ToolWrite( [INFO] [stdout] | ____________^ [INFO] [stdout] 148 | | Command::new(cmd) [INFO] [stdout] 149 | | .env_clear() [INFO] [stdout] 150 | | .args(args) [INFO] [stdout] ... | [INFO] [stdout] 153 | | .spawn()?, [INFO] [stdout] 154 | | )) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tool.rs:165:12 [INFO] [stdout] | [INFO] [stdout] 160 | pub fn new_with_file(cmd: &str, args: I, path: impl AsRef) -> io::Result [INFO] [stdout] | ------- ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 165 | Ok(ToolWrite( [INFO] [stdout] | ____________^ [INFO] [stdout] 166 | | Command::new(cmd) [INFO] [stdout] 167 | | .env_clear() [INFO] [stdout] 168 | | .args(args) [INFO] [stdout] ... | [INFO] [stdout] 171 | | .spawn()?, [INFO] [stdout] 172 | | )) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `zopen` (lib) due to 7 previous errors; 4 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "4a580d1ba72e80186ef9032c6086a5cc281b2ff4cf4906ff337e3f786b9f2467", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4a580d1ba72e80186ef9032c6086a5cc281b2ff4cf4906ff337e3f786b9f2467", kill_on_drop: false }` [INFO] [stdout] 4a580d1ba72e80186ef9032c6086a5cc281b2ff4cf4906ff337e3f786b9f2467