[INFO] fetching crate zookeeper-async 5.0.0... [INFO] checking zookeeper-async-5.0.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate zookeeper-async 5.0.0 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate zookeeper-async 5.0.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate zookeeper-async 5.0.0 [INFO] finished tweaking crates.io crate zookeeper-async 5.0.0 [INFO] tweaked toml for crates.io crate zookeeper-async 5.0.0 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] crate crates.io crate zookeeper-async 5.0.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 62a37727f73a6ac57dba1a30cde07444b3e3655ff06668379cd13f2e67979e54 [INFO] running `Command { std: "docker" "start" "-a" "62a37727f73a6ac57dba1a30cde07444b3e3655ff06668379cd13f2e67979e54", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "62a37727f73a6ac57dba1a30cde07444b3e3655ff06668379cd13f2e67979e54", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "62a37727f73a6ac57dba1a30cde07444b3e3655ff06668379cd13f2e67979e54", kill_on_drop: false }` [INFO] [stdout] 62a37727f73a6ac57dba1a30cde07444b3e3655ff06668379cd13f2e67979e54 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 6f7584fae260cbc8c1cd252d4f8b425b1795aea11a0485f1bc742f4b81427a86 [INFO] running `Command { std: "docker" "start" "-a" "6f7584fae260cbc8c1cd252d4f8b425b1795aea11a0485f1bc742f4b81427a86", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.78 [INFO] [stderr] Compiling libc v0.2.153 [INFO] [stderr] Checking pin-project-lite v0.2.13 [INFO] [stderr] Compiling hashbrown v0.14.3 [INFO] [stderr] Compiling toml_datetime v0.6.5 [INFO] [stderr] Checking memchr v2.7.1 [INFO] [stderr] Compiling slab v0.4.9 [INFO] [stderr] Compiling async-trait v0.1.77 [INFO] [stderr] Checking bytes v1.5.0 [INFO] [stderr] Checking log v0.4.21 [INFO] [stderr] Checking overload v0.1.1 [INFO] [stderr] Checking sharded-slab v0.1.7 [INFO] [stderr] Checking smallvec v1.13.1 [INFO] [stderr] Checking snowflake v1.3.0 [INFO] [stderr] Checking nu-ansi-term v0.46.0 [INFO] [stderr] Checking tracing-log v0.2.0 [INFO] [stderr] Compiling quote v1.0.35 [INFO] [stderr] Checking tracing-subscriber v0.3.18 [INFO] [stderr] Compiling syn v2.0.52 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling indexmap v2.2.5 [INFO] [stderr] Checking mio v0.8.11 [INFO] [stderr] Checking socket2 v0.5.6 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking getrandom v0.2.12 [INFO] [stderr] Checking uuid v1.7.0 [INFO] [stderr] Compiling toml_edit v0.21.1 [INFO] [stderr] Compiling derive_more v0.99.17 [INFO] [stderr] Compiling proc-macro-crate v3.1.0 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Compiling tokio-macros v2.2.0 [INFO] [stderr] Compiling num_enum_derive v0.7.2 [INFO] [stderr] Checking tokio v1.36.0 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking num_enum v0.7.2 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Checking zookeeper-async v5.0.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/recipes/cache.rs:346:30 [INFO] [stdout] | [INFO] [stdout] 306 | let (ops_chan_tx, mut ops_chan_rx) = unbounded_channel(); [INFO] [stdout] | ----------- ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 307 | let ops_chan_rx_zk_events = ops_chan_tx.clone(); [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 316 | let zk = self.zk.clone(); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 317 | let path = self.path.clone(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 318 | let data = self.data.clone(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 319 | let event_listeners = self.event_listeners.clone(); [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 346 | self.offer_operation(Operation::Initialize) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/recipes/cache.rs:310:13 [INFO] [stdout] | [INFO] [stdout] 307 | let ops_chan_rx_zk_events = ops_chan_tx.clone(); [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 310 | / ops_chan_rx_zk_events [INFO] [stdout] 311 | | .send(Operation::ZkStateEvent(s)) [INFO] [stdout] | |_________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/recipes/leader_latch.rs:94:19 [INFO] [stdout] | [INFO] [stdout] 89 | pub fn new(zk: Arc, id: String, parent_path: String) -> Self { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 94 | path: Arc::default(), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/recipes/leader_latch.rs:95:20 [INFO] [stdout] | [INFO] [stdout] 89 | pub fn new(zk: Arc, id: String, parent_path: String) -> Self { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 95 | state: Arc::new(AtomicU8::new(State::Latent as u8)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/recipes/leader_latch.rs:96:27 [INFO] [stdout] | [INFO] [stdout] 89 | pub fn new(zk: Arc, id: String, parent_path: String) -> Self { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 96 | subscription: Arc::default(), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/recipes/leader_latch.rs:97:29 [INFO] [stdout] | [INFO] [stdout] 89 | pub fn new(zk: Arc, id: String, parent_path: String) -> Self { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 97 | has_leadership: Arc::default(), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/recipes/leader_latch.rs:123:37 [INFO] [stdout] | [INFO] [stdout] 123 | self.check_leadership().await [INFO] [stdout] | ^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/recipes/shared_lock.rs:48:20 [INFO] [stdout] | [INFO] [stdout] 46 | fn new(path: String, zookeeper: Arc) -> Self { [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 47 | LockGuard { [INFO] [stdout] 48 | state: Mutex::new(LockGuardState { [INFO] [stdout] | ____________________^ [INFO] [stdout] 49 | | id: None, [INFO] [stdout] 50 | | prefix: None, [INFO] [stdout] 51 | | path, [INFO] [stdout] 52 | | zookeeper, [INFO] [stdout] 53 | | acquired: false, [INFO] [stdout] 54 | | }), [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 8 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `zookeeper-async` (lib) due to 9 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/recipes/cache.rs:346:30 [INFO] [stdout] | [INFO] [stdout] 306 | let (ops_chan_tx, mut ops_chan_rx) = unbounded_channel(); [INFO] [stdout] | ----------- ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 307 | let ops_chan_rx_zk_events = ops_chan_tx.clone(); [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 316 | let zk = self.zk.clone(); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 317 | let path = self.path.clone(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 318 | let data = self.data.clone(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 319 | let event_listeners = self.event_listeners.clone(); [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 346 | self.offer_operation(Operation::Initialize) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/recipes/cache.rs:310:13 [INFO] [stdout] | [INFO] [stdout] 307 | let ops_chan_rx_zk_events = ops_chan_tx.clone(); [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 310 | / ops_chan_rx_zk_events [INFO] [stdout] 311 | | .send(Operation::ZkStateEvent(s)) [INFO] [stdout] | |_________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/recipes/leader_latch.rs:94:19 [INFO] [stdout] | [INFO] [stdout] 89 | pub fn new(zk: Arc, id: String, parent_path: String) -> Self { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 94 | path: Arc::default(), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/recipes/leader_latch.rs:95:20 [INFO] [stdout] | [INFO] [stdout] 89 | pub fn new(zk: Arc, id: String, parent_path: String) -> Self { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 95 | state: Arc::new(AtomicU8::new(State::Latent as u8)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/recipes/leader_latch.rs:96:27 [INFO] [stdout] | [INFO] [stdout] 89 | pub fn new(zk: Arc, id: String, parent_path: String) -> Self { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 96 | subscription: Arc::default(), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/recipes/leader_latch.rs:97:29 [INFO] [stdout] | [INFO] [stdout] 89 | pub fn new(zk: Arc, id: String, parent_path: String) -> Self { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 97 | has_leadership: Arc::default(), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/recipes/leader_latch.rs:123:37 [INFO] [stdout] | [INFO] [stdout] 123 | self.check_leadership().await [INFO] [stdout] | ^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/recipes/shared_lock.rs:48:20 [INFO] [stdout] | [INFO] [stdout] 46 | fn new(path: String, zookeeper: Arc) -> Self { [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 47 | LockGuard { [INFO] [stdout] 48 | state: Mutex::new(LockGuardState { [INFO] [stdout] | ____________________^ [INFO] [stdout] 49 | | id: None, [INFO] [stdout] 50 | | prefix: None, [INFO] [stdout] 51 | | path, [INFO] [stdout] 52 | | zookeeper, [INFO] [stdout] 53 | | acquired: false, [INFO] [stdout] 54 | | }), [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 8 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `zookeeper-async` (lib test) due to 9 previous errors [INFO] running `Command { std: "docker" "inspect" "6f7584fae260cbc8c1cd252d4f8b425b1795aea11a0485f1bc742f4b81427a86", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6f7584fae260cbc8c1cd252d4f8b425b1795aea11a0485f1bc742f4b81427a86", kill_on_drop: false }` [INFO] [stdout] 6f7584fae260cbc8c1cd252d4f8b425b1795aea11a0485f1bc742f4b81427a86