[INFO] fetching crate zone-alloc 0.4.0... [INFO] checking zone-alloc-0.4.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate zone-alloc 0.4.0 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate zone-alloc 0.4.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate zone-alloc 0.4.0 [INFO] finished tweaking crates.io crate zone-alloc 0.4.0 [INFO] tweaked toml for crates.io crate zone-alloc 0.4.0 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 13 packages to latest compatible versions [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 1532045fbfe9c73d1cba3811dd9aebe8f6769062b358d7341fefcae9c102fa6e [INFO] running `Command { std: "docker" "start" "-a" "1532045fbfe9c73d1cba3811dd9aebe8f6769062b358d7341fefcae9c102fa6e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "1532045fbfe9c73d1cba3811dd9aebe8f6769062b358d7341fefcae9c102fa6e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1532045fbfe9c73d1cba3811dd9aebe8f6769062b358d7341fefcae9c102fa6e", kill_on_drop: false }` [INFO] [stdout] 1532045fbfe9c73d1cba3811dd9aebe8f6769062b358d7341fefcae9c102fa6e [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 7310deb69f2dbddc2c6761c457df4e2d038a2ca5eebc51935feb0232c322b76f [INFO] running `Command { std: "docker" "start" "-a" "7310deb69f2dbddc2c6761c457df4e2d038a2ca5eebc51935feb0232c322b76f", kill_on_drop: false }` [INFO] [stderr] Compiling ahash v0.8.11 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking once_cell v1.19.0 [INFO] [stderr] Checking allocator-api2 v0.2.18 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Checking zone-alloc v0.4.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: the feature `return_position_impl_trait_in_trait` has been stable since 1.75.0 and no longer requires an attribute to enable [INFO] [stdout] --> src/lib.rs:168:12 [INFO] [stdout] | [INFO] [stdout] 168 | #![feature(return_position_impl_trait_in_trait)] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(stable_features)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the feature `return_position_impl_trait_in_trait` has been stable since 1.75.0 and no longer requires an attribute to enable [INFO] [stdout] --> src/lib.rs:168:12 [INFO] [stdout] | [INFO] [stdout] 168 | #![feature(return_position_impl_trait_in_trait)] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(stable_features)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `get_mut` is never used [INFO] [stdout] --> src/registry_container.rs:34:8 [INFO] [stdout] | [INFO] [stdout] 24 | pub(crate) trait RegistryContainer { [INFO] [stdout] | ----------------- method in this trait [INFO] [stdout] ... [INFO] [stdout] 34 | fn get_mut<'a, 'b>(&'a mut self, key: &K) -> Option<&'b mut V> [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `contains_key` and `get_mut` are never used [INFO] [stdout] --> src/registry_container.rs:44:8 [INFO] [stdout] | [INFO] [stdout] 41 | pub(crate) trait KeyedRegistryContainer: [INFO] [stdout] | ---------------------- methods in this trait [INFO] [stdout] ... [INFO] [stdout] 44 | fn contains_key(&self, key: &R) -> bool [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 53 | fn get_mut<'a, 'b, R>(&'a mut self, key: &R) -> Option<&'b mut V> [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/arena.rs:179:9 [INFO] [stdout] | [INFO] [stdout] 178 | pub fn alloc(&self, value: T) -> &mut T { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 179 | self.alloc_in_current_block(value) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/arena.rs:197:14 [INFO] [stdout] | [INFO] [stdout] 196 | fn alloc_in_new_block(&self, value: T) -> &mut T { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 197 | &mut self.alloc_extend(iter::once(value))[0] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/keyed_registry.rs:121:39 [INFO] [stdout] | [INFO] [stdout] 121 | .map(|(key, entry)| (key, entry.borrow())) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/keyed_registry.rs:131:39 [INFO] [stdout] | [INFO] [stdout] 131 | .map(|(key, entry)| (key, entry.borrow_mut())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/strong_registry.rs:82:10 [INFO] [stdout] | [INFO] [stdout] 77 | pub fn register_extend(&self, iterable: I) -> (H, H) [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 82 | (H::from(a), H::from(b)) [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/strong_registry.rs:82:22 [INFO] [stdout] | [INFO] [stdout] 77 | pub fn register_extend(&self, iterable: I) -> (H, H) [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 82 | (H::from(a), H::from(b)) [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `zone-alloc` (lib) due to 7 previous errors; 3 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: method `get_mut` is never used [INFO] [stdout] --> src/registry_container.rs:34:8 [INFO] [stdout] | [INFO] [stdout] 24 | pub(crate) trait RegistryContainer { [INFO] [stdout] | ----------------- method in this trait [INFO] [stdout] ... [INFO] [stdout] 34 | fn get_mut<'a, 'b>(&'a mut self, key: &K) -> Option<&'b mut V> [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `contains_key` and `get_mut` are never used [INFO] [stdout] --> src/registry_container.rs:44:8 [INFO] [stdout] | [INFO] [stdout] 41 | pub(crate) trait KeyedRegistryContainer: [INFO] [stdout] | ---------------------- methods in this trait [INFO] [stdout] ... [INFO] [stdout] 44 | fn contains_key(&self, key: &R) -> bool [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 53 | fn get_mut<'a, 'b, R>(&'a mut self, key: &R) -> Option<&'b mut V> [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/arena.rs:179:9 [INFO] [stdout] | [INFO] [stdout] 178 | pub fn alloc(&self, value: T) -> &mut T { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 179 | self.alloc_in_current_block(value) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/arena.rs:197:14 [INFO] [stdout] | [INFO] [stdout] 196 | fn alloc_in_new_block(&self, value: T) -> &mut T { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 197 | &mut self.alloc_extend(iter::once(value))[0] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/arena.rs:484:60 [INFO] [stdout] | [INFO] [stdout] 484 | let iter = (0..100).map(|i| Node::new(None, i, DropCounter(&drop_counter))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/arena.rs:486:66 [INFO] [stdout] | [INFO] [stdout] 486 | let iter = (0..100).map(|i| Node::new(Some(root), i, DropCounter(&drop_counter))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/keyed_registry.rs:121:39 [INFO] [stdout] | [INFO] [stdout] 121 | .map(|(key, entry)| (key, entry.borrow())) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/keyed_registry.rs:131:39 [INFO] [stdout] | [INFO] [stdout] 131 | .map(|(key, entry)| (key, entry.borrow_mut())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/registry.rs:260:60 [INFO] [stdout] | [INFO] [stdout] 260 | let iter = (0..100).map(|i| Node::new(None, i, DropCounter(&drop_counter))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/registry.rs:262:66 [INFO] [stdout] | [INFO] [stdout] 262 | let iter = (0..100).map(|i| Node::new(Some(root), i, DropCounter(&drop_counter))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/registry.rs:340:37 [INFO] [stdout] | [INFO] [stdout] 340 | .all(|(handle, value)| *registry.get_unchecked(handle) == value)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/registry.rs:343:37 [INFO] [stdout] | [INFO] [stdout] 343 | .all(|(handle, value)| *registry.get_unchecked(handle) == value)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/registry.rs:346:37 [INFO] [stdout] | [INFO] [stdout] 346 | .all(|(handle, value)| *registry.get_unchecked(handle) == value)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/registry.rs:349:37 [INFO] [stdout] | [INFO] [stdout] 349 | .all(|(handle, value)| *registry.get_unchecked(handle) == value)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/strong_registry.rs:82:10 [INFO] [stdout] | [INFO] [stdout] 77 | pub fn register_extend(&self, iterable: I) -> (H, H) [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 82 | (H::from(a), H::from(b)) [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/strong_registry.rs:82:22 [INFO] [stdout] | [INFO] [stdout] 77 | pub fn register_extend(&self, iterable: I) -> (H, H) [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 82 | (H::from(a), H::from(b)) [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 14 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `zone-alloc` (lib test) due to 15 previous errors; 3 warnings emitted [INFO] running `Command { std: "docker" "inspect" "7310deb69f2dbddc2c6761c457df4e2d038a2ca5eebc51935feb0232c322b76f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7310deb69f2dbddc2c6761c457df4e2d038a2ca5eebc51935feb0232c322b76f", kill_on_drop: false }` [INFO] [stdout] 7310deb69f2dbddc2c6761c457df4e2d038a2ca5eebc51935feb0232c322b76f