[INFO] fetching crate zng-wgt-undo 0.2.29... [INFO] checking zng-wgt-undo-0.2.29 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate zng-wgt-undo 0.2.29 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate zng-wgt-undo 0.2.29 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate zng-wgt-undo 0.2.29 [INFO] finished tweaking crates.io crate zng-wgt-undo 0.2.29 [INFO] tweaked toml for crates.io crate zng-wgt-undo 0.2.29 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 210 packages to latest compatible versions [INFO] [stderr] Adding android_log-sys v0.2.0 (latest: v0.3.1) [INFO] [stderr] Adding generic-array v0.14.7 (latest: v1.1.0) [INFO] [stderr] Adding hermit-abi v0.3.9 (latest: v0.4.0) [INFO] [stderr] Adding linux-raw-sys v0.4.14 (latest: v0.6.5) [INFO] [stderr] Adding nu-ansi-term v0.46.0 (latest: v0.50.1) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows v0.48.0 (latest: v0.58.0) [INFO] [stderr] Adding windows-sys v0.48.0 (latest: v0.59.0) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] [stderr] Adding windows-targets v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_aarch64_gnullvm v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_aarch64_msvc v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_i686_gnu v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_i686_msvc v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_x86_64_gnu v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_x86_64_gnullvm v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_x86_64_msvc v0.48.5 (latest: v0.52.6) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 114c35dadeb0091aba9f2b9c962d5185a76f5f91a3079e992d03c1a70146835e [INFO] running `Command { std: "docker" "start" "-a" "114c35dadeb0091aba9f2b9c962d5185a76f5f91a3079e992d03c1a70146835e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "114c35dadeb0091aba9f2b9c962d5185a76f5f91a3079e992d03c1a70146835e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "114c35dadeb0091aba9f2b9c962d5185a76f5f91a3079e992d03c1a70146835e", kill_on_drop: false }` [INFO] [stdout] 114c35dadeb0091aba9f2b9c962d5185a76f5f91a3079e992d03c1a70146835e [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 9226d67a503843868b585ef38aae0d5e211ddef3204f3af7e2ec0da54dfebf12 [INFO] running `Command { std: "docker" "start" "-a" "9226d67a503843868b585ef38aae0d5e211ddef3204f3af7e2ec0da54dfebf12", kill_on_drop: false }` [INFO] [stderr] Compiling serde v1.0.209 [INFO] [stderr] Checking tracing-core v0.1.32 [INFO] [stderr] Checking allocator-api2 v0.2.18 [INFO] [stderr] Compiling semver v1.0.23 [INFO] [stderr] Compiling ahash v0.8.11 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking dirs-sys v0.4.1 [INFO] [stderr] Checking futures-core v0.3.30 [INFO] [stderr] Compiling zng-app-context v0.5.6 [INFO] [stderr] Checking concurrent-queue v2.5.0 [INFO] [stderr] Compiling cfg_aliases v0.2.1 [INFO] [stderr] Checking rustc-hash v2.0.0 [INFO] [stderr] Compiling zng-var v0.5.2 [INFO] [stderr] Checking pretty-type-name v1.0.1 [INFO] [stderr] Checking take_mut v0.2.2 [INFO] [stderr] Checking zng-handle v0.2.5 [INFO] [stderr] Checking zng-clone-move v0.2.5 [INFO] [stderr] Checking mio v1.0.2 [INFO] [stderr] Checking spin v0.9.8 [INFO] [stderr] Checking crossbeam-channel v0.5.13 [INFO] [stderr] Checking directories v5.0.1 [INFO] [stderr] Checking futures-sink v0.3.30 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking nanorand v0.7.0 [INFO] [stderr] Checking uuid v1.10.0 [INFO] [stderr] Compiling clap_builder v4.5.15 [INFO] [stderr] Compiling thiserror v1.0.63 [INFO] [stderr] Checking futures-lite v2.3.0 [INFO] [stderr] Compiling zng-view-api v0.8.0 [INFO] [stderr] Checking dunce v1.0.5 [INFO] [stderr] Checking event-listener v5.3.1 [INFO] [stderr] Compiling zng-task v0.4.2 [INFO] [stderr] Checking os_pipe v1.2.1 [INFO] [stderr] Checking shared_child v1.0.1 [INFO] [stderr] Checking sharded-slab v0.1.7 [INFO] [stderr] Checking thread_local v1.1.8 [INFO] [stderr] Checking futures-timer v3.0.3 [INFO] [stderr] Compiling zng-app v0.10.0 [INFO] [stderr] Checking duct v0.13.7 [INFO] [stderr] Checking flume v0.11.0 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Compiling zng-wgt v0.4.12 [INFO] [stderr] Checking tracing-log v0.2.0 [INFO] [stderr] Checking event-listener-strategy v0.5.2 [INFO] [stderr] Checking sha2 v0.10.8 [INFO] [stderr] Checking async-channel v2.3.1 [INFO] [stderr] Checking async-lock v3.4.0 [INFO] [stderr] Checking tracing-subscriber v0.3.18 [INFO] [stderr] Checking blocking v1.6.1 [INFO] [stderr] Checking async-fs v2.1.2 [INFO] [stderr] Compiling clap v4.5.16 [INFO] [stderr] Compiling minifier v0.3.1 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Compiling bytemuck_derive v1.7.1 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Compiling displaydoc v0.2.5 [INFO] [stderr] Compiling linkme-impl v0.3.28 [INFO] [stderr] Compiling zng-var-proc-macros v0.2.8 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Compiling zng-color-proc-macros v0.2.6 [INFO] [stderr] Compiling zng-task-proc-macros v0.2.6 [INFO] [stderr] Checking tinystr v0.7.6 [INFO] [stderr] Compiling unic-langid-impl v0.9.5 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking linkme v0.3.28 [INFO] [stderr] Compiling unic-langid v0.9.5 [INFO] [stderr] Compiling fluent-syntax v0.11.1 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking bytemuck v1.17.1 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking atomic v0.6.0 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Compiling zng-app-proc-macros v0.3.5 [INFO] [stderr] Checking tracing-shared v0.1.5 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking indexmap v2.5.0 [INFO] [stderr] Checking zng-txt v0.2.7 [INFO] [stderr] Checking serde_spanned v0.6.7 [INFO] [stderr] Checking toml_datetime v0.6.8 [INFO] [stderr] Checking bitflags v2.6.0 [INFO] [stderr] Checking euclid v0.22.11 [INFO] [stderr] Checking bincode v1.3.3 [INFO] [stderr] Checking serde_bytes v0.11.15 [INFO] [stderr] Checking serde_variant v0.1.3 [INFO] [stderr] Checking zng-unique-id v0.4.5 [INFO] [stderr] Checking zng-tp-licenses v0.2.7 [INFO] [stderr] Checking toml_edit v0.22.20 [INFO] [stderr] Checking rustix v0.38.35 [INFO] [stderr] Checking zng-state-map v0.3.4 [INFO] [stderr] Checking zng-unit v0.2.7 [INFO] [stderr] Checking toml v0.8.19 [INFO] [stderr] Checking tempfile v3.12.0 [INFO] [stderr] Checking ipc-channel v0.18.2 [INFO] [stderr] Compiling zng-env-proc-macros v0.2.2 [INFO] [stderr] Checking zng-env v0.3.3 [INFO] [stderr] Checking zng-time v0.2.18 [INFO] [stderr] Checking zng-layout v0.2.23 [INFO] [stderr] Checking zng-color v0.3.8 [INFO] [stderr] Checking zng-ext-image v0.2.29 [INFO] [stderr] Checking zng-ext-window v0.3.19 [INFO] [stderr] Checking zng-ext-input v0.5.17 [INFO] [stderr] Checking zng-ext-undo v0.2.29 [INFO] [stderr] Checking zng-wgt-undo v0.2.29 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:31:23 [INFO] [stdout] | [INFO] [stdout] 25 | pub fn undo_scope(child: impl UiNode, is_scope: impl IntoVar) -> impl UiNode { [INFO] [stdout] | ------------------ ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 26 | let mut scope = WidgetUndoScope::new(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 27 | let mut undo_cmd = CommandHandle::dummy(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 28 | let mut redo_cmd = CommandHandle::dummy(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 29 | let mut clear_cmd = CommandHandle::dummy(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 30 | let is_scope = is_scope.into_var(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 31 | match_node(child, move |c, mut op| { [INFO] [stdout] | _______________________^ [INFO] [stdout] 32 | | match &mut op { [INFO] [stdout] 33 | | UiNodeOp::Init => { [INFO] [stdout] 34 | | WIDGET.sub_var(&is_scope); [INFO] [stdout] ... | [INFO] [stdout] 138 | | clear_cmd.set_enabled(can_undo || can_redo); [INFO] [stdout] 139 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:146:23 [INFO] [stdout] | [INFO] [stdout] 144 | pub fn undo_enabled(child: impl UiNode, enabled: impl IntoVar) -> impl UiNode { [INFO] [stdout] | ------------------ --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 145 | let enabled = enabled.into_var(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 146 | match_node(child, move |c, op| { [INFO] [stdout] | _______________________^ [INFO] [stdout] 147 | | if !enabled.get() { [INFO] [stdout] 148 | | UNDO.with_disabled(|| c.op(op)) [INFO] [stdout] 149 | | } [INFO] [stdout] 150 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:31:23 [INFO] [stdout] | [INFO] [stdout] 25 | pub fn undo_scope(child: impl UiNode, is_scope: impl IntoVar) -> impl UiNode { [INFO] [stdout] | ------------------ ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 26 | let mut scope = WidgetUndoScope::new(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 27 | let mut undo_cmd = CommandHandle::dummy(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 28 | let mut redo_cmd = CommandHandle::dummy(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 29 | let mut clear_cmd = CommandHandle::dummy(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 30 | let is_scope = is_scope.into_var(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 31 | match_node(child, move |c, mut op| { [INFO] [stdout] | _______________________^ [INFO] [stdout] 32 | | match &mut op { [INFO] [stdout] 33 | | UiNodeOp::Init => { [INFO] [stdout] 34 | | WIDGET.sub_var(&is_scope); [INFO] [stdout] ... | [INFO] [stdout] 138 | | clear_cmd.set_enabled(can_undo || can_redo); [INFO] [stdout] 139 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:146:23 [INFO] [stdout] | [INFO] [stdout] 144 | pub fn undo_enabled(child: impl UiNode, enabled: impl IntoVar) -> impl UiNode { [INFO] [stdout] | ------------------ --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 145 | let enabled = enabled.into_var(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 146 | match_node(child, move |c, op| { [INFO] [stdout] | _______________________^ [INFO] [stdout] 147 | | if !enabled.get() { [INFO] [stdout] 148 | | UNDO.with_disabled(|| c.op(op)) [INFO] [stdout] 149 | | } [INFO] [stdout] 150 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `zng-wgt-undo` (lib) due to 3 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 2 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `zng-wgt-undo` (lib test) due to 3 previous errors [INFO] running `Command { std: "docker" "inspect" "9226d67a503843868b585ef38aae0d5e211ddef3204f3af7e2ec0da54dfebf12", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9226d67a503843868b585ef38aae0d5e211ddef3204f3af7e2ec0da54dfebf12", kill_on_drop: false }` [INFO] [stdout] 9226d67a503843868b585ef38aae0d5e211ddef3204f3af7e2ec0da54dfebf12