[INFO] fetching crate zksync_consensus_roles 0.1.0-rc.11... [INFO] checking zksync_consensus_roles-0.1.0-rc.11 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate zksync_consensus_roles 0.1.0-rc.11 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate zksync_consensus_roles 0.1.0-rc.11 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate zksync_consensus_roles 0.1.0-rc.11 [INFO] finished tweaking crates.io crate zksync_consensus_roles 0.1.0-rc.11 [INFO] tweaked toml for crates.io crate zksync_consensus_roles 0.1.0-rc.11 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 196 packages to latest compatible versions [INFO] [stderr] Adding addr2line v0.22.0 (latest: v0.24.1) [INFO] [stderr] Adding base64 v0.21.7 (latest: v0.22.1) [INFO] [stderr] Adding bit-vec v0.6.3 (latest: v0.8.0) [INFO] [stderr] Adding fixedbitset v0.4.2 (latest: v0.5.7) [INFO] [stderr] Adding generic-array v0.14.7 (latest: v1.1.0) [INFO] [stderr] Adding gimli v0.29.0 (latest: v0.31.0) [INFO] [stderr] Adding hermit-abi v0.3.9 (latest: v0.4.0) [INFO] [stderr] Adding itertools v0.12.1 (latest: v0.13.0) [INFO] [stderr] Adding linux-raw-sys v0.4.14 (latest: v0.6.5) [INFO] [stderr] Adding logos v0.13.0 (latest: v0.14.1) [INFO] [stderr] Adding logos-codegen v0.13.0 (latest: v0.14.1) [INFO] [stderr] Adding logos-derive v0.13.0 (latest: v0.14.1) [INFO] [stderr] Adding matchers v0.1.0 (latest: v0.2.0) [INFO] [stderr] Adding miette v5.10.0 (latest: v7.2.0) [INFO] [stderr] Adding miette-derive v5.10.0 (latest: v7.2.0) [INFO] [stderr] Adding miniz_oxide v0.7.4 (latest: v0.8.0) [INFO] [stderr] Adding nu-ansi-term v0.46.0 (latest: v0.50.1) [INFO] [stderr] Adding ordered-float v2.10.1 (latest: v4.2.2) [INFO] [stderr] Adding prost v0.12.6 (latest: v0.13.2) [INFO] [stderr] Adding prost-build v0.12.6 (latest: v0.13.2) [INFO] [stderr] Adding prost-derive v0.12.6 (latest: v0.13.2) [INFO] [stderr] Adding prost-reflect v0.12.0 (latest: v0.14.0) [INFO] [stderr] Adding prost-types v0.12.6 (latest: v0.13.2) [INFO] [stderr] Adding protox v0.5.1 (latest: v0.7.1) [INFO] [stderr] Adding protox-parse v0.5.0 (latest: v0.7.0) [INFO] [stderr] Adding rand v0.4.6 (latest: v0.8.5) [INFO] [stderr] Adding rand_core v0.3.1 (latest: v0.6.4) [INFO] [stderr] Adding rand_core v0.4.2 (latest: v0.6.4) [INFO] [stderr] Adding rdrand v0.4.0 (latest: v0.8.3) [INFO] [stderr] Adding regex-automata v0.1.10 (latest: v0.4.7) [INFO] [stderr] Adding regex-syntax v0.6.29 (latest: v0.8.4) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] cf32684b2dcc0bcfa4edb57f817fca77ac3e04e4342aa13a8afc8100b03838a0 [INFO] running `Command { std: "docker" "start" "-a" "cf32684b2dcc0bcfa4edb57f817fca77ac3e04e4342aa13a8afc8100b03838a0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "cf32684b2dcc0bcfa4edb57f817fca77ac3e04e4342aa13a8afc8100b03838a0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "cf32684b2dcc0bcfa4edb57f817fca77ac3e04e4342aa13a8afc8100b03838a0", kill_on_drop: false }` [INFO] [stdout] cf32684b2dcc0bcfa4edb57f817fca77ac3e04e4342aa13a8afc8100b03838a0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] dad098cb11da2ea95b41beb3a4de5b7b04b1b11d013f435b8da09627853f1e9b [INFO] running `Command { std: "docker" "start" "-a" "dad098cb11da2ea95b41beb3a4de5b7b04b1b11d013f435b8da09627853f1e9b", kill_on_drop: false }` [INFO] [stderr] Checking subtle v2.6.1 [INFO] [stderr] Compiling either v1.13.0 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling anyhow v1.0.86 [INFO] [stderr] Checking zeroize v1.8.1 [INFO] [stderr] Compiling serde v1.0.209 [INFO] [stderr] Compiling bytes v1.7.1 [INFO] [stderr] Compiling regex-syntax v0.6.29 [INFO] [stderr] Compiling fnv v1.0.7 [INFO] [stderr] Checking generic-array v0.14.7 [INFO] [stderr] Compiling itertools v0.12.1 [INFO] [stderr] Compiling beef v0.5.2 [INFO] [stderr] Compiling thiserror v1.0.63 [INFO] [stderr] Compiling miette-derive v5.10.0 [INFO] [stderr] Compiling unicode-width v0.1.13 [INFO] [stderr] Compiling rustix v0.38.35 [INFO] [stderr] Compiling linux-raw-sys v0.4.14 [INFO] [stderr] Compiling hashbrown v0.14.5 [INFO] [stderr] Checking block-buffer v0.10.4 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Compiling ordered-float v2.10.1 [INFO] [stderr] Compiling prettyplease v0.2.22 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Compiling bitflags v2.6.0 [INFO] [stderr] Compiling regex-syntax v0.8.4 [INFO] [stderr] Compiling fastrand v2.1.1 [INFO] [stderr] Compiling indexmap v2.5.0 [INFO] [stderr] Compiling miette v5.10.0 [INFO] [stderr] Compiling fixedbitset v0.4.2 [INFO] [stderr] Compiling base64 v0.21.7 [INFO] [stderr] Compiling prost-derive v0.12.6 [INFO] [stderr] Compiling logos-codegen v0.13.0 [INFO] [stderr] Compiling petgraph v0.6.5 [INFO] [stderr] Compiling regex-automata v0.4.7 [INFO] [stderr] Compiling serde-value v0.7.0 [INFO] [stderr] Checking der v0.7.9 [INFO] [stderr] Checking tracing-core v0.1.32 [INFO] [stderr] Compiling prost v0.12.6 [INFO] [stderr] Compiling tempfile v3.12.0 [INFO] [stderr] Compiling multimap v0.10.0 [INFO] [stderr] Compiling log v0.4.22 [INFO] [stderr] Compiling prometheus-client v0.22.3 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking spki v0.7.3 [INFO] [stderr] Compiling logos-derive v0.13.0 [INFO] [stderr] Compiling prost-types v0.12.6 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking signature v2.2.0 [INFO] [stderr] Compiling num-integer v0.1.46 [INFO] [stderr] Compiling logos v0.13.0 [INFO] [stderr] Checking ff v0.13.0 [INFO] [stderr] Compiling prometheus-client-derive-encode v0.4.2 [INFO] [stderr] Checking stable_deref_trait v1.2.0 [INFO] [stderr] Checking keccak v0.1.5 [INFO] [stderr] Checking dtoa v1.0.9 [INFO] [stderr] Checking overload v0.1.1 [INFO] [stderr] Checking sha3 v0.10.8 [INFO] [stderr] Checking nu-ansi-term v0.46.0 [INFO] [stderr] Compiling num-bigint v0.4.6 [INFO] [stderr] Checking sec1 v0.7.3 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking tracing-log v0.2.0 [INFO] [stderr] Compiling regex v1.10.6 [INFO] [stderr] Checking sharded-slab v0.1.7 [INFO] [stderr] Compiling prost-reflect v0.12.0 [INFO] [stderr] Compiling protox-parse v0.5.0 [INFO] [stderr] Compiling prost-build v0.12.6 [INFO] [stderr] Checking regex-automata v0.1.10 [INFO] [stderr] Checking elsa v1.10.0 [INFO] [stderr] Checking group v0.13.0 [INFO] [stderr] Checking pkcs8 v0.10.2 [INFO] [stderr] Compiling curve25519-dalek v4.1.3 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking hmac v0.12.1 [INFO] [stderr] Checking crypto-bigint v0.5.5 [INFO] [stderr] Checking matchers v0.1.0 [INFO] [stderr] Checking thread_local v1.1.8 [INFO] [stderr] Compiling pin-project-internal v1.1.5 [INFO] [stderr] Compiling vise-macros v0.2.0 [INFO] [stderr] Compiling ctor v0.2.8 [INFO] [stderr] Checking signal-hook-registry v1.4.2 [INFO] [stderr] Checking compile-fmt v0.1.0 [INFO] [stderr] Checking tokio v1.40.0 [INFO] [stderr] Checking time v0.3.36 [INFO] [stderr] Checking vise v0.2.0 [INFO] [stderr] Checking tracing-subscriber v0.3.18 [INFO] [stderr] Checking elliptic-curve v0.13.8 [INFO] [stderr] Checking rfc6979 v0.4.0 [INFO] [stderr] Checking pin-project v1.1.5 [INFO] [stderr] Compiling protox v0.5.1 [INFO] [stderr] Compiling blst v0.3.13 [INFO] [stderr] Checking sha2 v0.10.8 [INFO] [stderr] Compiling zksync_protobuf_build v0.1.0-rc.11 [INFO] [stderr] Checking rand v0.4.6 [INFO] [stderr] Compiling ff_derive_ce v0.11.2 [INFO] [stderr] Checking threadpool v1.8.1 [INFO] [stderr] Checking ecdsa v0.16.9 [INFO] [stderr] Checking ed25519 v2.2.3 [INFO] [stderr] Checking unsafe-libyaml v0.2.11 [INFO] [stderr] Checking serde_json v1.0.127 [INFO] [stderr] Checking k256 v0.13.3 [INFO] [stderr] Checking ff_ce v0.14.3 [INFO] [stderr] Checking serde_yaml v0.9.34+deprecated [INFO] [stderr] Checking pairing_ce v0.28.6 [INFO] [stderr] Checking ed25519-dalek v2.1.1 [INFO] [stderr] Checking quick-protobuf v0.8.1 [INFO] [stderr] Checking assert_matches v1.5.0 [INFO] [stderr] Compiling zksync_protobuf v0.1.0-rc.11 [INFO] [stderr] Compiling zksync_consensus_roles v0.1.0-rc.11 (/opt/rustwide/workdir) [INFO] [stderr] Checking zksync_consensus_crypto v0.1.0-rc.11 [INFO] [stderr] Checking zksync_concurrency v0.1.0-rc.11 [INFO] [stderr] Checking zksync_consensus_utils v0.1.0-rc.11 [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/attester/tests.rs:230:18 [INFO] [stdout] | [INFO] [stdout] 230 | key: rng.gen::().public(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/attester/tests.rs:247:18 [INFO] [stdout] | [INFO] [stdout] 247 | key: rng.gen::().public(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/attester/keys/aggregate_signature.rs:42:21 [INFO] [stdout] | [INFO] [stdout] 39 | keys: impl Iterator, [INFO] [stdout] | -------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 42 | .verify(keys.map(|pk| (hash.0.as_bytes().as_slice(), pk))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/attester/keys/aggregate_signature.rs:124:13 [INFO] [stdout] | [INFO] [stdout] 120 | keys: impl Iterator, [INFO] [stdout] | ------------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 124 | keys.filter_map(|(idx, pk)| if self.contains(idx) { Some(pk) } else { None }), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/attester/keys/secret_key.rs:33:18 [INFO] [stdout] | [INFO] [stdout] 25 | pub fn sign_msg(&self, msg: V) -> Signed [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 33 | msg: V::extract(msg).unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/attester/messages/msg.rs:168:9 [INFO] [stdout] | [INFO] [stdout] 167 | pub fn weight_of_keys<'a>(&self, keys: impl Iterator) -> u64 { [INFO] [stdout] | --------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 168 | keys.filter_map(|key| self.weight(key)).sum() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/attester/messages/msg.rs:260:12 [INFO] [stdout] | [INFO] [stdout] 259 | pub fn cast(self) -> Result, BadVariantError> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 260 | Ok(Signed { [INFO] [stdout] | ____________^ [INFO] [stdout] 261 | | msg: V::extract(self.msg.insert())?, [INFO] [stdout] 262 | | key: self.key, [INFO] [stdout] 263 | | sig: self.sig, [INFO] [stdout] 264 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/node/keys.rs:32:18 [INFO] [stdout] | [INFO] [stdout] 27 | pub fn sign_msg>(&self, msg: V) -> Signed { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 32 | msg: V::extract(msg).unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/node/keys.rs:47:45 [INFO] [stdout] | [INFO] [stdout] 47 | ByteFmt::decode(bytes).map(|k| Self(Arc::new(k))) [INFO] [stdout] | - ^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/validator/tests.rs:500:18 [INFO] [stdout] | [INFO] [stdout] 500 | key: rng.gen::().public(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/validator/tests.rs:517:18 [INFO] [stdout] | [INFO] [stdout] 517 | key: rng.gen::().public(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/validator/conv.rs:26:27 [INFO] [stdout] | [INFO] [stdout] 26 | .map(|(i, v)| WeightedValidator::read(v).context(i)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/validator/conv.rs:33:27 [INFO] [stdout] | [INFO] [stdout] 33 | .map(|(i, v)| WeightedAttester::read(v).context(i)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/validator/keys/secret_key.rs:30:18 [INFO] [stdout] | [INFO] [stdout] 25 | pub fn sign_msg>(&self, msg: V) -> Signed { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 30 | msg: V::extract(msg).unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/validator/messages/leader_commit.rs:146:9 [INFO] [stdout] | [INFO] [stdout] 139 | let messages_and_keys = genesis [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 146 | / self.signature [INFO] [stdout] 147 | | .verify_messages(messages_and_keys) [INFO] [stdout] | |_______________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/validator/messages/msg.rs:120:12 [INFO] [stdout] | [INFO] [stdout] 119 | pub fn cast>(self) -> Result, BadVariantError> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 120 | Ok(Signed { [INFO] [stdout] | ____________^ [INFO] [stdout] 121 | | msg: V2::extract(self.msg.insert())?, [INFO] [stdout] 122 | | key: self.key, [INFO] [stdout] 123 | | sig: self.sig, [INFO] [stdout] 124 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/validator/messages/tests.rs:21:16 [INFO] [stdout] | [INFO] [stdout] 21 | .map(|raw| Text::new(raw).decode().unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/validator/messages/tests.rs:32:16 [INFO] [stdout] | [INFO] [stdout] 32 | .map(|raw| Text::new(raw).decode().unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/validator/testonly.rs:54:27 [INFO] [stdout] | [INFO] [stdout] 54 | .map(|w| (rng.gen(), w)) [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/validator/testonly.rs:56:60 [INFO] [stdout] | [INFO] [stdout] 56 | attester_weights: weights.into_iter().map(|w| (rng.gen(), w)).collect(), [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/validator/testonly.rs:162:14 [INFO] [stdout] | [INFO] [stdout] 161 | fn from(spec: SetupSpec) -> Self { [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 162 | Self(SetupInner { [INFO] [stdout] | ______________^ [INFO] [stdout] 163 | | genesis: GenesisRaw { [INFO] [stdout] 164 | | chain_id: spec.chain_id, [INFO] [stdout] 165 | | fork_number: spec.fork_number, [INFO] [stdout] ... | [INFO] [stdout] 190 | | blocks: vec![], [INFO] [stdout] 191 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 21 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `zksync_consensus_roles` (lib test) due to 22 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/attester/keys/aggregate_signature.rs:42:21 [INFO] [stdout] | [INFO] [stdout] 39 | keys: impl Iterator, [INFO] [stdout] | -------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 42 | .verify(keys.map(|pk| (hash.0.as_bytes().as_slice(), pk))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/attester/keys/aggregate_signature.rs:124:13 [INFO] [stdout] | [INFO] [stdout] 120 | keys: impl Iterator, [INFO] [stdout] | ------------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 124 | keys.filter_map(|(idx, pk)| if self.contains(idx) { Some(pk) } else { None }), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/attester/keys/secret_key.rs:33:18 [INFO] [stdout] | [INFO] [stdout] 25 | pub fn sign_msg(&self, msg: V) -> Signed [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 33 | msg: V::extract(msg).unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/attester/messages/msg.rs:168:9 [INFO] [stdout] | [INFO] [stdout] 167 | pub fn weight_of_keys<'a>(&self, keys: impl Iterator) -> u64 { [INFO] [stdout] | --------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 168 | keys.filter_map(|key| self.weight(key)).sum() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/attester/messages/msg.rs:260:12 [INFO] [stdout] | [INFO] [stdout] 259 | pub fn cast(self) -> Result, BadVariantError> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 260 | Ok(Signed { [INFO] [stdout] | ____________^ [INFO] [stdout] 261 | | msg: V::extract(self.msg.insert())?, [INFO] [stdout] 262 | | key: self.key, [INFO] [stdout] 263 | | sig: self.sig, [INFO] [stdout] 264 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/node/keys.rs:32:18 [INFO] [stdout] | [INFO] [stdout] 27 | pub fn sign_msg>(&self, msg: V) -> Signed { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 32 | msg: V::extract(msg).unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/node/keys.rs:47:45 [INFO] [stdout] | [INFO] [stdout] 47 | ByteFmt::decode(bytes).map(|k| Self(Arc::new(k))) [INFO] [stdout] | - ^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/validator/conv.rs:26:27 [INFO] [stdout] | [INFO] [stdout] 26 | .map(|(i, v)| WeightedValidator::read(v).context(i)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/validator/conv.rs:33:27 [INFO] [stdout] | [INFO] [stdout] 33 | .map(|(i, v)| WeightedAttester::read(v).context(i)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/validator/keys/secret_key.rs:30:18 [INFO] [stdout] | [INFO] [stdout] 25 | pub fn sign_msg>(&self, msg: V) -> Signed { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 30 | msg: V::extract(msg).unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/validator/messages/leader_commit.rs:146:9 [INFO] [stdout] | [INFO] [stdout] 139 | let messages_and_keys = genesis [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 146 | / self.signature [INFO] [stdout] 147 | | .verify_messages(messages_and_keys) [INFO] [stdout] | |_______________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/validator/messages/msg.rs:120:12 [INFO] [stdout] | [INFO] [stdout] 119 | pub fn cast>(self) -> Result, BadVariantError> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 120 | Ok(Signed { [INFO] [stdout] | ____________^ [INFO] [stdout] 121 | | msg: V2::extract(self.msg.insert())?, [INFO] [stdout] 122 | | key: self.key, [INFO] [stdout] 123 | | sig: self.sig, [INFO] [stdout] 124 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/validator/testonly.rs:54:27 [INFO] [stdout] | [INFO] [stdout] 54 | .map(|w| (rng.gen(), w)) [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/validator/testonly.rs:56:60 [INFO] [stdout] | [INFO] [stdout] 56 | attester_weights: weights.into_iter().map(|w| (rng.gen(), w)).collect(), [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/validator/testonly.rs:162:14 [INFO] [stdout] | [INFO] [stdout] 161 | fn from(spec: SetupSpec) -> Self { [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 162 | Self(SetupInner { [INFO] [stdout] | ______________^ [INFO] [stdout] 163 | | genesis: GenesisRaw { [INFO] [stdout] 164 | | chain_id: spec.chain_id, [INFO] [stdout] 165 | | fork_number: spec.fork_number, [INFO] [stdout] ... | [INFO] [stdout] 190 | | blocks: vec![], [INFO] [stdout] 191 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 15 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `zksync_consensus_roles` (lib) due to 16 previous errors [INFO] running `Command { std: "docker" "inspect" "dad098cb11da2ea95b41beb3a4de5b7b04b1b11d013f435b8da09627853f1e9b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "dad098cb11da2ea95b41beb3a4de5b7b04b1b11d013f435b8da09627853f1e9b", kill_on_drop: false }` [INFO] [stdout] dad098cb11da2ea95b41beb3a4de5b7b04b1b11d013f435b8da09627853f1e9b