[INFO] fetching crate zksync_consensus_bft 0.1.0-rc.11... [INFO] checking zksync_consensus_bft-0.1.0-rc.11 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate zksync_consensus_bft 0.1.0-rc.11 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate zksync_consensus_bft 0.1.0-rc.11 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate zksync_consensus_bft 0.1.0-rc.11 [INFO] finished tweaking crates.io crate zksync_consensus_bft 0.1.0-rc.11 [INFO] tweaked toml for crates.io crate zksync_consensus_bft 0.1.0-rc.11 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 276 packages to latest compatible versions [INFO] [stderr] Adding addr2line v0.22.0 (latest: v0.24.1) [INFO] [stderr] Adding base64 v0.21.7 (latest: v0.22.1) [INFO] [stderr] Adding bindgen v0.69.4 (latest: v0.70.1) [INFO] [stderr] Adding bit-vec v0.6.3 (latest: v0.8.0) [INFO] [stderr] Adding bitmaps v2.1.0 (latest: v3.2.1) [INFO] [stderr] Adding fixedbitset v0.4.2 (latest: v0.5.7) [INFO] [stderr] Adding generic-array v0.14.7 (latest: v1.1.0) [INFO] [stderr] Adding gimli v0.29.0 (latest: v0.31.0) [INFO] [stderr] Adding hermit-abi v0.3.9 (latest: v0.4.0) [INFO] [stderr] Adding itertools v0.12.1 (latest: v0.13.0) [INFO] [stderr] Adding linux-raw-sys v0.4.14 (latest: v0.6.5) [INFO] [stderr] Adding logos v0.13.0 (latest: v0.14.1) [INFO] [stderr] Adding logos-codegen v0.13.0 (latest: v0.14.1) [INFO] [stderr] Adding logos-derive v0.13.0 (latest: v0.14.1) [INFO] [stderr] Adding matchers v0.1.0 (latest: v0.2.0) [INFO] [stderr] Adding miette v5.10.0 (latest: v7.2.0) [INFO] [stderr] Adding miette-derive v5.10.0 (latest: v7.2.0) [INFO] [stderr] Adding miniz_oxide v0.7.4 (latest: v0.8.0) [INFO] [stderr] Adding nu-ansi-term v0.46.0 (latest: v0.50.1) [INFO] [stderr] Adding ordered-float v2.10.1 (latest: v4.2.2) [INFO] [stderr] Adding prost v0.12.6 (latest: v0.13.2) [INFO] [stderr] Adding prost-build v0.12.6 (latest: v0.13.2) [INFO] [stderr] Adding prost-derive v0.12.6 (latest: v0.13.2) [INFO] [stderr] Adding prost-reflect v0.12.0 (latest: v0.14.0) [INFO] [stderr] Adding prost-types v0.12.6 (latest: v0.13.2) [INFO] [stderr] Adding protox v0.5.1 (latest: v0.7.1) [INFO] [stderr] Adding protox-parse v0.5.0 (latest: v0.7.0) [INFO] [stderr] Adding rand v0.4.6 (latest: v0.8.5) [INFO] [stderr] Adding rand_core v0.3.1 (latest: v0.6.4) [INFO] [stderr] Adding rand_core v0.4.2 (latest: v0.6.4) [INFO] [stderr] Adding rdrand v0.4.0 (latest: v0.8.3) [INFO] [stderr] Adding regex-automata v0.1.10 (latest: v0.4.7) [INFO] [stderr] Adding regex-syntax v0.6.29 (latest: v0.8.4) [INFO] [stderr] Adding rustc-hash v1.1.0 (latest: v2.0.0) [INFO] [stderr] Adding sized-chunks v0.6.5 (latest: v0.7.0) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] [stderr] Adding tower v0.4.13 (latest: v0.5.0) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding which v4.4.2 (latest: v6.0.3) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] [stderr] Adding yansi v0.5.1 (latest: v1.0.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 4eeb77f4231b4f78f1151c5ec406f738eef95beed36d9bf869169b0ffa4c12b6 [INFO] running `Command { std: "docker" "start" "-a" "4eeb77f4231b4f78f1151c5ec406f738eef95beed36d9bf869169b0ffa4c12b6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "4eeb77f4231b4f78f1151c5ec406f738eef95beed36d9bf869169b0ffa4c12b6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4eeb77f4231b4f78f1151c5ec406f738eef95beed36d9bf869169b0ffa4c12b6", kill_on_drop: false }` [INFO] [stdout] 4eeb77f4231b4f78f1151c5ec406f738eef95beed36d9bf869169b0ffa4c12b6 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 27d49520c239f49807b07e33192c4775f5fe5ade9d0f9d520d1a67f2c184048f [INFO] running `Command { std: "docker" "start" "-a" "27d49520c239f49807b07e33192c4775f5fe5ade9d0f9d520d1a67f2c184048f", kill_on_drop: false }` [INFO] [stderr] Checking subtle v2.6.1 [INFO] [stderr] Checking const-oid v0.9.6 [INFO] [stderr] Compiling either v1.13.0 [INFO] [stderr] Compiling parking_lot_core v0.9.10 [INFO] [stderr] Compiling generic-array v0.14.7 [INFO] [stderr] Compiling lock_api v0.4.12 [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Compiling beef v0.5.2 [INFO] [stderr] Compiling anyhow v1.0.86 [INFO] [stderr] Compiling libc v0.2.158 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling bytes v1.7.1 [INFO] [stderr] Compiling regex-syntax v0.6.29 [INFO] [stderr] Checking scopeguard v1.2.0 [INFO] [stderr] Compiling rustix v0.38.35 [INFO] [stderr] Compiling unicode-width v0.1.13 [INFO] [stderr] Checking cpufeatures v0.2.13 [INFO] [stderr] Compiling equivalent v1.0.1 [INFO] [stderr] Compiling hashbrown v0.14.5 [INFO] [stderr] Compiling regex-syntax v0.8.4 [INFO] [stderr] Compiling linux-raw-sys v0.4.14 [INFO] [stderr] Compiling prettyplease v0.2.22 [INFO] [stderr] Compiling bitflags v2.6.0 [INFO] [stderr] Compiling fixedbitset v0.4.2 [INFO] [stderr] Compiling itertools v0.12.1 [INFO] [stderr] Compiling base64 v0.21.7 [INFO] [stderr] Compiling fastrand v2.1.1 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Compiling cfg-if v1.0.0 [INFO] [stderr] Checking signal-hook-registry v1.4.2 [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Compiling log v0.4.22 [INFO] [stderr] Compiling semver v1.0.23 [INFO] [stderr] Compiling multimap v0.10.0 [INFO] [stderr] Checking tracing-core v0.1.32 [INFO] [stderr] Compiling fs_extra v1.3.0 [INFO] [stderr] Compiling dunce v1.0.5 [INFO] [stderr] Compiling prometheus-client v0.22.3 [INFO] [stderr] Compiling paste v1.0.15 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling rustc_version v0.4.1 [INFO] [stderr] Checking ff v0.13.0 [INFO] [stderr] Checking keccak v0.1.5 [INFO] [stderr] Checking dtoa v1.0.9 [INFO] [stderr] Compiling aws-lc-rs v1.8.1 [INFO] [stderr] Checking stable_deref_trait v1.2.0 [INFO] [stderr] Compiling curve25519-dalek v4.1.3 [INFO] [stderr] Checking base16ct v0.2.0 [INFO] [stderr] Compiling jobserver v0.1.32 [INFO] [stderr] Compiling ordered-float v2.10.1 [INFO] [stderr] Compiling num-integer v0.1.46 [INFO] [stderr] Checking overload v0.1.1 [INFO] [stderr] Checking elsa v1.10.0 [INFO] [stderr] Compiling indexmap v2.5.0 [INFO] [stderr] Checking nu-ansi-term v0.46.0 [INFO] [stderr] Checking group v0.13.0 [INFO] [stderr] Checking sharded-slab v0.1.7 [INFO] [stderr] Compiling cc v1.1.15 [INFO] [stderr] Checking tracing-log v0.2.0 [INFO] [stderr] Checking thread_local v1.1.8 [INFO] [stderr] Compiling num-bigint v0.4.6 [INFO] [stderr] Checking compile-fmt v0.1.0 [INFO] [stderr] Checking opaque-debug v0.3.1 [INFO] [stderr] Checking http v1.1.0 [INFO] [stderr] Checking time v0.3.36 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Compiling regex-automata v0.4.7 [INFO] [stderr] Checking rand v0.4.6 [INFO] [stderr] Compiling petgraph v0.6.5 [INFO] [stderr] Checking mirai-annotations v1.12.0 [INFO] [stderr] Checking threadpool v1.8.1 [INFO] [stderr] Compiling cmake v0.1.51 [INFO] [stderr] Checking untrusted v0.9.0 [INFO] [stderr] Checking unsafe-libyaml v0.2.11 [INFO] [stderr] Checking rustls-pki-types v1.8.0 [INFO] [stderr] Compiling rustls v0.23.12 [INFO] [stderr] Checking quick-protobuf v0.8.1 [INFO] [stderr] Checking bit-vec v0.6.3 [INFO] [stderr] Checking atomic-waker v1.1.2 [INFO] [stderr] Checking http-body v1.0.1 [INFO] [stderr] Compiling snow v0.9.6 [INFO] [stderr] Checking bitmaps v2.1.0 [INFO] [stderr] Checking regex-automata v0.1.10 [INFO] [stderr] Compiling im v15.1.0 [INFO] [stderr] Checking tower-layer v0.3.3 [INFO] [stderr] Checking rand_xoshiro v0.6.0 [INFO] [stderr] Checking bytesize v1.3.0 [INFO] [stderr] Compiling aws-lc-sys v0.20.1 [INFO] [stderr] Compiling blst v0.3.13 [INFO] [stderr] Checking build_html v2.5.0 [INFO] [stderr] Checking base64 v0.22.1 [INFO] [stderr] Checking yansi v0.5.1 [INFO] [stderr] Checking diff v0.1.13 [INFO] [stderr] Checking pretty_assertions v1.4.0 [INFO] [stderr] Compiling tempfile v3.12.0 [INFO] [stderr] Checking sized-chunks v0.6.5 [INFO] [stderr] Checking matchers v0.1.0 [INFO] [stderr] Checking regex v1.10.6 [INFO] [stderr] Compiling logos-codegen v0.13.0 [INFO] [stderr] Compiling zeroize_derive v1.4.2 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Compiling prost-derive v0.12.6 [INFO] [stderr] Compiling miette-derive v5.10.0 [INFO] [stderr] Compiling tokio-macros v2.4.0 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Compiling pin-project-internal v1.1.5 [INFO] [stderr] Compiling prometheus-client-derive-encode v0.4.2 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Compiling ctor v0.2.8 [INFO] [stderr] Checking zeroize v1.8.1 [INFO] [stderr] Compiling vise-macros v0.2.0 [INFO] [stderr] Checking der v0.7.9 [INFO] [stderr] Checking tokio v1.40.0 [INFO] [stderr] Compiling curve25519-dalek-derive v0.1.1 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking block-buffer v0.10.4 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Compiling logos-derive v0.13.0 [INFO] [stderr] Compiling thiserror v1.0.63 [INFO] [stderr] Compiling miette v5.10.0 [INFO] [stderr] Checking pin-project v1.1.5 [INFO] [stderr] Checking inout v0.1.3 [INFO] [stderr] Checking universal-hash v0.5.1 [INFO] [stderr] Checking crypto-bigint v0.5.5 [INFO] [stderr] Checking cipher v0.4.4 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking signature v2.2.0 [INFO] [stderr] Compiling logos v0.13.0 [INFO] [stderr] Checking hmac v0.12.1 [INFO] [stderr] Checking sha3 v0.10.8 [INFO] [stderr] Checking sha2 v0.10.8 [INFO] [stderr] Checking vise v0.2.0 [INFO] [stderr] Checking rfc6979 v0.4.0 [INFO] [stderr] Checking tracing-subscriber v0.3.18 [INFO] [stderr] Checking ed25519 v2.2.3 [INFO] [stderr] Checking polyval v0.6.2 [INFO] [stderr] Checking aead v0.5.2 [INFO] [stderr] Checking chacha20 v0.9.1 [INFO] [stderr] Compiling prost v0.12.6 [INFO] [stderr] Checking aes v0.8.4 [INFO] [stderr] Checking ghash v0.5.1 [INFO] [stderr] Checking ctr v0.9.2 [INFO] [stderr] Checking spki v0.7.3 [INFO] [stderr] Checking sec1 v0.7.3 [INFO] [stderr] Checking poly1305 v0.8.0 [INFO] [stderr] Checking pkcs8 v0.10.2 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking blake2 v0.10.6 [INFO] [stderr] Checking prost-types v0.12.6 [INFO] [stderr] Compiling async-trait v0.1.81 [INFO] [stderr] Checking aes-gcm v0.10.3 [INFO] [stderr] Compiling test-casing-macro v0.1.3 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking chacha20poly1305 v0.10.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking test-casing v0.1.3 [INFO] [stderr] Checking elliptic-curve v0.13.8 [INFO] [stderr] Compiling serde v1.0.209 [INFO] [stderr] Checking ed25519-dalek v2.1.1 [INFO] [stderr] Compiling protox-parse v0.5.0 [INFO] [stderr] Compiling prost-build v0.12.6 [INFO] [stderr] Checking http-body-util v0.1.2 [INFO] [stderr] Checking ecdsa v0.16.9 [INFO] [stderr] Checking k256 v0.13.3 [INFO] [stderr] Checking zksync_concurrency v0.1.0-rc.11 [INFO] [stderr] Checking tokio-util v0.7.11 [INFO] [stderr] Checking tower v0.4.13 [INFO] [stderr] Checking h2 v0.4.6 [INFO] [stderr] Checking rustls-webpki v0.102.7 [INFO] [stderr] Checking serde-value v0.7.0 [INFO] [stderr] Checking serde_json v1.0.127 [INFO] [stderr] Checking serde_yaml v0.9.34+deprecated [INFO] [stderr] Checking zksync_consensus_utils v0.1.0-rc.11 [INFO] [stderr] Checking prost-reflect v0.12.0 [INFO] [stderr] Compiling ff_derive_ce v0.11.2 [INFO] [stderr] Checking ff_ce v0.14.3 [INFO] [stderr] Checking pairing_ce v0.28.6 [INFO] [stderr] Checking hyper v1.4.1 [INFO] [stderr] Compiling protox v0.5.1 [INFO] [stderr] Checking hyper-util v0.1.7 [INFO] [stderr] Compiling zksync_protobuf_build v0.1.0-rc.11 [INFO] [stderr] Checking zksync_consensus_crypto v0.1.0-rc.11 [INFO] [stderr] Compiling zksync_protobuf v0.1.0-rc.11 [INFO] [stderr] Compiling zksync_consensus_roles v0.1.0-rc.11 [INFO] [stderr] Compiling zksync_consensus_storage v0.1.0-rc.11 [INFO] [stderr] Compiling zksync_consensus_network v0.1.0-rc.11 [INFO] [stderr] Checking tokio-rustls v0.26.0 [INFO] [stderr] Checking tls-listener v0.10.1 [INFO] [stderr] Checking zksync_consensus_bft v0.1.0-rc.11 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:81:32 [INFO] [stdout] | [INFO] [stdout] 75 | let (replica, replica_send) = [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 81 | s.spawn_bg(async { replica.run(ctx).await.wrap("replica.run()") }); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:82:32 [INFO] [stdout] | [INFO] [stdout] 74 | let (leader, leader_send) = leader::StateMachine::new(ctx, cfg.clone(), pipe.send.clone()); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 82 | s.spawn_bg(async { leader.run(ctx).await.wrap("leader.run()") }); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:84:17 [INFO] [stdout] | [INFO] [stdout] 79 | let prepare_qc_recv = leader.prepare_qc.subscribe(); [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 84 | / leader::StateMachine::run_proposer(ctx, &cfg, prepare_qc_recv, &pipe.send) [INFO] [stdout] 85 | | .await [INFO] [stdout] | |__________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/replica/replica_prepare.rs:85:35 [INFO] [stdout] | [INFO] [stdout] 84 | high_qc.verify(self.config.genesis()).map_err(|err| { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 85 | Error::InvalidMessage(validator::ReplicaPrepareVerifyError::HighQC(err)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/testonly/mod.rs:28:31 [INFO] [stdout] | [INFO] [stdout] 27 | let (send, _) = oneshot::channel(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 28 | InputMessage::Network(ConsensusReq { [INFO] [stdout] | _______________________________^ [INFO] [stdout] 29 | | msg: rng.gen(), [INFO] [stdout] 30 | | ack: send, [INFO] [stdout] 31 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `zksync_consensus_bft` (lib) due to 6 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:81:32 [INFO] [stdout] | [INFO] [stdout] 75 | let (replica, replica_send) = [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 81 | s.spawn_bg(async { replica.run(ctx).await.wrap("replica.run()") }); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:82:32 [INFO] [stdout] | [INFO] [stdout] 74 | let (leader, leader_send) = leader::StateMachine::new(ctx, cfg.clone(), pipe.send.clone()); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 82 | s.spawn_bg(async { leader.run(ctx).await.wrap("leader.run()") }); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:84:17 [INFO] [stdout] | [INFO] [stdout] 79 | let prepare_qc_recv = leader.prepare_qc.subscribe(); [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 84 | / leader::StateMachine::run_proposer(ctx, &cfg, prepare_qc_recv, &pipe.send) [INFO] [stdout] 85 | | .await [INFO] [stdout] | |__________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/replica/replica_prepare.rs:85:35 [INFO] [stdout] | [INFO] [stdout] 84 | high_qc.verify(self.config.genesis()).map_err(|err| { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 85 | Error::InvalidMessage(validator::ReplicaPrepareVerifyError::HighQC(err)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/testonly/mod.rs:28:31 [INFO] [stdout] | [INFO] [stdout] 27 | let (send, _) = oneshot::channel(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 28 | InputMessage::Network(ConsensusReq { [INFO] [stdout] | _______________________________^ [INFO] [stdout] 29 | | msg: rng.gen(), [INFO] [stdout] 30 | | ack: send, [INFO] [stdout] 31 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/testonly/node.rs:59:17 [INFO] [stdout] | [INFO] [stdout] 52 | let (consensus_actor_pipe, consensus_pipe) = pipe::new(); [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 58 | let validator_key = self.net.validator_key.clone().unwrap(); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 59 | / crate::Config { [INFO] [stdout] 60 | | secret_key: validator_key.clone(), [INFO] [stdout] 61 | | block_store: self.block_store.clone(), [INFO] [stdout] 62 | | replica_store: Box::new(in_memory::ReplicaStore::default()), [INFO] [stdout] ... | [INFO] [stdout] 66 | | .run(ctx, consensus_actor_pipe) [INFO] [stdout] 67 | | .await [INFO] [stdout] | |______________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/testonly/run.rs:103:21 [INFO] [stdout] | [INFO] [stdout] 102 | fn from(err: anyhow::Error) -> Self { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 103 | Self::Other(err.into()) [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/testonly/run.rs:206:48 [INFO] [stdout] | [INFO] [stdout] 201 | for (i, node) in nodes.into_iter().enumerate() { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 205 | let mut node = node; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 206 | spec.run(ctx, node.pipe()).await [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/testonly/run.rs:309:10 [INFO] [stdout] | [INFO] [stdout] 228 | let mut recvs = vec![]; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 231 | let mut sends = HashMap::new(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 232 | // Blockstores of nodes, indexed by port; used to simulate the effect of gossip. [INFO] [stdout] 233 | let mut stores = HashMap::new(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 234 | // Outbound gossip relationships to simulate the effects of block fetching. [INFO] [stdout] 235 | let mut gossip_targets = HashMap::new(); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 278 | let (gossip_send, gossip_recv) = channel::unbounded(); [INFO] [stdout] | ----------- ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 309 | .await [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/testonly/run.rs:266:54 [INFO] [stdout] | [INFO] [stdout] 238 | let (actor_pipe, dispatcher_pipe) = pipe::new(); [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 265 | let mut network_pipe = dispatcher_pipe; [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 266 | spec.run(ctx, &mut network_pipe).await [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/testonly/run.rs:303:22 [INFO] [stdout] | [INFO] [stdout] 287 | for (i, (port, recv)) in recvs.into_iter().enumerate() { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 288 | let gossip_send = gossip_send.clone(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 303 | .await [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/testonly/run.rs:306:73 [INFO] [stdout] | [INFO] [stdout] 278 | let (gossip_send, gossip_recv) = channel::unbounded(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 306 | s.spawn(async { twins_gossip_loop(ctx, stores, gossip_recv).await }); [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/testonly/twins/tests.rs:204:5 [INFO] [stdout] | [INFO] [stdout] 183 | items: Vec, [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 187 | let mut acc = BTreeSet::new(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 204 | / acc.into_iter() [INFO] [stdout] 205 | | // Get rid of cases where some partitions were left empty. [INFO] [stdout] 206 | | .filter(|ps| ps.iter().all(|p| !p.is_empty())) [INFO] [stdout] 207 | | // Make it unique so every combination only appears once. [INFO] [stdout] 208 | | .map(BTreeSet::from_iter) [INFO] [stdout] | |_________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/testonly/twins/tests.rs:195:35 [INFO] [stdout] | [INFO] [stdout] 194 | .flat_map(|ps| { [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 195 | (0..ps.len()).map(move |i| { [INFO] [stdout] | ___________________________________^ [INFO] [stdout] 196 | | let mut ps = ps.clone(); [INFO] [stdout] 197 | | ps[i].insert(item.clone()); [INFO] [stdout] 198 | | ps [INFO] [stdout] 199 | | }) [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tests.rs:338:25 [INFO] [stdout] | [INFO] [stdout] 338 | secret_key: sk.clone(), [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 15 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `zksync_consensus_bft` (lib test) due to 16 previous errors [INFO] running `Command { std: "docker" "inspect" "27d49520c239f49807b07e33192c4775f5fe5ade9d0f9d520d1a67f2c184048f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "27d49520c239f49807b07e33192c4775f5fe5ade9d0f9d520d1a67f2c184048f", kill_on_drop: false }` [INFO] [stdout] 27d49520c239f49807b07e33192c4775f5fe5ade9d0f9d520d1a67f2c184048f