[INFO] fetching crate zkstate 0.1.23... [INFO] checking zkstate-0.1.23 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate zkstate 0.1.23 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate zkstate 0.1.23 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate zkstate 0.1.23 [INFO] finished tweaking crates.io crate zkstate 0.1.23 [INFO] tweaked toml for crates.io crate zkstate 0.1.23 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] crate crates.io crate zkstate 0.1.23 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 35860be9d893f80ca7862eb7bd419ec5a3465cd071ed743148afbeaa8d64f761 [INFO] running `Command { std: "docker" "start" "-a" "35860be9d893f80ca7862eb7bd419ec5a3465cd071ed743148afbeaa8d64f761", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "35860be9d893f80ca7862eb7bd419ec5a3465cd071ed743148afbeaa8d64f761", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "35860be9d893f80ca7862eb7bd419ec5a3465cd071ed743148afbeaa8d64f761", kill_on_drop: false }` [INFO] [stdout] 35860be9d893f80ca7862eb7bd419ec5a3465cd071ed743148afbeaa8d64f761 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 94b47f0d12b1025b0734bcdfe6cc91aecc20fe4b704d33b7ddd6fd3ab8dd1bbc [INFO] running `Command { std: "docker" "start" "-a" "94b47f0d12b1025b0734bcdfe6cc91aecc20fe4b704d33b7ddd6fd3ab8dd1bbc", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.28 [INFO] [stderr] Compiling syn v1.0.74 [INFO] [stderr] Compiling serde_derive v1.0.127 [INFO] [stderr] Compiling serde v1.0.127 [INFO] [stderr] Compiling memchr v2.4.0 [INFO] [stderr] Compiling crossbeam-utils v0.8.5 [INFO] [stderr] Compiling serde_json v1.0.66 [INFO] [stderr] Checking slab v0.4.4 [INFO] [stderr] Checking ppv-lite86 v0.2.10 [INFO] [stderr] Compiling anyhow v1.0.43 [INFO] [stderr] Checking itoa v0.4.7 [INFO] [stderr] Checking getrandom v0.2.3 [INFO] [stderr] Checking net2 v0.2.37 [INFO] [stderr] Checking iovec v0.1.4 [INFO] [stderr] Checking lazycell v1.3.0 [INFO] [stderr] Checking time v0.1.43 [INFO] [stderr] Checking regex-syntax v0.6.25 [INFO] [stderr] Checking bytes v0.5.6 [INFO] [stderr] Checking snowflake v1.3.0 [INFO] [stderr] Checking rand_core v0.6.3 [INFO] [stderr] Checking uuid v0.8.2 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking mio v0.6.23 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking crossbeam-channel v0.5.1 [INFO] [stderr] Checking rand v0.8.4 [INFO] [stderr] Compiling quote v1.0.9 [INFO] [stderr] Checking aho-corasick v0.7.18 [INFO] [stderr] Checking mio-extras v2.0.6 [INFO] [stderr] Checking regex v1.5.4 [INFO] [stderr] Checking env_logger v0.9.0 [INFO] [stderr] Compiling zookeeper_derive v0.4.1 [INFO] [stderr] Checking zookeeper v0.6.0 [INFO] [stderr] Checking chrono v0.4.19 [INFO] [stderr] Checking treediff v4.0.0 [INFO] [stderr] Checking zkstate v0.1.23 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:94:17 [INFO] [stdout] | [INFO] [stdout] 90 | pub fn empty(initial_state: T) -> Self { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 91 | let (chan_tx, chan_rx) = crossbeam_channel::unbounded(); [INFO] [stdout] | ------- ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 94 | zk: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:95:20 [INFO] [stdout] | [INFO] [stdout] 90 | pub fn empty(initial_state: T) -> Self { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 91 | let (chan_tx, chan_rx) = crossbeam_channel::unbounded(); [INFO] [stdout] | ------- ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 95 | inner: Arc::new(RwLock::new(initial_state)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:96:20 [INFO] [stdout] | [INFO] [stdout] 90 | pub fn empty(initial_state: T) -> Self { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 91 | let (chan_tx, chan_rx) = crossbeam_channel::unbounded(); [INFO] [stdout] | ------- ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 96 | state: Arc::new(RwLock::new(InternalState { [INFO] [stdout] | ____________________^ [INFO] [stdout] 97 | | id: "empty".to_string(), [INFO] [stdout] 98 | | zk_path: "empty".to_string(), [INFO] [stdout] 99 | | epoch: 0, [INFO] [stdout] ... | [INFO] [stdout] 103 | | chan_tx [INFO] [stdout] 104 | | })) [INFO] [stdout] | |_______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:309:15 [INFO] [stdout] | [INFO] [stdout] 301 | let state = self.state.read().unwrap(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 309 | match self.inner.read() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:334:15 [INFO] [stdout] | [INFO] [stdout] 326 | let state = self.state.read().unwrap(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 334 | match self.inner.read() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `zkstate` (lib test) due to 6 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:94:17 [INFO] [stdout] | [INFO] [stdout] 90 | pub fn empty(initial_state: T) -> Self { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 91 | let (chan_tx, chan_rx) = crossbeam_channel::unbounded(); [INFO] [stdout] | ------- ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 94 | zk: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:95:20 [INFO] [stdout] | [INFO] [stdout] 90 | pub fn empty(initial_state: T) -> Self { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 91 | let (chan_tx, chan_rx) = crossbeam_channel::unbounded(); [INFO] [stdout] | ------- ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 95 | inner: Arc::new(RwLock::new(initial_state)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:96:20 [INFO] [stdout] | [INFO] [stdout] 90 | pub fn empty(initial_state: T) -> Self { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 91 | let (chan_tx, chan_rx) = crossbeam_channel::unbounded(); [INFO] [stdout] | ------- ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 96 | state: Arc::new(RwLock::new(InternalState { [INFO] [stdout] | ____________________^ [INFO] [stdout] 97 | | id: "empty".to_string(), [INFO] [stdout] 98 | | zk_path: "empty".to_string(), [INFO] [stdout] 99 | | epoch: 0, [INFO] [stdout] ... | [INFO] [stdout] 103 | | chan_tx [INFO] [stdout] 104 | | })) [INFO] [stdout] | |_______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:309:15 [INFO] [stdout] | [INFO] [stdout] 301 | let state = self.state.read().unwrap(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 309 | match self.inner.read() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:334:15 [INFO] [stdout] | [INFO] [stdout] 326 | let state = self.state.read().unwrap(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 334 | match self.inner.read() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `zkstate` (lib) due to 6 previous errors [INFO] running `Command { std: "docker" "inspect" "94b47f0d12b1025b0734bcdfe6cc91aecc20fe4b704d33b7ddd6fd3ab8dd1bbc", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "94b47f0d12b1025b0734bcdfe6cc91aecc20fe4b704d33b7ddd6fd3ab8dd1bbc", kill_on_drop: false }` [INFO] [stdout] 94b47f0d12b1025b0734bcdfe6cc91aecc20fe4b704d33b7ddd6fd3ab8dd1bbc